Commit Graph

132 Commits (e2869ecafe0d42d4450dbf0ec6b4c590badc8cf3)

Author SHA1 Message Date
Dries Buytaert 4f94488b55 - SID will now only be appended when session.use_trans_sid is set. Patch
by Kjartan.
2002-11-21 18:25:38 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert 562df8fe43 * Added Jeremy's pager:
"This is a simple, generic pager for Drupal-CVS.  It is designed to be
  easily themeable and expandable.  The code is highly-commented to
  enhance readability."

 "Pagers are constructed by combining the provided pieces (all of which
  can be easily modified to display the text or image you prefer) into
  your custom pager."

* Statistics module fixes by Jeremy:

 - removed superfluous check for existence of watchdog()
 - saving changes in admin page displays status and returns same page
 - no longer return 1971/01/01 in "view statistics" table
 - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
 - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
   max_timestamp" moving towards ANSI-SQL compliance.

* Added a "theme_item_list" function to format itemized lists.  Also
  changed a couple of modules to take advantage of it.  Makes for a
  more consistent UI.
2002-11-09 13:59:36 +00:00
Dries Buytaert 8d103a0898 - Committed Marco's block rewrite:
+ Blocks are not longer called if not rendered: major performance
     improvement.
   + Fixed some bugs (preview option was broken, path option was broken).
   + Removed "ascii"-type blocks.
   + Added permission to for "PHP blocks"
   + ...

  NOTES:

   + You'll want to run "update.php":

       ALTER TABLE blocks DROP remove;
       ALTER TABLE blocks DROP name;

   + You'll want to update your custom modules as well as the modules in
     the contrib repository.  Block function should now read:

       function *_block($op = "list", $delta = 0) {
         if ($op == "list") {
           return array of block infos
         }
         else {
           return subject and content of $delta block
         }
       }
2002-10-26 15:17:26 +00:00
Kjartan Mannes 7d1c1fcc16 . fixing what I did earlier. Not sure how that happend. 2002-10-20 19:17:17 +00:00
Kjartan Mannes 0b323c0d8a - applying patch from Ax. Bug #389:
"Notice: Undefined variable: conf" in common.inc on line 779
2002-10-20 11:59:34 +00:00
Kjartan Mannes 390b1e35a9 - changed format_date to allow W (week of year) in a custom format. 2002-10-04 17:10:16 +00:00
Kjartan Mannes 984dfaa7d8 - fixed a bug in module_invoke_all , it will now also add 0's to the result
array. Thanks Moshe.
2002-09-27 17:06:50 +00:00
Dries Buytaert b8c815d245 - An attempt to solve drupal_goto() in presence of session IDs. 2002-08-08 18:24:53 +00:00
Dries Buytaert b5c56be324 - Made it possible to store arrays in the variables table. Patch by Marco. 2002-07-06 13:30:26 +00:00
Dries Buytaert 118da4b744 - A variety of small localization updates. Patch by Ori Folger. 2002-07-05 18:28:02 +00:00
Kjartan Mannes 9c23d8ae42 - cosmetics mostly. 2002-06-15 17:48:54 +00:00
Kjartan Mannes a5c05512fc - added some missing title attributs to links. 2002-06-14 13:48:35 +00:00
Dries Buytaert 38aaf5f35d - Added missing translations and the like. 2002-05-31 20:29:30 +00:00
Steven Wittens 7cd6e0b17d The default form action (request_uri) didn't escape HTML entities (such as &amp;) 2002-05-21 16:00:39 +00:00
Kjartan Mannes 581bc6a267 - more coding style fixes. 2002-05-13 18:59:53 +00:00
Kjartan Mannes 7f19e13259 - minor cleanup 2002-05-12 16:51:49 +00:00
Dries Buytaert 827755bed0 - Fixed typo. 2002-05-12 16:13:37 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Kjartan Mannes 86552cb4b6 - changed block, module and theme config pages to use checkboxes.
- coding style clean ups.
- fixed taxonomy causing errors.
2002-05-11 16:21:48 +00:00
Dries Buytaert f9b2936937 - Fixed broken RSS feeds.
TODO:
    + Make l()/lm()/la() urlencode() URLs?
    + Fix problems with the #-trick in drupal_url()/l().
2002-05-05 19:04:26 +00:00
Kjartan Mannes 921e6bc19a - rolling back common.inc. Wasn't supposed to be in the last commit. 2002-05-04 18:58:32 +00:00
Kjartan Mannes 69ec1a6996 - making sure the nodes call filter(). 2002-05-04 18:56:43 +00:00
Kjartan Mannes 8b153f32f4 - filter changes part 1. Part 2 tomorrow. 2002-05-03 20:27:53 +00:00
Kjartan Mannes c3a36313ac - fixing drupal_url() 2002-05-02 18:56:11 +00:00
Dries Buytaert 3a0f4b7219 - Included Moshe's guidelines on the use of t(). 2002-05-02 18:47:35 +00:00
Dries Buytaert f8329dd47c Patch by Moshe Weitzman:
- request_uri() behaves on non-apache web servers. i've tested on IIS and
apache (many platforms).

- modules may now implement the _search_item() hook which overrides the
default formatting of search results. modules already can customize which
fields are indexed. no module currently uses this hook but
externalpage.module expects to do so.

- added an optional $attribs argument to l(), lm(), and la() which is an
associative array of attributes which are inserted into the <a> tag (feature
#146).

- drupal_str_replace() is deleted (i had recently added it). i verified that
no scripts are currently calling this function. use strtr() or str_replace()
instead.

- arbitrary elements may be added to the <channel> and <item> blocks of an
RSS feed by passing the $args associative array. the core RSS engine is now
able to support elements like <cloud> and <catagory> [1] and RSS 1.0[2]

[1] http://backend.userland.com/rss092
[2] http://groups.yahoo.com/group/rss-dev/files/namespace.html
2002-04-27 13:19:37 +00:00
Dries Buytaert dbf9469d52 - Made the date strings configurable. Patch by Simon Lindsay. 2002-04-24 21:04:37 +00:00
Dries Buytaert 681dfc4ac0 - Bugfix: solve problem with locales being "disabled". Reported by Jerritt,
fixed by Marco.
2002-04-24 20:55:20 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Dries Buytaert d8cd54969c - Added Marco's long-awaited taxonmy module and patches - a replacement
for the meta system.  The patches add some extra functionality to the
  comment system (for example, comments can be set read-only) and fix a
  couple of small problems.

  + I integrated the required SQL updates from the varius *.mysql files
    into the "update.php" script.  Upgrading should be easy ...

  + I did not apply/commit the "user.diff" as requested by Marco ...

  + I didn't know what to do with "forum.module" and "forum2.module":
    what do you want me to do with it Marco?  Which one should go in?

  + Can we remove "node_index()" now; both from "node.module" and the
    themes?

  + Thanks Marco!
2002-04-14 20:46:41 +00:00
Kjartan Mannes 1e4308a939 - made the user information block into two different blocks. One for
login and one for user information.
- added link to help in book module (post-patch, see below).
- applied various patches:
  Patch by Greg Tyrelle <greg@tyrelle.net>
  - tracker module now shows usernames next to comments.

  Patch by Moshe Weitzman <moshe@wallaware.com>
  - book module has a more complete help.
  - added administrative link to export book to html
  - fixed non book nodes not showing up in trees.

  Patch by moshe weitzman <weitzman@tejasa.com>
  - links can be defined in the configuration file.
2002-04-02 09:45:57 +00:00
Kjartan Mannes e3d2c46f04 - applied search patch.
- added who is online block.
- made weblog module more configurable.
- users may now delete their own accounts (Feature #8)
- users may now request a password using email address *or* username.
  formerly required both items to match an account which was onerous.
- the link to request a new password is now presented whenever a user
  fails login.
- there is now a confirmation message after submitting edits to your
  user information.
- error messages in user.module may now be stylized by themes.
- <hook>_form has a $param setting you can fill with form parameters.
- improved wording for a few config settings.
- fixed various non-coding standard things.
2002-03-05 20:15:17 +00:00
Dries Buytaert f9a508d5dd - Fixed more than 30 HTML and XML well-formedness errors. 2002-01-27 14:58:45 +00:00
Dries Buytaert 8b04230c79 - Fixed a typo 2002-01-05 17:01:33 +00:00
Dries Buytaert 58152c45d1 Integrated Marco's generic/improved cache into Drupal. Requires an
SQL update.  See below for more details.

- Merged the file "cache.inc" into "common.inc".

- In addition, I renamed the field 'url' in the cache table to
  a more generic 'cid' (cache identifier).  It's no longer for
  URLs only.

- Made the "cache_set()" function ASNI compliant such that it
  will play nice with other databases such as Postgres.

- Added some extra input checking.

- Updated the old caching code in the functions "page_header()"
  and "page_footer()" to use the new, generic cache API.

- Updated "update.php" to make the required SQL changes.
2002-01-05 16:28:34 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Dries Buytaert d8e9eefa9b - Merged 3 tiny include files into "common.inc". 2001-12-27 15:27:44 +00:00
Dries Buytaert 8c8b305892 - Added "query log" functionality to Drupal. Inspired by weitzman's
code/patch.
2001-12-23 21:47:02 +00:00
Steven Wittens bdcb96e6cc Replaed incorrect "<p />" tag in form_item with a better <p> ... </p> combination. 2001-12-20 22:00:00 +00:00
Steven Wittens e798fe8373 form_checkbox() was totally broken: a checkbox needs a value on top of being (un)checked. When it is checked, the value is sent as "name=value". When not checked, nothing is sent. Usually a value of "1" will suffice, but I added explicit separate $value and $checked parameters to make sure no mix-up occurs, and to allow more freedom. 2001-12-20 21:44:46 +00:00
Dries Buytaert ab20a866c1 comment.module:
- small improvements to the comment admin interface.
  - merged comment.inc and comment.module.
2001-12-08 11:37:07 +00:00
Dries Buytaert 91d1115768 - Made a small improvement to format_name() 2001-12-05 18:54:14 +00:00
Dries Buytaert d852a999de Node and book updates:
- Fixed a glitch in the book overview in the admin section.
  - When updating a book page through the admin section, no new revision
    is created unless explictely specified.
  - Improved the usability of the node and book pages a little.
2001-12-01 15:20:48 +00:00
Kjartan Mannes 7d0c316f82 - fixed pass by reference errors. PHP only allows declaration of &$vars, not
passing them that way.
  For more info: http://no.php.net/manual/en/language.references.pass.php
2001-11-26 18:27:34 +00:00
Dries Buytaert eb7c5f60b9 - Bugfix: when updating a book page, the name of the author did not change.
- Bugfix: the "Edit comments" part of the node administration pages did not
  display the correct comments.

- Bugfix: somethimes, update in a book page would mess up the book.

- Improvement: when "node administrators" update a book page through the
  "update this book page"-link (like regular users do), their update will
  be subject to moderation.

- Improvement: made some intermediate changes to the filter mechanism. Needs
  more work.
2001-11-24 15:10:36 +00:00
Kjartan Mannes f5be5fdfa4 - modified node_save so that revisions are not validated using check_input,
as this breaks revisions.
- modified link_node() to take a third parameter $main, which will be passed on
  to _link hooks. This lets modules decide which links a node will get when
  shown on the main page, or when not.
- updated themes to use the new syntax.
2001-11-23 17:10:46 +00:00
Dries Buytaert 84cdc3c6c0 - fixed a typo in an English sentence. 2001-11-12 22:17:16 +00:00
Dries Buytaert a2e6910902 - Made the node forms support "help texts": it is not possible to configure
Drupal to display submission guidelines, or any other kind of explanation
  such as "NO TEST POSTS", for example.

- Added node versioning: it is possible to create revisions, to view old
  revisions and to roll-back to older revisions.  You'll need to apply a
  SQL update.

  I'm going to work on the book module now, so I might be changing a few
  things to enable collaborative, moderated revisions - but feel free to
  send some first feedback, if you like.

- Added some configuration options which can be used to set the minimum
  number of words a blog/story should consist of.  Hopefully this will
  be usefull to stop the (almost empty) test blogs.

- Various improvements:
   + Fine-tuned new node permission system.
   + Fine-tuned the functions in node.inc.
   + Fine-tuned some forms.
   + XHTML-ified some code.
2001-11-03 18:38:30 +00:00