Commit Graph

247 Commits (d9d4b9bdab8ac4b6e5c01926da9d5a084707be94)

Author SHA1 Message Date
Steven Wittens d9d4b9bdab - #27231: Friendly DB error screens. 2005-07-27 01:58:43 +00:00
Dries Buytaert ba1660168f - Patch #27003 by Neil: use named constants instead of strings 2005-07-23 05:57:27 +00:00
Dries Buytaert db3a2cc175 - Patch #11927 by stefan/Robin: improved theming of tablesort icons. 2005-07-02 12:32:09 +00:00
Dries Buytaert 5c8843704c - Patch #18213 by chx: boostrap system. Modified to work with HEAD, tidied
up the documentation a little.

  chx: can you double-check whether the global $conf variable is secure?
       (That is, make sure it can't be send using the URL or something.)
2005-06-22 20:19:58 +00:00
Dries Buytaert eb536bf5ec - Patch #24157 by chx/Robin/...: changed file_exists() to is_file() to fix several problems with modules using theimage toolkit. 2005-06-19 08:59:06 +00:00
Dries Buytaert abc16b1d6d - Patch #25067 by Thox: renamed 'light' and 'dark' to 'odd' and 'even'.
TODO: update the "Migrating themes from Drupal 4.6 to Drupal HEAD"-page in
        the Drupal handbook!
  TODO: update the themes in the contributions repository.
2005-06-19 08:50:46 +00:00
Dries Buytaert a7af266b6d - Patch #25143 by Robin: use count() instead of is_array() so we don't render code for empty arrays, and such you don't get warnings using PHP5. 2005-06-19 08:13:14 +00:00
Steven Wittens a597354bcb - Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags. 2005-05-31 21:14:27 +00:00
Dries Buytaert 0250938e2b - Patch #17028 by Ber: theme xml_icon should allow inline XML icons. 2005-05-26 19:08:14 +00:00
Steven Wittens 6be2c61896 - #20809: User-configurable, per-theme, optional favicons. 2005-05-25 06:03:18 +00:00
Steven Wittens a52bb9b1dd - #23516: Remove ][ from form item id's. 2005-05-25 03:50:25 +00:00
Steven Wittens 5154c3aca4 - Fixing some plain/url check calls. 2005-05-18 21:12:17 +00:00
Dries Buytaert 03250bd3e3 - Patch #21397 by jjeff: fixed behavior of theme_image with regard to attributes. 2005-05-06 09:01:46 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert 6658273b36 - Patch #21855 by TDobes: the recent commit of phptemplate caused a number of problems for non-phptemplate themes. A patch is attached to address these issues.
Changes include:
    * parsing of the primary/secondary links has been moved out of phptemplate and into theme_get_setting.
    * unnecessary and XHTML-invalidating duplicate div#help removed from themes/bluemarine/page.tpl.php (this is already generated by theme_help)
    * weird generation of the "edit primary/secondary links" messages removed from bluemarine and placed in theme.inc
    * unnecessary changes to themes/bluemarine/style.css rolled back (the phptemplate bluemarine had an older version of style.css than the one in core)
    * chameleon updated to work with new link scheme (passes links through theme_links)
2005-05-05 07:35:58 +00:00
Dries Buytaert e274f97c87 - Removed the Xtemplate engine and added the PHPTemplate engine.
- Converted the Bluemarine theme from XTemplate to PHPTemplate.
- Moved the the Pushbutton theme and the Xtemplate engine to the contributions repository.
2005-05-04 18:12:18 +00:00
Dries Buytaert a10eac3291 - Patch #21517 by Stefan and TDobes: theme system improvements. 2005-04-30 17:47:57 +00:00
Dries Buytaert 79a5700c57 - Usability improvement: made the markers easier to understand. 2005-04-24 16:22:30 +00:00
Dries Buytaert 495a03ae9d - Patch #12794 by assimonds: make sure the node module is optional. 2005-04-13 17:59:39 +00:00
Dries Buytaert 7bdcba1720 - Patch #19739 by Uwe: corrected many typo's in the documentation and code comments 2005-03-31 21:18:08 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Dries Buytaert 99233a9c99 - Patch #19590 by Moshe: lazy initialization of the theme system. Improves
performance of pages that don't need the theme system (such as RSS feeds)
  and makes it easier to set a custom theme.
2005-03-29 21:01:47 +00:00
Dries Buytaert 97ae6568e6 - Patch #13738 by TDobes: theme system fixes:
* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
2005-03-16 19:41:12 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 467dbdc4a1 - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. 2005-01-27 12:57:08 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert cc508ad2f0 - Patch 13738 by TDobes: there was a major theming issue I missed in my bug-testing after the multi-site patch landed. Styles now seem to have their description field filled with the filename of their parent theme/template rather than the theme_key of the parent. This is a problem because init_theme still expected to see the theme_key and therefore dropped back to the base theme (no theme at all). 2004-12-01 22:41:19 +00:00
Dries Buytaert 4e4e2aa777 - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly. 2004-11-24 22:50:25 +00:00
Dries Buytaert 30110a8770 - Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
    1. Update theme upgrade instructions in the handbook: node_link() is gone.
    2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Steven Wittens 583e63c136 Theme system bug: only show search box if search.module is enabled. 2004-10-14 02:38:33 +00:00
Steven Wittens 9c9905d9a0 #10648: Fix watchdog-related tablesort coloring bug in IE, add support for <tr> attributes to theme_table() and reduce specificy of watchdog coloring CSS rules. 2004-09-14 20:01:00 +00:00
Dries Buytaert b84b6e42cf - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments. 2004-09-09 05:51:08 +00:00
Steven Wittens 98a9d5ee2d - #9576: Patch by TDobes, only allow the user to choose between enabled themes. 2004-08-22 14:43:49 +00:00
Dries Buytaert 6881cc9ad6 - Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided. Makes for clean XHTML. 2004-08-21 16:21:56 +00:00
Dries Buytaert 03fa966c1f - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes. 2004-08-21 10:16:13 +00:00
Steven Wittens 9f2d6f0e51 - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
2004-08-20 17:21:37 +00:00
Dries Buytaert 81861a8e91 - Removing some DOS-style line endings. Thanks TDobes. 2004-08-20 09:34:53 +00:00
Dries Buytaert 6ea5c56ded - Theme system changes. Please consult http://drupal.org/node/view/9576 for details. 2004-08-20 07:51:27 +00:00
Steven Wittens 9cb5f7cdf8 Avatar/picture fixes:
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958: Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
2004-08-20 04:35:33 +00:00
Dries Buytaert d5e1e83e77 - Patch #9900 by Al: bugfix: don't display two <hr />'s. 2004-08-16 21:27:39 +00:00
Dries Buytaert f99830a498 - Patch by Al: improved the admin/help pages (first step). 2004-08-10 05:44:17 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Steven Wittens edc2f13d82 - #9287: More doxygen/documentation fixes by JonBob 2004-07-22 16:06:54 +00:00
Dries Buytaert 56fa37cb8e - Made the example theme display status messages. Not sure why it wasn't. 2004-07-08 16:08:21 +00:00
Dries Buytaert 5b73def39b - Changed the way status messages are printed as per Kristjan's suggestion:
http://drupal.org/files/issues/error_messages_list.png (issue #9138).

  drupal_set_message() has been changed to group message by type and a
  helper function, theme_status_message(), is added to display the messages.
  Chameleon and Xtemplate have been updated to use this new function.

- Updated CHANGELOG.txt.
2004-07-08 16:04:07 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert b713e3d489 - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).

- Added forum-sticky.png.  Made by Steven.
2004-06-20 20:04:28 +00:00