Angie Byron
f76acb2d9d
#282405 by Damien Tournoud, lilou, Dave Reid: Enforce coding standard on elseif.
2008-10-12 04:30:09 +00:00
Angie Byron
ecf7ad41d0
#242873 by pwolanin and bjaspan: Make drupal_set_title() do check_plain() by default.
2008-10-11 21:11:02 +00:00
Angie Byron
4f17920c75
#319466 : SA-2008-47 ( #295053 ): CSRF in cached forms.
2008-10-11 04:06:29 +00:00
Angie Byron
6828096e7e
#284887 by Dave Reid and dww: Disable autocomplete if user does not have access to the callback.
2008-10-10 07:49:49 +00:00
Angie Byron
6bdd105f22
#318575 by jvandyk: Change 'remaining' to 'completed' in Batch API, to better reflect what's actually happening.
2008-10-09 22:54:08 +00:00
Angie Byron
4a0e68e838
#125315 by chx, sun, Gábor Hojtsy, drumm, and friends: Add #input_format FAPI property that can be used by WYSIWYG editors. WOOHOO.
2008-09-27 19:47:43 +00:00
Angie Byron
2cb811acb3
#229129 follow-up by chx: Fix module dependency checking again.
2008-09-27 06:29:47 +00:00
Angie Byron
17846beda6
#299672 follow-up by chx: Better fix for only caching form if #cache is set to TRUE.
2008-09-21 06:34:41 +00:00
Angie Byron
a3bb66e4e8
#259623 by dopry and Damien Tournoud: Convert includes/requires to use absolute paths.
2008-09-20 20:22:25 +00:00
Angie Byron
9c2e5a52c9
#299672 by fago: Cache form only if #cache is set to TRUE.
2008-09-20 16:10:29 +00:00
Angie Byron
1e8ee589bb
#180063 by andremolnar, TheMystic, and R.Muilwijk: Add a parameter to form_set_error().
2008-09-19 02:37:29 +00:00
Dries Buytaert
7f29b14277
- Patch #305645 by pwolanin: ['REQUEST_TIME'] -> REQUEST_TIME. Improved developer experience.
2008-09-17 07:11:59 +00:00
Dries Buytaert
e5b0e5f76c
- Patch #302763 by Dave Reid, Rob Loach: replace time() by ['REQUEST_TIME'] as per Rasmus' suggestion. Removed drupal_referrer() for consistency.
2008-09-06 08:36:22 +00:00
Dries Buytaert
fee4182cb9
- Patch #296300 by chx: remove edit[] and fixed Doxygen.
2008-08-17 11:08:23 +00:00
Dries Buytaert
bb153976b1
- Patch #279404 by chx: removed old cruft. See http://drupal.org/files/issues/fapi_award.jpg .
2008-08-15 07:55:54 +00:00
Dries Buytaert
28d2ee1a00
- Patch #290869 by swenterl, cwgordon07: fixed notice in #ahah handling.
2008-08-13 06:38:33 +00:00
Dries Buytaert
5c14dcafeb
- Patch #290869 by Wim Leers: AHAH functionality was not working for radio buttons.
2008-08-12 10:23:27 +00:00
Dries Buytaert
674b933c56
- Patch #245001 by kkaefer et al: unify #process callback naming.
2008-07-18 07:06:24 +00:00
Dries Buytaert
57fe5103da
- Patch #252013 by Eaton, pwolanin, Susurrus et al: drupal_render() now printes #markup, not #value.
2008-07-16 21:59:29 +00:00
Dries Buytaert
41fdf60ba4
- Patch #273523 by aclight: fixed E_NOTICE in theme_fieldset().
2008-06-25 09:57:07 +00:00
Dries Buytaert
9b82787b22
- Patch #243773 by chx, catch, boombatower, yched, dmitrig01, et al: use the batch API for running the tests instead of an all-in-one approach. Great work.
2008-06-24 21:51:03 +00:00
Dries Buytaert
81c71bc891
- Patch #216515 by chx, Damien Tournoud, et al: fixed form API glitch with caching.
2008-06-24 17:01:33 +00:00
Dries Buytaert
2e18cb8924
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
...
et al. Can you say 'registry'? Drupal now maintains an internal registry of
all functions or classes in the system, allowing it to lazy-load code files as
needed (reducing the amount of code that must be parsed on each request). The
list of included files is cached per menu callback for subsequent loading by
the menu router. This way, a given page request will have all the code it needs
but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
Dries Buytaert
841c098fba
- Modified patch #230374 by killes, jakeg, Eaton et al: corrected problem with form API caches not being flushed. This could lead to performance issues.
2008-05-05 21:28:49 +00:00
Dries Buytaert
b9ce36b0d5
- Patch #88892 by darthsteven et al: improved the PHPdoc of form_set_value(). Great work. Much better. :)
2008-04-14 17:51:38 +00:00
Dries Buytaert
56d2664a90
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
2008-04-14 17:48:46 +00:00
Dries Buytaert
66c79ee792
- Patch #117748 by pwolanin: made account creation work again.
2008-03-15 11:02:47 +00:00
Dries Buytaert
1d390ef36c
- Patch #216059 by nedjo, theborg, karens, goba, webchick et al: AHAH triggered by text input enter key press breaks autocomplete.
2008-02-12 13:52:33 +00:00
Dries Buytaert
b8a1eab1fb
- Patch #210131 by dvessel, catch, John, et al: updated jQuery library.
2008-02-06 19:38:28 +00:00
Gábor Hojtsy
06bb3d2e09
#117748 by quicksketch: short fix to trim() required fields for validation, with documentation
2008-02-04 10:23:32 +00:00
Gábor Hojtsy
ab7fb80056
#216061 by Eaton: nid was not set in node creation (programatic node creation regression)
2008-02-03 19:26:10 +00:00
Gábor Hojtsy
9edadd40dc
#216042 by Eaton: provide the complete form to element validators as well (critical regression for CCK)
2008-01-30 21:42:17 +00:00
Gábor Hojtsy
de791184f3
#214922 by Eaton: fix code typo which prevented from image buttons in a tree form from working
2008-01-28 12:09:12 +00:00
Gábor Hojtsy
eb7d6f05ff
#206955 follow up by merlinofchaos: avoid misusing default values for image buttons
2008-01-28 00:15:34 +00:00
Gábor Hojtsy
ea79c66c03
#194327 by dvessel, David_Rothstein, catch, theborg: IE form submission button correction was buggy
2008-01-25 16:24:48 +00:00
Gábor Hojtsy
fe65a869fa
#195283 by pwolanin: code documentation for the 'forms' function group
2008-01-21 15:17:01 +00:00
Gábor Hojtsy
d2fddb4763
#201017 by chx: AHAH callbacks were not working for regular buttons
2008-01-02 15:18:15 +00:00
Dries Buytaert
178c28535b
- Patch #204900 by webernet: code style fixes. Likely my last patch of the year. Fiew. Thanks all, and see you on the other side. :)
2007-12-31 08:54:37 +00:00
Gábor Hojtsy
de79420bc9
#195176 by chx: form_set_error doxygen was misleading
2007-12-23 12:33:13 +00:00
Gábor Hojtsy
ac4c8f7ab0
#203274 by Pasqualle: remove excessive witespace from our code (minor)
2007-12-22 23:24:26 +00:00
Gábor Hojtsy
310765bccb
#192767 follow up by chx: array_shift() should not be called with runtime references
2007-12-19 22:42:07 +00:00
Gábor Hojtsy
e7fc2383df
#192767 by fago, Eaton, chx: taking form_state per reference in form constructor function. Will be replaced with a nicer PHP 5 solution in Drupal 7.
2007-12-18 16:24:01 +00:00
Gábor Hojtsy
5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
Gábor Hojtsy
d83289f857
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
2007-12-06 09:58:34 +00:00
Gábor Hojtsy
bc0d7cb369
XSS fixes forward ported from Drupal 5.1 - previously not committed parts of http://drupal.org/cvs?commit=53675
2007-12-05 18:13:03 +00:00
Dries Buytaert
9a96837b89
- Patch #163246 by keith smith, freso, O Govinda, catch, webchick et al: fixed minor spelling issues and fixed spacing issues.
2007-11-26 16:36:44 +00:00
Gábor Hojtsy
8baa1261ed
#194652 by Heine: specify explicit accept-charset for forms to avoid browser guessing
2007-11-23 12:02:38 +00:00
Gábor Hojtsy
4615c96d59
#193191 by chx: allow form elements to enable form caching - allows custom form elements to leverage the AHAH framework
2007-11-19 19:23:28 +00:00
Gábor Hojtsy
c40af9443d
#193274 by dmitrig01 and quicksketch: send submit button data with AHAH submissions
2007-11-19 10:05:48 +00:00
Dries Buytaert
17d1527e3d
- Patch #146466 by douggreen, Steven et al: Remove temporary table usage from search module
2007-11-13 14:04:08 +00:00
Gábor Hojtsy
c856eac135
#191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate
2007-11-12 19:06:33 +00:00
Gábor Hojtsy
702c0a2bcd
#190283 by myself and JirkaRbyka: use get_t() in pre-database setup code, add missing javascript key to language objects (kills notices) and document st() better
2007-11-11 16:14:45 +00:00
Dries Buytaert
c187cc95b6
- Patch #168829 by Neil Drumm: fixed link in documentation.
2007-11-09 07:40:55 +00:00
Dries Buytaert
a547bdbce1
- Patch #172097 by Eaton: improved PHPdoc of form API.
2007-10-31 15:10:33 +00:00
Dries Buytaert
1cf05b0019
- Patch #89196 by catch, keith, earnie, webchick et al: string massaging.
2007-10-25 15:32:56 +00:00
Gábor Hojtsy
bad3e24164
#111719 follow up patch by multiple contributors: ensure proper XHTML id attribute values for form elements
2007-10-24 13:35:26 +00:00
Gábor Hojtsy
b94f2716cf
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
2007-10-21 18:59:02 +00:00
Gábor Hojtsy
6dcfce0127
#111719 follow up patch by chx: roll back form item ID patch
2007-10-20 10:49:55 +00:00
Dries Buytaert
8d526b10e5
- Patch #111719 by dvessel et al: ensure clean form IDs.
2007-10-19 16:59:28 +00:00
Gábor Hojtsy
8a10f3ea22
#181328 : pass on whole form to #process functions to enable advanced form handling (such as required by some CCK widgets)
2007-10-16 14:06:23 +00:00
Gábor Hojtsy
385c2afac1
#182178 by bragon: cols is a required attribute on textarea
2007-10-15 21:19:00 +00:00
Gábor Hojtsy
1e8ddda9b7
#169079 by yched: improve consistency of menu API and batch API by allowing batch definition in non .module files, which opens the possibility of better performing batches (which are likely to reside in .admin.inc files generally)
...
- apply this change in locale.module
- improve batch API code documentation
2007-10-15 15:18:39 +00:00
Gábor Hojtsy
19322c375b
Four watchdog() calls which still used t(), identified by myself after implementing extraction code for Drupal 6 at #182765
2007-10-15 14:52:18 +00:00
Gábor Hojtsy
3fb218cb7e
#182310 by chx: remove #DANGEROUS_SKIP_CHECK, as with the AHAH functionality now we have safer methods to add things in the cached form for validation, so we don't need this security hole possibility kept anymore.
2007-10-11 09:22:39 +00:00
Gábor Hojtsy
212c0484b9
#181741 by quicksketch: fix AHAH throbber/progress bar issues and generalize progress display configuration to allow module developers to choose from the throbber and progress bar
2007-10-10 10:24:25 +00:00
Dries Buytaert
bb5e71d4ee
- Patch #172636 by chx: fixed watchdog call.
2007-10-06 15:23:18 +00:00
Gábor Hojtsy
31b73898af
#157752 by quicksketch: extend AHAH functionality to most types of form elements, without writing JavaScript. Also AHAH enable the blocks admin page.
2007-10-05 09:35:09 +00:00
Gábor Hojtsy
c9c86ebf84
#145251 by chx: document that one needs to include the proper 'op' value in arrays passed to drupal_execute() to trigger the right action
2007-09-25 15:14:37 +00:00
Gábor Hojtsy
5206daafd6
#177529 by chx: if no checkbox was selected, we still need an empty array()
2007-09-25 11:29:10 +00:00
Gábor Hojtsy
00ae7949ef
#172824 by yched: let the batched processes perform drupal_execute() properly
2007-09-14 10:40:55 +00:00
Gábor Hojtsy
5030ea40a5
#150851 by pwolanin and chx: different radio buttons in the same set should have different HTML id values (XHTML validity fix)
2007-09-11 17:23:58 +00:00
Dries Buytaert
2db2c039fb
- Patch #172950 by webernet: code style fixes.
2007-09-04 21:10:45 +00:00
Dries Buytaert
a8800e4f26
- Patch #146667 by coofercat: fixed bug in form builder.
2007-08-26 07:31:48 +00:00
Gábor Hojtsy
9291424560
#169247 by profix898 slightly modified: fix E_NOTICE when form_id is not set on a non-programmed form
2007-08-23 18:02:52 +00:00
Gábor Hojtsy
87bdc95bff
#165013 by Eaton: fix image button behaviour by processing the right values coming in the request
2007-08-10 10:51:17 +00:00
Gábor Hojtsy
db5311d144
#85208 by neclimdul and bjaspan (slightly modified): if no maxlength was specified, do not generate an empty HTML attribute
2007-08-09 10:43:03 +00:00
Dries Buytaert
80ff5109a7
- Patch #162708 by Eaton and Earl: add support for image buttons to FAPI3.
...
This is a small form API extension (doesn't break existing code) that
facilitates the Drupal 6 upgrade of the Views module. A good example
of why it can be beneficial to start upgrading your modules early on in
the code freeze. ;)
2007-07-29 17:28:23 +00:00
Dries Buytaert
eb65040c5e
- Patch #149593 by yched: batch API fixes.
2007-07-20 05:44:13 +00:00
Dries Buytaert
834eab503f
- Patch #121620 by Eaton et al: fixes for formAPI #type .'_value' callback patch.
2007-07-14 15:23:29 +00:00
Gábor Hojtsy
e27972be52
#157605 by Wim Leers: remove two lines of dead code from expand_date()
2007-07-12 11:03:54 +00:00
Dries Buytaert
8cd661b82b
- Patch #121620 by Eaton, dopry et al: formAPI #type .'_value' callback, remove hardcoded switch from form.inc, has been ready for about one week and required to make the CCK better.
2007-07-04 15:45:37 +00:00
Dries Buytaert
2ceae6ad58
- Patch #154398 by quicksketch et al: add dynamic AHAH submission properties to Forms API. This patch was ready for a long time and is somewhat of a usability improvement (enabler).
2007-07-04 15:42:38 +00:00
Dries Buytaert
20093d5fc8
- Patch #111086 by webchick: fix contact module error message.
2007-07-03 19:53:01 +00:00
Dries Buytaert
ef6deb6c9a
- Patch #154299 by Eaton: button details are lost.
2007-07-03 19:13:49 +00:00
Dries Buytaert
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
Dries Buytaert
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Dries Buytaert
2bf7c1c0e3
- Patch #147662 by Gordon et al: add new #pre_render callback to drupal_render().
2007-06-28 07:48:41 +00:00
Steven Wittens
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
Dries Buytaert
a92aff941a
- Patch #145177 by asimmonds: drupal_execute fixes.
2007-06-17 12:07:51 +00:00
Gábor Hojtsy
57c9a13e1f
#118026 by kkaefer with fixes from myself: JavaScript translation support and script.js as a default theme JS file to use, if found
2007-06-08 12:51:59 +00:00
Dries Buytaert
9e0da3dc7c
- Patch #143026 by ChrisKennedy and Steven: dynamically check password strength and confirmation.
2007-06-08 06:04:15 +00:00
Dries Buytaert
27388f6655
- Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id().
2007-06-05 12:13:23 +00:00
Dries Buytaert
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
Dries Buytaert
21e3e4b490
- Patch #136067 by ChrisKennedy: fixed required-attribute of password fields.
2007-05-31 12:36:18 +00:00
Dries Buytaert
a55c0d676b
- Patch #145135 by bjaspan and stefan: xhtml compliance.
2007-05-28 18:53:29 +00:00
Dries Buytaert
7131fd5313
- Patch #146536 by nedjo: typo programed -> programmed
2007-05-28 06:20:28 +00:00
Dries Buytaert
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
Dries Buytaert
2ea8460ea9
- Patch #146187 by walkah: FAPI 3 removes ['#post'] from hook_form_alter.
2007-05-25 15:39:34 +00:00
Dries Buytaert
b4ef53eccc
- Patch #127539 by yched: batch processing fixes.
2007-05-16 07:56:19 +00:00
Dries Buytaert
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00