Commit Graph

1980 Commits (d8d524ffef3c08a44f6563fb76af5fb55a6f397c)

Author SHA1 Message Date
Dries Buytaert d8d524ffef - Patch #4269 and #4248 by Killes: added missing t()'s to book module. 2004-07-25 14:22:16 +00:00
Steven Wittens b2882bf29a System.module improvements:
- #8193: Moving the two instances of the timezone list into a function.
- #3859: Adding drupal_goto for module/theme/settings pages. Aside from general drupal_goto usability, this fixes the bug of menu items not immediately appearing after enabling a module.
2004-07-22 02:13:13 +00:00
Dries Buytaert 2a538a399e - Patch by Andy: improved help text / module description. 2004-07-16 08:19:26 +00:00
Dries Buytaert 8aa052dc66 - Patch #9177 by James: fixed distributed authentication. 2004-07-15 17:20:15 +00:00
Steven Wittens 1c4cc2623e Removed the 'user' item in the menu which appeared when editing someone else's account. 2004-07-14 23:04:46 +00:00
Dries Buytaert 9b49f01f11 - Patch #7466 by TDobes: comments module would add a link of register even if "user_register" was set to 0. 2004-07-14 05:44:36 +00:00
Dries Buytaert 1c52b145ba - Patch #8080 by TDobes: added teaser support to the book and page module. 2004-07-13 21:52:35 +00:00
Dries Buytaert 739bb8a868 - Patch #9261 by drumm: made the aggregator overview tables more consistent by adding a items column to the categories table which acts like the same column in the feeds table. 2004-07-13 21:34:14 +00:00
Dries Buytaert 2c9b5e31b7 - Patch #9234 by TDobes: the latest menu changes have caused custom menu blocks not to render any output. If I create a new menu and menu items, and then enable the block, no output from that block is visible.
This commit fixes the problem: custom menus were being defined as MENU_CUSTOM_ITEM rather than MENU_CUSTOM_MENU.  It also fixes a problem in which custom menus were mistakenly given the MENU_VISIBLE_IN_BREADCRUMB bit when edited. This would cause their titles to show up in the breadcrumb (which is undesirable... only menu items should be in there).

Note that this will not fix any non-functioning custom menus you've defined since this bug appeared. You'll have to delete and recreate them or update the "type" column in the DB manually.
2004-07-13 21:23:23 +00:00
Dries Buytaert dbd1c4f1da - Patch #9253 by Morbus: fixed bug that manifested itself with a duplicate page when a user has submitted a comment that goes into the moderation queue. Part of the problem seemed to be that the "your comment is in the moderation queue" message was set as a theme print, as opposed to a drupal_set_message(). This patch fixes that, as well as adding a drupal_goto() to redirect the user back to where they came. 2004-07-13 20:51:29 +00:00
Dries Buytaert df2e5ef505 - Patch #8942 by Morbus: when testing under devel.module, the "SELECT timestamp from {history}" SQL statement is executed multiple times in two different functions. This duplicated code should be placed in a function, and that's been done already with node_last_visited() - the remaining code was just never updated to use the new routine. This patch changes the old code to use node_last_visited, and also modifies node_last_visited() to cache the result of the database call. 2004-07-13 20:44:13 +00:00
Dries Buytaert 3613729d4f - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
Changes are as follows:
"maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
"maintain personal pages" -> "edit own pages" (page.module)
"maintain personal stories" -> "edit own stories (story.module)
2004-07-13 20:40:46 +00:00
Dries Buytaert 6477705fc8 - Small code simplifications.
- Small usability improvement thanks to using drupal_goto() after deleting an
  alias.
2004-07-13 07:10:56 +00:00
Dries Buytaert 9e43afadc7 - Patch by Matt: made it possible to alias an URL multiple times. 2004-07-11 06:53:39 +00:00
Dries Buytaert bbb41d0f71 - Patch by JonBob: updated the comment module to take advantage of the latest
menu system improvements.
2004-07-10 18:11:18 +00:00
Dries Buytaert 1f288c11c4 - 'add block' -> 'add' 2004-07-10 16:06:49 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert e21f238ad7 - Patch 8756 by Morbus:
* improves the doxygentation and help text.
* deletes comment_admin and comment_page; using proper callbacks instead.
* related/modified callbacks/menus/functions were tweaked to not use arg() at all.
* the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
* moderation pages weren't properly showing defined votes or thresholds; fixed.
* when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
* we show "submit votes" on the moderation votes page only when votes actually exist.
* fixes the (broken in CVS) comment/reply and comment/edit features.
* fixes the (broken in CVS) "save settings" for comment view options and comment moderation.

In addition I:

* fixed a couple warnings introduced by Morbus' patch.
* fixed a couple translation bugs.
* fixed comment_node_url().

I also found that:

* the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
2004-07-10 07:58:47 +00:00
Steven Wittens 27dc584ba9 Fixed a bug caused by inverting the setting for configurable timezones. 2004-07-09 00:25:10 +00:00
Dries Buytaert 82c9fab7c7 - Patch #9010 by Morbus: reorganized the order of functions in the comment
module.
2004-07-08 19:58:10 +00:00
Dries Buytaert a067187711 - Patch #8509 by Killes and Steven: added support for sending compressed
pages.  Useful to reduce your site's bandwidth.
2004-07-08 19:22:48 +00:00
Dries Buytaert 898bdeffaf - Marked required fields on the node (story, book, page, blog) and comment
forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!
2004-07-08 15:24:30 +00:00
Dries Buytaert 144c1abb58 - Renamed '... your ...' to '... my ...' (cfr. 'my account). 2004-07-08 15:19:08 +00:00
Dries Buytaert 78876f01d5 - Fixed colspan in tracker table.
- Renamed '... your ...' to '... my ...' (cfr. 'my account).
2004-07-08 15:18:48 +00:00
Dries Buytaert bf42dddea7 - Usability improvement: users can also separate 'list items' (i.e. favorite
movies) using a comma.  Only few users actually read the form description,
  it seems ...
2004-07-08 15:17:21 +00:00
Dries Buytaert 24600b8a43 - Simplified some of the help texts.
- Removed left-over instance of theme('error'): error handling is now done by
  the form code.
2004-07-08 15:12:23 +00:00
Dries Buytaert 7059b64965 - Made the user module's administration form mark required form fields. 2004-07-08 15:11:05 +00:00
Dries Buytaert 4dbc900d3b - Renamed the blog module's block for sake of clarity.
- Made the blog module's submission form mark required form fields.
2004-07-08 15:09:53 +00:00
Dries Buytaert c989fc7cf7 - Small improvement to the filter.module's help text.
- Revert patch that accidentically got committed.  Thanks jhriggs.
2004-07-08 13:35:15 +00:00
Dries Buytaert 64b12b4a56 - Fixed braino. Reported by Steven. 2004-07-08 07:56:16 +00:00
Dries Buytaert 039c77121a - Patch #9031 by Morbus: this last tracker patch was broken - for installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements. 2004-07-08 06:15:49 +00:00
Dries Buytaert 9a56e93c3d - Patch #9125 by Morbus: remove access users permission. Will bring it back later. 2004-07-08 06:12:39 +00:00
Dries Buytaert d3904c05cc - Usability improvements: reworked/simplified the timezone/date settings a
little and made the form groups use consistent titles.
2004-07-07 22:45:21 +00:00
Dries Buytaert 6a43d01e27 - Usability: improved the error reporting of the file system settings on the
'home » administer » settings" page.
2004-07-07 22:19:20 +00:00
Dries Buytaert 3568ed57e1 - Moving the title.module from core to contrib as discussed on the mailing list. 2004-07-07 20:18:22 +00:00
Dries Buytaert b05086c92f - Patch #8975 by drumm: remove block placement preview. Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
Anything else that can be removed?  Less is more.
2004-07-07 05:42:24 +00:00
Dries Buytaert 9d35fe7a7d - Patch #4166 by daBrado: don't show the profile fields when the user does
not have the 'access users' permission set.
2004-07-06 17:27:33 +00:00
Dries Buytaert 0654129e16 - Patch #8382 by jseng/junyor: allows autodiscovery of BloggerAPI via RSD. 2004-07-06 16:54:28 +00:00
Dries Buytaert 4e9ef33896 - Patch #9031 by Ber: if the comment module is not available comment_num_all()
should not be called.
2004-07-06 07:38:35 +00:00
Dries Buytaert 7bb88809b7 - Patch #9049 by JonBob: fixed a number of tab issues. 2004-07-06 07:33:59 +00:00
Dries Buytaert 4bbc277881 - Patch #9046 by asimmonds: comment signature option was not displayed. 2004-07-05 05:42:06 +00:00
Steven Wittens ac27d4bf81 Fixed broken poll results:
- If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
- Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
2004-07-04 23:40:14 +00:00
Steven Wittens d615cb245e - Added revisions tab to node view (when needed)
- Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
2004-07-04 19:24:52 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 353c05d015 - Made it possible to edit blog posts and made the blog module use tabs. 2004-07-04 10:30:42 +00:00
Dries Buytaert 3fb070f419 - Patch #8952 by Morbus: watchdog module beautifications.
* slightly reorders the functions in anticipation of http://drupal.org/node/view/9010.
  * reorders help definitions to match the alphabetical nature of the menu items.
  * tweaked visual appearance of menu code (whitespace, etc.)
  * minor tweaks to "warning" help to match style of others.
2004-07-03 14:10:09 +00:00
Dries Buytaert cca82f8ee4 - Increased the maxlength value of the URL form. 2004-07-03 08:37:48 +00:00
Dries Buytaert e47c623e3d - Patch #9006 by Killes: For some reason there is a array_merge that nobody seems to need. It generates an error under php5. Found by redLED. 2004-07-03 07:07:33 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 3701c02e59 - Small watchdog module optimization by Morbus. 2004-07-02 18:32:12 +00:00