Dries Buytaert
5fdaa818da
- Patch #68690 by mindless: new attachments not shown.
2007-03-06 16:43:10 +00:00
Dries Buytaert
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
Dries Buytaert
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
Dries Buytaert
3b543c18f5
- Rollback of E_ALL patch. Too much extra breakage.
2007-01-25 22:14:06 +00:00
Dries Buytaert
fd32b42196
- Patch #112715 by webchick et al: fixed some E_ALL errors.
2007-01-25 21:32:07 +00:00
Dries Buytaert
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
Steven Wittens
6c3f2ef2cd
Fix JS upload after theme_button change.
2007-01-15 11:22:34 +00:00
Dries Buytaert
a7d58587cb
- Patch #103164 by davea and RobRoy: made downloads work on IE6. Send correct headers.
2007-01-02 10:25:33 +00:00
Neil Drumm
dfd86399c0
#106232 by chx. Add spaces for code style.
2007-01-02 05:05:38 +00:00
Dries Buytaert
5d2f993c22
- Patch #102583 by ChrisKennedy: file upload maxsize displayed incorrectly.
2006-12-14 13:30:59 +00:00
Steven Wittens
cc2cb795d5
#101714 : Allow OpenDocument file extensions by default.
2006-12-06 20:37:25 +00:00
Steven Wittens
80f691eeef
#101164 : Fix file upload in PHP5 (pass by reference)
2006-12-05 23:10:48 +00:00
Neil Drumm
222fa77f84
#61528 by Darren Oh. Let the browser fully handle downloading attachments.
2006-11-28 02:38:28 +00:00
Neil Drumm
85a1cea720
#98391 by RobRoy. Don't show the file upload field if the files directory won't work.
2006-11-28 02:28:48 +00:00
Neil Drumm
706a462c89
#97870 by killes. Keep file information updated as it is saved.
2006-11-27 23:01:11 +00:00
Neil Drumm
8b1e5d0505
#97231 by pwolanin. Keep the node type in a property and use it consistently.
2006-11-26 02:43:48 +00:00
Neil Drumm
b5bf8a8f47
#97824 by Gurpartap. Move enclosing elements outside of their t().
2006-11-26 02:20:01 +00:00
Dries Buytaert
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
Dries Buytaert
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
Dries Buytaert
cb8be5f821
- Patch #89285 by profix: code simplifications.
2006-10-26 05:31:14 +00:00
Steven Wittens
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
Neil Drumm
f37cfb92b2
Fix for #81740 by myself. Reference objects as objects.
2006-10-17 08:20:42 +00:00
Dries Buytaert
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
Dries Buytaert
90f9bffbc0
- Patch #82045 by chx, eaton et al: fixed nodeapi.
2006-10-05 15:26:17 +00:00
Dries Buytaert
24ac1a1fb2
- Patch #85257 by RobRoy: fixed default upload restrictions.
2006-09-26 14:11:58 +00:00
Dries Buytaert
e4b063e1ef
- Patch #83297 by yched et al: prevent double escaping of filenames in upload module.
...
(Needs to be backported, I think)
2006-09-10 07:38:52 +00:00
Dries Buytaert
35c33e3cf5
- Patch #83222 by edkwh: more theme('placeholder') clean-up. Good catch.
2006-09-09 08:25:24 +00:00
Dries Buytaert
a45c5f8169
- Patch #30525 by rblomme et al: make downloading attachments work with IE6.
2006-09-08 16:26:51 +00:00
Dries Buytaert
49fa25fb76
- Rollback of patch #68418 : clean up node submit hooks. Needs more thinkering.
...
Restores the old node API.
2006-08-31 21:58:36 +00:00
Dries Buytaert
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
Steven Wittens
6bbc4d7bf1
- Fix upload.js after edit[] patch (note: uploading is still broken, with or without JS)
2006-08-30 18:56:31 +00:00
Dries Buytaert
5524604a95
- Patch #68418 by Moshe et al: clean up node submit hooks.
2006-08-29 18:43:26 +00:00
Neil Drumm
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
Dries Buytaert
f2f3416549
- Patch #80934 by timnc: more t() fixes.
2006-08-27 12:43:18 +00:00
Dries Buytaert
234d5bef20
- Patch #38454 by drumm, jaza, webchick, timnc et al: add field pre- and suffixes to textfields.
2006-08-26 09:56:17 +00:00
Dries Buytaert
c4f1e4ba13
- Patch #76444 by chx, moshe, eaton, angie et al: make it possible to control access to form elements.
2006-08-22 11:13:04 +00:00
Dries Buytaert
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
Steven Wittens
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Dries Buytaert
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
Neil Drumm
129c8eb18c
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
2006-08-06 23:00:42 +00:00
Neil Drumm
0299beb05e
#72545 by pwolanin, validation for upload module administration.
2006-08-06 22:49:27 +00:00
Dries Buytaert
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
Neil Drumm
c11c1c2800
#73605 by RobRoy, make hook_link() implementations consistent with documentation.
2006-07-19 07:15:35 +00:00
Dries Buytaert
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Dries Buytaert
e93f8be871
- Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants.
2006-07-05 11:45:51 +00:00
Neil Drumm
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
Neil Drumm
8d70d932b1
#71616 by keve, cleanup
2006-07-04 08:48:05 +00:00
Neil Drumm
7c05eaa9ac
#66662 by stefan nagtegaal, Remove PHP notices
2006-06-11 23:58:55 +00:00
Neil Drumm
4b462ae384
#57307 by killes, upload_load should return an ordered set
2006-06-11 22:38:04 +00:00
Dries Buytaert
96862f8511
- Patch #66842 by Heine: use proper variable to show filename.
2006-06-02 14:21:45 +00:00
Gerhard Killesreiter
5059b82164
fixing stuff
2006-06-01 21:54:48 +00:00
Dries Buytaert
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
Dries Buytaert
bddd9aeb6f
- Patch #51506 by gordon: new feature: added auto-complete functionality to user profiles.
2006-05-12 08:50:22 +00:00
Neil Drumm
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
Neil Drumm
845a6d71b4
#30025 by m3avrck, Upload module needs a 'default' maxfile size setting
2006-05-04 10:25:01 +00:00
Steven Wittens
b176270018
#60532 : Multiple file upload broken in some browsers (fix)
2006-04-27 19:32:54 +00:00
Steven Wittens
23bd2c005a
#60532 : multiple file upload broken in some browsers
2006-04-27 18:12:25 +00:00
Gerhard Killesreiter
00f8037e45
#59648 , Upload.module misuse of hook_file_download, paralyzes other modules' hook, patch by jakeg
2006-04-27 09:38:34 +00:00
Gerhard Killesreiter
fae7896d4f
#57949 , fixed broken links in helptexts, patch by wulff
2006-04-26 17:41:09 +00:00
Gerhard Killesreiter
dd814739ab
#56555 , Upload list settings not being respected, initially., patch by chx and dopry
2006-04-18 08:32:04 +00:00
Dries Buytaert
d071f99172
- Removing trailing whitespace.
2006-04-17 20:48:26 +00:00
Gerhard Killesreiter
3bdc01fdfd
#23373 , make uploaded file list themable, patch by yogadex / Moshe / drumm
2006-04-14 20:57:03 +00:00
Neil Drumm
fb580ade43
Fixing indentation.
2006-04-14 19:20:46 +00:00
Gerhard Killesreiter
70aae83c8e
#58166 , fixes for typos, patch by Uwe Herrmann
2006-04-11 11:33:15 +00:00
Gerhard Killesreiter
8ce5fe4d1f
#57307 , order files by fid, patch by Robert Douglass
2006-04-08 18:35:35 +00:00
Steven Wittens
e585942e0f
#53689 : upload_js doesn't allow form altering with hook_form_alter
2006-04-07 10:08:15 +00:00
Gerhard Killesreiter
c3cb1ea435
#56921 , revert earlier patches, patch by chx
2006-04-06 15:30:19 +00:00
Steven Wittens
34eefb7072
#57294 : Upload.module should not overwrite other #attributes in form_alter
2006-04-04 23:40:42 +00:00
Neil Drumm
352fb57d6c
#56921 by chx, removing the $form = from $form = form_builder($form_id, $form) then it works.
2006-04-02 23:14:51 +00:00
Gerhard Killesreiter
27ccbf1f6f
#55520 , improved docs, patch by dopry
2006-03-30 17:45:32 +00:00
Gerhard Killesreiter
bbf695fb04
#56467 , removed cruft, patch by Nedjo
2006-03-30 14:31:16 +00:00
Gerhard Killesreiter
4797222c13
#55520 , upload.module does not display previews for when private files are enabled, patch by dopry.
2006-03-29 06:49:25 +00:00
Gerhard Killesreiter
1b7fd5e67b
#54913 , problem with checking filesize during uploading if user belongs into more than one role, patch by dopry
2006-03-24 17:45:04 +00:00
Gerhard Killesreiter
26612e9cbd
#54298 , Only user = 1 can upload files, patch by dopry
2006-03-21 11:44:46 +00:00
Gerhard Killesreiter
0de876d095
#54186 , Uploads still listed on upload form after validation errors, patch by timcn
2006-03-16 15:27:45 +00:00
Gerhard Killesreiter
b049f762c7
#53666 , Invalid argument supplied for foreach() in upload_save, patch by Markus Petrux
2006-03-13 22:23:09 +00:00
Dries Buytaert
c54de86134
- Patch #42358 by dopry et al: fixed problem with attaching files.
2006-03-10 19:03:25 +00:00
Dries Buytaert
28c0c6197a
- Patch #52092 by wtanaka, dopry and moshe: fixed regression with hook_file_download.
2006-03-10 19:02:06 +00:00
Dries Buytaert
347a5bb5f6
- Patch #31354 by Junyor et al: move node revision information for files to a separate table. (Today's critical bugfix #1.)
2006-02-22 10:06:46 +00:00
Dries Buytaert
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
Dries Buytaert
3698f85720
- Patch #50454 by DaveNotik: fixed syntax error. (Today's 1th critical bugfix)
2006-02-21 08:36:10 +00:00
Dries Buytaert
68820e23df
- Patch #49476 by Moshe: fixed incorrect access check.
2006-02-20 16:44:54 +00:00
Steven Wittens
d38429248e
- #47510 : Show JavaScript alert when PHP errors occur
2006-02-05 19:04:58 +00:00
Dries Buytaert
7e2e715393
- Patch #20795 by Steven: improved consistency of the code.
2006-01-08 12:20:55 +00:00
Dries Buytaert
c297f2e09c
- Patch #41161 by Moshe: bugfix: hide the upload form when uploads are not enabled for a node type.
2006-01-08 12:12:20 +00:00
Dries Buytaert
f940d8a290
- Patch #43362 by dorpy, junyor: critical bug fix: uploads loose their state.
2006-01-05 21:03:31 +00:00
Dries Buytaert
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
Dries Buytaert
0dfc8e059f
- Patch #41437 by webchick: improved code comments.
2005-12-17 17:24:46 +00:00
Dries Buytaert
922a46d281
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
2005-12-15 16:24:40 +00:00
Dries Buytaert
810e75050d
- Patch #39358 by m3avrck and Souvent22: make the upload.module work + revisions fixes.
2005-12-10 19:43:12 +00:00
Dries Buytaert
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
Dries Buytaert
0f6067fc84
- Removed valid_input_check().
2005-11-30 11:03:58 +00:00
Dries Buytaert
2d0df351d7
- Various fixes. Updated CHANGELOG.txt
2005-11-29 20:17:10 +00:00
Dries Buytaert
c647b39c2c
- Patch #37798 by Neil: fixed problem with node settings.
2005-11-27 11:11:46 +00:00
Dries Buytaert
b1b1e2045f
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
2005-11-25 10:11:59 +00:00
Dries Buytaert
4febf6443b
- Patch #35121 by m3avrck: fixed problem with list and description values aren't saved for uploaded files.
2005-11-21 15:36:53 +00:00
Steven Wittens
daca20e034
#37378 : Missing for _form_builder() in js upload
2005-11-13 02:00:37 +00:00
Dries Buytaert
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
Dries Buytaert
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
Dries Buytaert
ef7d2c8a9f
- Patch #34920 by tangent: reorganized the node submission form a bit.
2005-10-28 14:04:20 +00:00
Dries Buytaert
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
Dries Buytaert
a1ae4da70b
- Removing tabs and trailing whitespaces.
2005-10-07 06:51:43 +00:00
Dries Buytaert
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert
53bdeae273
- Modified patch #30775 by timcn, Souvent22, m3avrck: give file uploads descriptions.
...
(Modified the form a bit.)
2005-09-27 15:54:39 +00:00
Steven Wittens
69247d7aad
- #30128 : Call by reference left-overs
2005-09-02 02:11:41 +00:00
Dries Buytaert
e03ce2f996
- Patch #28483 by Steven: JavaScript enabled uploading.
...
Comment from Steven: It does this by redirecting the submission of the form to a hidden <iframe> when you click "Attach" (we cannot submit data through Ajax directly because you cannot read file contents from JS for security reasons). Once the file is submitted, the upload-section of the form is updated. Things to note:
* The feature degrades back to the current behaviour without JS.
* If there are errors with the uploaded file (disallowed type, too big, ...), they are displayed at the top of the file attachments fieldset.
* Though the hidden-iframe method sounds dirty, it's quite compact and is 100% implemented in .js files. The drupal.js api makes it a snap to use.
* I included some minor improvements to the Drupal JS API and code.
* I added an API drupal_call_js() to bridge the PHP/JS gap: it takes a function name and arguments, and outputs a <script> tag. The kicker is that it preserves the structure and type of arguments, so e.g. PHP associative arrays end up as objects in JS.
* I also included a progressbar widget that I wrote for drumm's ongoing update.php work. It includes Ajax status updating/monitoring, but it is only used as a pure throbber in this patch. But as the code was already written and is going to be used in the near future, I left that part in. It's pretty small ;). If PHP supports ad-hoc upload info in the future like Ruby on Rails, we can implement that in 5 minutes.
2005-08-31 18:37:30 +00:00
Dries Buytaert
d9d6a6e05c
- Patch #7582 by Gerhard: improved node revisions!
...
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.
TODO:
1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions. Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
Dries Buytaert
307eefd1ce
- Patch #29737 by m3avrck: fixed broken link in upload.module.
2005-08-29 19:01:18 +00:00
Dries Buytaert
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
Dries Buytaert
12c5614599
- Alternative solution for #28721 : expand "File attachments"-group on node edit form when files are attached.
2005-08-17 19:27:03 +00:00
Dries Buytaert
7c6a21aedd
- Patch by Uwe: tidied up the CVS IDs.
2005-08-11 13:02:08 +00:00
Dries Buytaert
53195677b6
- Patch #24183 by drumm: remove unnecessary setting from upload module. Currently the upload module checks two max file sizes. First it checks a global option; if its too big it quits. Then it checks another max file size (or even sizes) related to the roles which a user is in. We can remove the global option since the individual roles are checked.
2005-07-22 19:06:19 +00:00
Dries Buytaert
3a457c3614
- 'File Attachments' -> 'File attachments'.
2005-07-03 15:47:11 +00:00
Dries Buytaert
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert
e550f84162
- Patch #16204 by Thox: committed the collapsible form elements patch.
...
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
2005-06-21 09:45:45 +00:00
Steven Wittens
8bfe10bb96
- Typo in upload messages: %quote -> %quota
2005-05-31 04:10:21 +00:00
Steven Wittens
52fd9fffa9
- #23213 : Report upload size limits in megabytes, not bytes.
2005-05-25 04:27:55 +00:00
Dries Buytaert
52c383d2e4
- Patch #23160 by drumm: fixed status message by adding a missing string substition.
2005-05-19 19:33:49 +00:00
Steven Wittens
5154c3aca4
- Fixing some plain/url check calls.
2005-05-18 21:12:17 +00:00
Dries Buytaert
33f4134fac
- Patch #22723 by ejort: 'from' to 'FROM'.
2005-05-14 18:15:23 +00:00
Dries Buytaert
14f0d9a90a
- Patch #22806 by Neil: replaced left-over <em>foo<em> with theme('placeholder', 'foo')
2005-05-14 17:20:47 +00:00
Steven Wittens
898e2b6688
- #21429 : Maximum upload file size was checked in bytes, not megabytes.
2005-05-07 02:00:34 +00:00
Dries Buytaert
2debcfb1ef
- Patch #15595 by Stefan and Djun: improved status messages.
...
TODO: we should write down a couple guidelines for these document them in
the PHPDoc code of drupal_set_message()! .
2005-05-05 22:22:46 +00:00
Dries Buytaert
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
Dries Buytaert
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
Steven Wittens
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
Steven Wittens
d7588e4594
- #12211 : Show link indicating that a node has attachments on the homepage
2005-03-18 08:05:47 +00:00
Dries Buytaert
632918e571
- Patch #16963 by Neil: the upload's module help text was in bad shape. Edited it down to what is needed with links that actually work.
2005-02-08 19:43:02 +00:00
Steven Wittens
10e3d66d87
- Missing apostrophe
2005-02-08 18:43:37 +00:00
Steven Wittens
5f78d14373
#16993 : Bad query in upload.
2005-02-08 16:12:10 +00:00
Dries Buytaert
1970f1d2a8
- Fixed warning in the feed generation (enclosures).
2005-02-07 14:16:27 +00:00
Dries Buytaert
7ccc5a6b1b
- Patch #16358 by James: added toolkit to enable better image handling. The avatar code and the upload module have been updated to take advantage of the new image API.
...
There are 5 main functions that modules may now utilize to handle images:
* image_get_info() - this function checks a file. If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
* image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image). This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
* image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
* image_rotate - rotate an image by X degrees
* image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).
Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
2005-02-01 16:27:43 +00:00
Dries Buytaert
7931c778d7
- Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
...
NOTE: this needs to be documented.
2005-02-01 14:09:31 +00:00
Dries Buytaert
993ea0c6c5
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
2005-01-29 22:02:37 +00:00
Dries Buytaert
e6d36892ab
- Moved the upload settings to 'admin/settings'.
2005-01-29 08:31:17 +00:00
Dries Buytaert
173f528f59
- Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
...
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert
37f6473a88
- Patch #16023 by chx: the upload.module still used the old node_access_*_sql calls.
2005-01-23 15:37:58 +00:00
Dries Buytaert
1dbe0dc2ee
- Patch #14917 by UnConeD/Steven:
...
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.
2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.
3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert
26875e9b38
- Added missing space
2004-12-29 23:03:05 +00:00
Dries Buytaert
627699cc9e
- Patch #14545 by nysus: don't grant access to files if the node is not accessible.
2004-12-29 23:01:01 +00:00
Dries Buytaert
9574766ad8
- Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency.
2004-11-23 22:20:41 +00:00
Steven Wittens
474beff640
Missing check if file upload fails.
2004-10-20 16:57:35 +00:00
Steven Wittens
710d76171e
#10441 : Splitting up upload permissions in 2: one for uploading and one for viewing/downloading. It does not make sense to only allow downloading for people who can upload themselves.
2004-09-19 22:56:26 +00:00
Dries Buytaert
3ffde628c5
- Patch #8179 by JonBob: the legacy handlers and file upload previews were mistakenly cached when they cannot be. Attached patch fixes this as well as a reference to an undefined constant in legacy_menu().
2004-09-17 18:08:28 +00:00
Dries Buytaert
5c7983c4de
- Patch #8179 by JonBob: reintroduced menu caching.
2004-09-16 07:17:56 +00:00
Steven Wittens
9a38369d0c
#10560 : Upload.module
...
- removing file checks for uid #1 to be consistent with the roles/permissions.
- renaming script files to .txt's to prevent accidental execution (we don't allow them by default, but you never know)
2004-09-13 19:14:32 +00:00
Steven Wittens
e35674d4a2
Upload.module: add explicit cast to (array) for $node->files in case it's not set (e.g. nodes that don't take attachments).
2004-09-05 09:15:18 +00:00
Steven Wittens
44f341bebc
Patch by me and Kjartan.
...
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.
File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Dries Buytaert
94e30bf776
- Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks.
2004-08-21 06:42:38 +00:00
Dries Buytaert
fa25c7a0ca
- Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions).
2004-08-19 15:41:57 +00:00
Steven Wittens
eb5d7d2a27
Fixed bad permissions in upload.module:
...
- Admin - upload only shows up for 'access administration section' perms
- Users without 'upload files' perm do not see the attachments form (and cannot attach even when sending their own http request)
Note: if a user can edit a node, but not 'upload files', then the attachments are left untouched (and cannot be changed).
2004-08-18 21:55:39 +00:00
Dries Buytaert
0e36182c96
- Code improvements by Stefan:
...
+ " -> '
+ Using form_set_error() instead of drupal_set_message().
+ Removed dead code.
2004-08-18 19:45:50 +00:00
Dries Buytaert
775153089d
- Small change to the wording of the 'note'.
2004-08-18 06:08:04 +00:00
Steven Wittens
8050af67b3
Setting the default workflow for attachments by upload.module to be enabled.
...
This makes sense because people will expect attachments to work everywhere when they enable this module. This also matches comment.module's behaviour, where comments are allowed by default unless turned off.
2004-08-18 04:24:33 +00:00
Dries Buytaert
78b052a6af
- The upload (filehandler) module has landed!
2004-08-17 21:35:26 +00:00