Commit Graph

863 Commits (d6a91bddcf30884441667fe87936e7b34769c713)

Author SHA1 Message Date
Dries Buytaert 9e54dc27ff - Patch #7968 by Adrian: use the complete URL as the cache ID to make Drupal's
caching work on virtual hosts.
2004-08-06 20:38:48 +00:00
Dries Buytaert 9bad647d76 - Patch #9819 by JonBob: fixed XHTML bug - make sure the <div> is always closed. 2004-08-06 20:18:25 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Dries Buytaert a52cf8297a - Patch #7458 by killes: conditionally include xmlrpc.inc. 2004-08-04 20:36:24 +00:00
Dries Buytaert c0f6fccac3 - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes. 2004-08-03 18:01:48 +00:00
Dries Buytaert 9945bca528 - Patch #9650 by Adrian: this change introduces a module_load function, which maintains a list of modules that have already been loaded in a static array, and will not load another module of the same name, or if the file does not exist.
Modules can be stored anywhere, as there is now a set of functions called module_get_filename, and module_set_filename .. which allow system_listing and module_list to specify the locations of the files.

A new function module_load_all() replaces the hardcoded includes in module_init, and loads all modules which have been enabled, using module_load.

module_listing no longer includes files itself, instead it just keeps the listing (and sets the filenames).

This patch is a requirement for the multisite configuration patch, as overriding modules are currently being loaded due to the only protection of loading them is include_once.
2004-07-31 11:17:27 +00:00
Steven Wittens 6c73823b10 Fixing a rather nasty bug with page cache:
The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.

This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
*phew*
2004-07-29 01:41:33 +00:00
Steven Wittens ef6cbfda6f - Fixing broken tablesort due to typo with quotes. 2004-07-25 19:50:23 +00:00
Dries Buytaert 2af5dff6a2 - Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
db_next_id().
2004-07-25 18:16:49 +00:00
Dries Buytaert 702a057683 - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.

  This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
2004-07-25 14:25:42 +00:00
Steven Wittens edc2f13d82 - #9287: More doxygen/documentation fixes by JonBob 2004-07-22 16:06:54 +00:00
Steven Wittens b8d653f1e8 - Fixing bad strpos usage (have to use the ===/!== operators to check for 'false' in this case) 2004-07-21 15:30:35 +00:00
Dries Buytaert 7765fa1f7a - Patch #9290 by Morbus / JonBob / TDobes: SUBTASK removal patch for menu.inc. 2004-07-15 17:16:58 +00:00
Dries Buytaert f63c3be30c - Code and documentation improvements by JonBob. 2004-07-14 20:42:20 +00:00
Dries Buytaert 63a327db97 - Patch #9287 by JonBob: made the code style in the three database include files consistent with Drupal standards, and adds a wealth of Doxygen-style comments to aid developers in writing solid database access code using the API. 2004-07-14 19:15:25 +00:00
Dries Buytaert ce8e264382 - Patch #9262 by Ber / JonBob: the menu did not build correctly, thus the additional menu's were never displayed, but were saved. Only the last custom menu was displayed. 2004-07-14 05:46:12 +00:00
Dries Buytaert 50d78e9855 - Patch #9238 by JonBob: added code and Doxygen comments to common.inc and
bootstrap.inc.
2004-07-13 07:21:14 +00:00
Steven Wittens a080ce5f0f Slightly improved code in drupal_xml_parser_create. 2004-07-12 21:38:41 +00:00
Steven Wittens 77c0b577da Now Drupal tries iconv, recode and mbstring to convert unknown XML encodings to UTF-8. It also throws a friendlier error message when none of these extensions is installed. 2004-07-12 21:35:31 +00:00
Dries Buytaert 323d9fe054 - Call 'exit' hook when drupal_goto() is called. Also necessary for the
devel.module.
2004-07-11 07:31:11 +00:00
Dries Buytaert f163fa9956 - Patch by JonBob: a significant documentation update for the menu system! 2004-07-10 18:10:36 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert a067187711 - Patch #8509 by Killes and Steven: added support for sending compressed
pages.  Useful to reduce your site's bandwidth.
2004-07-08 19:22:48 +00:00
Dries Buytaert 56fa37cb8e - Made the example theme display status messages. Not sure why it wasn't. 2004-07-08 16:08:21 +00:00
Dries Buytaert 5b73def39b - Changed the way status messages are printed as per Kristjan's suggestion:
http://drupal.org/files/issues/error_messages_list.png (issue #9138).

  drupal_set_message() has been changed to group message by type and a
  helper function, theme_status_message(), is added to display the messages.
  Chameleon and Xtemplate have been updated to use this new function.

- Updated CHANGELOG.txt.
2004-07-08 16:04:07 +00:00
Dries Buytaert 02ae1ce670 - Many form_ functions called theme('form_element') with the wrong parameters!
- Fixed order of parameters in form_checkboxes() (plural).
2004-07-08 11:31:12 +00:00
Dries Buytaert 7bb88809b7 - Patch #9049 by JonBob: fixed a number of tab issues. 2004-07-06 07:33:59 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert f3aa87122e - Textarea's did not have error handling support yet. 2004-07-04 06:19:41 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 60513799a1 - Patch #8941 by JonBob: allow local tasks to be ordered by weight, as well
as simplifying the theming of local tasks so they can be more easily
  rendered in a non-tab manner.
2004-06-30 20:45:45 +00:00
Dries Buytaert e3e051cc0d - Patch #8585 by Junyor: sort blog items by creation date. Added some database indices. 2004-06-30 07:26:02 +00:00
Steven Wittens 6a00c7c2f2 - Preventing caching of page when status messages are present (needed for redirects after form submission to work properly)
- Double-quotes to Single-quotes
2004-06-28 20:00:53 +00:00
Dries Buytaert 0a35280978 - Patch #8603 by TDobes: added support for sticky forum topics to the blog
and forum module.
2004-06-27 16:02:31 +00:00
Dries Buytaert 0be1e6cff7 - Issue #8735 by njivy: made the pager code ignore EOLs. 2004-06-22 05:45:15 +00:00
Dries Buytaert 77ec01f592 - Patch #8344 by Kjartan: drupal_http_request() did not always handle EOLs
correctly.
2004-06-21 20:14:41 +00:00
Dries Buytaert 090743bdba - Patch #8670 by asimmonds: more spelling fixes. 2004-06-21 20:05:37 +00:00
Dries Buytaert b713e3d489 - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).

- Added forum-sticky.png.  Made by Steven.
2004-06-20 20:04:28 +00:00
Dries Buytaert 4e1f368e88 - "" -> ''. 2004-06-20 08:31:45 +00:00
Dries Buytaert ce45c91a53 - Patch #8652 by Adrian: incorrect implode. 2004-06-20 08:30:57 +00:00
Dries Buytaert efed4cfc70 - Patch #8679 by asimmonds: fixed spelling mistakes. 2004-06-20 08:27:03 +00:00
Dries Buytaert 1b46d7fcfe - Patch #8614 by JonBob: better way to display menus. 2004-06-19 14:57:44 +00:00
Dries Buytaert cbc230a36c - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
logical name.  Requires a database upgrade.
2004-06-19 10:39:36 +00:00
Dries Buytaert a42b84e5d6 First tab improvements by Adrian:
+ Changed menu.inc to generate two separate lists instead of nested lists:
    that seems to be the only alternative to get rid of absolute positioning.

  + Changed the tabs code to be more sexy and put the code in misc/drupal.css
    so all themes are automagically updated.
2004-06-19 08:24:14 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Kjartan Mannes 7cd54567bd - Commiting patch #8288: Let modules pass $attributes to form_checkboxes() and form_radios(). 2004-06-04 18:10:05 +00:00
Kjartan Mannes c957fe0aab - Commited patch #4878: Support file uploads via blogapi. 2004-06-04 18:00:48 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Kjartan Mannes c3463a22ae - Removing early experimental tab code that slipped in.
- Fixing a copy paste error in file.inc.
- Some double => single quote changes.
2004-06-02 18:26:44 +00:00