Commit Graph

142 Commits (d5fe0cfe2017241094a84e4c4fb6bfdf1928f8eb)

Author SHA1 Message Date
Dries Buytaert 0000c2e401 - Code review: improved search API, tidied up the search related code,
and fixed a tiny bug when searching for users.
2001-05-09 18:28:09 +00:00
Dries Buytaert fae651d75f - Fixed submission bug in book.module. (reported by Remco) 2001-05-07 18:44:40 +00:00
Dries Buytaert 64f0be062f - Fixed a bug in the book submission part.
- Fixed a bug in navigation through book pages.
- Fixed a bug in sorting books by weight.
2001-05-06 19:51:14 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00
Dries Buytaert 1681877761 CHANGES:
- Added moderator information to forum.module.

- Simplified story.module, page.module, forum.module and book.module
  by removing redundant code, and by doing other small house-keeping
  tasks.
2001-05-03 18:48:42 +00:00
Dries Buytaert 343e71c8eb CHANGES:
- Added moderator permissions to nodes.

- Added moderator support to structure.module.

- Added new moderate.module.

- Renamed moderation.module to queue.module to avoid confusing.
  Updated theme yaroon as it seems to have a hard-coded reference
  to moderation.module.

- Polished on:
   + account.module: improved access list
   + fixed HTML typo in node.module

ACTIONS:

- Jeroen: can jeroen2.theme be removed from ./themes/yaroon?
2001-05-02 20:52:19 +00:00
Dries Buytaert fead09a8de Welp. Large commit ahead.
CHANGES:

- Added "read" and "write" permissions into drupal but removed
  it again because - when finished after 3 hours of work - it
  was considered nothing but added complexity that didn't buy
  us anything. :I

  (I'll explain this in detail on the mailing list, I guess.)

- Added a very simple help.module to group all available
  documentation on a single page.

- Fixed bug in node_control(), book.module: UnConeD forgot to
  global $user when updating the combobox code.

- Removed static wishlist.module: in future, the wishlist can
  be maintained as a page in our collaborative book.

- Revised most of settings.module: tidied up the code and the
  descriptions to accompany the settings and introduced a new
  "default maximum number of nodes to display on the main page"
  variable.

- Revised most of comment.module: the administration interface
  looks better now, integrated node permissions, and -finally-
  made it possible to delete comments.

- Polished on:
   + account.module
   + structure.module
   + locale.module
   + module.module
   + forum.module

- Form-ified:
   + account.php
   + account.module
   + setting.module
   + cvs.module
   + submit.php
   + comment.module
   + forum.module
   + book.module
   + page.module
   + locale.module

- Updated CHANGELOG

INFO:

- Designed a "generic tracker system with optional backends"
  on paper.  The idea is to allow registered users to hot-list
  certain topics, individual nodes or threads (comments) and
  to "plug-in" output backends like - for instance - an e-mail
  digest.  The design requires "intelligent blocks" though.


TODO:

- I want to tidy up the headline.module and backend.class as
  well as merge in headlineRSS10.module.  Julian spent quite
  some time working on headline.module but I'm not sure what
  he changed and whether he'd contribute it back?
2001-04-30 17:13:08 +00:00
Dries Buytaert ef7d5e1201 CHANGES:
- Added new form_* functions to common.inc, used for building
  forms: it should improve 'stability' (no form typos, every-
  thing properly escaped/unescaped) and should help providing
  a very consistent user interface (wrt forms).

- Adjusted node.module to use the new form functions.
  (Can be used as an example.)

- Adjusted book.module to use the new form functions.
  (Can be used as an example.)

- Merged function.inc into common.inc!

- Slowly removing all global $status and $rstatus variables:
  use node_status() instead.

TODO:

- Apart from implementing the permission system, I'll spend
  some time updating most modules today and tomorrow to use
  the new form functions.
2001-04-29 12:39:55 +00:00
Dries Buytaert 26fed7826f - Fixed two more </TD</TR>'s. 2001-04-21 17:43:42 +00:00
Steven Wittens 89fb6b6b4e Fixed error in HTML... (</TD</TR> changed to </TD></TR>) 2001-04-21 15:37:38 +00:00
Dries Buytaert cccb132c81 - Addition: added a "promote" field to the node table, which
makes "promoting nodes" to the main page possible.  Stories
  and reviews could be promoted by default, but - on accasion
  a good book entry could be manually promoted too.  Thus all
  existing content types can be shown on the main page, not
  just stories.

  Requires a SQL update, see 2.00-to-x.xx.sql!

- Addition: implemented "auto-post new submissions" feature
  to disable or by-pass the moderation queue in addition to
  "moderate new submissions".

  TODO: admin moderation versus registered user moderation.

- Addition: added category and topic support to page.module.
2001-04-21 14:19:20 +00:00
Dries Buytaert 3f1979aa3c - Addition: made it so that comments can be enabled/disabled on
a node per node basis, rather then on a category per category
  basis.  The default settings for each individual category can
  be changed though.

  Example: it can be setup so that - by default - all stories
  posted to the category "article" will have comments enabled
  but stories submitted to "announcement" not.

  Different configuration schemes can easily be added later.

  Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.

- Addition: made submit.php only use categories that users can
  actually submit new content to.
2001-04-19 19:59:48 +00:00
Dries Buytaert 19f85e9912 - fixed sub-directory problem reported by UnConeD 2001-04-17 17:03:41 +00:00
Dries Buytaert 6a71425ebc - improved interface a bit 2001-04-16 19:31:31 +00:00
Dries Buytaert b1c66cb5de Another big update so please read this carefully because there is important information hidden in it.
Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.

I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)

Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)

In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)

I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)

Oh, I also fixed a few bugs and made various small improvements.
2001-04-16 18:21:22 +00:00
Dries Buytaert b9952f537d Large commit, read it carefully, and make the required changes to
your theme:

- corrected some missing translations in story.module.  Oops!
- grealty simplified the "moderation threshold mechanism"(tm) so
  that module writers don't have to worry about this.  As a result
  story.module and book.module became a bit smaller and easier to
  grasp.
- greatly simplified new "category" and "topic" code which is soon
  going to replace the "section" code.  Needs more work though so
  hang on thight.
- includes/section.inc and modules/section.module are replaced by
  includes/structure.module and modules/structure.module.
- beautified example.theme a bit without adding HTML complexity:
  it is a good example but still useful as a theme
- made theme example use "categories" and "topics"
    --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
- made theme marvin use "categories" and "topics"
    --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
- added 2 new "story listings" to administrator interface of
  story.module to verify story integrity.
- optimized comment table a bit (work in progress)
2001-04-16 11:38:12 +00:00
Dries Buytaert 1f0565806b - improved submit.php:
it now uses the new category code, incl content bindings.
  You can setup different "categories" which map on a content
  type.  Example:
    review   -> review.module
    article  -> story.module
    column   -> story.module
    announc. -> story.module
    addons   -> file.module
    themes   -> file.module
- "generalised" story.module and book.module's output.
- fixed bug in includes/timer.inc
- fixed glitch in theme example.theme: it said "$how by" but
  the variable $how has never been declared.
- added "drupal development settings" to display some timings
- more work on the categories/topics -> does NOT work yet
2001-04-15 17:01:32 +00:00
Dries Buytaert b87d482b38 Last nights updates (under construction):
- added _type() hook so each module can return the content types he/she
    implements
2001-04-13 08:27:32 +00:00
Dries Buytaert 4711869f52 - fixed a small SQL bug in page.module
- slightly improved story.module, node.module and book.module
- made the "default theme" a setting from the setting page
- polished a bit on the export function: we can now export the
  book or parts thereof through the following url:

    1.  http://drop.org/export/book/
          (full book)
    2.  http://drop.org/export/book/nid
          (where nid is the node id to start with)

  The export routine demonstrates how it can be done yet the
  output is too basic and can only improve over time.
2001-04-11 19:44:24 +00:00
Dries Buytaert 0f567be0ed - improved administrator interface of account, node, story and book
by (1) adding a few extra features to "easify" navigation and (b)
  to start using "status messages" as once suggested on the mailing
  list by Jeroen
2001-04-10 20:07:27 +00:00
Dries Buytaert 5e9f9b3633 - ... and order things by weight 2001-04-08 10:35:48 +00:00
Dries Buytaert 6e9982e090 - typo 2001-04-08 10:34:15 +00:00
Dries Buytaert 96a87f6c8f - improvements to book module:
a. only display childs 3 levels deep
    b. better index page
2001-04-08 10:31:59 +00:00
Dries Buytaert 38806b4a39 - fixed bug in common.inc: throttle()
- streamlined method invocation in node.inc
- added node_status() function to modules
- added NEW (mostly static) page module
- added NEW settings module
2001-04-07 15:02:28 +00:00
Dries Buytaert 8213f5b262 A lot of small changes (search-n-replace) make a big commit:
- fixed update bug in book.module
  - provide a log message when both adding and updating book pages
  - all configurable variables are now accessed through "variable_get()":
  - rewrote watchdog and submission throttle and removed watchdog.inc
  - improved robustness of sections.inc
  - imporved story.module
  - updated ./database/database.sql
2001-04-06 14:14:16 +00:00
Dries Buytaert 048664f278 - a bunch of various updates 2001-04-05 20:33:36 +00:00
Dries Buytaert 7fac91c2cc - various smaller improvements 2001-04-04 21:09:24 +00:00
Dries Buytaert 8d249c5f28 Last night's updates:
- improved "track drop.org": it has now 2 boxes, one for "track
   comments" and one for "track nodes"
 - various small improvements to the book module based on the
   feedback we got.
 - fixed typo in moderation module
 - ...
2001-04-04 12:54:10 +00:00
Dries Buytaert 805107cd22 Commiting my work of last Sunday:
- removed ban.inc and ban.module and integrated it in account.module
   under the name "access control" --> the ban code was not really up
   to standard so this has now been dealt with.  This refactoring and
   reintegration cuts down the code size with 100 lines too.  :-)
   (The ban.module code was really old and it showed.)

 - added node.module and made the other modules reuse some of this
   code --> cut down the code size of modules by at least 100 lines
   and adds stability.

 - added a status() function to admin.php to display a conform status
   message where appropriate.  See admin.php for usage.

 - removed $theme->control() and made comments.inc handle this itself
   wrapped in a $theme->box().  No need to clutter the themes with
   such complexity --> updated all themes already. :-)

 - some small visual changes to some administration pages to be more
   consistent across different modules.
2001-04-02 15:54:37 +00:00
Dries Buytaert d216096ede - simplified some of the node stuff:
stories can no longer be scheduled -> this functionality will be made
    generic for all nodes
2001-04-01 10:52:01 +00:00
Dries Buytaert 32ff43a48c - simplified book.module so that it is easier to maintain (yet a bit
less sexy) - the entire module is only 258 lines.
2001-03-31 19:10:53 +00:00
Dries Buytaert 871d0619aa - fixed another bug 2001-03-31 18:38:01 +00:00
Dries Buytaert 6ca6e831b6 - fixed bug in section.module: id -> nid
- fixed bug in book.module: not 100% yet
2001-03-31 17:56:12 +00:00
Dries Buytaert d1a07a2e8f - fixed "you-have-to-logout-and-login-before-permissions-change" bug
(reported by UnConeD)
- added "add node" link to book selection box and made it display the
  current location
- removed tabs and whitespaces from themes - done automatically
2001-03-31 14:58:37 +00:00
Dries Buytaert d9e72f37de - fixed update bug 2001-03-31 13:18:57 +00:00
Dries Buytaert 04ad9b8af9 - fixed issue depricated call-by-reference issues
- fixed small visual glitch in includes/function.inc
- changed SQL tables around a bit to be more consistent
  (result: small changes to a lot of different files)
- improved robustness of includes/node.inc
- improved output of cron.module
- improved output of node.php
2001-03-29 19:50:31 +00:00
Dries Buytaert a0d83fc0e8 - streamlined the book and story module 2001-03-28 21:29:44 +00:00
Dries Buytaert cb5bbdee20 - small improvements as well as 2 bugfixes 2001-03-26 20:22:09 +00:00
Dries Buytaert 456c39100f - improved search functionality 2001-03-25 18:21:30 +00:00
Dries Buytaert 5fb307f5bf - refactoring, refactoring, refactoring 2001-03-25 16:42:52 +00:00
Dries Buytaert 1f79863053 - large commit of everything else that has been queued in my backlog:
it's not 100% stable yet
2001-03-25 10:57:01 +00:00
Dries Buytaert 6275348098 - the "faq module" and the "documentation module" are going to be bundled
into a much more powerful and easier to maintain "book module": each
  "page" in the big "drop.org/drupal book" is a node and everyone with
  a user account can suggest new pages or updates of existing pages.
2001-03-24 16:36:13 +00:00