Commit Graph

253 Commits (ceb9859d70080b67ab2a46ee93528f0813d734a2)

Author SHA1 Message Date
Steven Wittens d1d52fe478 Minor code clean-up in aggregator_configure(). 2004-08-17 17:37:26 +00:00
Dries Buytaert c39ac09b32 - Added missing ')'. 2004-08-16 18:06:08 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert 0f088b79ca - Patch #9983 by Stefan: various code style improvements. 2004-08-12 18:00:11 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Dries Buytaert 8b820b13ec - Patch #9757 by Al: improved the aggregator help. Help texts should be to the point. 2004-08-04 17:45:46 +00:00
Dries Buytaert d21207ae85 - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended. 2004-07-26 18:42:31 +00:00
Dries Buytaert f2ac51dc5e - Patch #9346 by drumm: improved themability of some aggregator pages. 2004-07-25 18:49:57 +00:00
Dries Buytaert 739bb8a868 - Patch #9261 by drumm: made the aggregator overview tables more consistent by adding a items column to the categories table which acts like the same column in the feeds table. 2004-07-13 21:34:14 +00:00
Dries Buytaert 3613729d4f - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
Changes are as follows:
"maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
"maintain personal pages" -> "edit own pages" (page.module)
"maintain personal stories" -> "edit own stories (story.module)
2004-07-13 20:40:46 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert cca82f8ee4 - Increased the maxlength value of the URL form. 2004-07-03 08:37:48 +00:00
Steven Wittens 93b56f5073 - Fixing some usability bugs with aggregator admin: some forms lacked status messages, and redirected to themselves
- Now uses drupal_goto after every form submission [1]. Patches for other modules will follow.

[1] http://lists.drupal.org/archives/drupal-devel/2004-06/msg01147.html
2004-06-28 23:16:59 +00:00
Dries Buytaert ad3c6f345e - Patch #8681 by asimmonds: more help text updates 2004-06-21 08:26:20 +00:00
Dries Buytaert bd49f9d1b3 - Patch #8681 by Stefan: more help fixes. 2004-06-20 20:12:00 +00:00
Dries Buytaert b713e3d489 - Patch #8617 by TDobes: changes all gifs to pngs for better consistency (and
to get of proprietary formats).

- Added forum-sticky.png.  Made by Steven.
2004-06-20 20:04:28 +00:00
Dries Buytaert 4b449a7e5d - Patch #8670 by asimmonds: spelling fixes. 2004-06-20 19:43:28 +00:00
Dries Buytaert efed4cfc70 - Patch #8679 by asimmonds: fixed spelling mistakes. 2004-06-20 08:27:03 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Dries Buytaert 5bceb07008 - Usability improvement: simplified the administration menu of the aggregator
module.
2004-05-20 12:43:28 +00:00
Dries Buytaert 25a709a1f3 - Patch 7840 by Drumm: fixed warning. 2004-05-17 22:11:12 +00:00
Dries Buytaert e52c0f5d41 - Code improvements by JonBob. Thanks. 2004-05-17 22:00:06 +00:00
Kjartan Mannes 2f4d6e317c - Fixed pruning of old items giving errors when there are no old items. 2004-05-13 21:43:40 +00:00
Kjartan Mannes cd85011996 - Forgot to hide the edit menus. 2004-05-13 21:21:08 +00:00
Kjartan Mannes b0b1cdb76b - Fixed missing edit menu callbacks for feeds and categories.
- Fixed categorize not working under sources and category views.
2004-05-13 21:16:14 +00:00
Dries Buytaert e6ff8b7901 - Made the recent news items page, the source pages and the categorization
pages use pagers.  Removed the 'Items per page' setting and made Drupal
  remember news items much longer.
2004-05-13 18:47:27 +00:00
Dries Buytaert c314ff54a6 - Code improvements by JonBob. Thanks again. 2004-05-11 20:10:14 +00:00
Dries Buytaert 7bf77b6a5e - Patch #7411 by Ax: fixed some aggregator module warnings. 2004-05-07 07:26:31 +00:00
Kjartan Mannes 297c552c7e - Incorrect quotes. 2004-04-29 21:10:12 +00:00
Kjartan Mannes 857f1b1cce - Fixed bug #7094: Incorrect displayed umlauts in ISO-8859-1 RSS-feeds.
- Fixed feed status not being reset when items are removed.
2004-04-29 21:09:00 +00:00
Dries Buytaert 3117258552 - Various aggregator module improvements. Modified patch by drumm. 2004-04-27 20:10:09 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Steven Wittens a083daf841 Truncate UTF-8 patch. Introduced a new function truncate_utf8() for chopping off strings at unsure locations, without risking incomplete UTF-8 data. 2004-04-15 14:07:08 +00:00
Dries Buytaert 9abcd206d9 - Patch #7110 by drumm: fixed aggregator module help text. 2004-04-13 05:31:15 +00:00
Dries Buytaert 248a493d24 - Patch #6480 by eap: news items were displayed in the wrong order. 2004-03-25 20:12:36 +00:00
Steven Wittens fb6e4564d8 - Aggregator: fix for http://drupal.org/node/view/5733
- System: the 404 setting instructions advise using 'node', this should be '' (redirecting the user to the front page without any message whatsoever is confusing)
2004-02-19 12:27:33 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert bd78422715 - Patch 5592 by Goba: let drupal_map_assoc() rule. :-)
- Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
2004-02-15 15:19:36 +00:00
Dries Buytaert abf27dde48 - Fixed bug #5628: wrong timestamp in aggregator. Patch by BartJ. 2004-02-04 21:23:07 +00:00
Dries Buytaert 2aa8036057 - Fixed bug in image parsing: caused 'Array' to be printed on the screen. 2004-01-24 15:47:44 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert ce803acecb - Patch 5330 by Adrian: PostgreSQL updates and fixes. 2004-01-23 18:21:45 +00:00
Dries Buytaert 43e9bd79c2 - Patch 5256: code improvements: theme('header') + theme('footer') -> theme('page').
Patch by Gerhard.
2004-01-19 22:23:37 +00:00
Dries Buytaert adb93fad37 - Reworked error/status reporting in the aggregator module to fix a bug. 2004-01-17 17:18:36 +00:00
Dries Buytaert 6fc2070a22 Patch 5114 by Kjartan:
- Adds drupal_set_header() and drupal_get_headers().
 - Cache now stores custom headers.
 - Replace theme_head() with drupal_get_html_head(), added drupal_set_html_head().
 - Added RSS autodiscover links to node, blog and taxonomy pages.
2004-01-14 22:30:09 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert f2b984fcd4 - Removed some debug info. 2004-01-11 15:10:27 +00:00
Dries Buytaert ee305ae144 Round 3 of aggregator improvements:
- Added support for new tags:
   + Optinal feed image: <image> tag.
   + Dublin core dates: <dc:date> <dcterms:created>, <dcterms:issued>,
     <dcterms:modified>.
 - Usability improvements:
   + On the administration page, made the feed/bundle titles link
     to the feeds/bundles' pages.  On the feed/bundle's page, made
     the 'Last updated' field link to the administration page.
   + Moved the 'syndication' menu one level down.
 - Updated some content sensitive help.
 - Further improved themeability.
 - Fixed some invalid HTML.
2004-01-11 15:05:21 +00:00
Dries Buytaert 86f8a25059 Aggregator module improvements:
+ Added some a new theme fucntions to the aggregator to make it possible to
   theme the aggregator page.
 + Removed the <table> and much hardcoded CSS as well as theme("box")-es.
 + Added the aggregator's theme functions to Doxygen's themeable group.
 + Added breadcrumb trails to the aggregator pages.
 + Updated the core themes to take advantages of the improved themeability.

Screenshot:

 http://buytaert.net/temporary/aggregator-makeover.jpg
2004-01-10 15:31:26 +00:00
Kjartan Mannes 94c1c06d8a - Report XML parse errors. 2004-01-08 19:29:10 +00:00
Dries Buytaert 94f6e94ffd - Many excellent news aggregator improvements by Kjartan:
+ Added drupal_http_request().
    + Replaced rssfeeds with OPML feed subscription list.
    + Added support for pubDate.
    + Added support for conditional gets using ETag and Last-Modified.
2004-01-07 19:52:10 +00:00
Kjartan Mannes 9478f33c26 - Renamed import to aggregator.
- Added proper access checking to block and menu items.
2004-01-06 13:32:59 +00:00
Steven Wittens b817bdb302 - Improved XML encoding fix. There is now a function drupal_xml_parser_create():
/**
 * Wrapper around xml_parser_create() which extracts the encoding from the XML
 * data first and sets the output encoding to UTF-8. This function should be
 * used instead of xml_parser_create(), because PHP's XML parser doesn't check
 * the input encoding itself.
 *
 * This is also where unsupported encodings should be converted.
 * Callers should take this into account: $data might have been changed after
 * the call.
 *
 * @param $data The XML data which will be parsed later.
 */
2004-01-06 12:09:42 +00:00
Steven Wittens 0158c920ad Committed filter separation patch: all filter-related things are now in filter.module (which is a required module).
To do this cleanly, I reorganised some bits of system.module: there is now a generic handler available for simple variable-get/set based configuration pages. Look at filter_admin() or system_view() for example usage.

(based on the patch by Goba)
2004-01-05 19:50:43 +00:00
Steven Wittens f6cae09439 - Specify default XML encoding for not-so-well-formed files
(sorry last commit, I promise :P)
2003-12-30 06:41:24 +00:00
Steven Wittens 205aa25e9b - Improved regexp for encoding extraction 2003-12-30 06:28:01 +00:00
Steven Wittens 7ba70547c2 - Improved regexp for encoding extraction 2003-12-30 06:24:28 +00:00
Steven Wittens e8265f0759 - Bugfix: the XML parser in PHP4 requires you to specify the input encoding explicitly.
Added a short piece of code that does this.
(see drupal.org's Drupal Talk to see this bug in action)
2003-12-30 05:58:17 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert c18984562a - Removed the import module's custom menu. Added a 'news aggregator' menu to
the navigation block.
2003-12-26 19:01:11 +00:00
Dries Buytaert 6cde7fd99a - Translation fixes: fixed three usages of format_interval(). Patch by Goba. 2003-12-22 21:55:40 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 56c1521743 - Excessive CSS tags were generated for feeds and bundles. 2003-12-14 13:02:11 +00:00
Dries Buytaert ee92242333 - Bugfix: got rid of the double titles on the import module pages.
TODO: get rid of the custom import specific navigation menu.
2003-12-11 21:35:52 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 17db3d0e2a - Fixed theme glitch. 2003-11-14 20:31:21 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert 42e6309fd0 - Small documentation improvements. 2003-10-24 09:25:46 +00:00
Dries Buytaert 742410aafd - Bugfix: prefix not prepended to sequences. Fixes bug #3639.
Make sure to write:

    db_next_id({table}_field);

  instead of:

    db_next_id(table_field);
2003-10-22 13:03:32 +00:00
Dries Buytaert 2977a8cd3d - Some documentation fixes by Mark Coady. 2003-10-15 15:07:47 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert efe9006afb - Various translation and menu fixes from Gabor. 2003-10-05 17:39:40 +00:00
Kjartan Mannes 35ffabd23b - Fixing blog it link. 2003-10-03 22:46:55 +00:00
Dries Buytaert 9942b6a2c5 - There were 2 "content syndication" menu's: grouped them together. 2003-10-02 18:41:12 +00:00
Dries Buytaert 208eabd908 - Fixed import and comment module problems. Patch by Gabor.
> Currently the admin menu does not work for comment.module and import
> module. Import module has the problem of not taking care of the fact in
> the arg() function calls that the module is pushed one level down in the
> menu (similar to the user.module and block.modules problems already
> fixed). The comment.module has a problem with trying to translate an $op
> which comes from the URL (and is therefore not translated).
>
> The attached patch also fixes the bogus URLs in import.module help texts
> (as the module part is pushed down into /admin/node instead of /admin).
2003-09-29 19:11:39 +00:00
Dries Buytaert c8b28009cd - Made sure all menu items can be translated. Path by Goba. 2003-09-28 15:18:55 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert 49fb60a08b - Fixed documentation bug in import module. 2003-08-20 21:14:17 +00:00
Dries Buytaert 6b63aa6638 - Updated the import module to the new documentation scheme. Patch by
Michael.
2003-08-20 21:00:31 +00:00
Dries Buytaert 8a2d5bede9 - Rewrote handling of forum icons and added default icons made by Steven
Wittens.

- Renamed some column titles in the forum module as per Moshe's suggestion.

- Introduced a 'more-link' class to position the 'more' links.  Removed
  hard-coded markup from the modules.

- Fixed bug in import module: the theme functions called a non-existing
  function.
2003-08-16 05:49:45 +00:00
Dries Buytaert 6842d59732 - Documentation fixes by Michael F. 2003-08-13 18:40:26 +00:00
Dries Buytaert b22cd5d1c7 - Bugfix: changed an inner join back to a left join. Patch by Bart Jansens 2003-08-10 10:35:26 +00:00
Dries Buytaert 39950fe2e2 - Committed a modified version of Ulf's input checking changes. Patch #95.
I added an error message, changed a few things around and fixed tw typos.
2003-08-08 22:24:55 +00:00
Dries Buytaert 22b6d2f30c - Performance improvement: changed a fair amount of "left joins" to "inner
joins".  Patch by Gerhard.
2003-07-12 22:21:55 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert 877143131d - Bugfix: don't show the "blog it" links when the blog module is disabled.
Patch by Bart Jansens.
2003-07-08 09:07:30 +00:00
Dries Buytaert 4d29898a96 - Bugfix: flush the cache after updating the new feeds (or after having
added or removed news items).  Fixes bug #2088.
2003-06-28 22:48:18 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert 1c38cd9099 - Bugfix: renamed "create PHP content" to "create php content". Reported
by Simon, patch by Gerhard.

- Improvement: synchronized the import module help with the version on
drupal.org.
2003-06-24 15:55:22 +00:00
Dries Buytaert 265127591f - Bugfix: fixed the character when importing news feeds. Reported at
http://drupal.org/node/view/2036.
2003-06-22 07:36:06 +00:00