Commit Graph

118 Commits (cdbcbac8b0c626af1e5ce04a0cdf7853af764fef)

Author SHA1 Message Date
Dries Buytaert 77130e7ab2 - Patch #36079 by James: fixed date handling in blogapi.module. 2005-12-16 06:36:00 +00:00
Dries Buytaert ab0232c022 - Patch #37737 by asimmonds/eaton: fixed blogapi.module checkboxes on settings page. 2005-12-03 09:59:25 +00:00
Dries Buytaert bcb6257b31 - Removed valid_input_check(). 2005-11-30 10:09:28 +00:00
Dries Buytaert dac42f83c8 - Patch #36079 by ax/chx: various blogapi.module fixes. 2005-11-09 19:03:35 +00:00
Dries Buytaert b4644f8e66 - Patch #36250 by hunmonk: admin batch delete broken, node_delete needs reworked.
This commit changes the node_delete() API.  A list of affected modules is available at http://drupal.org/node/36250#comment-52963.
2005-11-04 19:40:28 +00:00
Dries Buytaert a8b218827a - Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! / 2005-11-01 10:17:34 +00:00
Steven Wittens 0cac6939b7 - Fix usage of header() to drupal_set_header()
- Emit charset for blogapi RSD
2005-10-25 03:43:57 +00:00
Dries Buytaert 81b35fbe4a - Patch #34749 by ax: make blogapi autodiscovery (rsd) work with Flock. Yay! 2005-10-21 09:56:59 +00:00
Dries Buytaert 75fe6b6c0a - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. 2005-10-11 19:44:35 +00:00
Dries Buytaert a1ae4da70b - Removing tabs and trailing whitespaces. 2005-10-07 06:51:43 +00:00
Dries Buytaert 7e1527ee61 - Patch #29465: new form API by Adrian et al.
TODO:
  + The contact.module was broken; a new patch for contact.module is needed.
  + Documentation is needed.
  + The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert 56903f504a - Patch #31650 by Robert: removed redundant XML-RPC blogapi setting. 2005-09-19 18:41:30 +00:00
Steven Wittens 69247d7aad - #30128: Call by reference left-overs 2005-09-02 02:11:41 +00:00
Dries Buytaert d9d6a6e05c - Patch #7582 by Gerhard: improved node revisions!
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node.  This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.

TODO:

1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions.  Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
Dries Buytaert c9fc300b1f - Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system!  If you have a module that implements node
  types, you'll have to udpate its CVS HEAD version.

  We replaced _node_name() and _node_types() by _node().  The new _node()
  hook let's you define one or more node types, including their names.
  The implementation of the _node() hook needs to:

   return array($type1 => array('name' => $name1, 'base' => $base1),
                $type2 => array('name' => $name2, 'base' => $base2));

  where $type is the node type, $name is the human readable name of the type
  and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.

  For example, the story module's node hook looks like this:

    function story_node() {
      return array('story' => array('name' => t('story'), 'base' => 'story'));
    }

  The page module's node hook module like:

    function page_node() {
      return array('page' => array('name' => t('page'), 'base' => 'page'));
    }

  However, more complex node modules like the project module and the
  flexinode module can use the 'base' parameter to specify a different base.

  The project module implements two node types, proejcts and issues, so it
  can do:

    function project_node() {
      return array(
       array('project_project' => array('name' => t('project'), 'base' => 'project'),
       array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
    }

  In the flexinode module's case there can only one base ...

  This hook will simplify the CCK, and will make it easy (or easier) to merge
  the story and page module.

  In addition, node_list() became node_get_types().  In addition, we created
  the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 6a4e6df36f - Patch #17592 by killes: improved access denied messages. 2005-08-22 20:39:43 +00:00
Dries Buytaert 79f08aca2c - Patch #26637 by Robert Douglas: $teaser misnamed in themes theme_node().
TODO: update documentation!
2005-08-07 14:55:17 +00:00
Steven Wittens e545feff3e - #28053: left-over blogapi bugs after xmlrpc library switch 2005-08-02 22:18:12 +00:00
Dries Buytaert 4da128a416 - Fixed problem with node_load() in blogapi. Reported by nysus. 2005-07-19 16:32:05 +00:00
Steven Wittens 6978fcb6ec - Typo after node_load simplification patch 2005-07-17 23:44:47 +00:00
Dries Buytaert 2895357de0 - Modified patch #25031 by chx: modified node_list() so one has both the module and its type.
TODO: update migration page in handbook.
2005-07-17 20:57:43 +00:00
Dries Buytaert 160a1e0ef8 - Patch #25634 by chx: simplified node_load(). 2005-07-17 18:29:32 +00:00
Dries Buytaert ed3bf725bb - Patch #26391 by chx: replaced the old XML-RPC library with a smaller/better/working one. 2005-07-13 18:46:15 +00:00
Dries Buytaert eb803411d1 - Patch #24003 by Steven: fix problems with node attribute checking (and improve defaults). 2005-06-06 18:59:37 +00:00
Steven Wittens a597354bcb - Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags. 2005-05-31 21:14:27 +00:00
Steven Wittens 195f672075 - Missing parameter for variable_get 2005-04-27 17:07:03 +00:00
Steven Wittens 31d2520e8d - #20868: Blogapi was still using the old workflow variables. 2005-04-23 06:38:27 +00:00
Dries Buytaert f401bbf048 - Patch #19406 by David: fixed problem with posting using BloggerAPI. 2005-04-13 19:03:36 +00:00
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Dries Buytaert e872b005f1 - Patch #6195 by nedjo/James: allow posting to multiple node types. 2005-01-31 19:36:20 +00:00
Steven Wittens 8655d4368a - Fixing a couple of watchdog() calls. 2005-01-09 12:58:53 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert 25bbc0d4c4 - Fixed parentheses. 2004-10-18 18:40:53 +00:00
Dries Buytaert 07cdcb439b - Patch by James: made the blogapi module work again. 2004-10-18 18:29:15 +00:00
Dries Buytaert c9d1894911 - Patch #11682: changed FILTER_DEFAULT_FORMAT to FILTER_FORMAT_DEFAULT to make the Blog API work. 2004-10-18 08:00:41 +00:00
Dries Buytaert cca3c34faa - Patch #11401 by Goba: documentation updates:
+ Made error strings in blog.module consistent.
   + Explained a bit better what the RSD setting is for in the blog module.
   + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
2004-10-09 06:29:16 +00:00
Dries Buytaert de93655e36 - Patch #10993 by walkah: fixed problem with blogapi's error checking. 2004-09-21 20:18:24 +00:00
Steven Wittens 2f0221e9dd Fixing default of node_promote_blog to match node.module. 2004-09-17 18:00:16 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert e891a8785c - Patch #10669 by Ax: bugfix: getting a post from latest Drupal into latest ecto yields an error "response contains string value where integer expected". 2004-09-09 05:15:38 +00:00
Steven Wittens 44f341bebc Patch by me and Kjartan.
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 5f9bea269c - Patch #10115 by James: bugfixes:
+ If an array of tb urls is given for mt_tb_ping_urls, the last url actually gets pinged twice.
   + mt_allow_comments and mt_convert_breaks were not being sent properly in the xmlrpc response for getPost.
2004-08-16 20:32:32 +00:00
Dries Buytaert 3a259e9184 - Patch by James Seng and James Walkah:
* Don't rely on a blog table (i.e. do 'extended' the drupal way.
  * Allow listing / setting new 'input format' - (using mt.supportedTextFilters).
  * Handle MT extensions to metaWeblog.newPost/editPost where applicable.
  * Implemented mt.supportedMethods.
  * Also did a bit of refactoring to make sure we generate post values the same for both newPost/editPost but also for getRecentPosts and getPost
2004-08-15 18:55:03 +00:00
Dries Buytaert 334f24b448 - Patch by James: made the blogapi work with DA.
* Refactored the "brains" of user_login() to user_authenticate($user, $pass) so that blogapi (and others) can authenticate users (including those using DistAuth) without all the html and drupal_goto calls
   * Updates blogapi_validate_user to use user_authenticate.
2004-08-14 07:00:27 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert 3613729d4f - Patch #8398 by TDobes: changed permissions for the blog, story, and page modules (and all occurrances elsewhere) to match their 4.4.x equivalents. In the discussion when these permissions were introduced, it was decided that "edit own ..." was clearer, but "maintain personal ..." slipped into CVS HEAD anyway, while "edit own ..." landed in the 4.4.x branch.
Changes are as follows:
"maintain personal blog" -> "edit own blog" (aggregator.module, blog.module, blogapi.module)
"maintain personal pages" -> "edit own pages" (page.module)
"maintain personal stories" -> "edit own stories (story.module)
2004-07-13 20:40:46 +00:00
Dries Buytaert 0654129e16 - Patch #8382 by jseng/junyor: allows autodiscovery of BloggerAPI via RSD. 2004-07-06 16:54:28 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert 6f48727a9a - Patch #8357 by Ax: added support for mt.getRecentPostTitles to the
blogapi module.  Used by ecto.  I changed '$titles_only' to '$bodies'
  as the patch favored '!$titles_only'.
2004-06-15 17:45:44 +00:00
Kjartan Mannes 818d636e00 - Commiting patch #7577: comment.module clean up. 2004-06-04 18:50:29 +00:00
Kjartan Mannes c957fe0aab - Commited patch #4878: Support file uploads via blogapi. 2004-06-04 18:00:48 +00:00
Dries Buytaert c0b85a5721 - Patch #4950 by Stefan (and Morbus): made watchdog messages translatable. 2004-06-02 19:01:40 +00:00
Dries Buytaert 7640f490a8 - Patch #8244 by walkah: Taxonomy_get_tree changes break mt.getCategoryList 2004-06-02 18:46:04 +00:00
Dries Buytaert d09023164e - Patch #7957 by James: made the blogapi module send absolute URLs instead of relative URLs. 2004-05-22 21:32:07 +00:00
Dries Buytaert e1447f9b5a - Code improvements to the blogapi module. Patch by JonBob. 2004-05-15 15:33:26 +00:00
Dries Buytaert 2caeac91ae - Patch #7163 by walkah: blogapi mt.getCategoryList should return an empty array by default. Reported by Adriaan. 2004-04-15 21:40:37 +00:00
Dries Buytaert 1080e6c04b - Fixed bug 4722. Patch by James. 2003-12-22 11:28:07 +00:00
Kjartan Mannes 77a0d99c86 - Fixed bug #4722: blogger.newPost not working. Patch by James Walker. 2003-12-20 11:57:40 +00:00
Kjartan Mannes 84c7e91a2d - Fixed <title> extraction deleting body.
- Fixed metaWeblog/Blogger incompatibilities in blogger.editPost and
  blogger.getRecentPosts.
- Fixed coding style deviations.
- Fixed access checks, now requires maintain personal blog.
- Fixed taxonomy integration.
- Fixed blogger.getUserInfo
- Improved user login/access error messages.
2003-12-09 23:38:32 +00:00
Dries Buytaert fff2f548ac - Improved form items: added <label> tags to improve accessibility and added
theme_form_element() function to improve themeability.  I left form_item()
  and the calls to form_item() intact for now.
2003-11-17 19:16:55 +00:00
Dries Buytaert 2f639017c4 - Replaced the bloggerapi module by the blogapi module writen by James. 2003-11-15 20:11:04 +00:00