Commit Graph

229 Commits (cc63aad6587b1eaa2bb9f2f9a51655e97eb23ec5)

Author SHA1 Message Date
Alex Pott 8b1819bf3b
Issue #3276213 by nod_, Wim Leers, lauriii, mherchel, longwave: Uncaught exception when data-caption contains markup upcasting to a model element 2022-11-16 11:38:14 +00:00
Dave Long b2bc383ebe Issue #3319917 by nod_, lauriii: Remove raw-loader dependency 2022-11-09 14:31:21 +00:00
Alex Pott a844919d15
Issue #3319735 by claudiu.cristea: Rename CKE5 button tooltip "Insert Drupal Media" to "Insert Media" 2022-11-09 09:08:30 +00:00
Alex Pott b5208e2855
Issue #3318867 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 35.3.0 2022-11-03 16:55:50 +00:00
effulgentsia 4ff2694583 Issue #3313473 by Wim Leers, tim.plunkett, effulgentsia, smustgrave, mglaman, balintpekker: CKEditor 5 plugin definitions should be derivable 2022-11-02 14:14:04 -07:00
catch e9d3e92f88 Issue #3317330 by Wim Leers, nod_: Random failure in ImageTest::testAltTextRequired 2022-10-26 15:36:58 +01:00
catch a575c44283 Issue #3315884 by Wim Leers, lauriii: Fix typos: s/CKEditor5/CKEditor 5/ 2022-10-26 09:11:33 +01:00
catch 35f35949ad Issue #3317332 by Wim Leers: Remove obsolete core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/README.md 2022-10-26 09:07:11 +01:00
catch 6a1bac3cc0 Issue #3316816 by Wim Leers, nod_: Stabilize FunctionalJavascript testing AJAX: make ::setValue() trigger both "input" and "formUpdated" events 2022-10-24 12:59:34 +01:00
catch e7943531b3 Issue #3314478 by Wim Leers, pooja saraah, smustgrave, lauriii, alexpott: Follow-up for #3231334: global attributes should result in HTMLRestrictions becoming simplified 2022-10-21 13:44:27 +01:00
catch cd4c806b0d Issue #3314770 by Wim Leers, smustgrave, bnjmnm, alexpott: Enforce order of CKEditor 5 plugin settings in config export (as well as other sequences) 2022-10-21 13:35:32 +01:00
catch b4b36b94b4 Issue #3313946 by nod_, longwave, Wim Leers: Update CKEditor 5 to 35.2.1 2022-10-21 07:27:49 +01:00
Alex Pott c0d535a9b5
Issue #3315319 by Wim Leers, Spokje, alexpott, lauriii: Random fails in Drupal\Tests\ckeditor5\FunctionalJavascript\AdminUiTest and Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test 2022-10-18 16:32:56 +01:00
Alex Pott 1de949a521
Issue #3314511 by Wim Leers: CKEditor 4 → 5 upgrade path may trigger warnings in some edge cases, making upgrade path tests impossible 2022-10-11 21:13:40 +01:00
Alex Pott 78fb66dfd2
Issue #3314541 by saschaeggi, eashika, Wim Leers: Remove unnecessary fill from SVG icon for the "Media Library" CKEditor 5 button — enabling dark mode support in contrib 2022-10-11 15:09:46 +01:00
Alex Pott b29f980b79
Issue #3112452 by lalitware, guilhermevp, narendra.rajwar27, WagnerMelo, ravi.shankar, mradcliffe, adalbertov, himanshu_sindhwani, quondam, Vidushi Mehta, alexpott, longwave, anmolgoyal74: Fix indentation consistency in core's yaml files 2022-10-09 12:06:21 +01:00
Alex Pott dd250aca70
Issue #3276469 by Wim Leers, Reinmar: [drupalMedia] MediaImageTextAlternativeUi has an extraneous border on the "cancel" button 2022-10-06 22:33:20 +01:00
Lauri Eskola 3a4d030cb1
Issue #3300246 by mglaman, Wim Leers: Allow other CKEditor 5 plugins to rerender drupal-media when their attribute changes 2022-10-06 16:45:48 +03:00
Alex Pott a30c59d48c
Issue #3310760 by poker10, Wim Leers: Broken issue links in @todos 2022-10-03 20:06:14 +01:00
Alex Pott 846cce70f4
Issue #3284254 by Wim Leers, smustgrave, nod_: HTMLRestrictions should not allow <tag attr="*"> because that is equivalent to <tag attr> 2022-10-03 16:53:07 +01:00
Alex Pott 6bbfb05500
Issue #3181778 by quietone, longwave, aldairsoares, beatrizrodrigues, Aline Teixeira Ramos, KapilV, raman.b, anushrikumari, CChiste, mallezie, Ratan Priya, rakesh.regar, Kevin.Notari, vicheldt, mauryarahul11, yogeshmpawar, bbrala, alexpott, bruno.bicudo: [w/c September 17th] Replace t() with $this->t() in all plugins 2022-09-28 09:49:56 +01:00
Alex Pott 2c468a0049
Issue #3264947 by Niklan, quietone, ravi.shankar, longwave, TR, xjm: [Sep 12, 2022] Add missing docblocks for test methods ::setUp() and ::tearDown() 2022-09-27 13:28:52 +01:00
Lauri Eskola 6da66e99da
Issue #3196973 by casey, nod_, andypost, yogeshmpawar, droplet, Wim Leers, justafish, finnsky: Use Mutation observer for BigPipe replacements 2022-09-23 17:55:59 +03:00
catch c1b854c381 Issue #3309800 by Spokje: /core/modules/ckeditor5/js/ckeditor5.js fails JS linting 2022-09-15 09:42:41 +01:00
catch 1781f1fa4a Issue #3309318 by longwave: Remove IE11 workaround from CKEditor 5 2022-09-13 12:19:05 +01:00
catch 8aa8ce1ffb Issue #3278415 by nod_, lauriii, catch, Wim Leers, longwave, xjm, claudiu.cristea: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies 2022-09-09 07:26:42 +01:00
catch 09f8f13d8a Issue #3270438 by Wim Leers, xjm, Spokje, lauriii, nod_: Remove CKEditor 4 from core 2022-09-08 13:20:26 +01:00
catch aa2f8c333a Issue #3307186 by lauriii, xjm, Wim Leers, catch, hooroomoo, yash.rode, Luke.Leber, zrpnr, nod_, Spokje, gabesullice, bnjmnm, anand.toshniwal93, tim.plunkett: Mark CKEditor 5 stable 2022-09-07 15:06:29 +01:00
Lauri Eskola 3f094e0c29
Issue #3280343 by bnjmnm, pooja saraah, Wim Leers: Audit of CKEditor 5 @todo items 2022-09-07 10:09:29 +03:00
Alex Pott d0154b5bfd
Issue #3307713 by lauriii, Spokje: Remove @ckeditor/ckeditor5-dev-utils 2022-09-06 00:11:21 +01:00
bnjmnm 5a240204ec Issue #3231336 by Wim Leers, lauriii: Simplify HtmlRestrictions and FundamentalCompatibilityConstraintValidator now that "forbidden tags" are deprecated 2022-09-02 10:09:17 -04:00
Lauri Eskola 76486e0e10
Issue #3275120 by Wim Leers, bnjmnm: [drupalMedia] alt_field setting on "Image" media not respected 2022-09-02 16:49:33 +03:00
xjm 45904f2ade
Issue #3306153 by lauriii, Wim Leers, bnjmnm: Update CKEditor 5 to 35.1.0 2022-08-31 13:59:16 -05:00
bnjmnm e4d7b69b1a Issue #3285054 by lauriii, Wim Leers: Add ckeditor5-stylesheets: false to Claro and Olivero (and fix it) 2022-08-31 11:22:32 -04:00
Lauri Eskola 4024e3c478
Issue #3304731 by phenaproxima, bnjmnm: Update remaining tests using Classy to use Starterkit 2022-08-31 10:46:00 +03:00
bnjmnm e1d4f00419 Issue #3222756 by nod_, Wim Leers, bnjmnm, scott_euser, Akhildev.cs, lauriii, catch: Allow using images from external source 2022-08-30 14:41:43 -04:00
catch 11c447451c Issue #3227033 by Spokje, xjm, dww, longwave, Wim Leers, ravi.shankar, catch, mstrelan, quietone, bbrala: Remove Quick Edit from core 2022-08-29 20:57:07 +01:00
Lauri Eskola c2af57548d
Issue #3291797 by mherchel, andy-blum, lauriii, xjm, catch: Refactor Drupal 10 settings tray / off-canvas to use modern CSS 2022-08-29 11:47:09 +03:00
Lauri Eskola f09840a74b
Issue #3270734 by Wim Leers, longwave, andregp, bnjmnm: Update Editor + CKEditor 5 module to not use CKEditor 4 in tests 2022-08-26 21:08:10 +03:00
Lauri Eskola 226fa76bf2
Issue #3306216 by bnjmnm, Wim Leers, Reinmar: Contrast perception issues with icons including low-opacity fills 2022-08-26 20:02:03 +03:00
Lauri Eskola 9ca6256b8a
Issue #3271097 by bnjmnm, xjm, Wim Leers, phenaproxima: Replace CKEditor 4 with CKEditor 5 in the Standard profile and StandardTest 2022-08-25 23:37:53 +03:00
Lauri Eskola 1921b1bddf
Issue #3305621 by longwave, Wim Leers: HTMLRestrictions::mergeAllowedElementsLevel() fails when merging <ol type="1"> 2022-08-24 18:17:11 +03:00
Alex Pott f7ef84514c
Issue #3278636 by nod_, Wim Leers, mrinalini9, bnjmnm: HTMLRestrictions::fromString() bug: multiple occurrences of same tag results in only last one being respected 2022-08-22 09:11:19 -07:00
catch ee3835bcc1 Issue #3283776 by Wim Leers, lauriii: Make CKEditor5PluginDefinition::getElements() consistent with CKEditor5PluginDefinition::get*() 2022-08-21 16:16:30 +09:00
catch cc2cafca3b Issue #3268306 by lauriii, Wim Leers, catch, Dom.: [GHS] Custom/unofficial HTML tags not retained: <drupal-media>, <drupal-entity>, <foobar> 2022-08-19 23:48:31 +09:00
bnjmnm fb85980012 Issue #3294908 by nod_, Wim Leers, DanielVeza: Configuration overlaps between Styles and other CKE5 plugins 2022-08-17 12:32:35 -04:00
Alex Pott 6a1855c2e2
Issue #3290810 by Spokje, catch, dww, longwave, alexpott: Remove updates added prior to 9.4.0 (9.4.4 for ckeditor) and add 9.4.0 database dumps 2022-08-11 13:02:30 +01:00
Alex Pott b957382d75
Issue #1014086 by catch, nod_, martin107, quietone, dww, mariacha1, Spokje, yogeshmpawar, pounard, Wim Leers, mfer, mikeytown2, mbutcher, moshe weitzman, Fabianx, borisson_, alexpott, donquixote, sun, andypost, dawehner: Stampedes and cold cache performance issues with css/js aggregation 2022-08-08 10:12:23 +01:00
Lauri Eskola 4efef25d16
Issue #3301631 by nod_, Taran2L, xjm: Regression with CKEditor 35.0.1 and modal dialogs 2022-08-06 00:12:34 +03:00
bnjmnm 0603b8c233 Issue #3222797 by Wim Leers, nod_, bnjmnm, larowlan, mpp, Luke.Leber, lauriii, DanielVeza, Reinmar: Upgrade path from CKEditor 4's StylesCombo to CKEditor 5's Style 2022-08-05 08:20:57 -04:00
catch 65319149c0 Issue #3292780 by nod_, Spokje: Move Quick Edit related Javascript from core/modules/ckeditor5/js/ckeditor5.es6.js::detach() to the Quick Edit module 2022-08-04 20:18:45 +09:00
xjm b68ad4691c
Issue #3301495 by lauriii, xjm, nod_, quietone: Update CKEditor 5 to 35.0.1 2022-08-03 21:26:10 -05:00
Alex Pott 07a160117a
Issue #3295935 by lauriii: Follow-up to #3268983: Move test case to correct group 2022-07-26 09:31:37 +01:00
Lauri Eskola b6f4e50475
Issue #3245967 by bnjmnm, Wim Leers, nod_, lauriii, tim.plunkett, andregp, Antoniya, AaronMcHale, rkoller, cedewey, worldlinemine, shaal: Messages upon switching to CKEditor 5 are overwhelming 2022-07-14 22:09:53 +03:00
Lauri Eskola c78d1a8987
Issue #3268983 by nod_, iSoLate, plach, Wim Leers, acbramley, larowlan, scott_euser, catch: [regression] FilterHtml throws Unsupported operand types error when * used in tag attribute 2022-07-14 12:56:27 +03:00
Lauri Eskola f5d4496eef
Issue #3295898 by Spokje, nod_: Remove core/modules/ckeditor5/ckeditor5.libraries.yml.orig 2022-07-14 10:38:09 +03:00
Lauri Eskola cd700d8409
Issue #3281454 by _shY, pooja saraah, deviantintegral, quietone, alexpott, nod_: Update various module tests to not use Bartik and Seven 2022-07-13 12:01:29 +03:00
catch e67c6851df Issue #3246246 by Wim Leers, effulgentsia, lauriii, xjm, nod_: CKEditor 5 plugins needing more complex conditions: point to handbook page 2022-07-13 11:19:40 +09:00
catch 0becafafbc Issue #3271094 by Wim Leers, lauriii, xjm, catch: Move Media CKEditor 4 integration into CKEditor 2022-07-11 12:24:52 +09:00
catch ccce80147c Issue #3291744 by lauriii, xjm, Abhijith S, Wim Leers, bnjmnm, catch: Ensure Editor config entities using CKEditor 4 only store plugins settings for actually enabled plugins 2022-07-11 11:37:07 +09:00
catch c60c4fc316 Issue #3291295 by Ishani Patel, Webbeh: Incorrect ckeditor5.plugin.media_media schema label 2022-06-30 22:00:41 +01:00
xjm 4a960dce1b
Issue #3270831 by Wim Leers, bnjmnm, xjm, catch: Make the CKEditor 4 → 5 upgrade path work even when the CKEditor 4 module is removed 2022-06-29 12:28:34 -05:00
catch c1ef4a06e4 Issue #3292626 by Spokje, dww: Remove core/modules/ckeditor5/css/quickedit.css 2022-06-25 23:00:21 +01:00
catch 1c5c378e02 Issue #3291018 by Spokje, Wim Leers: Move \Drupal\Tests\ckeditor5\Functional\CKEditor5QuickEditLibraryTest to the quickedit namespace/directory 2022-06-17 16:40:04 +01:00
catch e47f94cab0 Issue #3291047 by Wim Leers, Spokje: Move Quick Edit-specific styling of CKEditor 4 & 5 into Quick Edit module 2022-06-17 14:48:30 +01:00
Alex Pott 6dd0db56c8
Issue #3281535 by mondrake, daffie: Fix 'Access to an undefined property' PHPStan L0 errors in test code 2022-06-14 11:27:54 +01:00
Alex Pott cf9a90784a
Issue #3283599 by eleonel: Fix a typo in Help message on ckeditor5.module 2022-06-13 10:53:01 +01:00
catch 3ccd5985f4 Issue #3251384 by mherchel, xjm, catch, ckrina, longwave, andy-blum, droplet, lauriii, bnjm: Remove support for UC Browser 2022-06-10 13:29:37 +01:00
Lauri Eskola 6d6ab58776
Issue #3274937 by nod_, woldtwerk, Dom., Wim Leers: Get CKEditor 5 to work in (modal) dialogs 2022-06-09 17:38:23 +03:00
bnjmnm 6bfe646ddc Issue #3247683 by Wim Leers, lauriii, bnjmnm, Reinmar: Disable CKEditor 5's automatic link decorators (in Drupal filters should be used instead) 2022-06-06 12:34:11 -04:00
bnjmnm 02e337e913 Issue #3273983 by Wim Leers, ifrik, lauriii: Do not assume that plugin supporting <tag attr> also supports <tag> in SourceEditingRedundantTags and upgrade path 2022-06-06 12:22:09 -04:00
Lauri Eskola 94b5d57502
Issue #3274648 by nod_, Wim Leers: HTMLRestrictions::merge() and ::toGeneralHtmlSupportConfig() fail on allowed attribute values that can be interpreted as integers 2022-06-01 12:27:12 +03:00
bnjmnm a476ccf7a5 Issue #3276217 by lauriii, Wim Leers: [drupalMedia] add tests to confirm GHS attributes are retained in linked media 2022-05-31 16:43:09 -04:00
Lauri Eskola 9018da4a5b
Issue #3274651 by Wim Leers, nod_, alexpott: Impossible to enable <ol type> or <ul type> with GHS: switch to List's successor, DocumentList 2022-05-30 17:33:58 +03:00
xjm 3b3972e94a
Issue #3277438 by Wim Leers, bnjmnm, lauriii, xjm, nod_, Reinmar: Update to CKEditor 5 v34.1.0 2022-05-26 16:08:26 -05:00
Alex Pott c81f543972
Issue #3280602 by larowlan, DanielVeza, Wim Leers, mstrelan: Exceptions for CKEditor 5 plugin definitions containing wildcard tags when PHP is built with libxml 2.9.14 2022-05-19 09:16:09 +01:00
Lee Rowlands 5e24bdc8f6
Issue #3276218 by lauriii: Follow-up to #3268318: Enable link manual decorator unrestricted test case 2022-05-14 12:23:49 +10:00
bnjmnm 11ac481e09 Issue #3259593 by hooroomoo, Dom., Wim Leers, lauriii: Alignment being available as separate buttons AND in dropdown is confusing 2022-05-12 14:00:29 -04:00
Lauri Eskola 32bf036947
Issue #3269657 by hooroomoo, Wim Leers: [drupalMedia] The CKEditor 4 → 5 upgrade path for the media_embed filter should not forcefully allow the `data-view-mode` attribute on `<drupal-media>` 2022-05-11 22:17:03 +03:00
Lauri Eskola b51ab0dafc
Issue #3275237 by hooroomoo, lauriii, Wim Leers, nod_: Don't convert, instead use response.entity_type in DrupalImageUploadEditing 2022-05-09 14:17:28 +03:00
Lauri Eskola ce0ec61fdf
Issue #3278394 by Wim Leers, bnjmnm: HTMLRestrictions' diff operation bug: diff(<tag attr="A B">, <tag attr>) should return an empty result 2022-05-09 11:36:19 +03:00
Alex Pott da0e89bcc6
Issue #3278163 by xjm, nod_, lauriii: yarn upgrade for latest security vulnerabilities 2022-05-05 09:20:46 +01:00
catch 35b8d4f54c Issue #3272516 by Wim Leers, yogeshmpawar, bnjmnm, catch: Deprecate FilterInterface::getHTMLRestrictions()' forbidden_tags functionality 2022-05-02 17:20:08 +01:00
catch a9ac24ad01 Revert "Revert "Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes don't work if alignment not enabled""
This reverts commit 45ee80dd72.
2022-04-28 21:25:26 +01:00
catch 45ee80dd72 Revert "Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes don't work if alignment not enabled"
This reverts commit 72c250879a.
2022-04-28 20:55:43 +01:00
bnjmnm 5127c3fa59 Issue #3228691 by Wim Leers, lauriii, nod_: Restrict allowed additional attributes to prevent self XSS 2022-04-28 10:41:49 -04:00
bnjmnm 72c250879a Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes don't work if alignment not enabled 2022-04-28 08:31:52 -04:00
Lauri Eskola e935c438b8
Issue #3261599 by hooroomoo, Wim Leers, bnjmnm: Use CKEditor 5's native <ol start> support (and also support <ol reversed>) 2022-04-28 02:10:38 +03:00
catch b0d868fcfb Issue #3229078 by scott_euser, Wim Leers, hooroomoo, brentg, yogeshmpawar, catch: Unit tests for all @CKEditor5Plugin plugin classes 2022-04-27 21:27:02 +01:00
catch ad44453c64 Issue #3248425 by nod_, yogeshmpawar, Wim Leers, lauriii, bnjmnm, marcvangend: Ensure that all classes and functions in Drupal-specific CKEditor 5 plugins are documented 2022-04-27 12:54:38 +01:00
catch b26aa84f01 Issue #3276627 by Wim Leers, hooroomoo: CKEditor5::shouldHaveVisiblePluginSettingsForm() does not correctly handle configurable CKE5 plugin that has a filter condition 2022-04-27 12:11:52 +01:00
catch 44f5e5c5c8 Issue #3276670 by hooroomoo, Wim Leers: Some configurations of allowed view modes cause CKE to fail to initialize 2022-04-27 12:07:14 +01:00
Lauri Eskola 464291fb69
Issue #3231334 by Wim Leers, bnjmnm: Global attributes (<* lang> and <* dir="ltr rtl">): validation + support (fix data loss) 2022-04-26 17:56:10 +03:00
Lauri Eskola 613b8627d1
Issue #3230230 by bnjmnm, johnwebdev, Wim Leers, lauriii, Anna_CKSource, Reinmar: Enable table captions; override CKE5's default downcast to generate <table><caption></table> instead of <figure><table><figcaption></figure> 2022-04-23 18:04:50 +03:00
Lauri Eskola 1d5995a256
Issue #3261943 by bnjmnm, lauriii, Wim Leers, andreasderijcke, ifrik: Confusing behavior after pressing "Apply changes to allowed tags" with invalid value 2022-04-23 17:37:28 +03:00
Alex Pott dafde75531
Issue #3273325 by Dom., Wim Leers, andregp, ifrik: CKE5 and contrib: better "next action" description on upgrade path messages 2022-04-15 13:21:06 +01:00
Alex Pott 46903e6c3c
Issue #3274278 by Wim Leers, jcnventura, yogeshmpawar, andregp, bnjmnm: Migrate "codetag" contrib CKEditor 4 plugin to built-in equivalent in core's CKEditor 5 2022-04-15 13:16:28 +01:00
Alex Pott b825f91084
Issue #3233491 by hooroomoo, xjm, lauriii, nod_, justafish, droplet, effulgentsia: Create process for reviewing changes in 3rd party JavaScript dependencies 2022-04-15 13:12:47 +01:00
bnjmnm 42b26d707a Issue #3245720 by hooroomoo, nod_, Wim Leers, lauriii, yash.rode: [drupalMedia] Support choosing a view mode for <drupal-media> 2022-04-14 10:11:56 -04:00
bnjmnm c4197f11f1 Issue #3268318 by lauriii, Wim Leers, tim.plunkett: [drupalMedia] <a> with GHS allowed attributes downcast wraps data-caption with <a> 2022-04-13 11:01:49 -04:00