Commit Graph

389 Commits (cb34d838f32095d551fbd81f5655205126811725)

Author SHA1 Message Date
Dries Buytaert 3a7b64ae03 - Patch #61893 by timnc: remove message_na(). 2006-07-29 17:56:41 +00:00
Neil Drumm eaf5f2e029 #49299 by wtanaka, properly break words 2006-07-11 07:04:34 +00:00
Dries Buytaert 58752cfaa2 - Patch #72284 by me:
+ reorganized ?q=admin/settings
   + deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Dries Buytaert e93f8be871 - Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants. 2006-07-05 11:45:51 +00:00
Neil Drumm 59aa2ae8e8 #71925 by Steven, remove # prefix from link array keys. 2006-07-04 08:59:05 +00:00
Neil Drumm af6c897056 #65024 by killes, remove an extra condition. 2006-06-12 03:44:54 +00:00
Dries Buytaert 226eed7047 - Patch #67146 by webchick: make sure that the forum vocabulary shows up first. 2006-06-06 15:35:39 +00:00
Dries Buytaert cf3bfe006b - Patch #18260 by Morbus: fixed taxonomy links. 2006-05-29 12:58:19 +00:00
Dries Buytaert 1b291a2917 - Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules 2006-05-18 14:58:57 +00:00
Dries Buytaert e1304697c4 - Patch #62350 by hunmonk: fixed problem with deleting forum containers. 2006-05-08 15:16:16 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Gerhard Killesreiter d6a164c400 #5371, drupal_get_destination, pager and tablesort array handling, patch by Steven 2006-04-13 08:25:27 +00:00
Steven Wittens 9794b5538e - #55898: Generic, permissive admin XSS/HTML filtering for mission/footer/...
- Clean up some raw output
2006-04-07 15:32:17 +00:00
Gerhard Killesreiter 3000db0d13 #40664, adding new forum topic, forum not pre-selected in pull down menu., fix by Jonas Kvarnstrom, patch by drumm 2006-04-06 18:36:57 +00:00
Steven Wittens be0b774cbc - #57523: Make taxonomy delete vocabulary consistent with other taxonomy hook ops 2006-04-06 04:21:12 +00:00
Steven Wittens ec04325bb2 - Make forum_hot_topic scale a bit more logical 2006-04-06 04:18:30 +00:00
Gerhard Killesreiter 603a6618ee #28625, Forum vocabulary does not handle standard vocabulary features correctly, removed these features by means of formapi, patch by profix898, with some love by dopry and chx 2006-03-31 06:43:46 +00:00
Gerhard Killesreiter 002fee7aae #56105, remove title validation, already enforced by #required, patch by Moshe 2006-03-27 18:02:48 +00:00
Gerhard Killesreiter 0ed9f460dc #55805, missing {}, patch by Cvbge 2006-03-25 10:52:40 +00:00
Gerhard Killesreiter 717d6e30c5 #54098, forum "last post" column show oldest, not most recent, patch by Zen. 2006-03-24 10:13:10 +00:00
Gerhard Killesreiter d11c07502d #54910, Forum and taxonomy term delete work only superficially, patch by Zen 2006-03-23 21:46:35 +00:00
Gerhard Killesreiter 40e2a3b379 #51635, Moving forum post leaving shadow copy results in warning, patch by Zen/webchick 2006-03-08 22:11:54 +00:00
Dries Buytaert 7add598ee2 - Patch #51850 by chx, webchick et al: fixed various problems with db_rewrite_sql, made db_rewrite_sql slightly more robust. 2006-03-08 15:13:20 +00:00
Dries Buytaert d2865f2a99 - Patch #52850 by Zen: fapi conversion + minor fixes
* converts forum_admin to fapi.
    * handles invalid terms in hook_menu
    * adds comments, fixes typos etc.
    * reorganises functions a little bit - moves hook_menu to the top.. groups hooks together and forms together
2006-03-07 19:03:02 +00:00
Dries Buytaert d7e9371e94 - Removing whitespace 2006-03-03 08:37:47 +00:00
Gerhard Killesreiter 1d865eb4c4 #51613, forum.module forms ignore proper form submission path, patch by merlinofchaos 2006-02-28 13:36:59 +00:00
Dries Buytaert 19afd2ceb7 - Patch #45850: it was impossible to create shadow topic. (Today's critical bugfix #2.) 2006-02-23 12:21:15 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert f030164bcb - Patch #46743 by Morbus: fixed double encoding issue. 2006-02-15 20:47:35 +00:00
Dries Buytaert 91152ba7af - Patch #46743 by m3avrck: clean up forum topic navigation. Bring it in line with book.module. 2006-02-10 05:05:44 +00:00
Dries Buytaert 88490f6413 - Patch #47691 by Cvbge: quickfix postgresql 2006-02-09 08:52:03 +00:00
Dries Buytaert a723204ee4 - Patch #47691 by wtanaka: performance improvement for _forum_topics_read. 2006-02-09 08:09:55 +00:00
Dries Buytaert 87f5947e51 - Patch #47868 by wtanaka: performance improvement: active topics block selects an unused column. 2006-02-04 09:56:04 +00:00
Dries Buytaert 31293d5a2e - Patch #46864 by stmind: fixed problem with node-level permissions and forums. 2006-02-01 14:19:44 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert 10d7f7731b - Patch #45281 by chx: made categories with forum topics work again. 2006-01-19 17:55:54 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 52507806eb - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. 2006-01-18 19:29:17 +00:00
Dries Buytaert 92acb92699 - Patch #33747 by Ber and Moshe: bugfix + code improvement: clean up some of the taxonomy loading code. 2006-01-10 12:35:20 +00:00
Dries Buytaert b170d83d14 - Removed global . 2006-01-09 10:12:30 +00:00
Dries Buytaert 4e35060451 - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. 2005-12-31 13:04:40 +00:00
Dries Buytaert 799ceae29b - Patch #42705 by Cvbge: added missing format_plural(). 2005-12-31 11:21:32 +00:00
Dries Buytaert ea2d791095 - Patch 41169 by Chris: got rid of expensvie object 2 array casts. 2005-12-31 10:48:56 +00:00
Steven Wittens 79a193a2d2 - #42234: Use standardized feed icon for RSS 2005-12-29 04:46:40 +00:00
Dries Buytaert 1ef56e36a0 - Patch #42343 by wulff: added 2 missing t() functions. 2005-12-26 11:26:21 +00:00
Dries Buytaert 544aefad8a - Modified patch #40534: improved themability of forum icons (makes it possible to use animated gifs) + removed forum setting. 2005-12-11 12:44:39 +00:00
Dries Buytaert 99e27195e8 - Patch #40664 by Gerhard: assign default forum when adding a forum topic from within a forum. 2005-12-10 19:58:40 +00:00
Dries Buytaert 32d9af4916 - Patch #39598 by Gerhard: fixed problem with taxonomy terms not being selected. 2005-12-06 12:20:24 +00:00
Dries Buytaert c4c5ce122d - Patch #31323 by Gerhard: delete extra data when a revision is deleted. 2005-12-05 16:07:18 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 94f290c8ee - Patch #38849 by wtanaka: forum icon does not display as locked (aka closed) if comments are "disabled" instead of "read only". 2005-12-03 10:02:23 +00:00
Dries Buytaert 272c6b95fa - Patch #39667 by killes: fixed typo in function call: _forum_get_vid -> _forum_get_vid(). 2005-12-02 15:38:58 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00
Dries Buytaert 90535c33aa - Patch #38854 by wtanaka: fixed XHTML validation problem. 2005-11-26 19:45:31 +00:00
Dries Buytaert d4692d569c - Patch #35644 by webchick: fixed the sizes of the textareas on the node edit forms. 2005-11-23 16:18:28 +00:00
Dries Buytaert aeed4cd8e4 - Patch #35644 by webchick: forms API simplificiations. 2005-11-12 11:26:16 +00:00
Steven Wittens 85492ae9a5 #36791: node_validate was called twice 2005-11-12 02:54:13 +00:00
Dries Buytaert b4644f8e66 - Patch #36250 by hunmonk: admin batch delete broken, node_delete needs reworked.
This commit changes the node_delete() API.  A list of affected modules is available at http://drupal.org/node/36250#comment-52963.
2005-11-04 19:40:28 +00:00
Dries Buytaert a8b218827a - Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! / 2005-11-01 10:17:34 +00:00
Dries Buytaert da1de1df9f - Patch #35205 by stefan: removed some deprecated code from forum.module! Yay. 2005-10-28 13:56:26 +00:00
Dries Buytaert 0f37358003 - Patch #35061 by Cvbge/ntosi: fixed SQL query problem on PostgreSQL 8. 2005-10-28 13:40:17 +00:00
Steven Wittens 9f143557a3 - #35505: Forum form api typo 2005-10-28 00:42:55 +00:00
Steven Wittens 6777fdb193 - #26583: Make forum taxonomy links redirect to forums rather than taxonomy pages. 2005-10-21 11:12:46 +00:00
Dries Buytaert 75fe6b6c0a - Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes. 2005-10-11 19:44:35 +00:00
Dries Buytaert a1ae4da70b - Removing tabs and trailing whitespaces. 2005-10-07 06:51:43 +00:00
Dries Buytaert 7e1527ee61 - Patch #29465: new form API by Adrian et al.
TODO:
  + The contact.module was broken; a new patch for contact.module is needed.
  + Documentation is needed.
  + The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert 9981e4326d - Patch #32459 by beardedstoat and tostinni: always add a secondary sort order so the newest comments are on top. 2005-10-01 13:30:06 +00:00
Dries Buytaert cba3391b1f - Fixed spaces 2005-09-27 15:06:35 +00:00
Dries Buytaert 67e68fc679 - Patch #28786 by Neil: move pagers out of table. 2005-09-24 07:53:26 +00:00
Dries Buytaert 61740bd8ee - Patch #10056: allow the node title forms to be customized. 2005-09-23 08:47:13 +00:00
Dries Buytaert 2dddd9e532 - Patch #29102 by menesis: fixed typo/left-over in switch-statement. 2005-09-08 19:22:28 +00:00
Dries Buytaert 16262e03d5 - Patch #28320 by Neil: improved the HTML/CSS of the user login block. 2005-09-07 20:56:00 +00:00
Dries Buytaert 67de4f67d2 - Usablity improvement: check whether the comment module is enabled. If not,
show an error message.
2005-09-06 19:38:56 +00:00
Dries Buytaert d9d6a6e05c - Patch #7582 by Gerhard: improved node revisions!
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node.  This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.

TODO:

1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions.  Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
Dries Buytaert 246274eb16 - Renamed _node() to _node_info()! We reserve _node for _nodeapi. 2005-08-29 19:58:49 +00:00
Dries Buytaert 8f32c39db2 - Patch #29102 by chx: fixed bug in forum module and tidied up the taxonomy_save_*() functions. 2005-08-28 15:58:52 +00:00
Dries Buytaert c9fc300b1f - Patch #29785 by Chx: multiple node types were broken so we refactored
part of the node system!  If you have a module that implements node
  types, you'll have to udpate its CVS HEAD version.

  We replaced _node_name() and _node_types() by _node().  The new _node()
  hook let's you define one or more node types, including their names.
  The implementation of the _node() hook needs to:

   return array($type1 => array('name' => $name1, 'base' => $base1),
                $type2 => array('name' => $name2, 'base' => $base2));

  where $type is the node type, $name is the human readable name of the type
  and $base is used instead of <hook> for <hook>_load, <hook>_view, etc.

  For example, the story module's node hook looks like this:

    function story_node() {
      return array('story' => array('name' => t('story'), 'base' => 'story'));
    }

  The page module's node hook module like:

    function page_node() {
      return array('page' => array('name' => t('page'), 'base' => 'page'));
    }

  However, more complex node modules like the project module and the
  flexinode module can use the 'base' parameter to specify a different base.

  The project module implements two node types, proejcts and issues, so it
  can do:

    function project_node() {
      return array(
       array('project_project' => array('name' => t('project'), 'base' => 'project'),
       array('project_issue' => array('name' => t('issue'), 'base' => 'project_issue'));
    }

  In the flexinode module's case there can only one base ...

  This hook will simplify the CCK, and will make it easy (or easier) to merge
  the story and page module.

  In addition, node_list() became node_get_types().  In addition, we created
  the following functions: node_get_name($type) and node_get_base($type).
2005-08-28 15:29:34 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 97bc92f6b9 - Patch #29133 by DriesK: forum vid remains when vocabulary is deleted. Prevents forum topics from getting lost. 2005-08-18 21:53:55 +00:00
Dries Buytaert 7625a4e91a - Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
Usernames can now be themed; eg. an icon/avatar could be added.

  TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Dries Buytaert 87e5399a9e - Patch #19621 by Morbus/drumm: fixed bugs with taxonomy_save_xxx() functions.
TODO: update image module too?
2005-07-18 19:31:16 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert f12d5c5347 - Patch #21918 by budda/Robin: forum icons are broken when you change the forum icon path. TODO 1: the forum icons should probably be configurable on a per-site or per-theme basis. TODO 2: I spent 5 minutes looking for this setting. 2005-06-19 08:43:59 +00:00
Steven Wittens a597354bcb - Code cleanup: improve format_plural usage, add some missing placeholder/check calls, and introduce API for <link> tags. 2005-05-31 21:14:27 +00:00
Steven Wittens f3cbb10d8e - #19434: Improved forum admin texts. 2005-05-25 06:41:51 +00:00
Steven Wittens 0ff0af1601 - #23014: Only show forum blocks if there are topics to list. 2005-05-25 03:59:38 +00:00
Dries Buytaert 235a39e589 - Removing the /*! USE INDEX */. It actually degrades performance significantly. 2005-05-20 11:04:06 +00:00
Steven Wittens 89ae34de47 - #19621: More sensible status messages for forum admin ("created forum" instead of "created term"). 2005-05-07 01:48:06 +00:00
Steven Wittens 85bf4a010b - Oopsie 2005-05-06 06:41:59 +00:00
Steven Wittens 0d134850d9 - Missing theme placeholder in forum delete message. 2005-05-06 06:32:13 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert c9c947619f - Added missing {}. 2005-04-12 18:55:33 +00:00
Dries Buytaert d0d5b52ac1 - Patch #19884 by Robin Monks: added help text for ?q=admin/forum/configure 2005-04-11 18:21:59 +00:00
Dries Buytaert 5c56cd5b33 - Patch #19434 by nysus: improved the forum module help texts. 2005-04-11 17:54:13 +00:00
Dries Buytaert 38eef18e98 - Patch #19615 by chx: fixed problem forum container getting lets when editing a forum. 2005-04-08 11:07:57 +00:00
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Dries Buytaert 7bdcba1720 - Patch #19739 by Uwe: corrected many typo's in the documentation and code comments 2005-03-31 21:18:08 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens bbae5e815d - #18795: Display message to forum admin if there are no forums yet. 2005-03-27 22:51:47 +00:00