030fd1798a
- Comment bug: anchor links should be specified using $fragment in url() and drupal_goto().
2006-01-06 01:14:17 +00:00
24899dba42
- Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default comment settings on node sumbission forms.
2006-01-05 14:35:55 +00:00
8d7ff5aea2
- Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering setting.
2006-01-05 10:53:47 +00:00
72ed68d48b
- Patch #42971 by markus_petrux: input format not correctly shown when editing a comment.
2006-01-03 23:04:23 +00:00
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
6164074655
- Patch #38999 by saerdna: There's no need that users with the "administer comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments.
2005-12-19 10:12:52 +00:00
21a9442bbb
- Patch #41081 by billturner: fixed problem with the comment settings form.
2005-12-15 16:31:01 +00:00
922a46d281
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
2005-12-15 16:24:40 +00:00
5accfa08f5
- Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
...
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00
764f1177ef
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
2005-12-14 20:10:45 +00:00
3ae534a64e
- Patch #28595 by Cvbge: fixed problems with bulk comment operations.
2005-12-08 09:11:32 +00:00
e019ce5107
- Patch #28595 by Jeremy: added support for bulk operations on comments.
2005-12-07 05:35:02 +00:00
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
80e02e6e73
- Patch #36434 by assimonds: fixed problem with editing signatures.
2005-12-03 19:39:15 +00:00
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
8784a7d13a
- Patch #39024 by Zen: comments that should be in the moderation queue get published.
2005-11-27 11:45:03 +00:00
c647b39c2c
- Patch #37798 by Neil: fixed problem with node settings.
2005-11-27 11:11:46 +00:00
247e012c35
- Patch #39013 by drumm: more logical naming of themeable functions
2005-11-27 11:07:02 +00:00
b1b1e2045f
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
2005-11-25 10:11:59 +00:00
bd2d91807e
- Patch #38575 by Neil: fixed infinite loop in comment.module.
2005-11-23 08:23:45 +00:00
62e5c58777
- Patch #38491 by Neil: refactor comment viewing controls to _execute model.
2005-11-22 15:48:46 +00:00
9f8fcab8db
- Patch #35726 by asimmonds: post_process -> build_after
2005-11-22 15:13:15 +00:00
28f973a986
- Patch #35726 by asimmonds/chx: converted the comment module to the forms API's _execute model.
2005-11-21 08:32:31 +00:00
e900d28640
- Patch #34295 by assimonds: added missing defines to comment.module. Improves
...
readability of the code.
2005-11-15 07:29:47 +00:00
d5d0149abe
- Patch #34295 by DrupalJapan and chx:
...
+ Fixed problem with configuration of comment display options.
+ Introduced defines for the various comment settings.
2005-11-13 09:05:38 +00:00
21bed11e66
- Add missing url()s around form actions (these would break without clean URLs)
2005-11-13 02:32:18 +00:00
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
3d13a38502
- Patch #36727 by Goba: fixed incorrect use of drupal_goto().
2005-11-08 20:57:41 +00:00
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
3fad92fc59
- #34645 : Make $links in theme_comment consistent with theme_node (Stefan)
2005-10-20 09:27:36 +00:00
e83b00d526
- Typo
2005-10-20 08:56:34 +00:00
8164ec2f49
- Code style
2005-10-20 08:53:59 +00:00
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
7863be5e82
- Patch #33433 by chx: fixed a number of form API problems.
...
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
2005-10-08 12:21:47 +00:00
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
0200ccf4da
- Patch by chx: fixed validation check.
2005-10-01 08:43:51 +00:00
1d94bb4a87
- Add some extra options.
2005-09-29 08:04:51 +00:00
45f4bcaa7d
- Patch #26031 by leafish_dylan: fixed comment pager (broken SQL query).
2005-09-27 18:34:59 +00:00
dff2df4809
- Patch #28786 by Neil: moved pagers out of table.
2005-09-27 18:10:19 +00:00
67e68fc679
- Patch #28786 by Neil: move pagers out of table.
2005-09-24 07:53:26 +00:00
2b3126b2cc
Patch #19934 by Morbus, chx: conf_init() should strip out port numbers in bootstrap.inc.
2005-09-19 19:13:35 +00:00
06af3e60e5
- Patch #29866 by Florian, Uwe: made the recent comments block only show comments on public nodes.
2005-09-19 15:11:05 +00:00
dec4ddd3a5
- Patch #28420 by Jeremy: provide a more generic interface that can be used
...
to validate other form submissions, not just comments. Two new functions
are introduced, form_token() and form_validate(). The first function uses
a private key and a public key to set a token in a hidden field. The second
function validates the token. The comment and contect module are updated to
use these functions.
2005-09-18 12:04:10 +00:00
1dc53d9761
- Patch #3986 by James (and Boris :)):consolidated all feed-related settings in one place.
...
* adds a "feed settings" section to admin/settings where 2 new settings are introduced:
* number of items per feed
* default length of feed descriptions (title only, teaser, full)
* patches all of core to obey the above - including the new aggregator (out) feeds
* adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
* includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.
2005-09-18 10:37:57 +00:00
57a734a989
- Patch #16140 by Gerhard: cure array_merge() warning due to invalide menu callback.
2005-09-07 20:45:53 +00:00
d9d6a6e05c
- Patch #7582 by Gerhard: improved node revisions!
...
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.
TODO:
1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions. Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
494e5ab97c
- Renamed 'user comments' to 'comment options' for consistency.'
2005-08-28 15:16:58 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
29d6660149
- Patch #23620 by Robin: don't hard code forms into comment.module. Will be
...
depricated by form API patch though. Hopefully helps migration.
2005-08-17 20:07:35 +00:00
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
e4096e1418
- #27551 : Rename check_output() to check_markup(). Needs contrib updates!
2005-07-29 21:06:33 +00:00
aa2de74fa2
- #27624 , #27614 , #27627 : dead code
2005-07-29 08:18:20 +00:00
bd055961cd
- #25285 : Use correct permission for node form comment admin
2005-07-25 09:41:29 +00:00
50dac6f671
- Fixed typo reported by Stefan: theem -> theme
2005-07-20 15:13:12 +00:00
13954f90dd
- Modified patch #18656 by Moshe: unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. Also gave administrators the ability to change the author and timestamp of a comment. Also removed comment links from the bottom of the comment preview box (as we did for nodes)
...
Modifications: fixed breadcrumbs, tidied up delete confirmation page to be consistent with node deletions..
2005-07-19 17:51:59 +00:00
160a1e0ef8
- Patch #25634 by chx: simplified node_load().
2005-07-17 18:29:32 +00:00
02460ed9d8
- Removed tab.
2005-07-05 19:31:36 +00:00
2c10ff4b5f
- Fixed problems with filter formats and problem with XML-RPC server.
2005-06-29 19:53:14 +00:00
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
e550f84162
- Patch #16204 by Thox: committed the collapsible form elements patch.
...
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
2005-06-21 09:45:45 +00:00
21274fbb94
- #23285 : Allow theming of comment previews, like node previews.
2005-05-22 21:14:59 +00:00
e5ecab0797
- Patch #22804 by Cvbge: fixed typo in documentation.
2005-05-14 17:23:18 +00:00
381853c6b9
- Patch #21221 by Robert: make status values in comment.module defined constants for readability.
2005-05-05 20:12:49 +00:00
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
8f1e9cd720
- Modified patch #18215 by ankur: make sure the comment statistics update after approval in the moderation queue.
2005-04-08 13:34:10 +00:00
a21f084160
- Patch by Drumm: change the wording for clarity.
2005-04-08 13:06:37 +00:00
961cf7af44
- By default, do not show comment controls.
2005-04-07 05:24:08 +00:00
29f6541c5e
- Patch #20103 by Neil: Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway.
2005-04-07 05:21:30 +00:00
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
5ad5f28cda
- Patch #19009 by chx: fixed a bug with comment replies letting one access nodes.
2005-03-20 19:42:14 +00:00
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
332a56334d
- Patch #17161 by Morbus: increase 40-character limit in URL field for comments.
2005-03-16 22:14:15 +00:00
3b5589f436
- Patch #14109 by wulff/Morbus: added missing t() funciton
2005-03-16 19:31:47 +00:00
a16e5d2492
- Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned).
2005-03-12 08:52:29 +00:00
2ec787df34
- Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this. I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module.
2005-03-10 18:28:21 +00:00
198ec98f75
#18329 : Unify confirmation messages (and make them themable)
2005-03-03 20:51:27 +00:00
a794dd4419
- #17877 : Auto-fill comment subject during _validate rather than _save.
2005-02-27 02:56:12 +00:00
5b7ecb8650
- Patch #17208 by asimmonds: help text fixes:
...
- permissions menu link updates in a number of modules help
- anchor link fix in distributed auth help
- "my account" link fix in user help
- spelling correction in tracker.module help
- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
9c5646288c
- Patch #11366 by Junyor: fixed twin comment problem in HEAD.
2005-02-11 19:01:53 +00:00
fbec279e4c
- Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
...
(Moshe: the patch against node.module failed to apply.)
2005-02-01 19:45:58 +00:00
7ae04af1e0
- Patch by Jose A Reyero: fixed probem with db_rewriste_sql() in the comment.module.
2005-01-31 19:30:13 +00:00
59c2208ea6
- Patch #16253 by Goba: incremental improvements to the new content markers.
...
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
993ea0c6c5
- Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query.
2005-01-29 22:02:37 +00:00
467dbdc4a1
- Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though.
2005-01-27 12:57:08 +00:00
173f528f59
- Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
...
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
09bd156ba2
- Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
...
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
e7edb55d63
- The real code fixes ;)
2005-01-17 19:00:03 +00:00
971a0e24aa
- Patch #14731 by chx: made it possible to rewrite node queries.
2005-01-16 18:44:49 +00:00
b8b36bd941
- Fix comment pager counting unpublished comments.
2005-01-12 16:02:42 +00:00
bf12368205
- Fix comment pager counting unpublished comments.
2005-01-12 16:02:20 +00:00
df6fe90286
- Updated two watchdog calls.
2005-01-09 10:06:26 +00:00
64b100d19a
- Patch #13260 by UnConeD: watchdog module improvements.
...
We added a 'severity' column to watchdog():
watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);
* Specify a severity in case you are reporting a warning or error.
* The $link-parameter is now the fourth parameter instead of the third.
TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
1dbe0dc2ee
- Patch #14917 by UnConeD/Steven:
...
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.
2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.
3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
09c55017f6
- Patch #14882 by Jeremy: removed some cruft: status = 2 is no more.
2004-12-29 18:41:52 +00:00
b2e04ead89
- Patch #14710 by tangent: only show post button if preview is optional or if we are in preview mode. We show the post button in preview mode even if there are form errors so that optional form elements (e.g., captcha) can be updated in preview mode.
2004-12-23 06:47:24 +00:00
e7b0b227b9
Making comment moderation query PGSQL/ANSI compatible.
2004-12-20 02:05:00 +00:00
2b17b3a966
- Patch #13907 by Neil: less ways to set the page title.
...
* Less logic in theme code.
* Encourages use of the menu system.
* Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
* Very slightly more efficient.
2004-12-15 21:19:42 +00:00
260f886699
- Fixed typo: db_queryd() -> db_query()
2004-12-11 12:26:40 +00:00
d61e7a663e
- Bugfix: make sure to update the node_comment_statistics table when a node is updated.
2004-12-11 11:41:17 +00:00
Steven Wittens
Dries Buytaert