Commit Graph

206 Commits (c37cfb0183b4febfc87d84e74c741dab5b3d2490)

Author SHA1 Message Date
Dries Buytaert eee72bfa95 - Patch 4859: new drupal_unpack() consolidates duplicate code and makes it
easy to show avatars next to nodes and comments.  Patch by Moshe.  As a
  showcase, maybe Xtemplate should have an option to enable/disable avatars?
2004-01-13 19:25:37 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 51ee09cc2e - Patch #4924: made the comment form themeable. Patch by Goba. 2004-01-03 12:32:21 +00:00
Dries Buytaert cfc0a5d175 - Fixed typo: comment_delete_thread() -> _comment_delete_thread(). 2003-12-30 14:19:57 +00:00
Dries Buytaert 21a0e8b904 - Updated code to use new semantics of url() and l(). 2003-12-29 19:49:11 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert baaa21e131 - Tidied up some inconsistencies in the code: scripts/code-style.sh is your friend. 2003-12-28 10:47:33 +00:00
Dries Buytaert 4c06410d18 - Fixed bug 4710: comment module should use drupal_set_message() correctly.
- Fixed the title and breadcrumb trail of the comment delete page, added
missing cache flush, improved usability and made it so that when you delete
a comment replies are deleted as well.

- Added 'delete comment' links to the comments on node pages.  Hopefully
this will make it easier to maintain old threads such as those attached to
the book pages on drupal.org.

- Comment module maintenance: added missing t() functions and improved
consistency of the calls to drupal_set_message(), used radio buttons instead
of a selection box.
2003-12-24 13:13:07 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert cc80cdf215 - Replaced the tables used to structure the threaded comment view by div's.
Patch by Goba.
2003-12-15 19:41:24 +00:00
Dries Buytaert 9bd9540856 - Bugfix: the location of comment submission form was incorrect. Patch by
Bart.
2003-12-09 20:15:18 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Dries Buytaert d45bf0f1e7 - Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc. 2003-12-04 20:53:19 +00:00
Dries Buytaert 4e2c0b250e - Introduced a drupal_set_message() and drupal_get_message() function.
Contributed themes and modules need to be updated:
   - modules: status() is no more; use drupal_set_message() instead.
   - themes: use drupal_get_message() to check for status messages and
     visualize them.
2003-12-01 13:45:33 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 7c06438424 - Made the comment module themable. Patch by CodeMonkeyX. 2003-11-15 10:03:31 +00:00
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert c629c7bd09 - Fixed bug #4080: comments shown against wrong node. Reported by chrish. 2003-11-12 12:24:01 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert 00d638ca57 - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.

- Usability improvement: introduced a form_group() function and updated
  the node and comment module to take advantage of it.  Patch #149 by
  Eric Farris.
2003-11-06 18:27:58 +00:00
Dries Buytaert ec33266795 - Improvement: made it possible to disable the comment controls and reworded some of the configuration settings.
- Improvement: removed a left-over from Drupal 4.2.0 (dead code).

- Improvement: replaced hard-coded XHTML around the XML icons with class="xml-icon".

- Improvement: removed the custom navigation menus shown at the top of the "user information page" and integrated them in the new navigation block.  The "my account" link in the navigation menu will unfold.  Also removed the "delete account" link/functionality (for now).

- Improvement: fix for "magic quotes" settings.  Patch by Steven.  I also removed check_php_settings().

- Improvement: block themability improvements.  Modified patch from Ax and Steve/CodeMonkeyX.

- Fixed bug #2617: editing user information does not work.  Patch by Kjartan.
2003-10-31 19:34:03 +00:00
Dries Buytaert a7e20bcd93 - Fixed typo in comment module documentation. Patch by Mark Coady. 2003-10-24 21:32:51 +00:00
Dries Buytaert 609ae6f5e7 - Documentation fix: updated context-sensitive help to match menu item changes.
Fixes critical bug #3453.  (In the end someone has to do it ...)
2003-10-24 09:34:05 +00:00
Dries Buytaert 742410aafd - Bugfix: prefix not prepended to sequences. Fixes bug #3639.
Make sure to write:

    db_next_id({table}_field);

  instead of:

    db_next_id(table_field);
2003-10-22 13:03:32 +00:00
Dries Buytaert 93add5ad77 - Simplified comment counter caches a bit: removed some redundant SQL code.
Maybe this will fix Jeremy's "phantom comments".
2003-10-20 21:35:35 +00:00
Dries Buytaert d64bc008fd Patch by Moshe:
- comment.module: fixed an ambigous 'timestamp' query

- forum.module: prev/next links no longer excerpt from the title+body in
their title attribute. they now excerpt from only their title. this is
more consistent with rest of drupal, and GROUP BY on node.body which
isn't appreciated by MSSQL. also replaced some '' with NULL which caused
errors in MSSQL

- statistics.module: replaced a USING join with a standard ON join. USING
is not as widely supported, and functionally equivalent.
2003-10-17 16:10:48 +00:00
Dries Buytaert 880842885b - Fixed bug #3637: made comment module settings translatable. Patch #13 by Moshe.
- Fixed bug #3642: removed duplicate settings from user page.  Patch #14 by Moshe.

- Fixed bug #3503: added 'forum topic' link to the 'create content' menu.  Patch
  by Gobar.  I think this might be more intuitive and consistent code-wise; I don't
  want to introduce small hacks.

- Cache improvement: small cache improvement to prevent SQL errors.  Patch by
  Jeremy.
2003-10-16 17:29:26 +00:00
Dries Buytaert 5d684e108e - Bugfix: stopped the menu system from generating empty lists (<ul></ul>). Patch
by Nick (CodeMonkeyX).

- Bugfix: anonymous users could not change comment settings.  Patch by Bart.

- Bugfix: the comment control form always showed "order by date - newest first",
  no matter what order you selected.  Patch by Bart.

- Small usability improvement: only display comment controls when there are
  comments to show.  Patch by Bart.
2003-10-14 18:08:33 +00:00
Dries Buytaert 3d0765c5db - Fixed a dozen link titles that were no longer correct due to the menu
changes.
2003-10-09 19:41:09 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 54a157edee - Fixed translation problem with comment module. Patch by Gobar. 2003-10-05 17:34:36 +00:00
Dries Buytaert a33df1de5d - Some documentation fixes by Matt. 2003-10-03 17:43:49 +00:00
Dries Buytaert 3803585f3b - Fixed bug #3449: comment display settings can't be translated. 2003-10-03 15:14:15 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Dries Buytaert 630325188a - Performance improvement: removed redundant inner join. Patch by Kjartan. 2003-10-03 11:42:52 +00:00
Dries Buytaert 208eabd908 - Fixed import and comment module problems. Patch by Gabor.
> Currently the admin menu does not work for comment.module and import
> module. Import module has the problem of not taking care of the fact in
> the arg() function calls that the module is pushed one level down in the
> menu (similar to the user.module and block.modules problems already
> fixed). The comment.module has a problem with trying to translate an $op
> which comes from the URL (and is therefore not translated).
>
> The attached patch also fixes the bogus URLs in import.module help texts
> (as the module part is pushed down into /admin/node instead of /admin).
2003-09-29 19:11:39 +00:00
Dries Buytaert c8b28009cd - Made sure all menu items can be translated. Path by Goba. 2003-09-28 15:18:55 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 3025ca0138 - Fixed bug 2803: a user's signature was being erased when administered. 2003-09-21 07:01:51 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert 8e657f64ef - Gerhard's uid 0 patches. These patches bring various performance
improvements.  Requires a database update.
2003-09-09 18:18:43 +00:00
Dries Buytaert 30c546931d - Fixed bug with being able to post comments while you shouldn't. Patch by
Garym.
2003-09-03 20:18:03 +00:00