Commit Graph

80 Commits (c31fe45f2f76722e1f479c3ca7bb19ce0f0facd2)

Author SHA1 Message Date
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 5646f894ac - Bugfix: fixed broken links. Patch by Ax. 2003-06-14 16:11:29 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert d54465b800 - Fixed 3 PostgreSQL problems!
- Fixed some locale problems; made it easier to translate some strings.

- Removed some dead wood.
2003-05-18 10:09:28 +00:00
Dries Buytaert 07ab3915c4 - Only export the "who is online" block when the access log is enabled.
Patch by Al.  Fixed bug #1692.

- Only export the "top nodes" block when the node counters are enabled.
2003-05-17 19:57:52 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 4ca11cab45 - Fixed the grammer of the Who's online block. Patch by Al. Fixes bug #1541. 2003-04-28 20:54:14 +00:00
Dries Buytaert e0166988fa - Drop some unneeded table-name qualifiers. Patch by Gary. 2003-04-22 18:50:59 +00:00
Dries Buytaert c32f544df9 - Fixed type: whos -> who's 2003-04-22 06:39:13 +00:00
Dries Buytaert 9c3bca068d - Added some missing quotes. 2003-04-21 12:20:25 +00:00
Dries Buytaert 9f82fee1b7 - Fixed broken query in the statistics module. Fix by Gary Lawrence Murphy. 2003-04-19 07:22:51 +00:00
Dries Buytaert 2bbd9c0c7c - Small fix. 2003-04-16 21:07:46 +00:00
Dries Buytaert 70f5b8649b A batch of changes:
- Renamed '---' to '<!--break-->'.

- Removed hard-coded call to the statistics module from the node module.
  Patch by Gerhard.

- Removed tables from poll module.  Modified patch by Al.  Changes to Al's
  patch are:
    "polltext" -> "poll-text"
    "pollfg"   -> "poll-foreground"
    "pollbg"   -> "poll-background"

- Changed some 'statistics.foo's to 's.foo's.  Patch by Gary.

[If this closes any bug reports, please update them on drupal.org.]
2003-04-14 18:44:59 +00:00
Dries Buytaert ab04177d6f - Fixed the broken access log pages.
- Changed some '%s's to '%d's - there are more of these left to fix.
- Added pager support to the access log pages.
- Tried to improve the usability of the access log pages.
2003-03-28 11:38:08 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert 4079abab3b - Ported Neil Ernst's patch to CVS: prefix a columname with a qualification
to make things work using PostgreSQL.

  NOTE: Neil's "&&"-patch will be part of Moshe's MSSQL patch.
2003-03-11 22:49:16 +00:00
Kjartan Mannes 9649350004 - Fixed log views so that the menu doesn't dissapear. (Note: don't use exit()
in Drupal unless you really need to!)
2003-03-09 21:40:01 +00:00
Dries Buytaert 91dfef65af - Fixed some typos spotted by Al Maw. 2003-02-25 19:52:32 +00:00
Dries Buytaert 277ceae515 - New menu houskeeping. Prototyped by Zbynek.
The following modules need updating:
    * glossary module
    * feed module (Breyten's version)
    * mailhandler module
    * notify module
    * project module
    * smileys module
    * admin module
    * style module
    * taxonomy_dhtml module

  To avoid unexpected problems menu_add() is deprecated (it will print an
  error message when used) and menu() should be used instead.
2003-02-20 22:44:51 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert f3c093f638 - Changed '%s' into '%d' such that an empty $user->uid is converted to 0. Requi
red for Drupal to work on new versions of PostgreSQL.  Patch by James, backported to CVS by me.
2003-02-09 17:58:56 +00:00
Dries Buytaert 4028362fda - Applied Moshe's _exit patch (slightly modified).
- Fixed bug in system.module.
2003-01-26 13:22:02 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 9a23223e25 - Applied Ori's format_plural() patch; see mailing list for details.
NOTE: some modules in the contributions repository might need to be updated.
2003-01-21 22:44:25 +00:00
Dries Buytaert fe72ab1c22 - Bugfix: statistics.module can't give referrer statistics other than the
external ones with clean URLs.  Patch by Ulf Rompe.
2003-01-16 22:27:01 +00:00
Dries Buytaert a4b1397677 - Ported David's taxonomy patch to Drupal CVS. 2003-01-09 20:02:42 +00:00
Dries Buytaert 337b80b1a6 - Fixed access log update bug introduced during clean URL commit. Patch by
Moshe.
2003-01-07 05:58:36 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert 36556762f9 - Made a database query ASNI compliant. Patch by Ax. 2003-01-05 00:05:53 +00:00
Dries Buytaert 2da18e8d0c - The statistics module would sometimes mistake a non-node ID with that
of a node.  Thanks David and Jeremy.
2003-01-04 23:38:58 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 105eef9896 - Small improvement to the links. 2002-12-30 16:30:16 +00:00
Dries Buytaert e9148b9180 - Usability improvement: made the access log, referrer logs and popular post
tables use the new table rendering functions.

- Usability improvement: a couple of strings could not be translated.
2002-12-29 16:40:08 +00:00
Dries Buytaert a4a8535a9e - Some small cosmetic changes. 2002-12-26 12:22:00 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert c3c366dcdc - The statistics module's blocks showed unpublished nodes. Patch by Ax. 2002-12-10 20:03:08 +00:00
Dries Buytaert 5b39f6767e * Applied slightly modified version of Marco's taxonomy patch:
- Fixed a bug with get_tree and multiple parents.
 - Fixed 3 wrong caches (this will avoid some queries).
 - Extension to taxonomy_term_count_nodes() (feature #159): "currently
   calling taxonomy_term_count_nodes() returns the amount of nodes in each
   term, would it be possible to extend this function so that it would only
   return the amount of nodes of a certain type under each term.
 - Confirm deleting a vocabulary or a term (requested by Moshe).
 - Use form_weight() in vocabulary and term forms.
 - After submitting a term, we end up at the term page (requested by Moshe).
 - Added status messages when adding, editing and deleting vocabularies and
   terms
 - Minor clean ups

* Made sure all modules use the same link delimiter; "|" for now.
2002-12-02 19:14:41 +00:00
Dries Buytaert 060810841b - Patch by Jeremy to fix a module loading bug:
- module.inc:
       + added call to _init for all modules

    - statistics.module:
       + added statistics_init()
       + moved all global actions into statistics_init()
2002-11-29 05:53:40 +00:00
Dries Buytaert e2869ecafe - Applied Jeremy's statistics module patch: made most (if not all) of the
strings translatable.
2002-11-28 22:13:46 +00:00
Dries Buytaert cc83f673f7 - Fixed the statistics block titles such that the username is displayed correctly.
Reported by Jeremy.
2002-11-26 19:54:54 +00:00
Dries Buytaert 8fa5440bb4 - Applied Jeremy's statistics module patches:
+ Fixed "recent users" title/timestamps.
   + Added statistics_node_delete() function.

- Applied Jeremy's node module patches:
   + Added call to statistics_node_delete().
   + Fixed call to taxonomy_node_delete().
2002-11-26 19:39:07 +00:00
Dries Buytaert a6c8b10d8e Applied Moshe's patches:
- Adds more title info to each line in the block: now showing author and number of comments in a unified way accross all modules.

- Added pager support to blog module.

- Blog module now uses standard node view, not its own hack which is more theme friendly (http://www.drupal.org/node.php?id=133).

- Blog module now uses node_feed() function for making RSS feeds. since all feeds are now consolidated, a couple tweaks to node_feed() and format_rss_* would lead us to support new RSS formats easily.

- Fixed bugs where unpublished entries were displayed.
2002-11-11 20:59:28 +00:00
Dries Buytaert c2f5ce820f - Made sure $content is initialized. Patch by James. 2002-11-09 19:50:44 +00:00
Dries Buytaert 562df8fe43 * Added Jeremy's pager:
"This is a simple, generic pager for Drupal-CVS.  It is designed to be
  easily themeable and expandable.  The code is highly-commented to
  enhance readability."

 "Pagers are constructed by combining the provided pieces (all of which
  can be easily modified to display the text or image you prefer) into
  your custom pager."

* Statistics module fixes by Jeremy:

 - removed superfluous check for existence of watchdog()
 - saving changes in admin page displays status and returns same page
 - no longer return 1971/01/01 in "view statistics" table
 - switched from "!=" to "<>" in SQL queries for ANSI-SQL compliance
 - switched from "MAX(timestamp) as timestamp" to "MAX(timestamp) as
   max_timestamp" moving towards ANSI-SQL compliance.

* Added a "theme_item_list" function to format itemized lists.  Also
  changed a couple of modules to take advantage of it.  Makes for a
  more consistent UI.
2002-11-09 13:59:36 +00:00
Dries Buytaert 3a7c6b68cf Patch by Jeremy:
- addressed one of Ax's issues:
 > = there are quite some "$output .= " which should be "$output
 > = "
 > (whenever $output hasn't been initialized before)

 - combined a few lines that could be accomplished in one step

 - changed "!" to "." in comment "This site is currently
   sustaining..." as if a low number, it looks silly.
2002-11-06 18:56:11 +00:00