Commit Graph

203 Commits (c00be4c49c4cd47138173fbed9bc144fd224a7de)

Author SHA1 Message Date
Alex Pott cbd3299e68 Issue #2916740 by chr.fritsch, xjm, Manuel Garcia, tstoeckler, alexpott, seanB, Sam152, amateescu, tim.plunkett, dawehner, larowlan, Berdir: Add generic entity actions 2018-01-09 08:47:01 +00:00
Nathaniel Catchpole 03fd77c842 Issue #2927806 by alexpott, mondrake, jibran, Mile23: Use PHPUnit 6 for testing when PHP version >= 7.2 2017-12-22 12:47:46 +00:00
Lee Rowlands 7d1545b32a
Issue #2927569 by tstoeckler, amateescu: Various tests do not set values for required field when creating entities 2017-12-11 07:07:20 +10:00
Nathaniel Catchpole 700a72fa37 Issue #1472946 by gnuget, andypost, mmrares, sidharthap, kiamlaluno, Himanshu5050, dineshkumares, amit.drupal: Remove usages of deprecated function drupal_realpath() throughout core functions 2017-11-14 15:53:29 +00:00
xjm 6dc062eb45 Issue #2901562 by mfernea, Jo Fitzgerald, Yogesh Pawar, 3ssom, Mile23, borisson_: Fix 'Squiz.WhiteSpace.SuperfluousWhitespace' coding standard 2017-11-09 15:13:57 -06:00
Nathaniel Catchpole 2fc85e7f0f Issue #2901572 by Jo Fitzgerald, bluccas, mfernea, klausi: Fix 'Drupal.Commenting.PostStatementComment' coding standard 2017-10-13 13:43:02 +01:00
Nathaniel Catchpole 64fa6ad712 Issue #2901744 by mfernea: Fix 'PSR2.Namespaces' coding standard 2017-10-10 16:09:51 +01:00
Nathaniel Catchpole 5b3fdce48b Issue #2887142 by maxocub, phenaproxima, Jo Fitzgerald, Adita, heddn, andypost: NodeType source plugin should include comment information 2017-10-10 15:12:03 +01:00
webchick 5cfa420d7e Issue #2853872 by heddn, maxocub, masipila, phenaproxima, quietone, andypost, larowlan: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics 2017-09-29 17:40:12 +02:00
Lee Rowlands 73bba855dc
Issue #2866513 by michielnugter, jonathan1055, mpdonadio, Jo Fitzgerald, Lendude, dawehner, Wim Leers: Convert web tests to browser tests for comment module 2017-09-24 10:44:51 +10:00
Nathaniel Catchpole 9ef92a408b Issue #2905627 by Lendude, dawehner: Part-2: Convert UpdatePathTestBase to BrowserTestBase 2017-09-08 14:24:15 +01:00
Nathaniel Catchpole ff6eea71c5 Issue #2614504 by blackra, jibran, mohit_aghera, Yogesh Pawar, larowlan, lokapujya, Munavijayalakshmi, thpoul, andypost, xjm: Values of 'name' & 'email' fields should be NULL when comment has author (uid > 0) 2017-09-05 13:42:31 +01:00
Nathaniel Catchpole cb9b6d420f Issue #2722609 by anoopjohn, mfernea, Jo Fitzgerald, chishah92, druprad, martin107, Mile23: Fix Drupal.Commenting.FunctionComment.ParamNameNoMatch 2017-09-04 18:30:59 +01:00
Nathaniel Catchpole 4f24c9169b Issue #2734345 by danmuzyka, hchonov, Jo Fitzgerald, GoZ, kristiaanvandeneynde, Berdir, alexpott: Comments: entity_id base field not overridden correctly in comment bundle field definitions for comment bundles attached to different entity target_type 2017-09-04 13:31:56 +01:00
xjm 11ef44a7f7 SA-CORE-2017-004 by arshadcn, amateescu, Wim Leers, Berdir, Lendude, dawehner, klausi, pwolanin, xjm, mpdonadio, mlhess, larowlan, milesw
(cherry picked from commit 65cef2e9f5)
2017-08-16 12:41:33 -05:00
Nathaniel Catchpole 9a389442d4 Issue #2901778 by xjm, jibran, annajl: Provide correct display name and title for comment admin view displays 2017-08-15 16:10:56 +09:00
xjm 620cc4c752 Issue #2898344 by jibran, xjm, Lendude, dawehner, andypost, mradcliffe, larowlan, annajl, Bojhan: Add filters to the comments administration pages 2017-08-14 20:51:57 -05:00
Lee Rowlands 04d69926b4
Issue #1986606 by jibran, pcambra, vijaycs85, dawehner, andypost, mbovan, Arla, adnen, vprocessor, tkuldeep17, xjm, kim.pepper, dobe, snig, larowlan, miro_dietiker, tim.plunkett, Berdir, Lendude, plach, olli, damiankloip: Convert the comments administration screen to a view 2017-07-29 16:55:37 +10:00
Nathaniel Catchpole c53b322847 Issue #2068063 by timmillwood, Berdir, tduong, Manuel Garcia, nlisgo, yongt9412, esod, lauriii, jonathan1055, vijaycs85, yoroy, amit.drupal, tkoleary, ifrik, Bojhan, xjm, tstoeckler, amateescu: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button 2017-06-15 13:02:05 +01:00
Alex Pott 4bd9426ae0 Issue #2881012 by Lendude, dawehner, michielnugter: Move generatePermutations out of testbase into a trait 2017-05-24 22:26:39 +01:00
Nathaniel Catchpole 5875eb523c Issue #2333985 by quietone, jarsenx, ultimike, heddn: Migrate menu_default_node_menu setting 2017-04-18 13:58:48 +01:00
Gabor Hojtsy 9ae4d129f6 Issue #2862006 by quietone, Jo Fitzgerald, phenaproxima: MigrateSourceTestBase returns false positives for most plugin tests 2017-04-13 10:45:27 +02:00
Alex Pott bdcd4979d8 Issue #2807875 by quietone, Jo Fitzgerald, erozqba, phenaproxima: Convert Comment's Migrate source tests to new base class 2017-04-04 17:45:22 +01:00
Alex Pott 012bca1943 Issue #2687977 by claudiu.cristea, alexpott, prics: Comment::preSave() unconditionally sets hostname to client host 2017-03-14 08:56:27 +00:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Nathaniel Catchpole ef4f88376b Issue #2561115 by michaellenahan, alexpott, Lendude, cilefen, lomasr, amit.drupal, Gábor Hojtsy, ifrik, dawehner: Rollback: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') 2017-02-22 12:37:49 +00:00
Nathaniel Catchpole 6018d048bb Issue #2389335 by Berdir, naveenvalecha, claudiu.cristea, almaudoh, joachim, jibran: Deprecate entity.query service and replace with using the entity storage's getQuery() method 2017-02-09 21:10:34 +00:00
Nathaniel Catchpole 3d72d4be83 Issue #2194783 by Berdir, vprocessor, andypost, Antonnavi, tim.plunkett, Crell, Mile23, catch: Rename EntityTypeInterface::isSubclassOf() to ::entityClassImplements() 2017-01-11 22:06:48 +00:00
Alex Pott ce7cf174eb Issue #2561115 by michaellenahan, Lendude, cilefen, lomasr, amit.drupal, Gábor Hojtsy, dawehner, ifrik: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') 2017-01-05 21:51:09 +00:00
Alex Pott 4259a06c6c Issue #2485385 by phenaproxima, quietone, alexpott, mikeryan, Berdir, blazey, xjm, hussainweb, catch, heddn, benjy: Move highwater field support to the source plugin, and do not expose its internals on MigrationInterface 2016-09-28 17:46:11 +01:00
xjm a8579d60d5 SA-CORE-2016-004 by alexpott, andypost, antongp, cashwilliams, catch, Chi, dawehner, dsnopek, Heine, kierheyl, Pere Orga, pwolanin, larowlan, q2u, stefan.r, xjm
(cherry picked from commit 75d6aa33cd)
2016-09-21 12:41:50 -05:00
xjm b991ba92c2 Revert "Issue #2485385 by phenaproxima, quietone, Berdir, blazey, hussainweb, mikeryan, benjy, alexpott: Move highwater field support to the source plugin, and do not expose its internals on MigrationInterface"
This reverts commit 0308eb77d4.
2016-09-15 09:50:48 -05:00
Alex Pott 0308eb77d4 Issue #2485385 by phenaproxima, quietone, Berdir, blazey, hussainweb, mikeryan, benjy, alexpott: Move highwater field support to the source plugin, and do not expose its internals on MigrationInterface 2016-09-15 15:24:32 +02:00
Nathaniel Catchpole 6c614cbf35 Issue #2459289 by Lendude, dhrjgpt2005, kalistos, dawehner, david_garcia: Boolean default values are not saved 2016-09-02 09:34:36 +01:00
Nathaniel Catchpole f6ae58526c Issue #2572801 by alexpott, vprocessor, andriyun, andypost, chishah92, Mile23, attiks, hussainweb, klausi, dawehner, pfrenssen: Fix 'Drupal.WhiteSpace.ScopeIndent' coding standard 2016-08-28 18:16:36 +01:00
Alex Pott 437ebf7c4f Issue #2785241 by quietone, Gábor Hojtsy: Add a translated node to d7_dump 2016-08-26 14:08:33 +01:00
Nathaniel Catchpole 3c42666bfc Issue #2787577 by alexpott, dawehner: When tests use multiple namespaces they should do so in a coding standards compliant way 2016-08-22 17:10:39 +01:00
Alex Pott 24343f970b Issue #2763283 by naught101, thomas73: Failure on comments with no subject 2016-08-13 23:52:22 +01:00
Alex Pott 7f8e1c93fc Issue #2627678 by claudiu.cristea, larowlan, jonathanjfshaw, alexpott, catch: Specify view mode to be used by comment formatter 2016-07-19 14:47:30 +01:00
Nathaniel Catchpole 899cb5239b Issue #2723591 by marvin_B8: Remove entity_load* usage for entity_test, entity_test* entity types 2016-05-17 10:40:48 +01:00
Alex Pott 31e613b3ce Issue #2692373 by heddn, rakesh.gectcr, edysmp, mikeryan, benjy: Value should be null when is produced skip process 2016-05-14 22:29:13 -05:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott d5d0d6ce87 Issue #2572777 by andypost, alexpott, attiks, andriyun: Fix 'Squiz.Strings.ConcatenationSpacing' coding standard 2016-05-05 12:07:19 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott f3f3800fe4 Issue #2674408 by alexpott: Fix "Drupal.Classes.UnusedUseStatement" standard in core 2016-04-05 11:50:03 +01:00
Alex Pott 0db5b13892 Issue #2686207 by Berdir: Convert simpletest kernel tests in modules A-I to phpunit 2016-03-28 19:36:47 +01:00
Alex Pott 4202cdd04b Issue #2684141 by benjy, dawehner: Convert migrate kernel tests to KernelTestBaseTNG 2016-03-21 09:31:08 +00:00
Alex Pott ee9f19cf98 Issue #2553655 by dawehner, Berdir, martin107: Convert ViewKernelTestBase to use KernelTestBaseTNG 2016-03-15 14:54:15 +00:00
Alex Pott daa52e9f1a Issue #2684095 by dawehner, amateescu: Convert field kernel tests to KernelTestBaseTNG 2016-03-10 15:54:24 +00:00
xjm 376fb615d7 Issue #2458223 by geertvd, eiriksm, dawehner, lokapujya, Gábor Hojtsy, jeqq, plach, Dom., jhodgdon, xjm, catch, alexpott, jibran: Duplicated field handlers in field UI for some base table fields 2015-11-17 22:32:23 -06:00
Alex Pott 03de872802 Issue #2604618 by andypost, xjm: Views operations dropbuttons do not work with Comment because it does not specify a list builder 2015-11-02 15:17:52 +00:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
xjm 176d9947e0 Issue #2560049 by hass, chrisfree, cilefen, Wim Leers, Gábor Hojtsy: Incorrect capitalisation of translatable strings 2015-10-05 11:28:57 -05:00
Nathaniel Catchpole 400baf1609 Issue #2464427 by jibran, Wim Leers, Berdir, borisson_: Replace CacheablePluginInterface with CacheableDependencyInterface 2015-10-02 09:26:50 +01:00
webchick 9fc8bba35e Issue #2573559 by phenaproxima, mikeryan: Remove MigrateDrupalTestBase::testSourcePlugin() 2015-09-30 11:43:24 -07:00
Alex Pott d551f8c9d5 Issue #2555899 by geertvd: Add test coverage for Comment link handlers handler 2015-09-08 13:46:00 +01:00
webchick 5fb22f43a5 Issue #2532534 by phenaproxima, miguelc303: Migration Files for Drupal 7 Comments 2015-09-03 10:07:45 -07:00
webchick f72ef07766 Issue #2522012 by phenaproxima, mikeryan, chx, benjy: Remove broken idlist handling, replace with more robust exception handling 2015-08-28 14:00:47 -07:00
Nathaniel Catchpole dd23c88ab7 Issue #2530846 by Berdir, mbovan: Fix and improve comment cache tag usage 2015-08-24 22:03:13 +01:00
Alex Pott f85c0c140d Issue #2505879 by RavindraSingh, geertvd, borisson_, JvE: Call to undefined method stdClass::id() 2015-08-12 19:20:38 +01:00
Alex Pott cdd12a90bb Issue #2455125 by mpdonadio, rteijeiro, jhodgdon, dawehner: Update EntityViewsData use of generic timestamp to use Field API formatter 2015-08-06 12:12:06 +01:00
webchick 05a8db295e Issue #2534004 by phenaproxima, mikeryan: Move module-specific migration support into the comment module 2015-08-03 21:08:57 -07:00
Alex Pott 1f53649bfb Issue #1392754 by tss, justAChris, jhodgdon: Comply with new documentation standards for @file for namespaced class files 2015-06-26 21:53:33 +01:00
Nathaniel Catchpole 872b4963ec Issue #2495073 by dawehner, catch: Views feed display plugin has to get all views data on init 2015-06-12 16:10:37 +01:00
Alex Pott fa2a7a56f7 Issue #2499835 by phenaproxima, chx, benjy: Remove broken Fake DB driver 2015-06-10 00:07:08 +01:00
Nathaniel Catchpole 68e606c354 Issue #2502255 by dawehner, larowlan: Enable tags cache plugin by default for Views 2015-06-09 22:58:45 +01:00
Nathaniel Catchpole 15c848bd62 Issue #2381277 by dawehner, plach, damiankloip, alexpott, olli, fgm, Wim Leers, Fabianx: Make Views use render caching and remove Views' own "output caching" 2015-06-08 15:48:29 +01:00
Nathaniel Catchpole 30ca0d1de6 Issue #2481453 by dawehner, pwolanin, rteijeiro, neclimdul, znerol: Implement query parameter based content negotiation as alternative to extensions 2015-06-08 11:11:09 +01:00
Nathaniel Catchpole 4509204286 Issue #2478483 by Wim Leers, Fabianx: Introduce placeholders (#lazy_builder) to replace #post_render_cache 2015-06-05 10:47:02 +01:00
Alex Pott dc474512a6 Issue #2456705 by dawehner, adamwhite, larowlan, YesCT: Comment views field handlers need to be replaced with field/entity aware handlers 2015-04-12 09:34:17 +01:00
Alex Pott 6a7d1bb208 Issue #2454163 by larowlan, geertvd, rteijeiro: Replace comment_username handler with generic views handler 2015-04-08 11:49:25 +01:00
Alex Pott fdc1c3daf8 Issue #2383863 by rpayanm, mgifford, maximpodorov, Valentine94: Spellchecking Drupal - Comments 2015-04-02 11:59:11 +01:00
Alex Pott c7fd064c22 Issue #2455131 by andypost, larowlan: Field comment_field_data.field_name should be using Field API formatter 2015-03-26 00:43:29 +00:00
Alex Pott eaffcfc511 Issue #2451885 by Gábor Hojtsy: Config entities need to ship with language or are assumed undefined 2015-03-17 08:28:57 +00:00
Alex Pott db60a8c7ec Issue #2273923 by mpdonadio, pfrenssen, effulgentsia, pcambra, xjm, tim.plunkett, martin107, cilefen: Remove html => TRUE option from l() and link generator 2015-03-09 15:57:27 +00:00
webchick ebcca481ee Issue #2429447 by dawehner, jhodgdon, xjm, jibran: Use data table as views base table, if available 2015-03-06 08:46:35 +11:00
Alex Pott 6eb18e4ff5 Issue #2356967 by bzrudi71: PostgreSQL: Fix tests in comment test group 2015-02-10 13:07:03 +00:00
webchick e45522cfd9 Issue #2380457 by Gábor Hojtsy, vijaycs85, olli, dawehner: Some fixes of the views config schema 2015-02-05 23:09:26 -08:00
Alex Pott f100d942e3 Issue #2394883 by Gábor Hojtsy, plach, jhodgdon: Language setup for entity and field based rendering in views is independent, confusing UI, lacking test coverage 2015-02-05 10:33:13 +00:00
Alex Pott 1c94124a5a Issue #2344151 by larowlan: Comment field access doesn't work if $items isn't present 2015-01-08 10:36:12 +00:00
Alex Pott 145b53cef3 Issue #2394041 by Gábor Hojtsy: Row language settings from entity views should be on display level for all views 2014-12-22 14:23:24 +00:00
Alex Pott 7cd91c92c0 Issue #2349553 by dawehner, pfrenssen, damiankloip: Store entity field information in the views data 2014-12-14 13:10:29 +01:00
Alex Pott 970ea07c17 Revert "Issue #2273923 by mpdonadio, pfrenssen, dawehner, xjm, cilefen: Remove html => TRUE option from l() and link generator"
This reverts commit 0bcabf50e0.
2014-12-13 21:44:18 +01:00
Alex Pott 0bcabf50e0 Issue #2273923 by mpdonadio, pfrenssen, dawehner, xjm, cilefen: Remove html => TRUE option from l() and link generator 2014-12-13 18:20:19 +01:00
Alex Pott 9e8a5230ad Issue #2359509 by Berdir: Incorrect type safe check in Entity::onUpdateBundleEntity() results too many cache clears 2014-12-11 09:35:31 +01:00
Alex Pott dedaf33cfe Issue #2385805 by Gábor Hojtsy: Views tests don't pass strict schema checking 2014-12-05 09:59:20 +00:00
Alex Pott 22d1816823 Issue #2325269 by Gábor Hojtsy, Arla: Test and fix views in test_views directories against their configuration schema 2014-12-02 16:18:11 +00:00
Nathaniel Catchpole 6714300ac1 Issue #2316909 by Berdir, alexpott: Revisit all built-in test/default views configuration in core 2014-11-24 22:15:38 +00:00
Alex Pott 1a73d7e6ab Issue #2328919 by Mile23, YesCT, tim.plunkett: Remove () from a bunch of @covers definitions in PHPUnit 2014-11-20 09:47:27 +00:00
Nathaniel Catchpole edd7889694 Issue #2376791 by dawehner, Wim Leers: Move all _content routing definitions to _controller 2014-11-20 09:47:06 +00:00
Nathaniel Catchpole 29817e452a Issue #2267453 by alexpott, dawehner, damiankloip: Fixed Views plugins do not store additional dependencies. 2014-11-11 13:04:05 +00:00
Alex Pott 195d49998a Issue #2347465 by tim.plunkett, dawehner, cilefen: Convert all instances of #type link/links to convert to use routes. 2014-10-09 07:39:37 +01:00
Alex Pott ba2b869092 Issue #2275659 by fago, pgautam: Separate FieldableEntityInterface out of ContentEntityInterface. 2014-10-01 16:11:14 +02:00
webchick 0189add1e3 Issue #2304987 by Berdir, Wim Leers: Fixed Don't invalidate cache tags of referenced entities, use entity list cache tags correctly, add test coverage for entity list cache tags. 2014-10-01 01:20:51 -07:00
catch 2c6cd92958 Issue #2340123 by Wim Leers: Setting cache tags can be tricky: use strings instead of nested arrays to improve DX. 2014-09-25 08:30:31 +01:00
Dries ca85441da2 Issue #2260121 by sun: PHPUnit Tests namespace of modules is ambiguous with regular runtime namespace (+ Simpletest tests). 2014-09-05 12:40:22 -04:00
Dries 05212a9727 Issue #2271349 by Berdir, Arla, blueminds, larowlan, Dave Reid: Node and Comment ops links should be display components (which can be disabled). 2014-09-05 12:31:15 -04:00
webchick 6f9fc447bb Issue #2037979 by Gábor Hojtsy, Sweetchuck, jhodgdon, dawehner: Fixed 'Current user's language' views filter label is named very misleading. 2014-08-29 22:17:55 -07:00
Alex Pott 50dfcc705a Issue #2324783 by JayeshSolanki | andypost: Fixed CommentLinkBuilderTest::setUp() should be protected. 2014-08-21 18:03:14 +01:00
Alex Pott b6ba35f006 Issue #2318251 by larowlan: Fixed Make comment links functionality testable and convert CommentLinkTest to PHPUnit. 2014-08-19 10:52:51 +01:00