Commit Graph

1966 Commits (bbb41d0f7192cb236c061caeb2606847da094755)

Author SHA1 Message Date
Dries Buytaert bbb41d0f71 - Patch by JonBob: updated the comment module to take advantage of the latest
menu system improvements.
2004-07-10 18:11:18 +00:00
Dries Buytaert 1f288c11c4 - 'add block' -> 'add' 2004-07-10 16:06:49 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert e21f238ad7 - Patch 8756 by Morbus:
* improves the doxygentation and help text.
* deletes comment_admin and comment_page; using proper callbacks instead.
* related/modified callbacks/menus/functions were tweaked to not use arg() at all.
* the "settings" subtab was weighted to -10 so it'd appear first (in prep of JonBob's local default).
* moderation pages weren't properly showing defined votes or thresholds; fixed.
* when moderation votes or thresholds didn't exist, no error stating as such was shown; fixed.
* we show "submit votes" on the moderation votes page only when votes actually exist.
* fixes the (broken in CVS) comment/reply and comment/edit features.
* fixes the (broken in CVS) "save settings" for comment view options and comment moderation.

In addition I:

* fixed a couple warnings introduced by Morbus' patch.
* fixed a couple translation bugs.
* fixed comment_node_url().

I also found that:

* the collapsed comment views (i.e. 'threaded list - collapsed) are broken.
2004-07-10 07:58:47 +00:00
Steven Wittens 27dc584ba9 Fixed a bug caused by inverting the setting for configurable timezones. 2004-07-09 00:25:10 +00:00
Dries Buytaert 82c9fab7c7 - Patch by Morbus: reorganized the order of functions in the comment
module.
2004-07-08 19:58:10 +00:00
Dries Buytaert a067187711 - Patch by Killes and Steven: added support for sending compressed
pages.  Useful to reduce your site's bandwidth.
2004-07-08 19:22:48 +00:00
Dries Buytaert 898bdeffaf - Marked required fields on the node (story, book, page, blog) and comment
forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!
2004-07-08 15:24:30 +00:00
Dries Buytaert 144c1abb58 - Renamed '... your ...' to '... my ...' (cfr. 'my account). 2004-07-08 15:19:08 +00:00
Dries Buytaert 78876f01d5 - Fixed colspan in tracker table.
- Renamed '... your ...' to '... my ...' (cfr. 'my account).
2004-07-08 15:18:48 +00:00
Dries Buytaert bf42dddea7 - Usability improvement: users can also separate 'list items' (i.e. favorite
movies) using a comma.  Only few users actually read the form description,
  it seems ...
2004-07-08 15:17:21 +00:00
Dries Buytaert 24600b8a43 - Simplified some of the help texts.
- Removed left-over instance of theme('error'): error handling is now done by
  the form code.
2004-07-08 15:12:23 +00:00
Dries Buytaert 7059b64965 - Made the user module's administration form mark required form fields. 2004-07-08 15:11:05 +00:00
Dries Buytaert 4dbc900d3b - Renamed the blog module's block for sake of clarity.
- Made the blog module's submission form mark required form fields.
2004-07-08 15:09:53 +00:00
Dries Buytaert c989fc7cf7 - Small improvement to the filter.module's help text.
- Revert patch that accidentically got committed.  Thanks jhriggs.
2004-07-08 13:35:15 +00:00
Dries Buytaert 64b12b4a56 - Fixed braino. Reported by Steven. 2004-07-08 07:56:16 +00:00
Dries Buytaert 039c77121a - Patch by Morbus: this last tracker patch was broken - for installations where the comment.module is turned on, $comments is never set to 0, and posts that have no comments instead get the value of the last successful comment_num_all. The attached patch corrects this ($comments is set to 0 before we do anything) and also merges the if statements. 2004-07-08 06:15:49 +00:00
Dries Buytaert 9a56e93c3d - Patch by Morbus: remove access users permission. Will bring it back later. 2004-07-08 06:12:39 +00:00
Dries Buytaert d3904c05cc - Usability improvements: reworked/simplified the timezone/date settings a
little and made the form groups use consistent titles.
2004-07-07 22:45:21 +00:00
Dries Buytaert 6a43d01e27 - Usability: improved the error reporting of the file system settings on the
'home » administer » settings" page.
2004-07-07 22:19:20 +00:00
Dries Buytaert 3568ed57e1 - Moving the title.module from core to contrib as discussed on the mailing list. 2004-07-07 20:18:22 +00:00
Dries Buytaert b05086c92f - Patch by drumm: remove block placement preview. Most themes, if not all the commonly used ones, can handle blocks on either side, and there is no way to see the preview without saving and seeing the results on the site.
Anything else that can be removed?  Less is more.
2004-07-07 05:42:24 +00:00
Dries Buytaert 9d35fe7a7d - Patch by daBrado: don't show the profile fields when the user does
not have the 'access users' permission set.
2004-07-06 17:27:33 +00:00
Dries Buytaert 0654129e16 - Patch by jseng/junyor: allows autodiscovery of BloggerAPI via RSD. 2004-07-06 16:54:28 +00:00
Dries Buytaert 4e9ef33896 - Patch by Ber: if the comment module is not available comment_num_all()
should not be called.
2004-07-06 07:38:35 +00:00
Dries Buytaert 7bb88809b7 - Patch by JonBob: fixed a number of tab issues. 2004-07-06 07:33:59 +00:00
Dries Buytaert 4bbc277881 - Patch by asimmonds: comment signature option was not displayed. 2004-07-05 05:42:06 +00:00
Steven Wittens ac27d4bf81 Fixed broken poll results:
- If you are allowed to vote, results are now shown on a separate node tab "node/id/results".
- Poll voting now submits to a separate URL and uses drupal_goto to go back to the poll node
2004-07-04 23:40:14 +00:00
Steven Wittens d615cb245e - Added revisions tab to node view (when needed)
- Updated node.module to use drupal_goto after submission: this allows people to refresh after submission without any problems.
2004-07-04 19:24:52 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 353c05d015 - Made it possible to edit blog posts and made the blog module use tabs. 2004-07-04 10:30:42 +00:00
Dries Buytaert 3fb070f419 - Patch by Morbus: watchdog module beautifications.
* slightly reorders the functions in anticipation of http://drupal.org/node/view/9010.
  * reorders help definitions to match the alphabetical nature of the menu items.
  * tweaked visual appearance of menu code (whitespace, etc.)
  * minor tweaks to "warning" help to match style of others.
2004-07-03 14:10:09 +00:00
Dries Buytaert cca82f8ee4 - Increased the maxlength value of the URL form. 2004-07-03 08:37:48 +00:00
Dries Buytaert e47c623e3d - Patch by Killes: For some reason there is a array_merge that nobody seems to need. It generates an error under php5. Found by redLED. 2004-07-03 07:07:33 +00:00
Dries Buytaert 9986cb36b5 - Patch by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 3701c02e59 - Small watchdog module optimization by Morbus. 2004-07-02 18:32:12 +00:00
Dries Buytaert d279d16ccb - Patch by James: theme_user_picture() linked to bad url. 2004-07-02 18:13:45 +00:00
Dries Buytaert 07d490058e - Patch by Morbus: made the watchdog module more doxygenish:
* @file header with a oneliner and blurb description about watchdog.module.
   * standardized the text between admin/help#watchdog and admin/logs.
   * tweaked the descriptions of log types available ever so slightly.
   * removed anything that referred to the old settings page.
   * added an assumed 'type' to one of the menu's.
2004-07-02 07:11:35 +00:00
Dries Buytaert c7b27b18de - Simplified referrer links. Suggested by Morbus. 2004-06-30 21:00:41 +00:00
Dries Buytaert 60513799a1 - Patch by JonBob: allow local tasks to be ordered by weight, as well
as simplifying the theming of local tasks so they can be more easily
  rendered in a non-tab manner.
2004-06-30 20:45:45 +00:00
Dries Buytaert fcded380a8 - Patch by James: fixed typo. 2004-06-30 20:43:07 +00:00
Dries Buytaert e3e051cc0d - Patch by Junyor: sort blog items by creation date. Added some database indices. 2004-06-30 07:26:02 +00:00
Dries Buytaert 4f00182423 - Fixed typo reported by Steven Mansour: form_set_name() -> form_set_error() 2004-06-30 05:44:59 +00:00
Dries Buytaert b284477713 - Bug by Morbus: fixed incorrect date being displayed in the forum overview when a topic has no comments yet. 2004-06-29 20:35:58 +00:00
Dries Buytaert 8edcb47063 - Patch by Junyor: updated help text to reflect menu changes. 2004-06-29 20:24:29 +00:00
Dries Buytaert f04547efd1 - Patch by Junyor: fixed broken link on the drupal.module setting page. 2004-06-29 19:41:04 +00:00
Steven Wittens 93b56f5073 - Fixing some usability bugs with aggregator admin: some forms lacked status messages, and redirected to themselves
- Now uses drupal_goto after every form submission [1]. Patches for other modules will follow.

[1] http://lists.drupal.org/archives/drupal-devel/2004-06/msg01147.html
2004-06-28 23:16:59 +00:00
Dries Buytaert fa192ae767 - Fixed bug with user information not being shown in the profile forms. 2004-06-28 08:32:16 +00:00
Dries Buytaert 2f393aaf31 - Fixed glitch in _user_categories(). Reported by Steven Mansour. 2004-06-28 08:09:30 +00:00
Dries Buytaert 47ef2e21de - Fixed 'pass by reference'-bug in the validation code and further simplified
it.
2004-06-28 07:23:53 +00:00