Commit Graph

584 Commits (a9cd69a4981edf25b995edcdde764994ff91eb8d)

Author SHA1 Message Date
xjm edf57d8ab8 Revert "Issue #2572795 by mfernea, pfrenssen, attiks, andypost, alexpott, xjm, Mile23, catch, borisson_: Fix coding standard for closures - Drupal.WhiteSpace.ScopeClosingBrace and Generic.Functions.OpeningFunctionBraceKernighanRitchie"
This reverts commit c422bdfa53.
2017-11-09 14:37:59 -06:00
xjm c422bdfa53 Issue #2572795 by mfernea, pfrenssen, attiks, andypost, alexpott, xjm, Mile23, catch, borisson_: Fix coding standard for closures - Drupal.WhiteSpace.ScopeClosingBrace and Generic.Functions.OpeningFunctionBraceKernighanRitchie 2017-11-09 10:56:52 -06:00
Nathaniel Catchpole 75dcf9af44 Issue #2870194 by alexpott, Mile23, jibran, larowlan, tim.plunkett: Ensure that process-isolated tests can use Symfony's PHPunit bridge to catch usages of deprecated code 2017-11-09 12:51:06 +00:00
effulgentsia b83782a74b Issue #2920001 by Wim Leers, dawehner, borisson_, aheimlich, davidwbarratt: Add cacheable HTTP exceptions: Symfony HTTP exceptions + Drupal cacheability metadata 2017-11-08 19:31:27 -08:00
Lee Rowlands 52a598e2bf
Issue #2910211 by tedbow, Wim Leers: Allow computed exposed properties in ComplexData to support cacheability 2017-11-08 12:01:36 +10:00
xjm 3af361c83c Issue #2874938 by Wim Leers, tim.plunkett, borisson_, effulgentsia: AdminRouteSubscriber must only mark HTML routes as administrative 2017-11-07 05:18:58 -06:00
Lee Rowlands c74c39e133
Issue #2871591 by tedbow, Wim Leers, dagmar, borisson_, amateescu, dawehner, damiankloip, tstoeckler, mradcliffe, larowlan: Allow ComplexData in TypedData to specify computed properties that should be exposed in normalization and other contexts 2017-11-06 09:14:37 +10:00
xjm 850f03b9be Issue #2825204 by dawehner, BR0kEN, xjm, pcambra, Wim Leers, tim.plunkett, tstoeckler, damiankloip, larowlan, effulgentsia, alexpott: REST views: authentication is broken 2017-10-24 12:14:02 -05:00
Nathaniel Catchpole 51f6344c8c Issue #2843764 by Wim Leers, arshadcn: EntityResource: Provide comprehensive test coverage for EntityFormDisplay entity 2017-10-24 12:51:08 +01:00
Nathaniel Catchpole 50f08589d0 Issue #2843765 by vaplas: EntityResource: Provide comprehensive test coverage for EntityViewDisplay entity 2017-10-24 12:48:44 +01:00
Lee Rowlands 4d4365299c
Issue #2843755 by Wim Leers, larowlan, andypost, jibran, Berdir: EntityResource: Provide comprehensive test coverage for Message entity 2017-10-24 08:55:57 +10:00
xjm 8f022a6234 Revert "Issue #2825204 by dawehner, BR0kEN, pcambra, Wim Leers, tim.plunkett, tstoeckler, damiankloip: REST views: authentication is broken"
This reverts commit 40b143ff9a.
2017-10-23 11:06:01 -05:00
Lee Rowlands 40b143ff9a
Issue #2825204 by dawehner, BR0kEN, pcambra, Wim Leers, tim.plunkett, tstoeckler, damiankloip: REST views: authentication is broken 2017-10-19 09:14:57 +10:00
Lee Rowlands 96452be02f
Issue #2915414 by Wim Leers, dawehner: Omit "_core" key from normalized config entities, which includes the default config hash 2017-10-19 08:40:31 +10:00
Nathaniel Catchpole 43c0eca73b Issue #2843781 by vaplas, Wim Leers: EntityResource: Provide comprehensive test coverage for EntityViewMode entity 2017-10-17 12:16:45 +01:00
Nathaniel Catchpole 831450a1f2 Issue #2909183 by Wim Leers, tedbow: Add path alias (PathItem) field PATCH test coverage 2017-10-17 12:15:55 +01:00
Nathaniel Catchpole 7b05eebfcf Issue #2843780 by vaplas, jamesdesq, Wim Leers: EntityResource: Provide comprehensive test coverage for EntityFormMode entity 2017-10-16 14:38:21 +01:00
Lee Rowlands 4997192be0
Issue #2449143 by damiankloip, tedbow, Wim Leers, dawehner, Pavan B S, Tybor, effulgentsia, larowlan: REST views specify HTML as a possible request format, so if there is a "regular" HTML view on the same path, it will serve JSON 2017-10-11 15:52:34 +10:00
Nathaniel Catchpole 64fa6ad712 Issue #2901744 by mfernea: Fix 'PSR2.Namespaces' coding standard 2017-10-10 16:09:51 +01:00
Nathaniel Catchpole f659d6ca8e Issue #2901726 by mfernea, gmario, finn.lewis, robertoperuzzo, rachel_norfolk: Fix 'Squiz.Functions.MultiLineFunctionDeclaration' coding standard 2017-10-10 15:43:06 +01:00
Gabor Hojtsy 3e2d434028 Issue #2883813 by chr.fritsch, Wim Leers, Berdir, phenaproxima, catch: Move File/Image media type into Standard once Media is stable 2017-10-09 18:46:43 +02:00
Nathaniel Catchpole 3529e208aa Issue #1848686 by Johnny vd Laar, Berdir, JeroenT, geertvd, mogtofu33, hauruck, Manuel Garcia, pfrenssen, Bambell, realityloop, ParisLiakos, webflo, cyborg_572, Algeron, zniki.ru, xjm, Wim Leers, dawehner, yoroy: Add a dedicated permission to access the term overview page (without 'administer taxonomy' permission) 2017-10-03 11:22:50 +01:00
Nathaniel Catchpole 2e18fe9373 Issue #2715485 by harsha012, mfernea, malavya, himanshu-dixit, vprocessor, tameeshb, Mile23, RajeevK, Jo Fitzgerald, tiago.urbano, xjm, klausi: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-25 14:14:30 +01:00
Lee Rowlands 647b586b22
Issue #2901704 by Wim Leers, damiankloip: Allow REST routes to use different request formats and content type formats 2017-09-23 07:07:28 +10:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
effulgentsia 3b6a05b573 Issue #2835767 by Wim Leers, vaplas, xjm, dawehner, Gábor Hojtsy, Berdir, seanB, larowlan: Media + REST: comprehensive test coverage for Media + MediaType entity types 2017-09-19 13:11:37 -07:00
effulgentsia 301152f8c6 Issue #2835845 by vaplas, Wim Leers, arshadcn, Berdir: EntityResource: Provide comprehensive test coverage for BlockContent entity 2017-09-19 12:29:56 -07:00
xjm 2242f4ad9e Issue #2901785 by mfernea, xjm, andriyun: Fix 'Generic.Formatting.SpaceAfterCast' coding standard 2017-09-17 16:38:34 -05:00
xjm cc30270e9a Revert "Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"""
This reverts commit b06757615a.
2017-09-16 14:24:44 -05:00
xjm b06757615a Revert "Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard""
This reverts commit 964954e1f3.
2017-09-16 12:02:55 -05:00
xjm 964954e1f3 Revert "Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard"
This reverts commit 2df73e2c00.
2017-09-16 12:02:42 -05:00
xjm 2df73e2c00 Issue #2715485 by harsha012, malavya, himanshu-dixit, mfernea, vprocessor, tameeshb, Mile23, Jo Fitzgerald, klausi, xjm: Fix 'Drupal.Commenting.InlineComment.NoSpaceBefore' coding standard 2017-09-16 11:19:25 -05:00
xjm 44a5c4cbe0 Issue #2901739 by andriyun, Jo Fitzgerald, mfernea, xjm: Fix 'Squiz.Arrays.ArrayDeclaration' coding standard 2017-09-15 16:52:14 -05:00
effulgentsia cc34cb8055 Issue #2843776 by Wim Leers, vaplas: EntityResource: Provide comprehensive test coverage for EntityTestBundle entity 2017-09-15 12:49:39 -07:00
Lee Rowlands a87e8aafdb
Issue #2843778 by Wim Leers: EntityResource: Provide comprehensive test coverage for ContactForm entity 2017-09-13 07:51:28 +10:00
Lee Rowlands 5679964152
Issue #2720233 by dawehner, Wim Leers, catch: Use arguments resolver in RequestHandler to have consistent parameter ordering 2017-09-10 10:07:43 +10:00
xjm 5ce3293016 Issue #2905181 by tedbow: Remove useless if statement in ResourceTestBase::assertResourceResponse() 2017-09-08 18:43:37 -05:00
Nathaniel Catchpole 9ef92a408b Issue #2905627 by Lendude, dawehner: Part-2: Convert UpdatePathTestBase to BrowserTestBase 2017-09-08 14:24:15 +01:00
Nathaniel Catchpole cb9b6d420f Issue #2722609 by anoopjohn, mfernea, Jo Fitzgerald, chishah92, druprad, martin107, Mile23: Fix Drupal.Commenting.FunctionComment.ParamNameNoMatch 2017-09-04 18:30:59 +01:00
xjm 84bbc5730a Revert "Issue #2824851 by Wim Leers, arshadcn, amateescu, tedbow, timmillwood, Berdir, tstoeckler: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior"
This reverts commit 3b3daa353f.
2017-09-03 06:10:11 -05:00
Nathaniel Catchpole 3b3daa353f Issue #2824851 by Wim Leers, arshadcn, amateescu, tedbow, timmillwood, Berdir, tstoeckler: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior 2017-08-22 16:54:10 +09:00
Nathaniel Catchpole c8392465c3 Issue #2902529 by mfernea: Fix 'Drupal.WhiteSpace.EmptyLines' coding standard 2017-08-21 14:04:51 +09:00
Nathaniel Catchpole 02a8ccbdcb Issue #2902406 by mfernea: Fix 'Drupal.Classes.UseLeadingBackslash' coding standard 2017-08-21 14:01:00 +09:00
Nathaniel Catchpole 1f191080c1 Issue #2902723 by mfernea, ccjjmartin: Fix 'Drupal.Commenting.FunctionComment.ReturnCommentIndentation' coding standard 2017-08-21 13:39:47 +09:00
xjm 11ef44a7f7 SA-CORE-2017-004 by arshadcn, amateescu, Wim Leers, Berdir, Lendude, dawehner, klausi, pwolanin, xjm, mpdonadio, mlhess, larowlan, milesw
(cherry picked from commit 65cef2e9f5)
2017-08-16 12:41:33 -05:00
Nathaniel Catchpole ef16fa1c8a Issue #2775553 by Wim Leers, naveenvalecha: Convert web tests to browser tests for REST module 2017-08-05 10:21:34 +09:00
Lee Rowlands 2db1774546
Issue #2843770 by Wim Leers, vaplas: EntityResource: Provide comprehensive test coverage for ResponsiveImageStyle entity 2017-07-15 10:26:28 +10:00
Nathaniel Catchpole f3f18a23c8 Issue #2882717 by Wim Leers, dawehner: EntityResourceTestBase: assert that PATCHed and POSTed entities contain the intended values 2017-07-03 20:48:50 +01:00
Gabor Hojtsy 7d510cc1bc Issue #2873789 by ponies, Wim Leers, xjm: Add change record to @deprecated for TypeLinkManagerInterface 2017-06-28 15:34:56 +02:00
Nathaniel Catchpole 7626a3d70b Issue #2869387 by tstoeckler, Wim Leers: Subclasses of ResourceTestBase for non-entity resources are required to add pointless code 2017-06-26 12:13:49 +01:00
xjm 62397e8ea8 Issue #2873761 by sorabh.v6, Wim Leers: Add Change record to @deprecated for ResourcePluginManager 2017-06-17 13:07:19 -04:00
Nathaniel Catchpole 5e2e4a8605 Issue #2843783 by vaplas, Wim Leers, tedbow: EntityResource: Provide comprehensive test coverage for Menu entity 2017-06-12 14:37:00 +01:00
Nathaniel Catchpole 3a6bbc8cae Issue #2843772 by Wim Leers, arshadcn: EntityResource: Provide comprehensive test coverage for DateFormat entity 2017-06-12 12:08:10 +01:00
Nathaniel Catchpole 7e052a1550 Issue #2843768 by Wim Leers, arshadcn, himanshu-dixit, yoroy: EntityResource: Provide comprehensive test coverage for Tour entity 2017-06-12 11:25:32 +01:00
Nathaniel Catchpole a2cc58de8a Issue #2846554 by Berdir, tedbow, amateescu, dawehner, himanshu-dixit, Wim Leers, badrange, damiankloip, catch: Make the PathItem field type actually computed and auto-load stored aliases 2017-06-06 21:27:48 +01:00
Alex Pott da74f223c3 Issue #2768651 by damiankloip, Wim Leers, mpdonadio, Munavijayalakshmi, Jo Fitzgerald, jhedstrom: Let TimestampItem (de)normalize to/from RFC3339 timestamps, not UNIX timestamps, for better DX 2017-05-24 21:47:56 +01:00
Alex Pott b9c288ba3e Issue #2843767 by arshadcn, Wim Leers, tstoeckler: EntityResource: Provide comprehensive test coverage for BaseFieldOverride entity + add missing access control handler 2017-05-23 15:38:02 +01:00
Alex Pott abf5997d93 Issue #2843758 by jamesdesq, vaplas, Wim Leers: EntityResource: Remove ViewAccessControlHandler and provide comprehensive test coverage for View entity 2017-05-23 15:38:02 +01:00
Alex Pott f135eb20cc Issue #2843771 by arshadcn, Wim Leers: EntityResource: Add an admin permission to RdfMapping entity and provide comprehensive test coverage 2017-05-23 14:58:45 +01:00
Alex Pott d0fceeeda9 Issue #2845364 by Wim Leers, EAnushan: Test coverage to show that as a non-administrator, you're able to modify the 'name' field, but only if you have the 'change own username' permission 2017-05-15 13:49:52 +01:00
Alex Pott 14a1f0cb0b Issue #2877778 by Wim Leers, tedbow: Harden test EntityResource + Dynamic Page Cache test coverage 2017-05-15 13:44:42 +01:00
Alex Pott 4398109471 Issue #2293697 by Wim Leers, dawehner, Jo Fitzgerald, clemens.tolboom, vedpareek, tedbow, Munavijayalakshmi, hchonov, alexpott, effulgentsia, tstoeckler, Crell, klausi, EclipseGc: EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available 2017-05-15 13:05:40 +01:00
Gabor Hojtsy 8f2aadc0f7 Issue #2869415 by Wim Leers, tstoeckler, dawehner: EntityResourceTestBase::getUrl() overrides BrowserTestBase::getUrl(), yet offers different functionality 2017-05-12 13:57:59 +02:00
effulgentsia 39803eb1f6 Issue #2827797 by Wim Leers, dawehner, effulgentsia, tedbow: ResourceResponse(Subscriber) + Dynamic Page Cache: making authenticated ResourceResponses significantly faster 2017-05-11 09:36:37 -07:00
Nathaniel Catchpole 494271d030 Issue #2712647 by slasher13, klausi, catch, jibran, Manuel Garcia, alexpott, mpdonadio, naveenvalecha, neclimdul, timmillwood, webflo, dawehner, Wim Leers, pounard: Update Symfony components to ~3.2 2017-05-02 10:37:54 +01:00
Alex Pott f170a96bc2 Issue #2843774 by jamesdesq, vaplas: EntityResource: Provide comprehensive test coverage for BlockContentType entity 2017-04-29 22:27:19 +01:00
Alex Pott a6b84bfbf2 Issue #2843756 by vaplas, Wim Leers, brentschuddinck, jamesdesq: EntityResource: Provide comprehensive test coverage for FieldStorageConfig entity 2017-04-29 21:27:29 +01:00
Alex Pott e31a0430c1 Issue #2869904 by tstoeckler: Config schema missing for less common HTTP methods in REST resources configured using 'method' granularity 2017-04-29 21:18:51 +01:00
Alex Pott 2dc6d91d60 Issue #2843754 by rogierbom, Wim Leers, gaurav.kapoor, vaplas: EntityResource: Provide comprehensive test coverage for Feed entity 2017-04-18 18:52:39 +01:00
Alex Pott 8938ab2906 Issue #2825973 by amateescu, timmillwood, himanshu-dixit, dawehner, Berdir, Wim Leers: Introduce a EditorialContentEntityBase class for revisionable and publishable entity types 2017-04-18 13:47:45 +01:00
Alex Pott 7cad23ab2a Issue #2848927 by Wim Leers, alexpott: EntityResource::addLinkHeaders() should use LinkRelationType plugin instances rather than definitions 2017-04-18 13:12:08 +01:00
Alex Pott a0dcc7f156 Issue #2853300 by Wim Leers: Standardize fatal error/exception handling: backtrace for all formats, not just HTML 2017-04-17 10:38:56 +01:00
Alex Pott b712a2d91f Issue #2843763 by arshadcn, Wim Leers: EntityResource: Provide comprehensive test coverage for ContentLanguageSettings entity 2017-04-15 10:21:42 +01:00
Alex Pott 757cfbbb82 Issue #2843766 by arshadcn: EntityResource: Provide comprehensive test coverage for FieldConfig entity 2017-04-15 10:20:00 +01:00
Alex Pott c522c8f789 Issue #2843773 by Wim Leers: EntityResource: Provide comprehensive test coverage for RestResourceConfig entity 2017-04-15 10:16:43 +01:00
Gabor Hojtsy 98bf96034c Issue #2359245 by Wim Leers, clemens.tolboom, marthinal, dawehner: REST resource plugin annotation class misses some properties 2017-04-13 12:37:56 +02:00
Gabor Hojtsy 509d3dbd0a Issue #2848378 by RenatoG, arshadcn, Wim Leers, GoZ, gaurav.kapoor, krina.addweb: Improve help text for REST module 2017-04-13 12:04:14 +02:00
Alex Pott 2cd2ec6c39 Issue #2827164 by tedbow, damiankloip, Wim Leers, dawehner: Entity reference field normalization has target_type and target_uuid, but not used in denormalization 2017-04-11 13:48:32 +01:00
Alex Pott 3e208146d2 Issue #2866056 by vaplas, mpdonadio, Wim Leers, dawehner: ResourceTestBase should not have a timeout 2017-04-10 20:47:40 +01:00
Alex Pott a8fec3492e Issue #2826407 by Wim Leers, dawehner, Jo Fitzgerald: PATCH + POST allowed format validation happens in RequestHandler::handle(), rather than in the routing system 2017-04-04 17:50:53 +01:00
Nathaniel Catchpole 3d292b3ede Issue #2843779 by vaplas, Yogesh Pawar: EntityResource: Provide comprehensive test coverage for ShortcutSet entity 2017-04-04 13:34:26 +01:00
Nathaniel Catchpole af81a985ea Issue #2843782 by arshadcn: EntityResource: Provide comprehensive test coverage for Editor entity 2017-04-04 12:06:22 +01:00
Nathaniel Catchpole c0933a14b1 Issue #2866252 by arshadcn, rakesh.gectcr: Refactor \Drupal\Tests\rest\Functional\EntityResource\Block\BlockResourceTestBase::getExpectedCacheTags 2017-04-03 22:11:02 +01:00
Alex Pott 8419d5e2eb Issue #2843752 by arshadcn, Wim Leers: EntityResource: Provide comprehensive test coverage for Item entity 2017-03-28 18:43:26 +01:00
Alex Pott e1524ff3e1 Issue #2843750 by vaplas, sumanthkumarc, Wim Leers: EntityResource: Provide comprehensive test coverage for Shortcut entity 2017-03-28 18:39:27 +01:00
Alex Pott 5955462816 Issue #2843786 by arshadcn: EntityResource: Provide comprehensive test coverage for ImageStyle entity 2017-03-28 18:37:52 +01:00
Alex Pott 5222fbfefd Issue #2843777 by arshadcn, Wim Leers: EntityResource: Provide comprehensive test coverage for NodeType entity 2017-03-28 13:11:16 +01:00
Alex Pott c7d9cdea0c Issue #2843775 by arshadcn, Wim Leers: EntityResource: Provide comprehensive test coverage for CommentType entity 2017-03-28 09:04:02 +01:00
Alex Pott df19756da3 Issue #2843759 by vaplas, Wim Leers: EntityResource: Provide comprehensive test coverage for SearchPage entity 2017-03-28 09:02:31 +01:00
Alex Pott 278c0b8a47 Revert "Issue #2843756 by vaplas, brentschuddinck, Wim Leers: EntityResource: Provide comprehensive test coverage for FieldStorageConfig entity"
This reverts commit bfaa4f5ab6.
2017-03-27 23:34:00 +01:00
Alex Pott df2fd66d59 Issue #2843756 by vaplas, brentschuddinck, Wim Leers: EntityResource: Provide comprehensive test coverage for FieldStorageConfig entity 2017-03-27 11:39:13 +01:00
Alex Pott 66c750c6c7 Issue #2843761 by vaplas, Wim Leers: EntityResource: Provide comprehensive test coverage for ConfigurableLanguage entity 2017-03-27 11:34:14 +01:00
Alex Pott 478f2fb92e Issue #2843762 by vaplas, Wim Leers: EntityResource: Provide comprehensive test coverage for Action entity 2017-03-27 11:31:19 +01:00
Alex Pott 0edd07b2f9 Issue #2853211 by vaplas, Wim Leers, arshadcn: EntityResource::post() incorrectly assumes that every entity type has a canonical URL 2017-03-27 09:30:26 +01:00
Alex Pott 4826159924 Issue #2843757 by vaplas, Wim Leers, alexpott: EntityResource: Provide comprehensive test coverage for FilterFormat entity 2017-03-27 09:15:12 +01:00
Chris McCafferty d20187f473 Issue #2817745 by Wim Leers: Add test coverage to prove that REST resource's "auth" configuration is also not allowing global authentication providers like "cookie" when not listed 2017-03-14 17:29:58 -04:00
Alex Pott bd69cfc93a Issue #2860096 by GoZ, jhodgdon: Remove api doc groups for updates eg. updates-8.2.x-to-8.3.x 2017-03-13 16:02:59 +00:00
Alex Pott e4461e6dc8 Issue #2832859 by vaplas, webflo, harings_rob, Wim Leers: Write EntityResourceTestBase subclasses for: MenuLinkContent 2017-03-07 16:47:20 +00:00
Chris McCafferty c1ec091625 Issue #2821711 by Wim Leers: Apache always sets Content-Type: text/html, even for DELETE requests 2017-03-06 19:35:38 -05:00
Alex Pott 6d2c634ea1 Issue #2844046 by Wim Leers, dawehner, tedbow: REST Resource config entities do not respect the status (enabled/disabled) 2017-03-06 12:59:35 +00:00