Commit Graph

567 Commits (a448f5a9b46c5a5e5bcd64072a420bef33161a44)

Author SHA1 Message Date
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert ff914280b9 - Synced/unified the error reporting from database.mysql.inc and database.pear.inc.
This makes debugging the PostgreSQL (and MSSQL) support somewhat easier.
2003-06-08 12:10:25 +00:00
Dries Buytaert 6ac9f88959 - Bugfix: fix glitch in menu rendering code. Patch #42 by Al. 2003-06-08 08:20:39 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 17cd7c497d - Added a function check_url() that CSS checks URLs (or parts thereof). 2003-06-06 21:08:35 +00:00
Kjartan Mannes 94f5eee15a - adding admin module to module_list. 2003-06-06 14:07:45 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 4582eeccd0 - Another register globals fix. Patch by Kjartan. 2003-06-01 19:51:40 +00:00
Dries Buytaert 82019d89fb - Omit "index.php" when using Apache. Patch by Al. 2003-05-31 13:05:06 +00:00
Dries Buytaert c6f9ca540d - Fixed typo. Patch by Marco. 2003-05-30 11:01:56 +00:00
Dries Buytaert 4499241fa1 - Make sure the HTML filter is applied before any other filter. Patch by
Al.
2003-05-30 05:45:35 +00:00
Dries Buytaert 7f2ce4acea - Fixed the order in which the CSS gets loaded. Patch by Al. 2003-05-30 05:10:35 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert b3c8b01d90 - Fixed a register globals problem in the pager. Patch by Al. (I also
removed a dead global variable.)
2003-05-23 21:33:24 +00:00
Dries Buytaert 5bd07f4bb2 - Fixed search module bug. Patch by Michael. 2003-05-23 17:59:25 +00:00
Dries Buytaert b68b2798d2 - Fixed a IIS bug with regard to register globals. This also avoids the
aforementioned ugly hack.  Patch by Moshe.
2003-05-20 04:41:36 +00:00
Dries Buytaert 65293a819b - Patch by Kjartan:
$_SERVER["HTTP_RAW_POST_DATA"] --> $GLOBALS["HTTP_RAW_POST_DATA"]

  Al: can you confirm that this fixes your problem?
2003-05-19 18:32:09 +00:00
Dries Buytaert bf28f8709b - Applied Moshe's patch that should make clean URLs work on IIS. I removed
a little hack that sometimes patches the request_uri(); I don't think
  this should trigger in first place.  If it does, let me know the URL of
  the form as well as the referring page.  (If this needs fixing after all,
  fixing this _inside_ request_uri() might be a better solution.)
2003-05-19 18:26:49 +00:00
Dries Buytaert 57c7d7b43b - The page_footer() function was always called twice due to the introduction
of the "footer" hook (and because of the existence of the page module).
  This caused the node view counter to be incremented twice per page view,
  the cache being set twice, etc.  Quite a bug.
2003-05-18 09:48:49 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert 9a62873a4b - Added <base href=""> to default theme. Patch by Al, though I had to add
a 'global $base_url;'.  Fixes bug #1533.
2003-05-07 20:39:27 +00:00
Dries Buytaert c2f3cb2b63 - Renamed 'xmlrpc_decode' to '_xmlrpc_decode' to avoid redeclaration when
PHP's XML-RPC library is enabled.

- Renamed 'xmlrpc_encode' to '_xmlrpc_encode' to avoid redeclaration when
  PHP's XML-RPC library is enabled.

- Removed 'if (funcion_exist("xmlrpc_encode"))' check from common.inc.
2003-04-29 22:02:02 +00:00
Dries Buytaert 31d8b14969 - A one line patch to theme.inc which adds a missing page title variable to
the header() function.  Patch by Moshe.
2003-04-25 20:10:36 +00:00
Dries Buytaert 709d9ec592 - Forgot to commit the modified "includes/common.inc" when applying the
htmlArea related modifications.  Thanks Gordon.
2003-04-23 18:58:43 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert b505b5ab65 - Committed Gordon's htmlarea patch. 2003-04-21 13:56:09 +00:00
Dries Buytaert cfb4d31f65 - Added missing quotes, initialized a variable an improved the error reporting
a little.
2003-04-21 12:36:09 +00:00
Dries Buytaert 81b05c6795 - Don't report duplicate entries - it is an OK thing to do. 2003-04-21 12:31:51 +00:00
Dries Buytaert a53e34e80e - Removed the deprecated function menu_add(). 2003-04-14 20:29:31 +00:00
Dries Buytaert 61780d8516 - Fixed bug in cache_get(). Patch by Anarcat. 2003-04-13 14:12:43 +00:00
Dries Buytaert 02f437a2f4 - Renamed 'validate_email_address' to 'valid_email_address'.
- Added a 'form_radio' function.
2003-04-13 13:42:51 +00:00
Dries Buytaert cb2d27c78d - Patch by Ax. Fixed some syntax errors:
-    case t("whatever");
    +    case t("whatever"):
2003-04-04 06:17:02 +00:00
Dries Buytaert 3ab5709af5 - Changed pconnect() to connect(). 2003-04-03 22:18:47 +00:00
Dries Buytaert 62f5ae01f6 - Some coding style fixes. 2003-04-03 22:18:27 +00:00
Dries Buytaert 3ad7449bc7 - Various improvements to the menu system.
- Changed the import and taxonomy module to use better URLs.  Patches by
  Al.

- Fixed locale module weirdness.  Patch by Kjartan.
2003-04-01 06:05:15 +00:00
Kjartan Mannes e73a163dbd - Rollback: $cid in cache_set() is not required to be numerical. 2003-03-29 18:08:56 +00:00
Dries Buytaert 4742ba3549 - Fixed some SQL query directives. 2003-03-29 16:30:40 +00:00
Dries Buytaert d1be768b28 - Moved the logic of email validation from user_validate_mail to a new function
in common.inc.  Modified patch from Gerhard.
2003-03-28 10:55:27 +00:00
Dries Buytaert 64b6cb5897 - Removed one line of dead code. 2003-03-19 22:01:38 +00:00
Dries Buytaert 8952e9c53e - Rollback: do not initialize the theme before initializing the user. 2003-03-17 07:01:12 +00:00
Dries Buytaert 2c0f3c9457 - Cache improvement: only flush cache when told to. 2003-03-16 21:49:33 +00:00
Dries Buytaert b2583b624c Patch by Ax:
- db_query_range() in database.mysql.inc wasn't updated to match
  db_query().

- Fixed phpdoc.
2003-03-16 17:38:51 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert 4ad174c411 - Eliminated system_init(), the session stuff, and made it possible to
rebuild the menu.
2003-03-12 21:46:14 +00:00