Commit Graph

199 Commits (a39939bb266dca02ffaabf2231cbef51a1af6f6e)

Author SHA1 Message Date
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm f09c890298 Issue #3132964 by jungle, longwave, sja112, dww, xjm, daffie: assertResponse() does not actually support a $message parameter, so stop passing one 2020-05-22 12:37:50 -05:00
xjm f9665f2d41 Issue #3138731 by jungle, dww: Fix "inheritdoc" typos in core 2020-05-21 21:48:02 -05:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
catch 474a690299 Issue #3092090 by Berdir, Wim Leers, plach, amateescu: Remove legacy Path Alias subsystem 2020-01-27 15:46:24 +00:00
catch df1a2b06de Issue #3097421 by longwave, andypost: Remove help.module BC layers 2019-11-29 16:03:38 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
catch 5be2df421d Issue #2940189 by Vlad Bo, claudiu.cristea, alexpott, NightHunterSV, andypost, almaudoh, voleger, Berdir: Deprecate system_get_info() 2019-10-07 14:46:33 +01:00
Lee Rowlands 973da43743
Issue #2994748 by jhodgdon, andypost, Amber Himes Matz: Make a way for Help Page Sections to be ordered 2019-07-29 14:43:34 +10:00
Alex Pott e39262bf5b
Issue #2228741 by rpayanm, mikelutz, voleger, epari.siva, malotor, Rolf van de Krol, quietone, Mile23, andypost, ianthomas_uk, Lendude, alexpott, dawehner, xjm, Gábor Hojtsy, Berdir, catch: Replace calls to format_string() with Drupal\Component\Render\FormattableMarkup 2019-07-11 09:06:33 +01:00
Alex Pott 23fad5b6a5
Issue #2926068 by almaudoh, andypost, voleger, claudiu.cristea, Oleksiy, YurkinPark, yo30, alexpott, dawehner, Berdir: Deprecate system_rebuild_module_data() and remove usages in core 2019-06-03 12:49:38 +01:00
catch 9791614b78 Issue #2731817 by mikelutz, ashishdalvi, Sonal.Sangale, dbt102, andypost, jhodgdon, martin107, roderik: Replace all calls to the deprecated Drupal::url() function in Core 2019-04-16 14:38:27 +09:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Lee Rowlands 0d6d22af0b
Issue #2926120 by idebr, zaporylie, borisson_: @var tag must not end with a full stop 2018-05-15 06:49:38 +10:00
Alex Pott b8f93d5b61
Issue #2901730 by mfernea, ankitjain28may, idebr: Fix 'Squiz.WhiteSpace.FunctionSpacing' coding standard 2018-05-11 10:26:36 +01:00
Alex Pott 3bfc5a384b
Issue #2938970 by MerryHamster, surbz, msankhala, alexpott, Jo Fitzgerald, Yasiru Nilan, Manuel Garcia, ZeiP, boaloysius, xjm, wturrell, tameeshb, darrenwh, ritzz: Replace drupal_render() in @param, @return, @see, @link, etc 2018-05-03 17:58:24 +01:00
Alex Pott b84b827d42
Issue #2935256 by Jo Fitzgerald, voleger, kim.pepper, ibustos, Yogesh Pawar, catch, jibran: Remove all usages of drupal_get_message and drupal_set_message in modules 2018-05-01 10:15:07 +01:00
Nathaniel Catchpole d90ac78f3e Issue #2798891 by ankitjain28may, trobey, TR: Define project dependencies in core module .info files 2018-04-06 13:13:01 +01:00
xjm 7a012b198b Issue #2922603 by tedbow, Wim Leers, andrewmacpherson: Mark Settings Tray module as stable 2018-01-29 16:38:57 -06:00
xjm 752fd5a721 Issue #2924780 by zaporylie: Missing @var annotation for scalars that provide default values 2017-11-22 12:43:49 -06:00
Nathaniel Catchpole 02a8ccbdcb Issue #2902406 by mfernea: Fix 'Drupal.Classes.UseLeadingBackslash' coding standard 2017-08-21 14:01:00 +09:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
Alex Pott a142151dc6 Issue #2735199 by klausi, naveenvalecha, dawehner, jhodgdon: Convert web tests to browser tests for help module 2016-06-18 10:19:15 +01:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Nathaniel Catchpole 1003490b99 Issue #2707261 by alexpott, jhodgdon: Calling moduleInvokeAll in Help block is wrong 2016-04-28 21:46:32 +01:00
Alex Pott 6dce6c2a9f Issue #2697909 by pguillard, himanshugautam, snehi, aburrows, jhodgdon: Fix "login (noun/adjective)" vs. "log in (verb)" in comments (and logout/log out) 2016-04-27 16:16:19 +01:00
Nathaniel Catchpole 0cbd30d5d6 Issue #2707109 by alexpott, jhodgdon: Help block should not be displayed when hook_help() implementations return an empty string 2016-04-19 17:32:54 +09:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott 0db5b13892 Issue #2686207 by Berdir: Convert simpletest kernel tests in modules A-I to phpunit 2016-03-28 19:36:47 +01:00
Alex Pott b511038777 Issue #2661200 by jhodgdon, Wim Leers, Cottser, Mile23, vijaycs85, larowlan, andypost, tim.plunkett, dawehner: Make admin/help page more flexible, and list tours on it 2016-03-11 12:10:41 +00:00
Alex Pott d5af25512e Issue #2342015 by Chi, joelpittet, vijaycs85, Matt V., Gábor Hojtsy, alexpott, catch: Content Translation module still implements hook_enable 2016-02-26 11:15:22 +00:00
Nathaniel Catchpole a3f5ca8a81 Issue #2338747 by dawehner, chx: Move {router} out of system.install and create the table lazy 2016-02-19 13:26:53 +09:00
Nathaniel Catchpole c7af20e47f Issue #2665672 by jhodgdon: hook_help() should allow render arrays for return values 2016-02-17 12:59:21 +09:00
Nathaniel Catchpole 7ab932fbee Issue #2657178 by xjm: Warn about experimental modules on their help pages 2016-02-01 21:21:43 +09:00
Nathaniel Catchpole b95ae50276 Issue #2604098 by Wim Leers: HelpBlock has the 'url' cache context instead of 'route' 2016-01-26 15:49:25 +09:00
Jennifer Hodgdon c5eb4480bb Issue #2607870 by Lars Toomre: Some docblock fixes for PHP type 'integer'
(cherry picked from commit e0516e391a)
2015-12-08 09:48:25 -08:00
Jennifer Hodgdon e225500828 Issue #2607332 by r_sharma08, ashhishhh, snehi, pjonckiere, dawehner: Missing @return tag in getActiveHelp(), denormalize(), createBookNode()
(cherry picked from commit 0a97f79072)
2015-12-07 10:40:28 -08:00
Alex Pott b3150847e0 Issue #2541344 by Wim Leers, borisson_, DietrichM, Xano, tim.plunkett, alvar0hurtad0, joshi.rohit100: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) 2015-10-30 16:25:58 +00:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
xjm b8251f61e9 Issue #2575869 by pwolanin, Wim Leers, JeroenT, dawehner, YesCT: Remove all remaining usage of deprecated UrlGeneratorInterface::generateFromPath() and delete it 2015-10-06 22:06:35 -05:00
webchick e36c84dea0 Issue #2568099 by Wim Leers, mdrummond, mortendk: Follow-up for #2407739: Remove the js-quickedit-main-content class that was added in favor of relying on <main> 2015-10-05 00:11:17 -07:00
webchick 1a70fc1292 Issue #2471739 by RajeevK, martins.kajins, pektinasen, LewisNyman, jaxxed: Convert reusable layout classes to BEM standards 2015-10-04 22:36:55 -07:00
Alex Pott b921d2b3c0 Revert "Issue #2471739 by RajeevK, martins.kajins, LewisNyman, jaxxed: Convert reusable layout classes to BEM standards"
This reverts commit cec8f5eb30.
2015-09-26 17:15:08 +02:00
Alex Pott cec8f5eb30 Issue #2471739 by RajeevK, martins.kajins, LewisNyman, jaxxed: Convert reusable layout classes to BEM standards 2015-09-26 13:37:21 +02:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
Alex Pott 05ff65b5e1 Issue #2568257 by mr.baileys, lauriii, xjm: Add double escape test for hook_help() 2015-09-19 18:28:10 +01:00
Nathaniel Catchpole 56bcfe4ece Issue #2560641 by alexpott, lauriii, Xano, borisson_, ianthomas_uk, olli: Remove all usages SafeMarkup::checkPlain() from render arrays 2015-09-03 23:37:10 +01:00
Nathaniel Catchpole f13b2d59bd Revert "Issue #2560641 by alexpott, lauriii, Xano, borisson_, ianthomas_uk: Remove all usages SafeMarkup::checkPlain() from render arrays"
This reverts commit 3100760954.
2015-09-03 23:36:44 +01:00
Nathaniel Catchpole 3100760954 Issue #2560641 by alexpott, lauriii, Xano, borisson_, ianthomas_uk: Remove all usages SafeMarkup::checkPlain() from render arrays 2015-09-03 23:36:26 +01:00
Alex Pott 026e9d8754 Issue #2549091 by Pravin Ajaaz, jhodgdon: Fix "associated to" ==> "associated with" 2015-08-18 13:10:00 +01:00
Alex Pott d904faacf1 Issue #2543554 by Wim Leers, tim.plunkett: Clean up Help & Statistics blocks 2015-08-06 17:20:58 +01:00
Nathaniel Catchpole 81658d5c87 Issue #2512132 by Wim Leers, effulgentsia, Fabianx: Make CSRF links cacheable 2015-07-15 15:09:47 +01:00
Alex Pott 1f53649bfb Issue #1392754 by tss, justAChris, jhodgdon: Comply with new documentation standards for @file for namespaced class files 2015-06-26 21:53:33 +01:00
Nathaniel Catchpole 9da500aff8 Issue #2494989 by catch, alexpott, vijaycs85: Don't render main help pages on modules page just to generate help links - can lead to high memory usage on form submit 2015-06-09 10:45:32 +01:00
webchick c680d33dc3 Issue #2495657 by alexpott, jhodgdon: Admin links are missing from a module's help page 2015-05-27 23:18:27 -07:00
xjm 088f8b357a Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912) 2015-05-24 15:08:46 -05:00
xjm a66bc57cd6 Issue #2476745 by joshi.rohit100, znerol, andile2012, webchick, Daniel Kanchev: Fix case of SuperNovaGenerator in HelpEmptyPageTest 2015-05-18 22:53:18 -05:00
xjm 0f2768f7be Issue #2488632 by rpayanm, jhodgdon: Help test module should be in the Testing package 2015-05-17 16:38:04 -07:00
Alex Pott 7342df62dd Issue #2335661 by Wim Leers, pwolanin, dawehner, Fabianx, larowlan, catch, Berdir: Outbound path & route processors must specify cacheability metadata 2015-05-09 05:23:46 -07:00
Alex Pott 6e466e49ec Issue #2474055 by dawehner, pwolanin: Performance regression in contact_help() 2015-04-20 16:12:40 +02:00
effulgentsia cbc03163b9 Issue #2281989 by stefan.r: Add a fast and simple way to get module name from the module handler 2015-04-17 16:05:59 -07:00
webchick 8f07297676 Issue #2375689 by Arla, Wim Leers, dawehner, tim.plunkett, Berdir: BlockBase::blockAccess() should return AccessResult instead of a bool 2015-04-16 09:45:19 -07:00
webchick 70f8ac6f31 Issue #2457887 by prateekMehta, stefan.r, rpayanm, alexpott: Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions 2015-03-29 15:13:25 -07:00
catch 938e2f648c Issue #2428805 by Wim Leers: Remove the ability to configure a block's cache contexts 2015-03-25 20:12:42 +00:00
catch 460af4c9f3 Issue #2329101 by Wim Leers: CacheableInterface only has a getCacheKeys() method, no getCacheContexts(), leads to awkward implementations 2015-02-20 09:18:26 +00:00
Alex Pott bc7c79c606 Issue #2415415 by er.pushpinderrana: help.api.php missing <?php at top 2015-02-03 09:49:27 +00:00
Alex Pott f6c5660879 Issue #2337317 by LewisNyman, idebr, ngocketit: Replace help page layout CSS with reuseable layout classes 2015-01-13 11:10:45 +00:00
Nathaniel Catchpole 4cd9d4577d Issue #2263359 by jhodgdon: hook_help(): Top of page help sections can't link to help pages without a fatal error or checking for help module 2014-12-08 11:11:21 +00:00
Nathaniel Catchpole 596978a71d Issue #2378095 by Wim Leers, Devin Carlson: Convert all remaining attached individual CSS/JS assets to attached asset libraries 2014-11-28 20:51:14 +00:00
Nathaniel Catchpole edd7889694 Issue #2376791 by dawehner, Wim Leers: Move all _content routing definitions to _controller 2014-11-20 09:47:06 +00:00
Alex Pott 195d49998a Issue #2347465 by tim.plunkett, dawehner, cilefen: Convert all instances of #type link/links to convert to use routes. 2014-10-09 07:39:37 +01:00
Alex Pott 4f49087b71 Issue #2277103 by tim.plunkett, pwolanin, Wim Leers, dawehner, hotpizzas: Switch Drupal::l() and LinkGenerator to expect a Url object. 2014-09-29 15:41:29 +02:00
Alex Pott 0463b81a08 Issue #2322889 by sun: Fixed Various setUp() and tearDown() methods are not protected. 2014-08-18 16:50:50 +01:00
Alex Pott 70bed3385f Issue #2301317 by pwolanin, dawehner, Wim Leers, effulgentsia, YesCT, xjm, alexpott: MenuLinkNG part4: Conversion. 2014-07-30 13:04:04 +01:00
Alex Pott 44f76c6bcf Revert "Issue #2301317 by pwolanin, effulgentsia, Wim Leers, dawehner, alexpott: MenuLinkNG part4: Conversion."
This reverts commit fd2db9cd35.
2014-07-30 13:02:58 +01:00
Nathaniel Catchpole fd2db9cd35 Issue #2301317 by pwolanin, effulgentsia, Wim Leers, dawehner, alexpott: MenuLinkNG part4: Conversion. 2014-07-30 11:47:01 +01:00
Alex Pott b560f348bd Issue #2303605 by cilefen: Rename *.menu_links.yml to *.links.menu.yml files to improve DX. 2014-07-16 23:39:40 +01:00
webchick 30c2afed20 Issue #697760 by sun: Replace getInfo() in tests with native phpDoc + annotations (following PHPUnit). 2014-07-10 20:50:37 -07:00
webchick 94e0188a10 Issue #2294129 by xjm, tim.plunkett: Switch hook_help() to use RouteMatch instead of Request. 2014-06-29 20:33:08 -07:00
Jennifer Hodgdon 2c77fc293e Issue #2261083 by amitgoyal, joshi.rohit100, er.pushpinderrana, aschmoe: Move mention of System Help block from Help module help to System module help 2014-06-20 10:44:03 -07:00
Jennifer Hodgdon 122c9b4696 Issue #2263047 by martin107, sachin_s: Move hook_help to system.api.php, remove now-empty help.api.php, and add explanation of all that hook_help does and update it so it fits d8 behavior 2014-06-06 12:57:38 -07:00
webchick d0d3e53361 Issue #2247991 by xjm, typhonius, donquixote: [May 27] Move all module code to PSR-4. 2014-05-27 19:43:20 -07:00
webchick eef067b5a5 Issue #2183113 by jhodgdon, effulgentsia, tim.plunkett, herom, larowlan: Update hook_help signature to use route_name instead of path. 2014-05-06 19:04:53 -07:00
Dries 3a8dd52c67 Issue #2226761 by Wim Leers: Change all default settings and config to fast/safe production values. 2014-05-05 12:38:12 -04:00
webchick a839132084 Issue #2245783 by tim.plunkett: Regression: Help blocks display on 403/404 page. 2014-04-22 20:58:34 -07:00
webchick 4ac79a1366 Issue #2226903 by pwolanin, dawehner, tvn, martin107, jessebeach: Step 1: Move static menu links to yml files. 2014-03-28 16:27:34 -07:00
Nathaniel Catchpole b9a978d202 Issue #2177041 by dawehner, Berdir, jibran: Remove all implementations of hook_menu. 2014-02-26 10:53:29 +00:00
webchick f09e295739 Issue #2160933 by TR: NoHelpTest is faulty. 2014-02-06 23:28:47 -08:00
webchick a979bbda18 Issue #2110501 by tim.plunkett, pwolanin, tstoeckler: ControllerBase should implement ContainerInjectionInterface like FormBase. 2014-02-02 19:12:30 -08:00
Alex Pott acd3a59ea8 Issue #2047633 by pwolanin, dawehner, kim.pepper, Xano, amateescu, tim.plunkett: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit. 2014-01-29 08:25:00 +00:00
Alex Pott 42e2c36937 Revert "Issue #2047633 by dawehner, pwolanin, Xano, amateescu, tim.plunkett: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit."
This reverts commit 531fd59314.
2014-01-24 19:01:38 +01:00
Alex Pott 531fd59314 Issue #2047633 by dawehner, pwolanin, Xano, amateescu, tim.plunkett: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit. 2014-01-23 23:14:32 +01:00
webchick 063b5cd333 Issue #2143933 by tim.plunkett, pwolanin, dawehner: Add _title and _title_callback to all routes. 2013-11-27 23:44:52 -08:00
Nathaniel Catchpole e1123158be Issue #2102453 by ACF, JulienD, InternetDevels: Remove drupal_set_title() in help module controllers. 2013-10-31 11:46:32 +00:00
Jennifer Hodgdon 30c60dfdc8 Issue #2091335 by lostkangaroo, cosmicdreams, batigolix, yingtho, neclimdul: Fix up hook_help for the help module 2013-10-22 16:18:25 -07:00