Commit Graph

127 Commits (a31b1b38765e3f91270e7339821721f6e80fa2b0)

Author SHA1 Message Date
Kjartan Mannes 2954836fba - Fixed empty searches being performed.
- Fixed empty searches being logged.
- Trim whitespace from start and end of search key.
2004-05-30 21:04:07 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert fd0ef2cc48 - Patch #7088 by TDobes: fixed incorrect comment links in search results. 2004-04-13 21:33:27 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert 1d5a29a357 - Log the search terms in a new watchdog category. 2004-01-02 16:44:11 +00:00
Dries Buytaert 21a0e8b904 - Updated code to use new semantics of url() and l(). 2003-12-29 19:49:11 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 3904790e03 - Tidied up the DoxyGen comments. Patch by Kjartan. 2003-12-08 06:32:19 +00:00
Dries Buytaert 800a58f571 - Removed duplicated code. Reported by Goba. 2003-11-30 10:39:15 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 06045ff7fc Patch by Ax to fixe and improve to the core doxygen PHPdoc:
* fixes all doxygen warnings [#]_ in the current code base
    + changes @param style from phpDocumentor (@param type $var desc) to doxygen (@param $var desc)
    + documents all undocumented parameters
    + escapes / fixes html warnings
    + fixes @defgroup in theme.inc
  * adds more groupings [#]_
    + drupal_{set|get}_title, drupal_{set|get}_breadcrumb
    + pager.inc: pager_api (pager_query(), pager_display()), pager pieces
  * adds a new group "themeable" which contains all themeable functions.
2003-11-24 22:46:03 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert 90e5e355cb - Bugfix: fixed problem with search key replacement. Patch by Kjartan. 2003-10-21 20:55:33 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert 01f3bcfc75 - Added page titles. Patch 0105 by Kendow. 2003-09-16 15:04:02 +00:00
Dries Buytaert ad5fb6cd6d - Noiseword fix. Patch by Matt. Reported by Bart. 2003-09-10 16:48:00 +00:00
Dries Buytaert 9b74d0b83c - Patch from Matt:
"The noise words description says that whitespace and line breaks will be
  stripped out, but the code never does any trimming.  This simple patch strips
  the whitespace from the noise words.  This probably takes care of bug #2804."
2003-09-10 07:56:06 +00:00
Dries Buytaert 2e22798a8d - More help system updates by Michael F. 2003-08-25 16:57:55 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert 3bb6ddee4b - Bugfix: fixed problem with search terms not being escaped properly. 2003-06-30 19:42:19 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert e95aa56e02 - Bugfix: fixed bug in the search module that prevented the title module
from working properly.  Patch by Moshe.  Fixes bug #1852.
2003-06-25 22:10:54 +00:00
Dries Buytaert 026c09b6ce - Bugfix: fixed searches to do boolean AND rather than OR. This isn't the best way to do things, but seems to be pretty much the only way to get things to be properly
ANSI-compliant.  Patch by #17 by Al.  (Note: I haven't really tested this fix but this should fix bug #1857.)
2003-06-16 17:20:50 +00:00
Dries Buytaert d80557672c - Made it possible to link search results. Patch by Ax.
- Removed some high ASCII characters from the code.  Patch by Ax.
2003-06-08 17:17:53 +00:00
Dries Buytaert 2aa762436f - Fixed a warning. Patch by Jacobo Tarrio. 2003-05-30 14:58:44 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert 5bd07f4bb2 - Fixed search module bug. Patch by Michael. 2003-05-23 17:59:25 +00:00
Dries Buytaert 8205b62666 - Replaced some PHP_SELF's by request_uri()'s. Patch by Gerhard. 2003-05-18 20:21:35 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert fe4b713b68 - Added title module; this brings back some old functionality. Thanks
Moshe and Gerhard.
2003-04-24 21:56:12 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert d5fe0cfe20 - Fixed bug in search.module: slashes where escaped twice. 2003-03-06 22:03:36 +00:00
Dries Buytaert 465a598770 - Fixed off-by-one bug in the search module. Patch by Brad. (Still looking
into the blog module patch.)
2003-02-16 17:47:53 +00:00
Dries Buytaert 83f5d82876 - Everything is using theme("function") now instead of $theme->function(). 2003-02-15 11:39:56 +00:00
Kjartan Mannes d154836125 - Applied patch from Axel: missing cid in comment search results. 2003-02-12 21:39:07 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 966f0811a2 - Tidied up some SQL queries. 2003-01-21 22:31:37 +00:00
Dries Buytaert 89b2069e4d - Clean URL patch. 2003-01-06 19:51:01 +00:00
Dries Buytaert 56da7ebfa2 - Fixed bug that prevented results containing multiple occurences of the
search word(s).  Patch by Ax.
2003-01-01 21:06:22 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 1cb8f3b2c6 - Made the search module use implicit AND'ing instead of OR'ing. Patch by
Gerhard.  Also updated the documentation a little.
2002-11-27 19:55:14 +00:00
Dries Buytaert aab82c0aeb - Fixed bug in search module. Patch by Gerhard. 2002-11-25 15:52:04 +00:00
Dries Buytaert 15aed817ad - Search configuration settings are now a part of the standard
configuration page.  Patch by Kjartan.
2002-11-21 18:18:19 +00:00
Dries Buytaert b3b3fd9a0a - Applied the correct search module patch (I hope). Thanks Gerhard. 2002-11-18 22:27:52 +00:00
Dries Buytaert 57a9590a44 - Committed Gerhard's search module improvements. 2002-11-18 19:10:44 +00:00
Dries Buytaert dbbfc7415b - Added form descriptions. Patch by Kjartan. 2002-11-17 06:58:13 +00:00
Kjartan Mannes 5d36c70449 - improved module descriptions.
- removed admin options for queue and comment module if the modules are not
  loaded.
- nodes are now auto promoted when queue module isn't enabled.
- moderation result block is now visible by the node author.
2002-06-08 16:17:29 +00:00
Steven Wittens 80a6b15942 Some small corrections to the system descriptions (as discussed in mailinglist) 2002-06-04 11:44:23 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Dries Buytaert 0908a06cd0 - Replaced a "mysql_query()" by a "db_query" as identified by Moshe (see
his sandbox) and fixed some typos in the module's comments.

  * Moshe: what are the $wordlist changes you made?  Mind to elaborate a
           bit on those?

  * TODO: validate the SQL queries used in the search module using a SQL
          validator tool - I wonder whether they are ANSI compliant.


-    // If the word is preceeded by a "+", then this word is required, and
+    // If the word is proceeded by a "+", then this word is required, and

-        $inputword = ("INSERT INTO search_index VALUES('$key', ". $node["lno"] .", '$node_type', $value)");
-        mysql_query($inputword);
+        db_query("INSERT INTO search_index VALUES('$key', ". $node["lno"] .", '$node_type', $value)");
       }

-      // Zap the weighted words array, so we dont add multiples.
+      // Zap the weighted words array, so we don't add multiples.
2002-05-26 11:00:50 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Dries Buytaert d8cd54969c - Added Marco's long-awaited taxonmy module and patches - a replacement
for the meta system.  The patches add some extra functionality to the
  comment system (for example, comments can be set read-only) and fix a
  couple of small problems.

  + I integrated the required SQL updates from the varius *.mysql files
    into the "update.php" script.  Upgrading should be easy ...

  + I did not apply/commit the "user.diff" as requested by Marco ...

  + I didn't know what to do with "forum.module" and "forum2.module":
    what do you want me to do with it Marco?  Which one should go in?

  + Can we remove "node_index()" now; both from "node.module" and the
    themes?

  + Thanks Marco!
2002-04-14 20:46:41 +00:00
Kjartan Mannes 7dfd5f0b7e - my editor got set up to insert tabs instead of spaces. Cleaning up. 2002-04-05 18:11:42 +00:00
Kjartan Mannes e3d2c46f04 - applied search patch.
- added who is online block.
- made weblog module more configurable.
- users may now delete their own accounts (Feature #8)
- users may now request a password using email address *or* username.
  formerly required both items to match an account which was onerous.
- the link to request a new password is now presented whenever a user
  fails login.
- there is now a confirmation message after submitting edits to your
  user information.
- error messages in user.module may now be stylized by themes.
- <hook>_form has a $param setting you can fill with form parameters.
- improved wording for a few config settings.
- fixed various non-coding standard things.
2002-03-05 20:15:17 +00:00
Dries Buytaert f9a508d5dd - Fixed more than 30 HTML and XML well-formedness errors. 2002-01-27 14:58:45 +00:00
Dries Buytaert ca95b491ff - Updated some of the descriptions. 2002-01-11 22:09:11 +00:00
Dries Buytaert 336b713a5f - A large batch of updates, amongst them a rewritten node system. More
information available on the mailing list.
2001-11-01 11:00:51 +00:00
Kjartan Mannes 864c18d4c3 - added the CVS keyword $Id$ to all files to make future version tracking
easier. Also changed the <? tag to <?php in some cases.
2001-10-20 18:57:09 +00:00
Dries Buytaert f1932821be - PEAR-ification of Drupal by claw: you can now host Drupal on a wide
range of databases including MySQL, PostgreSQL, MSSQL, and others.

  For additional information and an 'how to upgrade', check the mails
  sent to the mailing list.
2001-10-09 21:01:47 +00:00
Dries Buytaert 7a9bc86bd2 - Improved search architecture derived from Axel's new search patches.
(There is room for improvement so let's go from these ... and build
  on them.)

- Removed some $status's by calls to node_status().
2001-10-03 20:57:01 +00:00
Dries Buytaert 0cce47f15f - fixed small glitch in node_del()
- fixed small glitch in comment_del()

- changed the API of the form() function.  The first parameter, the
  "action"-attribute in the <form>-tag has been made optional.  By
  default, it will be set to "$REQUEST_URI".

  Why? Because in 98% of the cases we would do:

    global $REQUEST_URI;
    $form = form($REQUEST_URI, $form_content);

  while we can do:

    $form = form($form_content);

  now.

  Update your modules (and sorry for the inconvenience)!
2001-09-28 16:20:55 +00:00
Dries Buytaert 6cde632962 - book.module: fixed "/admin.php" bug reported by Gerhard.
- search.module: made the search categories translatable.
2001-09-27 18:30:36 +00:00
Dries Buytaert a1222d6430 - Fixed translation bugs (reported by Alexander Schwartz) 2001-09-24 18:46:07 +00:00
Dries Buytaert 6c7b845b34 - improved search module (vaguely derived from axel's code) 2001-09-22 21:01:39 +00:00
Dries Buytaert ca85a56f1b - Fixed 2 typos in the user module. Thanks Axel and Remco.
- Applied (modified versions of) Alexander's patches on the development
  branch.
2001-09-18 18:39:15 +00:00
Dries Buytaert e6a67118eb - Made search.php a module, being search.module.
- Updated the permission names to be more consistent.

- Small improvement to node.php.
2001-06-30 09:50:36 +00:00