Commit Graph

298 Commits (a31b1b38765e3f91270e7339821721f6e80fa2b0)

Author SHA1 Message Date
Dries Buytaert 62427644eb - Patch #23320 by Chris Messina: made it easier to theme the printer-friendly book pages. 2005-05-21 09:59:15 +00:00
Dries Buytaert 30da942645 - Patch #22123 by Djun: fixed off by one error in printer-friendly book pages. 2005-05-06 08:43:21 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert df9f93f98a - Modified patch #21441 from puregin + RobinMonks: fixed some bugs surrounding the book administration and beautified some code making it more consistent with the rest of Drupal. :-) 2005-05-05 09:36:51 +00:00
Dries Buytaert bca14f8991 - Patch #21687 by faago: fixed boroken 'delete'-link on the book administration page. 2005-04-30 21:34:41 +00:00
Steven Wittens 3361d9e7e9 - #21195: book admin broken under php5 2005-04-24 20:57:38 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert cb420f7121 - Work by chx and myself: added a site-wide contact form to the contact module. 2005-04-24 08:23:33 +00:00
Dries Buytaert 394fe19ac6 - Patch #20661 by rooey: fixed formatting of book navigation. Added missing '<div id=menu>'. 2005-04-17 16:03:50 +00:00
Dries Buytaert 293daa4820 - Patch #20451 by Moshe: some ancient code was assuming that all apges in a book are of type 'book'. 2005-04-13 18:50:57 +00:00
Dries Buytaert 398ed04670 - Patch #19960 by Gerhard: removed left-over DISTINCT. Spotted by BuddaBoy. 2005-04-04 21:32:21 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Dries Buytaert a7fa9552ca - Patch #19169 by TDobes: allow the book navigation to be themed. 2005-03-22 18:34:20 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert de0a0b7a81 - Patch #16462 by Moshe: book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page. 2005-02-06 09:37:10 +00:00
Dries Buytaert 9f77077584 - Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch. 2005-01-30 08:53:05 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert c8ef017446 - Patch #15948 by matteo: the book module should call the nodeapi hook when printing printer-friendly pages. 2005-01-23 22:35:41 +00:00
Dries Buytaert 630dcebf43 - Patch #15843 by Ber: in book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15. 2005-01-19 22:13:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 046536f470 - Patch #12366 by mathias: fixed missing book edit tab. 2004-12-22 20:47:47 +00:00
Dries Buytaert 78c24e67c0 - Bugfix: the book module incorrectly assumed that there is an active revision if n.moderate = 0. We can (and need) to rewrite this when the revision changes hit core. In essence, we need an efficient query to retrieve the 'last puslished revision that is not in the moderation queue'. 2004-12-18 10:27:28 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert 4726c93156 - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly. 2004-11-24 22:56:21 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert fa97839088 - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Dries Buytaert f67c046d40 - Modified patch #8552 by Gerhard: added 'add child page' link to book pages you can edit. 2004-11-15 12:49:59 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert bb3df8a1a9 - Patch #10632 by Gerhard: the book permissions in today's cvs are not consistent with the rest of Drupal. We have a "maintain books" and a "edit own book pages" permission. All other modules have a "create foo" permission. Thus the existing "maintain books" permission should be renamed to "create book pages" and a new "maintain books" permission should be introduced that allows editors to update book pages they haven't created themselves even without having "administer nodes" permission. 2004-11-04 22:31:46 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Dries Buytaert f1a087e376 - Patch #11879 by Moshe: deprecated the _content hook.
TODO:
   + Update Doxygen hook list (if required).
   + Document this in the developer's upgrade section.
2004-10-23 17:18:23 +00:00
Dries Buytaert a73f63f10c - Patch #11947 by puregin: ensured that a book node's weight is captured when the book node lists returned by book_location() and book_location_down() are generated. This information is required when selecting next page candidates in book_next().
Note that book_location_down() was missing an explicit field b.weight in the SQL SELECT statement, but this value would usually be supplied implicitly because it is used to ORDER the result.
2004-10-23 13:41:37 +00:00
Dries Buytaert 10f329c057 - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
Dries Buytaert 1f1a772a11 - Mofified patch #8862 by puregin: improved book module documentation. 2004-10-15 10:56:23 +00:00
Dries Buytaert 6a8e394301 - Fixed bug #11312: menu caching to aggresively. I did not apply the proposed
patch but moved the menu-logic to the $may_cache clause and added some checks
  to avoid SQL overhead.  I think this is the most performant solution.
2004-10-14 21:45:37 +00:00
Steven Wittens 63061bd745 fixing typoes. 2004-10-14 05:34:12 +00:00
Dries Buytaert e769215e2d - Code improvement: removed some redundant code from the book module. 2004-10-10 11:11:38 +00:00
Dries Buytaert cca3c34faa - Patch #11401 by Goba: documentation updates:
+ Made error strings in blog.module consistent.
   + Explained a bit better what the RSD setting is for in the blog module.
   + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
2004-10-09 06:29:16 +00:00
Dries Buytaert af1eb3b9db - Reintroduced the book outline feature: non-book pages now have an outline-tab on their node page, given you have permission to maintain books. Using the outline-tab, nodes can be added to a book's hierarchy. Also added some context sensitive help and fixed some quotes. 2004-10-08 11:17:59 +00:00
Dries Buytaert 014bbd32ee - Fixed SQL query in book module. Patch by killes. 2004-09-29 14:15:44 +00:00
Dries Buytaert f4b076bc01 - Patch #10977 by killes: review node access checks in book module. 2004-09-29 05:42:37 +00:00
Steven Wittens 1298d2b9c9 Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea. 2004-09-28 19:13:03 +00:00
Dries Buytaert 309b411803 - Modified patch #10904 by JonathanS: fixed book teasers not being check_output'ed. 2004-09-24 05:48:21 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 7b716e8e77 - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).
2004-09-08 15:38:26 +00:00
Dries Buytaert e1d7609710 - Patch #6464 by TDobes: don't enforce book revision -- rely on the default setting. 2004-09-07 21:55:23 +00:00
Steven Wittens cdff29b0ab Book.module: <top-level> item didn't show up in parent selector. 2004-08-24 03:22:26 +00:00