784202418f
#50771 , Wrong user name in admin/comment, patach by Markus Petrux
2006-02-27 14:54:24 +00:00
66576708a0
- Patch #51347 by eafarris: fixed typo: coment -> comment.
2006-02-26 19:52:09 +00:00
3489651659
- Patch #46690 by Zen: 'user comments' -> 'comment settings'.
2006-02-26 19:47:55 +00:00
c94a2dabb0
- Patch #50755 by markus: = -> ==.
2006-02-22 19:02:58 +00:00
cb05945caf
- Patch #47699 by wtanaka: performance improvement.
2006-02-22 10:05:06 +00:00
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
7489c87476
- Patch #43572 by Tobias: don't accept spaces.
2006-02-14 19:17:00 +00:00
583d5a4ee9
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
2006-02-10 05:25:57 +00:00
1819de963f
- #48518 : Editing own comment broken under postgresl
2006-02-09 09:09:03 +00:00
c9a19e3084
- #48239 : Comment thread coding inefficient
2006-02-09 08:33:36 +00:00
91e152b8b8
- Patch #47705 by DriesK: comment moderation/approval wasn't working due to a bug with its forms.
2006-02-04 09:54:16 +00:00
baa2ecc81c
- Patch #47045 by Cvbge: fixed problem with deleting comments.
2006-02-01 14:04:50 +00:00
a6dac9d2ab
- Modified patch #46227 by chx: comment token is broken.
2006-01-31 15:26:39 +00:00
20154df528
- Modified patch #45723 by wtanaka: creating a comment, editing a comment, or anything that validates a comment fails on PHP5.
2006-01-26 08:48:57 +00:00
5d43619ca7
- Patch #40752 by moshe/wtanaka: login and regsiter links on each comment don't redirect back to the topic.
2006-01-26 08:27:58 +00:00
b8832d76a0
- Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module
2006-01-25 08:54:40 +00:00
b6b98bb60d
- Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics.
2006-01-22 07:26:33 +00:00
4da1540a9f
- Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment.
2006-01-20 09:33:03 +00:00
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
e84a98a22b
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
2006-01-19 08:54:41 +00:00
47dd0142e6
- Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing comments work.
2006-01-18 15:09:39 +00:00
cb45cf58fb
- Patch #40755 by wtanaka: make the comment block themable.
2006-01-17 18:02:23 +00:00
226a26a556
- Removed reference to comment moderation.
2006-01-10 19:41:15 +00:00
49e5e1cd47
- #43097 : restore admin/comment tablesort
2006-01-08 00:29:37 +00:00
030fd1798a
- Comment bug: anchor links should be specified using $fragment in url() and drupal_goto().
2006-01-06 01:14:17 +00:00
24899dba42
- Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default comment settings on node sumbission forms.
2006-01-05 14:35:55 +00:00
8d7ff5aea2
- Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering setting.
2006-01-05 10:53:47 +00:00
72ed68d48b
- Patch #42971 by markus_petrux: input format not correctly shown when editing a comment.
2006-01-03 23:04:23 +00:00
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
6164074655
- Patch #38999 by saerdna: There's no need that users with the "administer comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments.
2005-12-19 10:12:52 +00:00
21a9442bbb
- Patch #41081 by billturner: fixed problem with the comment settings form.
2005-12-15 16:31:01 +00:00
922a46d281
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
2005-12-15 16:24:40 +00:00
5accfa08f5
- Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
...
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00
764f1177ef
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
2005-12-14 20:10:45 +00:00
3ae534a64e
- Patch #28595 by Cvbge: fixed problems with bulk comment operations.
2005-12-08 09:11:32 +00:00
e019ce5107
- Patch #28595 by Jeremy: added support for bulk operations on comments.
2005-12-07 05:35:02 +00:00
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
80e02e6e73
- Patch #36434 by assimonds: fixed problem with editing signatures.
2005-12-03 19:39:15 +00:00
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
8784a7d13a
- Patch #39024 by Zen: comments that should be in the moderation queue get published.
2005-11-27 11:45:03 +00:00
c647b39c2c
- Patch #37798 by Neil: fixed problem with node settings.
2005-11-27 11:11:46 +00:00
247e012c35
- Patch #39013 by drumm: more logical naming of themeable functions
2005-11-27 11:07:02 +00:00
b1b1e2045f
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
2005-11-25 10:11:59 +00:00
bd2d91807e
- Patch #38575 by Neil: fixed infinite loop in comment.module.
2005-11-23 08:23:45 +00:00
62e5c58777
- Patch #38491 by Neil: refactor comment viewing controls to _execute model.
2005-11-22 15:48:46 +00:00
9f8fcab8db
- Patch #35726 by asimmonds: post_process -> build_after
2005-11-22 15:13:15 +00:00
28f973a986
- Patch #35726 by asimmonds/chx: converted the comment module to the forms API's _execute model.
2005-11-21 08:32:31 +00:00
e900d28640
- Patch #34295 by assimonds: added missing defines to comment.module. Improves
...
readability of the code.
2005-11-15 07:29:47 +00:00
d5d0149abe
- Patch #34295 by DrupalJapan and chx:
...
+ Fixed problem with configuration of comment display options.
+ Introduced defines for the various comment settings.
2005-11-13 09:05:38 +00:00
21bed11e66
- Add missing url()s around form actions (these would break without clean URLs)
2005-11-13 02:32:18 +00:00
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
3d13a38502
- Patch #36727 by Goba: fixed incorrect use of drupal_goto().
2005-11-08 20:57:41 +00:00
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
3fad92fc59
- #34645 : Make $links in theme_comment consistent with theme_node (Stefan)
2005-10-20 09:27:36 +00:00
e83b00d526
- Typo
2005-10-20 08:56:34 +00:00
8164ec2f49
- Code style
2005-10-20 08:53:59 +00:00
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
7863be5e82
- Patch #33433 by chx: fixed a number of form API problems.
...
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
2005-10-08 12:21:47 +00:00
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
0200ccf4da
- Patch by chx: fixed validation check.
2005-10-01 08:43:51 +00:00
1d94bb4a87
- Add some extra options.
2005-09-29 08:04:51 +00:00
45f4bcaa7d
- Patch #26031 by leafish_dylan: fixed comment pager (broken SQL query).
2005-09-27 18:34:59 +00:00
dff2df4809
- Patch #28786 by Neil: moved pagers out of table.
2005-09-27 18:10:19 +00:00
67e68fc679
- Patch #28786 by Neil: move pagers out of table.
2005-09-24 07:53:26 +00:00
2b3126b2cc
Patch #19934 by Morbus, chx: conf_init() should strip out port numbers in bootstrap.inc.
2005-09-19 19:13:35 +00:00
06af3e60e5
- Patch #29866 by Florian, Uwe: made the recent comments block only show comments on public nodes.
2005-09-19 15:11:05 +00:00
dec4ddd3a5
- Patch #28420 by Jeremy: provide a more generic interface that can be used
...
to validate other form submissions, not just comments. Two new functions
are introduced, form_token() and form_validate(). The first function uses
a private key and a public key to set a token in a hidden field. The second
function validates the token. The comment and contect module are updated to
use these functions.
2005-09-18 12:04:10 +00:00
1dc53d9761
- Patch #3986 by James (and Boris :)):consolidated all feed-related settings in one place.
...
* adds a "feed settings" section to admin/settings where 2 new settings are introduced:
* number of items per feed
* default length of feed descriptions (title only, teaser, full)
* patches all of core to obey the above - including the new aggregator (out) feeds
* adds support for adding namespaces in _nodeapi('rss item') - which means things like iTunes RSS and yahoo's media rss can be implemented by the appropriate modules (i.e. audio.module)
* includes some additional info in the default node feed - specifically the element (links directly to comments) - and dc:creator - to show node author information.
2005-09-18 10:37:57 +00:00
57a734a989
- Patch #16140 by Gerhard: cure array_merge() warning due to invalide menu callback.
2005-09-07 20:45:53 +00:00
d9d6a6e05c
- Patch #7582 by Gerhard: improved node revisions!
...
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node. This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.
TODO:
1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions. Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
494e5ab97c
- Renamed 'user comments' to 'comment options' for consistency.'
2005-08-28 15:16:58 +00:00
7b8a409675
- Patch #29385 by chx: no ?> add end of files.
2005-08-25 21:14:17 +00:00
29d6660149
- Patch #23620 by Robin: don't hard code forms into comment.module. Will be
...
depricated by form API patch though. Hopefully helps migration.
2005-08-17 20:07:35 +00:00
7625a4e91a
- Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
...
Usernames can now be themed; eg. an icon/avatar could be added.
TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
e4096e1418
- #27551 : Rename check_output() to check_markup(). Needs contrib updates!
2005-07-29 21:06:33 +00:00
aa2de74fa2
- #27624 , #27614 , #27627 : dead code
2005-07-29 08:18:20 +00:00
bd055961cd
- #25285 : Use correct permission for node form comment admin
2005-07-25 09:41:29 +00:00
50dac6f671
- Fixed typo reported by Stefan: theem -> theme
2005-07-20 15:13:12 +00:00
13954f90dd
- Modified patch #18656 by Moshe: unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. Also gave administrators the ability to change the author and timestamp of a comment. Also removed comment links from the bottom of the comment preview box (as we did for nodes)
...
Modifications: fixed breadcrumbs, tidied up delete confirmation page to be consistent with node deletions..
2005-07-19 17:51:59 +00:00
160a1e0ef8
- Patch #25634 by chx: simplified node_load().
2005-07-17 18:29:32 +00:00
02460ed9d8
- Removed tab.
2005-07-05 19:31:36 +00:00
2c10ff4b5f
- Fixed problems with filter formats and problem with XML-RPC server.
2005-06-29 19:53:14 +00:00
58aee8cdad
- Patch #25603 by Stefan: made the sizes of forms consistent.
...
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
e550f84162
- Patch #16204 by Thox: committed the collapsible form elements patch.
...
NOTE: this patch works well, but the improved node edit form still has
some rough edges. It is important that we continue to improve
usability. Give it a try.
2005-06-21 09:45:45 +00:00
21274fbb94
- #23285 : Allow theming of comment previews, like node previews.
2005-05-22 21:14:59 +00:00
e5ecab0797
- Patch #22804 by Cvbge: fixed typo in documentation.
2005-05-14 17:23:18 +00:00
381853c6b9
- Patch #21221 by Robert: make status values in comment.module defined constants for readability.
2005-05-05 20:12:49 +00:00
a76a1e1f3f
- Patch 20910 by chx: centralize print theme page.
2005-04-24 16:34:36 +00:00
8f1e9cd720
- Modified patch #18215 by ankur: make sure the comment statistics update after approval in the moderation queue.
2005-04-08 13:34:10 +00:00
a21f084160
- Patch by Drumm: change the wording for clarity.
2005-04-08 13:06:37 +00:00
961cf7af44
- By default, do not show comment controls.
2005-04-07 05:24:08 +00:00
29f6541c5e
- Patch #20103 by Neil: Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway.
2005-04-07 05:21:30 +00:00
a3e9b35afc
- Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook.
2005-04-01 15:55:02 +00:00
be14203534
- #18817 : Clean up plain-text checking (see drupal-devel!)
2005-03-31 09:25:33 +00:00
5ad5f28cda
- Patch #19009 by chx: fixed a bug with comment replies letting one access nodes.
2005-03-20 19:42:14 +00:00
c3f1f7345e
- #18939 (Stefan): Always use paragraph tags around page help text.
2005-03-18 07:07:04 +00:00
332a56334d
- Patch #17161 by Morbus: increase 40-character limit in URL field for comments.
2005-03-16 22:14:15 +00:00
3b5589f436
- Patch #14109 by wulff/Morbus: added missing t() funciton
2005-03-16 19:31:47 +00:00
a16e5d2492
- Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned).
2005-03-12 08:52:29 +00:00
2ec787df34
- Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this. I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module.
2005-03-10 18:28:21 +00:00
Gerhard Killesreiter
Dries Buytaert
Steven Wittens