Commit Graph

3205 Commits (a0c8a442283ee1690113b07eb4044f82f51668ab)

Author SHA1 Message Date
Dries Buytaert a0c8a44228 - Patch #45076 by m3avrck: fix bad markup and title for some watchdog warnings. 2006-01-26 08:42:18 +00:00
Dries Buytaert 7946eca135 - Patch #35926 by asimmonds: make required vocabularies actually required. 2006-01-26 08:33:20 +00:00
Dries Buytaert 5d43619ca7 - Patch #40752 by moshe/wtanaka: login and regsiter links on each comment don't redirect back to the topic. 2006-01-26 08:27:58 +00:00
Steven Wittens 548e5d2b5f - #45742: XHTML slash fix. 2006-01-25 22:29:57 +00:00
Dries Buytaert f4f77fc851 - Patch #45742 by chx: fixed problem with closed tags being filtered out. 2006-01-25 19:20:28 +00:00
Dries Buytaert b8832d76a0 - Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module 2006-01-25 08:54:40 +00:00
Dries Buytaert 53a2ca41b4 - Patch #23538 by Zen: mark required fields are being required. The new forms API will enforce this too. :) 2006-01-25 08:52:47 +00:00
Dries Buytaert d20ed7e3be - Patch #45665 by wtanaka/moshe: removed dead code! w00t! 2006-01-24 18:32:20 +00:00
Dries Buytaert 42c5683d41 - Patch #45845 by jaza/chx: set default value of weight-selectors to 0 for consistency with Drupal 4.6. 2006-01-24 18:27:29 +00:00
Dries Buytaert 6f978a04f9 - Patch #45793 by chx: fixed bug in user.module that results in storing plain text passwords. 2006-01-24 10:15:03 +00:00
Dries Buytaert 2fa3490ebf - Patch #46106 by markus: usability improvement: moved the block description textfield up. 2006-01-24 08:38:29 +00:00
Dries Buytaert 576399c1f4 - Modified patch #37754 by Thomas: made the status message show up. 2006-01-24 08:26:21 +00:00
Dries Buytaert 3c6066cffa - Patch #45706 by markus: keep up with CSS improvements. 2006-01-24 08:22:12 +00:00
Dries Buytaert af43886456 - Patch #33861 by Morbus et al: clean up the watchdog view. 2006-01-24 08:18:26 +00:00
Dries Buytaert bc9cbefa30 - Patch #45729 by markus, jvandyk, moshe: fixed problem with permission checking. 2006-01-23 08:06:43 +00:00
Dries Buytaert 1766d40093 - Patch #44828 by chx/Crell: make sure the url/path is properly initialized in statistics_exit(). 2006-01-23 07:54:08 +00:00
Dries Buytaert 14ae238973 - Patch #45320 by Zen: improved usability of off-line mode. 2006-01-22 07:51:06 +00:00
Dries Buytaert 30acded344 - Patch #45697 by fgm: removed some useless global. 2006-01-22 07:43:19 +00:00
Dries Buytaert 542e6e0d22 - Patch #33102 by Kobus et al: show dates properly. 2006-01-22 07:37:17 +00:00
Dries Buytaert 4267ab5ea9 - Patch #45706 by markus: keeping up with CSS improvements. 2006-01-22 07:32:55 +00:00
Dries Buytaert b9240f63d7 - Patch #45684 by wtanaka: added missing ''s 2006-01-22 07:31:38 +00:00
Dries Buytaert b6b98bb60d - Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics. 2006-01-22 07:26:33 +00:00
Dries Buytaert 25f13a64c4 - Patch #45843 by markus: roles are no longer required. 2006-01-22 07:23:58 +00:00
Dries Buytaert 4da4f4c1af - Patch #44379 by Moshe: code improvements: always grant the 'authenticated user' role to authenticated users. Fixed glitch with udpate path. 2006-01-21 08:28:55 +00:00
Steven Wittens 7914ad0f3f - #40515: Ensure UTF-8 character set on the database side (and include upgrade path for incorrectly set up databases) 2006-01-21 01:42:52 +00:00
Dries Buytaert 0ff0c4beaa - Patch #42137 by Richard: deleting non existent user blocks the whole drupal site. 2006-01-20 09:37:00 +00:00
Dries Buytaert 4da1540a9f - Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment. 2006-01-20 09:33:03 +00:00
Dries Buytaert 9c4d4fe7b2 - Patch #45228 and patch #45025 by m3avrck and Uwe: aggregator module HTML/CSS cleanups. 2006-01-20 09:09:18 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert 4a7abb95b6 - Patch #45312 by Robin and Zen: made theme_user_list() more like theme_item_list(), made it robust for empty lists. 2006-01-20 08:58:09 +00:00
Dries Buytaert 10d7f7731b - Patch #45281 by chx: made categories with forum topics work again. 2006-01-19 17:55:54 +00:00
Dries Buytaert 4c1522e962 - Patch #45336 by Ber: bugfix: removed obsolete check_plain() check causing & problems. 2006-01-19 09:26:15 +00:00
Dries Buytaert f828c0ade2 - Patch #39430 by Jaza and Richard: code improvements: improved separation between UI and logic. 2006-01-19 08:58:00 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Steven Wittens ecd26ac8ae - #42277: Make node search indexing more robust against bad nodes and timeouts. 2006-01-18 21:31:40 +00:00
Dries Buytaert 52507806eb - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. 2006-01-18 19:29:17 +00:00
Dries Buytaert 2220c03633 - Patch #45206 by markus: attempt at making the node filters somewhat translatable. 2006-01-18 19:09:46 +00:00
Dries Buytaert 47dd0142e6 - Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing comments work. 2006-01-18 15:09:39 +00:00
Dries Buytaert 46913a7efd - Patch #45259 by chx/drumm: cast to object required. 2006-01-18 14:30:42 +00:00
Dries Buytaert 186ebd18da - Patch #42072 by m3avrck: more improvements to the node revesion overview screen. 2006-01-17 21:19:43 +00:00
Dries Buytaert baaf319c59 - Patch #42072 by m3avrck: improved the revision overview screen. 2006-01-17 19:26:49 +00:00
Dries Buytaert df631e3c7f - Patch #45041 by markus: rand() -> mt_rand() + removed deprecated comments. 2006-01-17 18:32:33 +00:00
Dries Buytaert cb45cf58fb - Patch #40755 by wtanaka: make the comment block themable. 2006-01-17 18:02:23 +00:00
Dries Buytaert 51d2ac2b9e - Critical feature #40670: made the form array accessible. 2006-01-17 17:42:29 +00:00
Dries Buytaert e145866243 - Patch #44136 by riccardoR: can't enable more than one language. 2006-01-17 17:35:47 +00:00
Dries Buytaert a50eb34bda - Patch #44381 by gerhard: improved consistency of API. Always pass an array. 2006-01-17 09:23:38 +00:00
Dries Buytaert 8b5175a983 - Patch #44754 by Zen: fixed "Who's new" block inaccuracy. 2006-01-17 09:04:20 +00:00
Dries Buytaert ae84e469b0 - Patch #39329 by markus: order sources in aggregator. 2006-01-15 17:03:34 +00:00
Dries Buytaert f649b42d9c - Patch #44767 by jvandyk: small (code) improvements 2006-01-15 16:57:56 +00:00
Steven Wittens 2e9bbda791 - #44772: {} -> [] (in anticipation of PHP de-deprecation) 2006-01-15 07:14:14 +00:00