Commit Graph

156 Commits (9979aceab035616297b1ba95ec33c9905a4fed2b)

Author SHA1 Message Date
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert 52d9dd1b01 - Patch #11977 by matteo: taxonomy_term_count() did not take node-level permissions into account and could return an incorrect number. 2004-11-15 10:00:50 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Steven Wittens 11b0b805fa #12186: Add xml icon to taxonomy listings. 2004-10-28 23:46:10 +00:00
Dries Buytaert 1362571d09 - Patch #11510 by Adrian: turned a non-ANSI SQL query into ANSI SQL so it works with PostgreSQL. 2004-10-18 17:46:19 +00:00
Dries Buytaert dfb3c3aec4 - Patch #11577 by drumm: changed t('ago') -> t('%time ago', ...) to make it
translatable in languages such as Spanish.
2004-10-15 05:10:35 +00:00
Steven Wittens 9e4399aae8 #10677: Confirmation when deleting a block + unifying confirmation screens. 2004-10-14 15:28:24 +00:00
Dries Buytaert 551782a5b2 - Modified patch #10424 by Jeremy: deleting terms can orphan child terms in the database.
I rewrote this patch for simplicity.
2004-10-13 18:38:33 +00:00
Dries Buytaert 57def735f4 - Patch #11166 by drumm: removed redundant help page from the taxonomy module. 2004-10-04 18:32:05 +00:00
Dries Buytaert 327a256a2e - Removed the title attribute from the taxonomy links. Temporary fix for #7468. 2004-09-30 19:12:44 +00:00
Steven Wittens 0ca171f2a9 - Adding menu callbacks to taxonomy admin. Before this patch, some admin pages only showed tabs and the wrong title. 2004-09-19 12:47:00 +00:00
Dries Buytaert 4e3a3aaed0 - Bugfix: using non numeric terms in taxonomy-page URLs would result in SQL errors. 2004-09-19 08:41:50 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Steven Wittens 5595bc79c6 #10279: Adding a note to taxonomy_render_nodes when there are no nodes to show, rather than showing an empty page. 2004-09-14 22:55:40 +00:00
Kjartan Mannes c054ce2c3f - Fixing taxonomy descriptions in node_view links. 2004-09-11 13:19:03 +00:00
Dries Buytaert 7b716e8e77 - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).
2004-09-08 15:38:26 +00:00
Steven Wittens 738dd5f353 #9292: Minor PHP5 fix. 2004-09-03 01:48:06 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert a36304af0d - Patch #8176 by JonBob: fixed braino in SQL query. 2004-08-12 22:16:01 +00:00
Steven Wittens 09fc61c065 - #9148 and #8766: Fix problem with using '%' in term names. 2004-08-10 14:50:53 +00:00
Dries Buytaert 290c3fbc38 - Patch #9875 by njivy: call to taxonomy_overview() is missing in admin view. 2004-08-09 05:14:03 +00:00
Dries Buytaert bdbc34c93b - Patch #6760 by JonBob: refactored the taxonomy module URLs to be nicer, improved the code/Doxygen comments.
As discussed before, the path "taxonomy/page/or/1,2" becomes "taxonomy/term/1+2" and the path "taxonomy/page/and/1,2" becomes "taxonomy/term/1,2". The most common case of listing nodes attached to a single term becomes simpler, since it doesn't require a meaningless "or" or "and". A depth of "0" is assumed, but a positive integer or "all" can be used. Feeds are available at "taxonomy/term/1+2/all/feed" and the like.

  This iteration of the patch also changes the structure of taxonomy_select_nodes(), since it was not following Drupal conventions. A handful of contrib modules call this function, and will need to be updated. Instead of passing in a $taxonomy object containing parameters for the function, the parameters are passed independently. This simplifies the code quite a bit. The queries were changed to only return node IDs for speed; all results from this function are passed through node_load() anyway, so the extra information returned was discarded. The AND query was also changed to avoid the strange trick and remove an extra query, at the expense of a table join per root term in the AND. This cleans up the code substantially while at the same time enabling the use of AND with a depth parameter.

  TODO: update contribution modules.
2004-08-07 19:45:54 +00:00
Dries Buytaert 6f024382e5 - Made the taxonomy module use drupal_goto() to fix up the interaction behavior. 2004-08-07 19:28:25 +00:00
Dries Buytaert 202eee42a9 - Patch #9543 by JonBob: added node-level access control! 2004-07-31 09:30:09 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert 898bdeffaf - Marked required fields on the node (story, book, page, blog) and comment
forms using the $required argument of the form_ functions.

- Replaced all Optional's and Required's from the taxonomy forms with proper
  use of the form_ functions.

Please check your contributed modules too!
2004-07-08 15:24:30 +00:00
Dries Buytaert 3568ed57e1 - Moving the title.module from core to contrib as discussed on the mailing list. 2004-07-07 20:18:22 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00
Dries Buytaert 9986cb36b5 - Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site). 2004-07-02 18:46:42 +00:00
Dries Buytaert 9f4a335887 - Taxonomy fix by Matt. 2004-06-23 20:52:46 +00:00
Dries Buytaert ad3c6f345e - Patch #8681 by asimmonds: more help text updates 2004-06-21 08:26:20 +00:00
Dries Buytaert 4b449a7e5d - Patch #8670 by asimmonds: spelling fixes. 2004-06-20 19:43:28 +00:00
Dries Buytaert cbc230a36c - Patch #7696 by TDobes: renamed 'static' to 'sticky' which is a more
logical name.  Requires a database upgrade.
2004-06-19 10:39:36 +00:00
Dries Buytaert c3a6f3dc54 - Patch #8632 by Mohse: made the taxonomy select menus more flexible.
Specifically, it lets you edit more than one node's taxonomy within
  the same form.

  This patch also removes the behavior where taxonomy remembers your
  last choice for a given vocab and automatically selects it for you.
  That is poor behavior.  If someone changes a date or author in a
  node, he is likely to inadvertently add taxo terms using with this
  'feature'.
2004-06-19 09:57:13 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert 3a8c1d6780 - Patch #8548 by Moshe: fixed warning when creating new vocabulary. 2004-06-17 18:10:05 +00:00
Dries Buytaert 5ba08f61c2 - Patch #8418 by Axel: don't insert tid=0's in the database 2004-06-15 18:41:25 +00:00
Dries Buytaert 7a33d9f6fd - Patch #7350 by Mathias: return part a taxonomy tree to a user-defined
depth/level.

- Updated CHANGELOG.txt.
2004-05-31 19:14:43 +00:00
Dries Buytaert fed7e664de - Patch #6682 by jhriggs: added form_checkboxes(), much like form_radios()
and updated some modules to take advantage of it.
2004-05-15 15:42:47 +00:00
Steven Wittens 33651a4edf #7468 - Added title="" attribute with term descriptions (if present) to taxonomy links.
See http://drupal.org/node/view/7468
2004-05-04 01:44:30 +00:00
Dries Buytaert 5403982589 - Patch #6009 by Matthias: reworked the help texts of the taxonomy module generated forms. The help text can now be customized. 2004-04-24 16:42:39 +00:00
Dries Buytaert e5e26a07d6 - Patch #7302 by Gerhard: saves the selected terms in a session variable. 2004-04-23 07:40:26 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 67fb5235c7 - Renamed 'taxonomy' menu to 'categories' for sake of usability. 2004-04-18 14:03:33 +00:00
Dries Buytaert 10bdb51c37 - Patch by JonBob/Jonathan: reworked the menu system so that menus are
configurable!  Menu items can be disabled, repositioned, added and
  so on.

  Upgrading to requires you to run update.php.

  This functionality depricates some of the 'navigation modules' in the
  contributions repository.  Furthermore, modules can now 'suggest'
  menu items and site adminstrators can choose to enable them.  Modules
  in the contributions repository should try to take advantage of this.
2004-04-15 20:49:42 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 10917b1213 - Patch #6470 by Brian: fixed XHTML error with multiple selection boxes. 2004-03-14 20:07:00 +00:00