Commit Graph

91 Commits (97858f9b2ebf7f32f00ab7688dc2eb6b3371207b)

Author SHA1 Message Date
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert 2b5dfdafa5 Bugfix: when we have to extract a comment's title from the comment's body,
first strip the body's HTML tags or we might get an empty title after all.
2003-01-02 18:34:13 +00:00
Dries Buytaert de95001c92 - Tidied up the use of check_output(). Might make rendering pages a bit
snappier (performance improvement).
2002-12-31 12:34:07 +00:00
Dries Buytaert 1011e87411 CHANGES:
- Usability improvement: made the comment administration pages use the
  new table rendering functions.

- Usability improvement: new comments will also be marked as new in the
  administration pages.

- Code improvement: changed the comment administration pages to use the
  default pager instead of a custom pager.

- Bugfix: "yes" and "no" were not translatable.

- $ diffstat comment.patch
  comment.module |   45 +++++++--------------------------------------
  1 files changed, 7 insertions, 38 deletions

TODO:

- Comment module: remove other custom pagers in the comment module.

- Pager/database: it would be nice if the functions db_query_range()
  and pager_query() would have the same semantic as db_query(); that
  is, using a variable number of arguments that are automatically
  escaped/checked.
2002-12-29 12:44:33 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert d2927a9064 - Small usability change. 2002-12-10 20:36:03 +00:00
Dries Buytaert eceead1819 - Removed the "comment anchors" in the themes; the anchor is emitted
by the comment module.  Patch by Ax.
2002-12-10 20:14:10 +00:00
Dries Buytaert a10cd273d3 - Avoid empty fields to be displayed. Patch by Moshe. 2002-12-08 08:04:58 +00:00
Dries Buytaert 5b39f6767e * Applied slightly modified version of Marco's taxonomy patch:
- Fixed a bug with get_tree and multiple parents.
 - Fixed 3 wrong caches (this will avoid some queries).
 - Extension to taxonomy_term_count_nodes() (feature #159): "currently
   calling taxonomy_term_count_nodes() returns the amount of nodes in each
   term, would it be possible to extend this function so that it would only
   return the amount of nodes of a certain type under each term.
 - Confirm deleting a vocabulary or a term (requested by Moshe).
 - Use form_weight() in vocabulary and term forms.
 - After submitting a term, we end up at the term page (requested by Moshe).
 - Added status messages when adding, editing and deleting vocabularies and
   terms
 - Minor clean ups

* Made sure all modules use the same link delimiter; "|" for now.
2002-12-02 19:14:41 +00:00
Dries Buytaert 0afe52df9b - Updated the query to put $score in the parameter list. 2002-11-20 21:01:45 +00:00
Dries Buytaert d259cc1973 - Commited Moshe's comment moderation improvements. 2002-11-20 20:59:54 +00:00
Dries Buytaert 9e32c2e960 Patch based on work of Kjartan:
- Changed cache API.

- Fixed caching bug in comment.module.  Odd this hasn't been reported yet.

- Fixed caching bug in forum.module.

- Fixed caching bug in system.module.

- Fixed caching bug in block.module.

- Simplified caching support in forum.module thanks to improved cache API.
2002-11-17 06:42:52 +00:00
Dries Buytaert cc381c1461 - Fixed glitch in block module: the admin links were not composed
correctly.  Patch by Stefan.

- Added missing t() functions and improved the %x directives for
  better readability and to ease the process of translating your
  site.  Patches by Stefan.

- Made two small additions to the 'code-clean.sh' script; it will
  now remove patch related junk.

NOTES:

- I removed the · related bits.  Let's tackle these later on
  in a separate patch after we got some sort of consensus.

- I removed the 'module_exist("drupal")' check in the user module;
  I *think* it is incomplete and therefore incorrect.

- Stefan, try using quotes in your translations and check whether
  everything still works.  Example: translate the "Create account"
  button to "Create \"haha\" account \'hihi\'" and see if you can
  still create new accounts.  Maybe automate this using a quick
  hack in the locale module ...
2002-11-01 10:47:20 +00:00
Kjartan Mannes 2afb09563d - dont print empty row if there are no next or prev links to show in admin_overview. 2002-10-24 14:29:00 +00:00
Dries Buytaert 88d6ef3a2a - Added missing t() function. Patch by Marco. 2002-10-22 18:39:56 +00:00
Dries Buytaert 30315c40c0 - Applied Moshe's comment module patch to address some of the usability
issues.
2002-10-13 09:18:58 +00:00
Dries Buytaert fec23c52f0 - Applied Moshe's comment.module patch. 2002-09-17 17:55:05 +00:00
Dries Buytaert 92326261d1 - Commited Marco's new comment module and forum module!!! 2002-09-15 13:00:12 +00:00
Kjartan Mannes a6121c1503 - fixing some incorrect l*() calls.
- fixing node_feed() to work with tax feeds. Thanks Moshe.
2002-06-15 13:48:08 +00:00
Kjartan Mannes 66ccfb3f8d - fixed the markup of the collapsed comment view settings.
- updated update.php and database.mysql disable a few more modules by default.
  Without the config options in place to disable things this might confuse users.
2002-06-15 10:49:44 +00:00
Dries Buytaert ca9fc85e4b - Bugfix: the comment module has a help function but it wasn't linked to. 2002-06-09 13:52:08 +00:00
Kjartan Mannes 5d36c70449 - improved module descriptions.
- removed admin options for queue and comment module if the modules are not
  loaded.
- nodes are now auto promoted when queue module isn't enabled.
- moderation result block is now visible by the node author.
2002-06-08 16:17:29 +00:00
Dries Buytaert 37ee9eed2e - Bugfix: we now keep a per-node $date cache in comment_is_new(). Suggested
by Natrak.
2002-06-08 14:30:05 +00:00
Kjartan Mannes 4a28077f46 - adding descriptions to modules (thanks Joe + Scott).
- fixed comment flat list view missing 1 comment.
- changed update.php around a bit.
    * security check isn't in effect if the db hasn't been updated.
    * instructions re-organized.
    * fixed some minor updates.
- updated database.mysql done by UnConeD.
- changelog update.
2002-06-01 21:57:29 +00:00
Dries Buytaert 38aaf5f35d - Added missing translations and the like. 2002-05-31 20:29:30 +00:00
Dries Buytaert 8bba059a8e - Fixed a drupal_goto() as identified by Marco. 2002-05-29 17:32:09 +00:00
Kjartan Mannes 000ee5d162 - cleaning up the access checks in node.module.
- reverting a taxonomy patch that added $context checking to node/comments.
2002-05-29 17:16:27 +00:00
Kjartan Mannes 837087ea99 - the comment control panel is now only shown when there are comments. 2002-05-20 21:55:22 +00:00
Kjartan Mannes c1f617a3ab - fixing bug #181. 2002-05-16 09:32:01 +00:00
Kjartan Mannes f86a944979 - applied Stevens link patch.
- fixed block permissions.
- fixed user admin page errors: http://www.drupal.org/node.php?id=173.
- cleaned up common.inc a bit: removed format_info, path_img, field_merge.
2002-05-12 15:40:57 +00:00
Dries Buytaert 8c69c3a912 - Improved viewing of individual comments. 2002-05-05 19:02:02 +00:00
Kjartan Mannes 72f33dde32 - fixed comment control settings:
http://www.drupal.org/node.php?id=115
2002-05-03 12:56:57 +00:00
Steven Wittens 75d4c15f07 Cosmetic bugfix:
Level 0 comments were still wrapped with a zero-width indentation table. Because the indentation-column contains a space, there was still a slight margin.
2002-04-25 20:59:50 +00:00
Kjartan Mannes de5b9a168d - bug fixes:
* fixed mails not being parsed properly.
    * tracker now shows user name when you view your own recent
      comments.
    * link to submission queue now points to the right place.
    * fixed jabber module.
    * theme is now activated when changed.
- applied Gerhards coding style patch.
2002-04-22 09:05:36 +00:00
Dries Buytaert 8043cb998f - Applied Marco's big patch, including contributions from Moshe:
+ Changed the db_query() API.

    + Wrapped all links in l(), lm(), la(), ..., drupal_url() functions.

    + XHTML-ified some HTML.

    + Wrapped a lot of text in the administrative pages in a t()
      function.

    + Replaced all $REQUEST_URI/$PATH_INFOs by request_uri().

    + Small bugfixes (eg. bug in book_export_html() and clean-ups (eg.
      RSS code).

    + Fixed some bugs in the taxonomy module (eg. tree making bug), added
      new functionality (eg. new APIs for use by other modules), included
      Moshe's taxonomy extensions, and some documentation udpates.

    + ...
2002-04-20 11:52:50 +00:00
Dries Buytaert d8cd54969c - Added Marco's long-awaited taxonmy module and patches - a replacement
for the meta system.  The patches add some extra functionality to the
  comment system (for example, comments can be set read-only) and fix a
  couple of small problems.

  + I integrated the required SQL updates from the varius *.mysql files
    into the "update.php" script.  Upgrading should be easy ...

  + I did not apply/commit the "user.diff" as requested by Marco ...

  + I didn't know what to do with "forum.module" and "forum2.module":
    what do you want me to do with it Marco?  Which one should go in?

  + Can we remove "node_index()" now; both from "node.module" and the
    themes?

  + Thanks Marco!
2002-04-14 20:46:41 +00:00
Kjartan Mannes 7dfd5f0b7e - my editor got set up to insert tabs instead of spaces. Cleaning up. 2002-04-05 18:11:42 +00:00
Kjartan Mannes e3d2c46f04 - applied search patch.
- added who is online block.
- made weblog module more configurable.
- users may now delete their own accounts (Feature #8)
- users may now request a password using email address *or* username.
  formerly required both items to match an account which was onerous.
- the link to request a new password is now presented whenever a user
  fails login.
- there is now a confirmation message after submitting edits to your
  user information.
- error messages in user.module may now be stylized by themes.
- <hook>_form has a $param setting you can fill with form parameters.
- improved wording for a few config settings.
- fixed various non-coding standard things.
2002-03-05 20:15:17 +00:00
Dries Buytaert 460f0e54df - Added documentation contributed by Moshe. 2002-02-22 19:44:22 +00:00
Kjartan Mannes 8c70eae2e4 - changing <? to <?php , reported by ax. 2002-02-16 13:38:00 +00:00
Dries Buytaert f9a508d5dd - Fixed more than 30 HTML and XML well-formedness errors. 2002-01-27 14:58:45 +00:00
Dries Buytaert c71e133958 - Added about 50 title tags. 2002-01-07 22:08:52 +00:00
Dries Buytaert f9abcda22f - Fixed bug with comment sorting (reported by weitzman).
- New comments are being marked with a small red star.
2002-01-03 22:02:23 +00:00
Dries Buytaert 52dfd806cc - Fixed a typo. 2002-01-01 22:20:41 +00:00
Dries Buytaert be3f89b06b - Fixed a typo: comments_all() -> comment_all() 2002-01-01 22:17:54 +00:00
Dries Buytaert d85e45bf64 - Added "x new comments" feature. Requires a SQL update.
- Tidied up some comment related code in node.module.
2001-12-31 13:02:53 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Dries Buytaert 9b69714c3f - Revised the comment links: when a user does not have the required
permissions to post comments, the "reply to this comment"-link is
  no longer shown.  Also, when a user is a "comment administrator",
  an "administer"-link will be displayed.

- Revised the threaded_min and threaded_max code: it makes rendering
  pages with more than 15 comments 200% times faster.
2001-12-27 20:35:40 +00:00
Dries Buytaert 9fa8e310d7 - Removed (the need for) the Comment-class: makes for cleaner code.
- Fixed the comment preview function: the preview shown was not being
  an exact preview of the comment.  Along the way, I polished the
  comment submission code.

- XMTML-ified the code, and quoted all "string"-based array indices.
2001-12-22 14:12:18 +00:00
Kjartan Mannes a4f431aeb4 - strip HTML tags from comment subjects. 2001-12-09 13:40:47 +00:00