Commit Graph

984 Commits (971a0e24aa6344da7ae07f476ed3fb371bd744d0)

Author SHA1 Message Date
Steven Wittens b228f0183a #11449: Adding a failsafe check for an improperly prefixed menu sequence. This is a temporary fix, awaiting a proper install system to end manual prefixing ;). 2004-10-16 19:42:52 +00:00
Steven Wittens ba2761929c #7289: locale import fixes 2004-10-16 01:00:23 +00:00
Steven Wittens ea17f39811 Tablesort used to output class=" active" for active columns with other properties (align="right"). Now it correctly uses class="foo active" if a class 'foo' was specified, and class="active" otherwise. 2004-10-15 22:16:00 +00:00
Dries Buytaert a5691cccc9 - Patch #11600 by jhriggs: the module_load_all() function will currently behave unexpectedly if a module cannot be found (has been removed, renamed, etc). Once one module fails to load, all subsequent modules will not be loaded due to a short circuit condition when performing a boolean AND. 2004-10-15 10:47:54 +00:00
Dries Buytaert 12eb20238c - Patch #11430 by JonBob: reseting the menus broke the admin pages. 2004-10-14 21:38:12 +00:00
Steven Wittens 583e63c136 Theme system bug: only show search box if search.module is enabled. 2004-10-14 02:38:33 +00:00
Steven Wittens b3451d0274 Adding a note about the usage of form_hidden inside form_checkbox and form_checkboxes. 2004-10-13 17:21:06 +00:00
Dries Buytaert 0261efc8fd - Patch #11531 by killes: it was not possible to deselect all choices of a form_checkboxes array. 2004-10-13 17:08:50 +00:00
Steven Wittens 986a476c45 Reverting the last #9292 (php 5 compatibility) patch, by request of killes. It broke stuff. 2004-10-12 23:33:38 +00:00
Dries Buytaert 306cfdf17a - Patch #9292 by Gerhard: fixed another array_merge + PHP5 woe. 2004-10-12 20:20:28 +00:00
Dries Buytaert 5f28d97a0f - Patch #11271 by Ber: fixed form_radios() to generate valid XHTML code. This makes the code generated by the poll module XHTML compliant.
- Similarly, I updated form_checkboxes() to generate valid XHTML code.
2004-10-12 19:55:53 +00:00
Dries Buytaert 467bc55972 - Patch #11434: made request_uri() (and thus forms) work on IIS. 2004-10-12 19:50:12 +00:00
Dries Buytaert c21e3634bb - Patch #11431 by Gerhard: made sure no empty strings are exported + replaced some double quotes by single quotes. 2004-10-11 19:57:42 +00:00
Dries Buytaert 905d530abd - Patch #11312 by killes: fixed problems with menu caching. 2004-10-06 12:18:03 +00:00
Dries Buytaert 570d203bb5 - Patch #11312 by Killes: rebuild the menu after importing a PO file. 2004-10-05 20:09:47 +00:00
Dries Buytaert 503c784557 - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache. 2004-10-04 22:04:07 +00:00
Dries Buytaert c78fff8e6a - Patch #10981 by Ber: removed custom links from configuration file. They are no longer used. 2004-09-21 18:39:01 +00:00
Dries Buytaert 6690793cbb - Patch #10472 by Gerhard and Steven: fixed bug when paging through the search results of the locale module. 2004-09-20 19:37:18 +00:00
Dries Buytaert 228b3c7cc8 - Patch #10945 by Adrian: more PostgreSQL fixes/updates. 2004-09-20 17:58:14 +00:00
Steven Wittens 85c0b42e8d #10859: Locale string duplication bug. 2004-09-19 00:08:50 +00:00
Dries Buytaert 1c7a8b161a - Patch #10419 by ccourtne: documentation improvements and rename prevention option. 2004-09-17 18:18:04 +00:00
Steven Wittens aded584102 Adding a note about drupal_eval() acting like a variable sandbox. 2004-09-16 16:12:21 +00:00
Dries Buytaert 770f4f8a59 - Patch #10859 by Gerhard: another attempt at fixing duplicate locale strings. 2004-09-16 14:18:00 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Steven Wittens f8b429e963 #10862: Smarter filter cache wiping. 2004-09-15 20:34:35 +00:00
Dries Buytaert d00f4a4ebf - Patch #10859 by killes: importing more than one po file could cause your database to contain more than one version of the source or the target string. 2004-09-15 15:44:56 +00:00
Dries Buytaert 3079ffeafe - Made it possible for the i18n module to hook in. 2004-09-15 09:54:32 +00:00
Steven Wittens 9c9905d9a0 #10648: Fix watchdog-related tablesort coloring bug in IE, add support for <tr> attributes to theme_table() and reduce specificy of watchdog coloring CSS rules. 2004-09-14 20:01:00 +00:00
Steven Wittens 793486909f #10803: file_save_data() does not pass $replace along. 2004-09-13 23:30:58 +00:00
Steven Wittens b75c1e1c8b Replace hardcoded <html lang="en"> with a locale dependant one. This is especially important for asian sites where this has an effect on font selection. 2004-09-09 13:36:01 +00:00
Steven Wittens 884c05a64f Changing the chinese POSIX language tags to RFC 1766 (underscore to hyphen). 2004-09-09 11:53:56 +00:00
Dries Buytaert b84b6e42cf - Patch #10663 by JonBob: documentation improvements: fixed some typos and improved consistency to the use of Doxygen/api.module commands in the comments. 2004-09-09 05:51:08 +00:00
Dries Buytaert 694b577b62 - Moved some documentation around and fixed a missing translation. 2004-09-08 18:46:41 +00:00
Dries Buytaert d56ced2a06 - Patch #10373 by jabart/killed: performance improvement: caching the variable table improves performance with 20% when serving cached pages. 2004-09-08 18:06:04 +00:00
Dries Buytaert 80086a9e02 - Fixed cache problem introduced by Adrian's PostgreSQL patch. 2004-09-08 17:45:27 +00:00
Dries Buytaert 7b716e8e77 - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).
2004-09-08 15:38:26 +00:00
Dries Buytaert 27f055b5cd - Patch #10192 by JonBob: fixed issue with menus not expanding. 2004-09-07 21:48:49 +00:00
Steven Wittens d441752dba - #9983: UI consistency patch. 2004-08-27 23:26:20 +00:00
Steven Wittens 44f341bebc Patch by me and Kjartan.
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Steven Wittens 51cf18e531 - #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken. 2004-08-22 17:03:42 +00:00
Steven Wittens 98a9d5ee2d - #9576: Patch by TDobes, only allow the user to choose between enabled themes. 2004-08-22 14:43:49 +00:00
Steven Wittens 05714da2ec Locale:
- Fixing broken .po import (due to file.inc changes).
- Do not show error notice on import page when no languages have been added (no longer necessary due to ability to add-and-import in one step).
- Added a notice about importing possibly taking a while.
- Raised the PHP execution time limit for importing (if not in safe mode, similar to cron.php).
2004-08-21 21:13:29 +00:00
Dries Buytaert 47b72af612 - Patch #6809 by TDobes: fixed the textarea hook so WYSIWYG editors are made possible again.
TODO: apply the documentation and htmlarea module patches.
2004-08-21 17:06:51 +00:00
Dries Buytaert 7736eb4995 - Patch #10166 by jvandyk: bugfix: valid_url() believed that URLs with encoded spaces in them (eg. http://example.org/my%20file.html ) are not valid. 2004-08-21 17:02:48 +00:00
Dries Buytaert f311646b1e - Patch #10195 by JonBob: bugfix: common.inc used the function ob_get_clean() which is only available in PHP >= 4.3. 2004-08-21 16:44:05 +00:00
Dries Buytaert 6881cc9ad6 - Patch #10202 by Ax: don't emit an erroneous whitespace when no table headers are provided. Makes for clean XHTML. 2004-08-21 16:21:56 +00:00
Dries Buytaert 03fa966c1f - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes. 2004-08-21 10:16:13 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Steven Wittens 9f2d6f0e51 - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
2004-08-20 17:21:37 +00:00
Dries Buytaert 1c6159e366 - Usability improvement: capitalize all header titles. 2004-08-20 14:36:07 +00:00
Dries Buytaert 81861a8e91 - Removing some DOS-style line endings. Thanks TDobes. 2004-08-20 09:34:53 +00:00
Dries Buytaert 6ea5c56ded - Theme system changes. Please consult http://drupal.org/node/view/9576 for details. 2004-08-20 07:51:27 +00:00
Steven Wittens 9cb5f7cdf8 Avatar/picture fixes:
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958: Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
2004-08-20 04:35:33 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00
Dries Buytaert eeb2b17b7b - Bugfix: include the xmlrpc library. 2004-08-17 18:40:59 +00:00
Steven Wittens 621ec02ee7 Fixing a faulty check in cache_get() which prevented empty data from being returned. This was required for filtercache, where a cache entry with empty data can have meaning (e.g. as the output for the input '<script></script>' when script is not allowed). 2004-08-16 22:39:48 +00:00
Dries Buytaert d5e1e83e77 - Patch #9900 by Al: bugfix: don't display two <hr />'s. 2004-08-16 21:27:39 +00:00
Dries Buytaert 1b1bcc35ac - Patch #10026 by Al: bugfix: don't show the 'more help' links when the help module is disabled. 2004-08-16 21:25:54 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert dd7764302f - Patch #10111 by Killes: fixed some SQL queries. 2004-08-16 17:42:36 +00:00
Dries Buytaert 9a26352b9c - Patch #9864 by JonBob: better form validation in menu administration. 2004-08-15 16:42:59 +00:00
Dries Buytaert cea07ecac6 - Patch #6806 by UnConeD: prefixed form IDs with 'edit-' so they won't clash
with other IDs.  Also makes things a tad more consistent.
2004-08-12 21:56:48 +00:00
Dries Buytaert 0f088b79ca - Patch #9983 by Stefan: various code style improvements. 2004-08-12 18:00:11 +00:00
Dries Buytaert d651b9dc3b - Patch #7535 by Gerhard: one could not search for the word 'From'. 2004-08-12 05:46:37 +00:00
Dries Buytaert 1831e1b690 - New locale module thanks to Gerhard, Goba, Marco, Kristjan and others.
The new locale module provides every functionality on the web interface, so you don't need to edit the configuration files or add columns, when you add a new language. This module is an integration of the old locale and localegettext modules, plus a bunch of logic to parse Gettext Portable Object files (opposed to Machine Object files, as supported by localegettext).

  Note: I made some minor changes to the context-sensitive help texts and to some of the status messages.
2004-08-11 11:26:20 +00:00
Dries Buytaert d6d3af1b67 - Patch #9663 by jvandyk: the $i counter variable in tablesort_get_order() is unused and should therefore be removed. 2004-08-10 19:15:57 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert f99830a498 - Patch by Al: improved the admin/help pages (first step). 2004-08-10 05:44:17 +00:00
Steven Wittens 88221c2f67 #7646 and more:
- Users who have not edited their account yet would be reset to GMT rather than the sitewide timezone.
- Users who chose GMT (zero timezone) on a site with a non-zero timezone as default would have incorrect timezone.
2004-08-10 01:30:09 +00:00
Dries Buytaert 9e54dc27ff - Patch #7968 by Adrian: use the complete URL as the cache ID to make Drupal's
caching work on virtual hosts.
2004-08-06 20:38:48 +00:00
Dries Buytaert 9bad647d76 - Patch #9819 by JonBob: fixed XHTML bug - make sure the <div> is always closed. 2004-08-06 20:18:25 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Dries Buytaert a52cf8297a - Patch #7458 by killes: conditionally include xmlrpc.inc. 2004-08-04 20:36:24 +00:00
Dries Buytaert c0f6fccac3 - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes. 2004-08-03 18:01:48 +00:00
Dries Buytaert 9945bca528 - Patch #9650 by Adrian: this change introduces a module_load function, which maintains a list of modules that have already been loaded in a static array, and will not load another module of the same name, or if the file does not exist.
Modules can be stored anywhere, as there is now a set of functions called module_get_filename, and module_set_filename .. which allow system_listing and module_list to specify the locations of the files.

A new function module_load_all() replaces the hardcoded includes in module_init, and loads all modules which have been enabled, using module_load.

module_listing no longer includes files itself, instead it just keeps the listing (and sets the filenames).

This patch is a requirement for the multisite configuration patch, as overriding modules are currently being loaded due to the only protection of loading them is include_once.
2004-07-31 11:17:27 +00:00
Steven Wittens 6c73823b10 Fixing a rather nasty bug with page cache:
The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.

This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
*phew*
2004-07-29 01:41:33 +00:00
Steven Wittens ef6cbfda6f - Fixing broken tablesort due to typo with quotes. 2004-07-25 19:50:23 +00:00
Dries Buytaert 2af5dff6a2 - Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
db_next_id().
2004-07-25 18:16:49 +00:00
Dries Buytaert 702a057683 - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.

  This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
2004-07-25 14:25:42 +00:00
Steven Wittens edc2f13d82 - #9287: More doxygen/documentation fixes by JonBob 2004-07-22 16:06:54 +00:00
Steven Wittens b8d653f1e8 - Fixing bad strpos usage (have to use the ===/!== operators to check for 'false' in this case) 2004-07-21 15:30:35 +00:00
Dries Buytaert 7765fa1f7a - Patch #9290 by Morbus / JonBob / TDobes: SUBTASK removal patch for menu.inc. 2004-07-15 17:16:58 +00:00
Dries Buytaert f63c3be30c - Code and documentation improvements by JonBob. 2004-07-14 20:42:20 +00:00
Dries Buytaert 63a327db97 - Patch #9287 by JonBob: made the code style in the three database include files consistent with Drupal standards, and adds a wealth of Doxygen-style comments to aid developers in writing solid database access code using the API. 2004-07-14 19:15:25 +00:00
Dries Buytaert ce8e264382 - Patch #9262 by Ber / JonBob: the menu did not build correctly, thus the additional menu's were never displayed, but were saved. Only the last custom menu was displayed. 2004-07-14 05:46:12 +00:00
Dries Buytaert 50d78e9855 - Patch #9238 by JonBob: added code and Doxygen comments to common.inc and
bootstrap.inc.
2004-07-13 07:21:14 +00:00
Steven Wittens a080ce5f0f Slightly improved code in drupal_xml_parser_create. 2004-07-12 21:38:41 +00:00
Steven Wittens 77c0b577da Now Drupal tries iconv, recode and mbstring to convert unknown XML encodings to UTF-8. It also throws a friendlier error message when none of these extensions is installed. 2004-07-12 21:35:31 +00:00
Dries Buytaert 323d9fe054 - Call 'exit' hook when drupal_goto() is called. Also necessary for the
devel.module.
2004-07-11 07:31:11 +00:00
Dries Buytaert f163fa9956 - Patch by JonBob: a significant documentation update for the menu system! 2004-07-10 18:10:36 +00:00
Dries Buytaert ac5b5616c0 - More tab-improvements by JonBob: improved support for the default tabs! 2004-07-10 15:51:48 +00:00
Dries Buytaert a067187711 - Patch #8509 by Killes and Steven: added support for sending compressed
pages.  Useful to reduce your site's bandwidth.
2004-07-08 19:22:48 +00:00
Dries Buytaert 56fa37cb8e - Made the example theme display status messages. Not sure why it wasn't. 2004-07-08 16:08:21 +00:00
Dries Buytaert 5b73def39b - Changed the way status messages are printed as per Kristjan's suggestion:
http://drupal.org/files/issues/error_messages_list.png (issue #9138).

  drupal_set_message() has been changed to group message by type and a
  helper function, theme_status_message(), is added to display the messages.
  Chameleon and Xtemplate have been updated to use this new function.

- Updated CHANGELOG.txt.
2004-07-08 16:04:07 +00:00
Dries Buytaert 02ae1ce670 - Many form_ functions called theme('form_element') with the wrong parameters!
- Fixed order of parameters in form_checkboxes() (plural).
2004-07-08 11:31:12 +00:00
Dries Buytaert 7bb88809b7 - Patch #9049 by JonBob: fixed a number of tab issues. 2004-07-06 07:33:59 +00:00
Dries Buytaert fe2b3e7c00 - Patch by Steven and me: refactored the form handling of nodes. The node system is now using form_set_error() and friends like the rest of Drupal does. This makes for both a consistent user experience and consistent code. It simplifies the forms and validation code, however, it does change the node API slightly:
* The _validate hook and the _nodeapi('validate') hook of the node API (1) no longer take an 'error' parameter and (2) should no longer return an error array. To set an error, call form_set_error().

    * The _form hook of the node module no longer takes a form hook and should not worry about displaying errors. Ditto for _nodeapi('form_post') and _nodeapi('form_pre').
2004-07-04 16:50:02 +00:00