Commit Graph

952 Commits (96aa5ca504c6509575e80e4f4394c7dd76f8241f)

Author SHA1 Message Date
Alex Pott cd7455f314
Revert "Issue #2917331 by catch, martin107, Deepak Goyal, longwave, andypost, ravi.shankar, daffie, larowlan: Decouple from Symfony CMF"
This reverts commit 98eed2b1a6.
2020-06-23 09:04:39 +01:00
Alex Pott 98eed2b1a6
Issue #2917331 by catch, martin107, Deepak Goyal, longwave, andypost, ravi.shankar, daffie, larowlan: Decouple from Symfony CMF 2020-06-22 12:18:44 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
Alex Pott 0f9cecbab6
Issue #3139414 by cburschka, mohrerao, pavnish, jungle, ravi.shankar, daffie, mondrake, sja112: Replace usages of deprecated AssertLegacyTrait::assert(No)Link() 2020-06-16 10:29:37 +01:00
Alex Pott 073679e731
Issue #3142752 by sja112, mondrake, xjm, longwave: AssertLegacyTrait::assert(No)Escaped() in functional tests still have a message passed in 2020-06-14 14:00:06 +01:00
Alex Pott 9d1faa52f4
Issue #2824935 by idebr, mfernea, Deepak Goyal, pfrenssen, longwave, hgunicamp, jofitz, andypost, daffie: Fix Squiz.ControlStructures.SwitchDeclaration coding standard 2020-06-02 09:46:52 +01:00
xjm 88375258cd Issue #3139412 by Bunty Badgujar, longwave, mondrake, xjm: Replace usages of deprecated AssertLegacyTrait::assertTitle() 2020-05-29 16:55:45 -05:00
Alex Pott 81e9500d67
Issue #3138718 by sja112, longwave, dww, xjm, alexpott: Convert British English spellings to American English, for the umpteenth time 2020-05-29 12:25:47 +01:00
xjm e4e64fa0ee Issue #3143339 by mohrerao, mondrake, longwave: Clean up the arguments of calls to WebAssert::titleEquals() and AssertLegacyTrait::assertTitle() 2020-05-28 17:29:40 -05:00
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm f09c890298 Issue #3132964 by jungle, longwave, sja112, dww, xjm, daffie: assertResponse() does not actually support a $message parameter, so stop passing one 2020-05-22 12:37:50 -05:00
xjm 0f66cce399 Issue #2937513 by eltori, longwave, klausi, catch, idebr: Fix 'Drupal.Commenting.DocComment.TagGroupSpacing' coding standard 2020-05-20 17:11:54 -05:00
catch 421c588c16 Issue #3131343 by mondrake, dww, jungle: Replace assertions involving calls to in_array() with assertContains()/assertNotContains() 2020-05-11 09:10:55 +01:00
xjm 8a8be6cc82 Issue #3087465 by zuhair_ak, tim.plunkett, Kristen Pol: Move hook_views_ui_display_top_links_alter() to views_ui.api.php 2020-05-09 13:18:46 -05:00
catch 40a5bd7e0a Issue #3126965 by jungle, quietone, longwave, mondrake, dww: Replace assert* involving count() and an integer literal with assertCount() 2020-05-07 19:07:00 +01:00
xjm 0e336272b3 Issue #3103010 by AndrewsizZ, No Sssweat, jungle, Lendude, jshimota01: Machine Name needs further clarification 2020-05-03 01:59:13 -05:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
catch 6cf25ba266 Issue #3131474 by jungle, mondrake: Replace assertions involving calls to array_search() with assertContains()/assertNotContains() 2020-05-01 09:48:22 +01:00
catch 54f84c2b5c Issue #3131223 by jungle, mondrake, longwave: Replace assertions involving calls to array_key_exists() with assertArrayHasKey()/assertArrayNotHasKey() 2020-04-28 12:14:56 +01:00
catch 4d02fe7c25 Issue #3128746 by mondrake, longwave, dww: Replace assertions involving calls to strpos() with more accurate string assertions 2020-04-27 10:02:44 +01:00
catch 4fe0b034a9 Issue #3128905 by jungle, longwave, Kristen Pol, mondrake: Replace assert* involving an instanceof operator with assertInstanceOf()/assertNotInstanceOf() 2020-04-24 21:27:52 +01:00
catch 3bcb729743 Issue #3033986 by TR, rishabhthakur, dww, Lendude, jungle: Remove useless 'limit' property override in multiple classes extending EntityListBuilder 2020-04-24 14:04:03 +01:00
catch 5132c83fac Issue #3082415 by Krzysztof Domański, mondrake, alexpott, longwave, jungle: Replace assert(Not)Same/Identical() on booleans with assert(Not)True/False() in PHPUnit tests 2020-04-17 16:00:07 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 6108526c9c
Issue #3113077 by mondrake, Hardik_Patel_12, Neslee Canil Pinto, swatichouhan012, prabha1997, neelam_wadhwani, Berdir, longwave: Replace assertContains() on strings with assertStringContainsString() or assertStringContainsStringIgnoringCase() 2020-04-12 12:34:00 +01:00
Alex Pott 6aee149769
Issue #3105701 by tedbow, xjm, Gábor Hojtsy, Krzysztof Domański, dww, Wim Leers, jungle: Do not allow core: 9.x in info.yml files 2020-03-13 22:25:24 +00:00
catch 3e9a5a531f Issue #2986452 by alexpott, andypost, kostyashupenko, daffie, kriboogh, larowlan, kristiaanvandeneynde, chrisrockwell, bleen, nevergone: Database reserved keywords need to be quoted as per the ANSI standard. Also resolves https://www.drupal.org/project/drupal/issues/371 2020-03-13 11:40:12 +00:00
Lauri Eskola 4b32a6e5bd
Issue #3113556 by tedbow, DamienMcKenna, bnjmnm, lauriii: Change Views UI to use drupal.dialog instead of jquery.ui.dialog 2020-03-05 15:08:11 +02:00
Alex Pott 6ae9811c48
Issue #3065720 by Lendude, alexpott, revati_gawas, texas-bronius: When creating a Page View in the wizard and setting a path with leading slash (/) the created View display ends up with a double-slash (//) 2020-03-02 22:55:40 +00:00
Alex Pott b57afe5c7f
Issue #3069696 by Berdir, andypost, dhirendra.mishra, longwave, alexpott: Remove BC layers from the entity system 2020-02-26 08:25:29 +00:00
Alex Pott 915b74f937
Issue #2570985 by ifrik, chipway, lomasr, jhodgdon, shimpy, govind.maloo, vacho, Balu Ertl, Manjit.Singh, alexpott, Bojhan, volkswagenchick, mradcliffe, xjm, tkoleary, yoroy, no_angel, dawehner, webchick, Sam152, RuslanP, Gábor Hojtsy, wengerk, wla_g: Update the module descriptions on the Extend page 2020-02-24 14:24:57 +00:00
catch fbde66e1c4 Issue #3110583 by govind.maloo, init90: Remove @todo - Use Url::fromPath() once https://www.drupal.org/node/2351379 is resolved 2020-02-06 14:36:26 +00:00
catch f1abfd2d0a Issue #2674328 by longwave, Berdir: Remove BC code in ViewUIConverter 2020-02-03 11:26:42 +00:00
Alex Pott 4577772da0
Issue #3101543 by lauriii, bnjmnm, ravi.shankar, alexpott: Update core JavaScript dependencies listed in package.json 2020-01-30 09:08:38 +00:00
Alex Pott 5b657b15b8
Revert "Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json"
This reverts commit 2dadb738bf.
2020-01-28 13:14:16 +00:00
Alex Pott 2dadb738bf
Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json 2020-01-28 11:36:14 +00:00
xjm 58bec68a93 Issue #3101787 by lauriii: Follow-up to #2849628: Copy change to Views UI module 2019-12-24 14:13:11 -06:00
Alex Pott e49e554766
Issue #2945243 by Lendude, msankhala, Nick Hope, dww: Remain on a View page after saving it 2019-12-05 11:02:58 +00:00
Lee Rowlands 2e2cdabc27
Issue #3097668 by andypost: Remove remaining @deprecated test in the Views UI module 2019-12-02 11:48:23 +10:00
Lee Rowlands 93b5b37321
Issue #3097475 by andypost: Remove all @deprecated code in the Views UI module 2019-11-29 21:29:34 +11:00
Lee Rowlands 34c888b1ed
Issue #3088282 by alexpott, gabesullice, Wim Leers: Missing Views link relationships when Views UI installed 2019-11-28 13:49:28 +11:00
catch 475ad55f56 Issue #3094292 by Berdir, jibran, plach, ravi.shankar, xjm: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries 2019-11-18 14:14:57 +00:00
catch 3a4d788113 Revert "Revert "Revert (yes really) "Issue #3094292 by plach, Berdir: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries"""
This reverts commit 1a3aa31f31.
2019-11-18 10:50:14 +00:00
xjm 1a3aa31f31 Revert "Revert "Issue #3094292 by plach, Berdir: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries""
This reverts commit f506b497bc.
2019-11-18 03:09:51 -06:00
xjm 4b12049a28 Revert "Issue #3094292 by Berdir, plach, jibran, ravi.shankar: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries"
This reverts commit ac65a88bed.
2019-11-17 22:48:52 -06:00
catch ac65a88bed Issue #3094292 by Berdir, plach, jibran, ravi.shankar: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries 2019-11-16 23:09:26 +00:00
catch f506b497bc Revert "Issue #3094292 by plach, Berdir: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries"
This reverts commit 7585b6e8e7.
2019-11-15 15:45:30 +00:00
catch 7585b6e8e7 Issue #3094292 by plach, Berdir: Remove usages of deprecated path alias services and clear "DeprecationListenerTrait" entries 2019-11-15 11:15:25 +00:00
Alex Pott f2469de972
Issue #3087546 by Berdir, alexpott, martin107, jibran: Remove deprecated entity manager 2019-11-14 10:49:28 +00:00
Alex Pott 2a009c5edd
Issue #3048498 by jonathan1055, Lendude, naveenvalecha, klausi, alexpott, Gábor Hojtsy: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard 2019-11-14 09:08:15 +00:00
catch 19f9474b9b Issue #2742585 by ZeiP, alexpott, mondrake, klausi, tomasnagy, Krzysztof Domański, sokru, kristiaanvandeneynde, dawehner, jeroenbegyn: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests 2019-11-08 13:53:52 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
catch bc6aabc9cd Issue #3087692 by Wim Leers, alexpott: Remove the core key from views configuration 2019-10-22 20:40:16 +01:00
Lee Rowlands 5ed00496f1
Issue #3067386 by tim.plunkett, effulgentsia, bnjmnm, lauriii, Wim Leers, huzooka, xjm: AJAX rebuild of Views UI form re-renders parts of the form without using Form API, so additional hooks are needed in lieu of hook_form_view_edit_form_alter() 2019-10-16 19:09:07 +10:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
catch 798ae0c796 Issue #3073579 by pebosi, cindytwilliams: Small design fix for Views UI advanced settings form 2019-09-16 11:59:09 +01:00
catch 8c898fc346 Issue #3070369 by lauriii, zrpnr, bnjmnm: Remove Drupal\views_ui\ViewEditForm::form dependency to jQuery UI tabs 2019-07-26 11:25:39 +01:00
Alex Pott ae248f2e43
Issue #3047801 by Eduardo Morales, mikelutz, pguillard, nlisgo, sathish.redcrackle, Berdir: Replace all calls to the deprecated Drupal::l() function in Core 2019-07-24 16:48:42 +01:00
catch 5d68f9fc21 Issue #3059872 by fhaeberle, alexpott: View names on view list table shouldn't be headings 2019-07-24 11:20:32 +01:00
Alex Pott 330e575d4d
Issue #3067198 by Berdir, mikelutz, alexpott: Properly deprecate UrlGeneratorTrait 2019-07-19 21:47:32 +01:00
catch 942682afb9 Issue #3067196 by Berdir, alexpott: Properly deprecate LinkGeneratorTrait 2019-07-12 16:12:45 +01:00
catch c12498bd9e Issue #2776031 by fgm, andypost, voleger, yogeshmpawar, Berdir, joachim: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage 2019-07-12 14:15:04 +01:00
Alex Pott e39262bf5b
Issue #2228741 by rpayanm, mikelutz, voleger, epari.siva, malotor, Rolf van de Krol, quietone, Mile23, andypost, ianthomas_uk, Lendude, alexpott, dawehner, xjm, Gábor Hojtsy, Berdir, catch: Replace calls to format_string() with Drupal\Component\Render\FormattableMarkup 2019-07-11 09:06:33 +01:00
Alex Pott 91fe1d2f77
Issue #2929133 by voleger, alexpott, Lendude: Replace all usages of getMock() 2019-05-31 10:22:21 +01:00
Alex Pott 408c540ccf
Issue #2886622 by Berdir, martin107, Mile23, tim.plunkett, mikelutz, jonathan1055: Deprecate all EntityManager methods with E_USER_DEPRECATED 2019-05-30 12:36:55 +01:00
Lee Rowlands ba509afbc9
Issue #3047866 by mikelutz, Berdir, TR, alexpott, andypost, Satyanarayan Reddy: Remove usage of deprecated \Drupal::entityManager() in core 2019-05-24 16:44:36 +10:00
Lauri Eskola 8f8ddab283
Revert "Issue #2822778 by wengerk, bighappyface, joelpittet, Lendude, lauriii, vivekguptakota, Meenakshi.g, shashikant_chauhan, GoZ, ifrik, Manuel Garcia, Neograph734: Modal popups in views is not showing properly when toolbar tray is upon modal"
This reverts commit 3257ff168b.
2019-05-22 12:08:14 +03:00
Alex Pott f7aeba594f
Issue #3033979 by TR, kimberlydb: Fix hiding view filter on admin/structure/views when JS disabled 2019-05-06 12:17:03 +01:00
Alex Pott d3a1192c05
Issue #2731333 by jhedstrom, Jo Fitzgerald, StryKaizer, Manuel Garcia, Lendude, alexpott, larowlan: Filter identifier in exposed filters allow more characters than description states 2019-05-06 11:55:49 +01:00
catch 615123f51c Issue #2286655 by alexpott, attiks, mark_fullmer, nielsonm, Mark Slatinek, quietone, catch, dawehner, aburke626, justafish: Gender neutral language 2019-04-17 16:30:13 +09:00
catch 9791614b78 Issue #2731817 by mikelutz, ashishdalvi, Sonal.Sangale, dbt102, andypost, jhodgdon, martin107, roderik: Replace all calls to the deprecated Drupal::url() function in Core 2019-04-16 14:38:27 +09:00
webchick fdbee96a7f Issue #2825446 follow-up by lauriii: Apply changes to ES6 files, too.’
git commit -m Issue
2019-04-05 21:27:01 -07:00
Alex Pott a1f4e9f043
Issue #3034254 by TR, alexpott, naveenvalecha: Remove @todo in ViewListBuilder 2019-04-02 18:43:27 +01:00
Lauri Eskola 9a4a499f07
Issue #3024527 by alexpott, markconroy, waako, occupant: Add and configure stylelint-order 2019-04-01 20:16:16 +03:00
webchick ba4424486e Issue #2825446 by Pancho, anavarre, michielnugter, dww, Lendude, dmsmidt: Moving a filter to the end of a Filter group in filter rearrange doesn't work but does allow dropping in invalid regions 2019-03-21 12:08:39 -07:00
Nathaniel Catchpole 9d96532b79 Issue #3035383 by andypost, martin107, Berdir: Replace deprecated usages of entityManager in list builder classes 2019-03-18 16:28:26 +00:00
Alex Pott 2c166a50a6
Issue #2969109 by martin107, andypost, kaythay, Berdir: Replace deprecated usages of entityManager in form classes 2019-03-10 07:34:23 +00:00
Lee Rowlands 094890e633
Issue #2942907 by plach, amateescu, Berdir, tim.plunkett, hchonov, gabesullice, jibran, xjm, tedbow, timmillwood, larowlan, Sam152, pmelab, catch, effulgentsia: Entity system does not provide an API for retrieving an entity variant that is safe for editing 2019-03-06 11:18:48 +10:00
xjm b77bf6a978 Issue #3025867 by tim.plunkett, Kristen Pol, phenaproxima, alexpott, xjm, andypost: Provide a classed object for TempStore metadata 2019-02-03 11:57:11 -05:00
Alex Pott 57f1f1a480
Issue #2215857 by michielnugter, Lendude, gmercer, tim.plunkett, cferthorney, marabak, olli, ericmulder1980, TwoD, sanduhrs, stella, dww, nod_: Behaviors get attached to removed forms 2019-01-31 01:02:35 +00:00
Alex Pott c23c05c90f
Issue #2691675 by Berdir, Mile23, alexpott: Replace deprecated entityManager() in ControllerBase descendents 2019-01-08 09:40:56 +00:00
Alex Pott 60505f3693
Issue #3019834 by Berdir, alexpott: Add @trigger_error() to deprecated url/link EntityInterface methods 2018-12-23 14:30:20 +01:00
Lauri Eskola 3257ff168b
Issue #2822778 by wengerk, bighappyface, joelpittet, Lendude, lauriii, vivekguptakota, Meenakshi.g, shashikant_chauhan, GoZ, ifrik, Manuel Garcia, Neograph734: Modal popups in views is not showing properly when toolbar tray is upon modal 2018-12-05 06:46:38 +02:00
Alex Pott 97ac5b70c2
Issue #2863563 by Lendude, michielnugter, larowlan: Convert PreviewTest WebTestBase to BrowserTestBase and JavascriptTestBase 2018-11-18 23:33:57 +00:00
Nathaniel Catchpole ac63952b33 Issue #2624770 by 20th, Jo Fitzgerald, claudiu.cristea, Berdir, mohit1604, amateescu, Sutharsan, derheap, Saviktor, Mile23, dawehner, kristiaanvandeneynde, alexpott: Use more specific entity.manager services in core.services.yml 2018-10-12 13:24:32 +01:00
Alex Pott 8c6c340fe6
Issue #2886547 by naveenvalecha, Mile23, longwave, impalash, Lendude, dawehner, Mixologic, xjm, borisson_, catch: Add trigger_error to deprecated TestBase base classes/traits that have none, reference CR 2018-10-01 15:40:09 +01:00
Alex Pott 2dabd1de10
Issue #2829185 by vaplas, Jo Fitzgerald, anmolgoyal74, chipway, gaurav.kapoor, mark_fullmer, amit.drupal, cilefen, longwave, xjm, wturrell, anavarre: Fix spelling errors in Drupal core comments 2018-09-20 17:12:38 +01:00
Alex Pott c51bd29cdf
Issue #2809553 by Lendude: Convert AJAX part of \Drupal\views_ui\Tests\RowUITest to BrowserTestBase 2018-09-18 16:52:03 +01:00
Alex Pott dd7fd60f19
Issue #2926122 by Adameue, zaporylie, BartoszUrbaniak, borisson_, idebr: Use lower-case, PEAR style, primitive data types 2018-09-14 14:07:04 +02:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Lauri Eskola e742590eed
Issue #2981652 by ApacheEx, corbacho, drpal, dawehner, xjm, alexpott, lauriii: Format core JavaScript using recently add Prettier 2018-08-09 18:49:18 +03:00
Nathaniel Catchpole 3b3eda5054 Issue #2987009 by alexpott: Remove unnecessary space in queries generated by Select::__toString() 2018-07-25 15:42:16 +09:00
Alex Pott 4ddf8b84e8
Issue #2983355 by ApacheEx, drpal: JS codestyle: indent 2018-07-05 16:34:50 +01:00
Alex Pott 27740c26de
Issue #2942900 by Mixologic, vaplas, jibran, dawehner, Lendude, martin107, alexpott, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 15:36:57 +01:00
Alex Pott ff99cb2133
Revert "Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver"
This reverts commit f55d974612.
2018-07-04 08:20:33 +01:00
Alex Pott f55d974612
Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 08:16:25 +01:00
Alex Pott bc53ca951e
Issue #2924753 by vaplas, alexpott, borisson_, xjm: Random fail in ExposedFormUITest 2018-05-14 14:26:12 +01:00
Alex Pott be6d515cad
Issue #2572613 by Malevi4, idebr, pfrenssen, Mile23, RajeevK: Fix 'Drupal.Array.Array.CommaLastItem' coding standard 2018-05-11 10:40:33 +01:00