Commit Graph

31 Commits (961cf7af4404cca36ec31a5327a484d7ca818f08)

Author SHA1 Message Date
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens d7588e4594 - #12211: Show link indicating that a node has attachments on the homepage 2005-03-18 08:05:47 +00:00
Dries Buytaert 632918e571 - Patch #16963 by Neil: the upload's module help text was in bad shape. Edited it down to what is needed with links that actually work. 2005-02-08 19:43:02 +00:00
Steven Wittens 10e3d66d87 - Missing apostrophe 2005-02-08 18:43:37 +00:00
Steven Wittens 5f78d14373 #16993: Bad query in upload. 2005-02-08 16:12:10 +00:00
Dries Buytaert 1970f1d2a8 - Fixed warning in the feed generation (enclosures). 2005-02-07 14:16:27 +00:00
Dries Buytaert 7ccc5a6b1b - Patch #16358 by James: added toolkit to enable better image handling. The avatar code and the upload module have been updated to take advantage of the new image API.
There are 5 main functions that modules may now utilize to handle images:

* image_get_info() - this function checks a file.  If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
* image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image).  This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
* image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
* image_rotate - rotate an image by X degrees
* image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).

Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
2005-02-01 16:27:43 +00:00
Dries Buytaert 7931c778d7 - Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
NOTE: this needs to be documented.
2005-02-01 14:09:31 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert e6d36892ab - Moved the upload settings to 'admin/settings'. 2005-01-29 08:31:17 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert 37f6473a88 - Patch #16023 by chx: the upload.module still used the old node_access_*_sql calls. 2005-01-23 15:37:58 +00:00
Dries Buytaert 1dbe0dc2ee - Patch #14917 by UnConeD/Steven:
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.

2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.

3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert 26875e9b38 - Added missing space 2004-12-29 23:03:05 +00:00
Dries Buytaert 627699cc9e - Patch #14545 by nysus: don't grant access to files if the node is not accessible. 2004-12-29 23:01:01 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Steven Wittens 474beff640 Missing check if file upload fails. 2004-10-20 16:57:35 +00:00
Steven Wittens 710d76171e #10441: Splitting up upload permissions in 2: one for uploading and one for viewing/downloading. It does not make sense to only allow downloading for people who can upload themselves. 2004-09-19 22:56:26 +00:00
Dries Buytaert 3ffde628c5 - Patch #8179 by JonBob: the legacy handlers and file upload previews were mistakenly cached when they cannot be. Attached patch fixes this as well as a reference to an undefined constant in legacy_menu(). 2004-09-17 18:08:28 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Steven Wittens 9a38369d0c #10560: Upload.module
- removing file checks for uid #1 to be consistent with the roles/permissions.
- renaming script files to .txt's to prevent accidental execution (we don't allow them by default, but you never know)
2004-09-13 19:14:32 +00:00
Steven Wittens e35674d4a2 Upload.module: add explicit cast to (array) for $node->files in case it's not set (e.g. nodes that don't take attachments). 2004-09-05 09:15:18 +00:00
Steven Wittens 44f341bebc Patch by me and Kjartan.
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Steven Wittens eb5d7d2a27 Fixed bad permissions in upload.module:
- Admin - upload only shows up for 'access administration section' perms
- Users without 'upload files' perm do not see the attachments form (and cannot attach even when sending their own http request)

Note: if a user can edit a node, but not 'upload files', then the attachments are left untouched (and cannot be changed).
2004-08-18 21:55:39 +00:00
Dries Buytaert 0e36182c96 - Code improvements by Stefan:
+ " -> '
   + Using form_set_error() instead of drupal_set_message().
   + Removed dead code.
2004-08-18 19:45:50 +00:00
Dries Buytaert 775153089d - Small change to the wording of the 'note'. 2004-08-18 06:08:04 +00:00
Steven Wittens 8050af67b3 Setting the default workflow for attachments by upload.module to be enabled.
This makes sense because people will expect attachments to work everywhere when they enable this module. This also matches comment.module's behaviour, where comments are allowed by default unless turned off.
2004-08-18 04:24:33 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00