Commit Graph

204 Commits (961cf7af4404cca36ec31a5327a484d7ca818f08)

Author SHA1 Message Date
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Steven Wittens 57af1cef64 - #19515: Improved system/test clean URL checker. 2005-03-27 23:37:20 +00:00
Dries Buytaert f514f55112 - Patch #18700 by Stefan and James: removed GD1 calls, improved error/status reporting, etc. 2005-03-23 20:26:21 +00:00
Dries Buytaert f8d634e38a - Patch #18093 by Junyor: clean up handling of image toolkit code in absence of
any toolkits.
2005-03-21 21:25:49 +00:00
Steven Wittens e6b14d2615 - #13738: Fix bug in configuring theme styles 2005-03-18 08:27:01 +00:00
Steven Wittens c3f1f7345e - #18939 (Stefan): Always use paragraph tags around page help text. 2005-03-18 07:07:04 +00:00
Dries Buytaert 97ae6568e6 - Patch #13738 by TDobes: theme system fixes:
* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
2005-03-16 19:41:12 +00:00
Dries Buytaert 3becbd8997 - Patch #16914 by chx: avoid that putting a .theme file directly in './themes'
breaks your Drupal.  Only themes in './themes/subdir' are picked up now.
2005-03-08 22:06:11 +00:00
Dries Buytaert dcf985de21 - Patch #18404 by Gerhard: removed incorrect/outdated documentation from a form description. 2005-03-05 09:11:00 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert 501dd722a7 - Patch #16966 by Neil: don't document code in the help text. 2005-02-08 19:33:01 +00:00
Dries Buytaert 7ccc5a6b1b - Patch #16358 by James: added toolkit to enable better image handling. The avatar code and the upload module have been updated to take advantage of the new image API.
There are 5 main functions that modules may now utilize to handle images:

* image_get_info() - this function checks a file.  If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
* image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image).  This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
* image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
* image_rotate - rotate an image by X degrees
* image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).

Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
2005-02-01 16:27:43 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert d14bc428c6 - Patch #15570 by Drumm: integrated the admin and system module. Renamed the callback as per Goba's suggestion. 2005-01-14 15:21:39 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert aa1413d82e - Fixed #13643: increased the maxlength of the 'path to custom logo'-setting. 2004-11-30 18:40:24 +00:00
Dries Buytaert 0c6a18cb44 - Patch #5942 by TDobes: fixed theme stuff after multi-site configuration patch. 2004-11-25 06:17:03 +00:00
Dries Buytaert 5d759ccbb9 - Patch #5942 by jhriggs and Adrian:
+ added support for multi-site configurations.
    + tidied up some old cruft and added code comments.
2004-11-24 22:44:01 +00:00
Dries Buytaert f37a65cab9 - Patch #12353 by Stefan: usability improvement: don't show 'throttle fields' unless the throttle module is enabled. 2004-11-15 11:26:04 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert ef95773b1c - Modified patch by Jeremy: throttle module improvements and fixes:
+ throttle module: flush cache when the throttle enables/disables
   + throttle module: prevent throttle being enabled by 0 users or guests when disabled
   + system module: remove requirement for statistics.module
   + block module: update help text to reflect access log is no longer required
   + statistics module: throttle is now enabled/disabled, not using levels 0-5
2004-11-14 20:20:09 +00:00
Steven Wittens 95595ae6f8 #12384: Test if clean URLs work before allowing them to be turned on. 2004-11-02 12:47:10 +00:00
Dries Buytaert 2c45ab85fb - Fixed bug #9948: added some checks to system_setting_save() to avoid PHP warnings/errors. 2004-10-16 07:35:29 +00:00
Steven Wittens 583e63c136 Theme system bug: only show search box if search.module is enabled. 2004-10-14 02:38:33 +00:00
Steven Wittens 2c4a82bda2 #11503: (more) missing t() 2004-10-12 16:10:54 +00:00
Dries Buytaert 503c784557 - Simplified/reorganized version of patch #9620 by Jeremy: fixed errors when writing to cache. 2004-10-04 22:04:07 +00:00
Dries Buytaert 86b9c40c88 - Patch #11001 by Philippe: added support for dates in ISO-8601 format. 2004-09-22 17:50:55 +00:00
Dries Buytaert 1a91e6e1bc - Patch #10730 by Adrian: made it possible to upload a logo. 2004-09-21 18:33:51 +00:00
Steven Wittens 710d76171e #10441: Splitting up upload permissions in 2: one for uploading and one for viewing/downloading. It does not make sense to only allow downloading for people who can upload themselves. 2004-09-19 22:56:26 +00:00
Steven Wittens a51fdd781a #9292: Minor PHP 5 fixes. 2004-09-19 00:27:46 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 2446f32c92 - Renamed the 'first day of week' setting to be more consistent with the other date settings. 2004-09-12 17:18:36 +00:00
Dries Buytaert d186dcc8c8 - Patch #10668 by drumm: moved the 'first day of week' settings to the system module for other modules to reuse. This is considered to be a usability improvement because it simplifies some pages/workflow. 2004-09-12 17:16:17 +00:00
Steven Wittens 90c1623b4d Typo: "are be" 2004-09-11 16:40:53 +00:00
Kjartan Mannes df70600153 - Decode node type to userfriendly name. 2004-09-06 18:32:54 +00:00
Steven Wittens 44f341bebc Patch by me and Kjartan.
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Steven Wittens 98a9d5ee2d - #9576: Patch by TDobes, only allow the user to choose between enabled themes. 2004-08-22 14:43:49 +00:00
Dries Buytaert 03fa966c1f - Patch #9576 by TDobes: bugfix: fixed bug in recent theme system changes. 2004-08-21 10:16:13 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert 6696028a75 - Patch by TDobes: bugfix: fixed a typo. 2004-08-21 06:34:59 +00:00
Steven Wittens 9f2d6f0e51 - Fixing 'flash of unstyled content' in bluemarine/pushbutton, which got reintroduced after the template changes.
- Fixed separate styles: added theme_get_styles() and the xtemplate {styles} tag to make sure stylesheets get included in the right order (drupal-specific, template-specific, style-specific).
- Fixing missing class on screenshots.
- Renamed drupal_get_theme_setting() and drupal_get_theme_settings() to theme_get_setting() and theme_get_settings().
2004-08-20 17:21:37 +00:00
Dries Buytaert 1a82f4d4db - Usability improvement: changed 'Status' to 'Enabled' because that is what
we use elsewhere.
2004-08-20 14:37:47 +00:00
Dries Buytaert 6ea5c56ded - Theme system changes. Please consult http://drupal.org/node/view/9576 for details. 2004-08-20 07:51:27 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Steven Wittens 26cb5c1d54 #10013: Rolling back accidental commit of Adrian's template system changes (got in through the code style improvements patch). 2004-08-14 17:19:30 +00:00
Dries Buytaert 0f088b79ca - Patch #9983 by Stefan: various code style improvements. 2004-08-12 18:00:11 +00:00
Dries Buytaert 4a35c8aa0d - Patch #8155 by JonBob: removed legacy _system() hook. 2004-08-10 21:27:23 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00