Commit Graph

32 Commits (949a7014df31a89f226bdbd1222e4f229b63d49f)

Author SHA1 Message Date
Dries Buytaert 2fe79310df - Rewrote the most of the menu system; this fixes Al's problem with the
"create content" link.

- Manually merged the user module's new menu items.  Al's patch did not
  apply.

- Added some missing t()s.
2003-09-28 10:51:40 +00:00
Dries Buytaert 0ff789c61d - Patch by Kjartan:
+ Fixed CSS to use the same format as the rest of drupal.css.
   + Added fallback routine for menu icons.
   + Fixed anonymous users not seeing the menu.
   + Added proper access checks for admin and help menu items.
2003-09-26 23:05:14 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 645d026e09 - Added $Id$ tags. Patch by Chris. 2003-09-25 07:27:22 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert 4d16c7c65b Implemented more suggestions by Keith:
- Made sure the 'Topic' title is only shown above the topics, not the icons.

- Automatically shorten the username when it is too long.  I implemented this
  as part of format_name() and could therefore nuke some code in the
  statistics module.  This is change is somewhat experimental and I'm willing
  to revert or change this if a number of people aren't too happy with this
  behavior.

- Left align the dates and authors: makes it easier/faster to scan.

- Made the little tablesort arrows clickable.
2003-08-22 21:35:25 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 8a2d5bede9 - Rewrote handling of forum icons and added default icons made by Steven
Wittens.

- Renamed some column titles in the forum module as per Moshe's suggestion.

- Introduced a 'more-link' class to position the 'more' links.  Removed
  hard-coded markup from the modules.

- Fixed bug in import module: the theme functions called a non-existing
  function.
2003-08-16 05:49:45 +00:00
Dries Buytaert 5c40037c8e 1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.
2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.
2003-08-15 15:17:23 +00:00
Kjartan Mannes 17ef869e3a Applied 0007.almaw.home-link-using-l.patch
- Fix link_page to use l() to generate home link.

Applied 0058.kika.themeable-usermenu.patch
- Modifies user menu be themeable.
2003-08-11 20:41:37 +00:00
Dries Buytaert d017514eba - Improvement: made it possible to translate the forum module. Patch #53 by Stefan.
- Improvement: some small changes to the user module to ease translation and to make things slightly more consistent.  This should be a better alternative for patch #54.

- Improvement: increase the maxlength of the node title.  This should fix bug #2018 and #2176.
2003-07-02 17:09:09 +00:00
Dries Buytaert 2323e57233 - Improvement: moved hard-coded CSS from user module to drupal.css. Patch
#57 by Kristjan.
2003-06-26 19:30:20 +00:00
Dries Buytaert 3ee119d0f7 - Improvement: SQL improvements to the user module. Patch #44 and #45 by
Gerhard.

- Improvement: CSS improvements.  Patch #40 by Al.

 (TODO: we might be able to simplify admin.css now both drupal.css and
 admin.css are included to render administration pages.  Tags like "body"
 and friends can probably be inherited.)
2003-06-23 18:02:56 +00:00
Dries Buytaert 328de12db5 - Made <pre> wrap. Patch #21 by Al. 2003-06-17 18:13:03 +00:00
Dries Buytaert 2edb978db3 - Bugfix: fixed glitch with "blog it" images. Patch #15 by Al. 2003-06-15 19:41:15 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 222e1e5583 - Documentation improvements: improved and updated the block module documentation. Patch #44 by Al. We should add some real-life path examples!
- Fixed the "blog it" image size.  Patch #49 by Al.

- Some SQL performance improvements to the forum module.  This should also be more PostgreSQL safe.  Patch by me.

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.63 sec

changed to:

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.00 sec
2003-06-10 17:33:43 +00:00
Dries Buytaert 54ddba4eea - Fixes CSS for archive calendar so that you can make non-link days padded
in a sensible fashion. Also removes table width 100% and puts that in css.
  Patch #48 by Al.
2003-06-08 19:26:26 +00:00
Dries Buytaert 58ca1ad668 - CSS fixes by Al. Patch #45. 2003-06-08 17:47:26 +00:00
Dries Buytaert 4627ade43e - CSS improvements. Patch #38 by Al. 2003-06-08 08:27:00 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert c14dd46e3e - No comment 2003-06-03 19:00:22 +00:00
Dries Buytaert befac110f4 - Got it right this time. 2003-06-03 18:59:17 +00:00
Dries Buytaert 4078d6da17 - The .form-item .form-submit item got lost in my previous commit. 2003-06-03 18:56:30 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 39f6a9e79a - CSS improvements to the calendar of the archive module. Updated the Xtemplate
theme and theme Marvin to take advantage of this.  Patch by Al.  Pretty stuff.
2003-05-31 12:42:02 +00:00
Dries Buytaert 8a9ff42413 - CSS improvements for the poll module. Patch by Al. 2003-05-30 21:43:24 +00:00
Dries Buytaert ed1a9cbfa7 Patch by Al:
- Made the import module use theme_item_list() instead of emitting the HTML
  and CSS itself.

- Renamed the "blog-it" tag to "icon" so it can be used for other (but
  similar) purposes.
2003-05-30 05:53:10 +00:00
Dries Buytaert e39cfcd22b - More CSS updates and fixes. Patch by Al. 2003-05-29 15:36:17 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00