Commit Graph

1487 Commits (9369dccc04d423dc9a65617ddc9d3ed5730e5b2c)

Author SHA1 Message Date
Dries Buytaert 30c546931d - Fixed bug with being able to post comments while you shouldn't. Patch by
Garym.
2003-09-03 20:18:03 +00:00
Dries Buytaert 2c342df5a9 - Fix for bug #2691: crash due to locale module. Patch by Bruno. 2003-09-03 12:05:46 +00:00
Kjartan Mannes 15a2cbd243 - Fixing a broken query when tracking by host. 2003-08-31 22:15:49 +00:00
Dries Buytaert 756a5da544 - Added an "edit account" link. 2003-08-30 21:52:39 +00:00
Dries Buytaert 796399ffd4 - Fixed bug #2689. Patch by Bruno. 2003-08-30 21:20:21 +00:00
Dries Buytaert e330d7c654 - Fixed bug #2690. Patch by Bruno. 2003-08-30 21:16:23 +00:00
Dries Buytaert 6f4e902e3b - Corrected the form description of the URL aliasing; don't add a trailing
slash.  Reported by Stefan.
2003-08-30 07:40:19 +00:00
Dries Buytaert 89005902e4 - Tested and committed Kjartan's performance patches. (Fixed the access check
in update.php though.)
2003-08-27 05:49:52 +00:00
Dries Buytaert 93fb265d47 - Removed a debug statement. 2003-08-26 07:13:08 +00:00
Dries Buytaert 8a6ba5f1d0 - More mass-operation fixes. 2003-08-26 07:12:06 +00:00
Dries Buytaert f58a88dd26 - Fixed a couple of bugs with the mass node operations. 2003-08-26 07:05:11 +00:00
Dries Buytaert 410d619287 - Made the statistics module use the new help system. Patch by Michael.
- Increased the number of nodes shown on the admin top nodes page.
2003-08-25 20:07:02 +00:00
Dries Buytaert 2e22798a8d - More help system updates by Michael F. 2003-08-25 16:57:55 +00:00
Dries Buytaert 9abe339c99 Patches from Moshe:
- Tracker module: adds a missing call to tablesort_pager().
 - Tablesort:
   + add 'title' attributes
   + let arbitrary querystring params flow through to pager links
   + removed ugly border around the arrow
2003-08-25 16:12:09 +00:00
Dries Buytaert cefb123e24 - Updated the profile module to use the new help system. Patch by Michael. 2003-08-23 18:27:05 +00:00
Dries Buytaert e98fe741a9 - Updated the node module to take advantage of the new help system. Patch by
Michael.
2003-08-23 18:25:35 +00:00
Dries Buytaert 6a5ce3cad1 - Fixed bug #2548: error reporting from modules didn't always work. 2003-08-23 12:15:45 +00:00
Dries Buytaert c485b54555 - Fixed a number of small user experience inconsistencies pointed out by
Keith.
2003-08-23 10:11:10 +00:00
Dries Buytaert 4d16c7c65b Implemented more suggestions by Keith:
- Made sure the 'Topic' title is only shown above the topics, not the icons.

- Automatically shorten the username when it is too long.  I implemented this
  as part of format_name() and could therefore nuke some code in the
  statistics module.  This is change is somewhat experimental and I'm willing
  to revert or change this if a number of people aren't too happy with this
  behavior.

- Left align the dates and authors: makes it easier/faster to scan.

- Made the little tablesort arrows clickable.
2003-08-22 21:35:25 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 134c9eb887 - Added some missing {} to make database prefixing work. Patch by Moshe. 2003-08-22 05:07:25 +00:00
Dries Buytaert 7f6ecbec0e - Fixed bug with user sessions. Patch by Jeremy. 2003-08-22 05:00:43 +00:00
Dries Buytaert 694a38c179 - Updated modules to new help system. Patch by Michael. 2003-08-21 20:50:03 +00:00
Dries Buytaert 022db9a21a - Updated the locale module to the new help system. Patch from Michael. 2003-08-21 19:29:31 +00:00
Dries Buytaert 3d89a559ca - Updated the story module to the new help system. 2003-08-21 18:21:15 +00:00
Dries Buytaert da8f92dc3b - Updated the system module to the new help system. Needs a bit of work after the
rest has been completed.
2003-08-21 18:13:28 +00:00
Dries Buytaert 9fac5f5fb9 - Updated the taxonomy module to use the new help system. 2003-08-21 18:02:37 +00:00
Dries Buytaert 2bc440112b - Forgot to remove a debug statement. Thanks Bart. 2003-08-21 17:42:00 +00:00
Dries Buytaert f9b06a482b - Correct caps in table headers 2003-08-21 16:54:21 +00:00
Dries Buytaert 8d013b1666 - Applied Moshe's tablesort patch! Note that I changed the arrow images
because those of Moshe where not identical.
2003-08-21 15:47:50 +00:00
Dries Buytaert 8a3512d481 - Updated the throttle module to the new documentation scheme. 2003-08-20 21:19:17 +00:00
Dries Buytaert 49fb60a08b - Fixed documentation bug in import module. 2003-08-20 21:14:17 +00:00
Dries Buytaert 47797714ab - Updated the tracker module to the new help system scheme. 2003-08-20 21:06:51 +00:00
Dries Buytaert 6b63aa6638 - Updated the import module to the new documentation scheme. Patch by
Michael.
2003-08-20 21:00:31 +00:00
Dries Buytaert 0431f0700f - Committed Jeremy's session patch: this brings us one step closer to having
session for anonymous users.
2003-08-20 19:19:13 +00:00
Dries Buytaert b79b831152 - Updated the user module to use the new help system approach. 2003-08-19 20:48:25 +00:00
Dries Buytaert 6c1af75896 - Updated the watchdog module to use the new help function approach. 2003-08-19 19:59:33 +00:00
Dries Buytaert 8a2d5bede9 - Rewrote handling of forum icons and added default icons made by Steven
Wittens.

- Renamed some column titles in the forum module as per Moshe's suggestion.

- Introduced a 'more-link' class to position the 'more' links.  Removed
  hard-coded markup from the modules.

- Fixed bug in import module: the theme functions called a non-existing
  function.
2003-08-16 05:49:45 +00:00
Dries Buytaert db8c3edca5 - Bugfix: don't user term->descriptions in link attributes as they are HTML
code on their own.
2003-08-16 05:25:33 +00:00
Dries Buytaert f7bc6af717 - Bugfix: changed 'INNER JOIN' back to 'LEFT JOIN'. 2003-08-15 16:41:53 +00:00
Dries Buytaert 5c40037c8e 1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.
2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.
2003-08-15 15:17:23 +00:00
Dries Buytaert 6842d59732 - Documentation fixes by Michael F. 2003-08-13 18:40:26 +00:00
Dries Buytaert c25bc33181 - Usability improvements based on Keith Instone's suggestions:
* Removed 'handbook' title.

   * Added a 'books' link to the book location bar: the link takes you to
     the book overview page.

   * Renamed a few 'collaborative books' to 'books' so that the links and
     page/box titles match.
2003-08-13 07:24:14 +00:00
Dries Buytaert e0b97a7587 - Usability improvement: changed the title of the main block on the user
information page.  Suggested by Keith Instone.
2003-08-13 07:08:27 +00:00
Kjartan Mannes 48805032c8 - Applied modified version of almaw's 0064 patch: form item attributes.
- Applied modified version of mathias' 0073 patch: node form name.
  $params["options"] is now an array so some contrib modules might
  need minor changes.

- Applied mathhias' 0074 patch: missing access check on who is new
  block.
2003-08-12 20:37:16 +00:00
Dries Buytaert c6b215c057 - Heavily modified version of Gerhard's patch #82: the queue module does now
inform the user about the status of his or her post.
2003-08-12 19:39:53 +00:00
Dries Buytaert 37310ee6f0 - Added missing t() functions to watchdog. Patch #80 by Stefan. 2003-08-12 19:12:22 +00:00
Dries Buytaert 442f5b0757 - Added missing translation functions. Patch #78 by Stefan. Merged by hand
as the patch no longer applied.

- Fixed broken "view post" URL on administration page.  Reported by Bart.
2003-08-12 19:09:44 +00:00
Dries Buytaert 7af49ab274 - Committed Marco's comment module patch:
+ Dramatically improves performance of large discussions/threads: only
      very few SQL queries are required.
    + Replaces custom pager with standard pager.

  Modifications by me:

    + Reworded some code comments.
    + Removed dependencies on pager internals.
2003-08-12 18:32:54 +00:00
Kjartan Mannes 17ef869e3a Applied 0007.almaw.home-link-using-l.patch
- Fix link_page to use l() to generate home link.

Applied 0058.kika.themeable-usermenu.patch
- Modifies user menu be themeable.
2003-08-11 20:41:37 +00:00
Dries Buytaert b22cd5d1c7 - Bugfix: changed an inner join back to a left join. Patch by Bart Jansens 2003-08-10 10:35:26 +00:00
Dries Buytaert cecaa68e65 - Miscellanious comment module fixes. Patch 20030806.comment-misc.patch by
Bart Jansens.
2003-08-08 22:57:10 +00:00
Dries Buytaert 39950fe2e2 - Committed a modified version of Ulf's input checking changes. Patch #95.
I added an error message, changed a few things around and fixed tw typos.
2003-08-08 22:24:55 +00:00
Dries Buytaert e2f098af85 - Block module documentation improvement. Patch by Gerhard. 2003-08-07 16:53:36 +00:00
Dries Buytaert 56c662174d - More help system improvements by Michael. 2003-08-06 21:14:05 +00:00
Dries Buytaert 4131b785f7 - Help system improvements from Michael. 2003-08-05 18:33:39 +00:00
Dries Buytaert 173dfb5950 - Added missing {}. Fixes bug 2423 reported by kenzky. 2003-08-05 07:06:26 +00:00
Dries Buytaert d42158ce66 - Added more filters and support for "mass-operations" to the node overview page
in the admin section.  Comments?
2003-08-02 06:49:32 +00:00
Dries Buytaert 498f13c002 - If $node->path has been initialized (via a form for example), node_url will return it. This is not good because path could still be null (empty). Patch by Matt Westgate. 2003-07-31 09:56:29 +00:00
Dries Buytaert 869d8c6707 - Fixed broken links in the versioning system. Patch by Bart Jansens. 2003-07-31 09:50:33 +00:00
Dries Buytaert 9fe3d9c46a - Fixed bug in user_validate_name(): . (dot) should be allowed for DA to work.
Fixes bug #107.
2003-07-26 18:01:14 +00:00
Dries Buytaert 30337a7d29 - Bugfix: remove forum block caching as it contains text that can be translated.
Fixes bug #2329.
2003-07-26 17:39:12 +00:00
Dries Buytaert e278e46f49 - Applied Moshe's 007 patch: "read more" and author optimizations. 2003-07-26 13:18:49 +00:00
Dries Buytaert cbbc3e80c0 - Bugfix: made deleting polls work. Patch by Marco. 2003-07-24 12:33:57 +00:00
Dries Buytaert 75512ae3dc - Fixed the update path of user_save(). Patch by Gerhard. Tnx. 2003-07-23 19:48:08 +00:00
Dries Buytaert 3833e4de9d - Cache system improvements by Gerhard: removed some left-overs. 2003-07-23 18:33:12 +00:00
Dries Buytaert 83ae5b5c36 - Fixed typo: implde() -> implode(). Reported by Moshe. 2003-07-23 05:16:10 +00:00
Dries Buytaert c39562ae03 - Fixed node_save() and user_save() bug introduced by table prefix changes.
Modified patches from Gerhard.

- Changed the order of the checks in node_teaser().  Patch from Kobus.
2003-07-21 15:36:05 +00:00
Dries Buytaert d1b175cec7 - Some queue module fixes by Trogeir. 2003-07-17 22:48:15 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 1252d51264 - Changed some INNER JOINs back to LEFT JOINs. Patch by Gerhard. Not tested
by me.
2003-07-16 07:58:02 +00:00
Dries Buytaert b66c616b8a - Some documentation fixes as per Charlie's suggestion: bug #2260. 2003-07-14 21:35:59 +00:00
Dries Buytaert 3c374a3ef2 - Documentation improvement by Charly. Task #2257. 2003-07-13 07:47:01 +00:00
Dries Buytaert 22b6d2f30c - Performance improvement: changed a fair amount of "left joins" to "inner
joins".  Patch by Gerhard.
2003-07-12 22:21:55 +00:00
Dries Buytaert d5cdbcd644 - Bugfix: fixed username not being fetched with the title module. Fixes bug
#1852.

  (Going to backport this to the DRUPAL-4-2-0 branch.)
2003-07-12 10:36:56 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert 1c2fc43b51 - Bugfix: fixed HTML typo in comment module. Patch by Torgeir Berg. 2003-07-10 05:02:57 +00:00
Dries Buytaert c89f78aa4d - Bugfix: fixed the "check for duplicate e-mail addresses" test. Patch by
Marco.
2003-07-09 21:54:35 +00:00
Dries Buytaert b59094355a - Made the tracker module link to your own posts. Patch 79 from Gerhard.
- Added a permalink to the Xtemplate theme.  Requested by Scott.

- Added pager support to the locale module.
2003-07-09 18:39:46 +00:00
Dries Buytaert bfd68e80eb - Made it easier to translate some text on the tracker page. Patch #71 by
Stefan.
2003-07-08 11:24:28 +00:00
Dries Buytaert 12506d8365 - Added 3 missing t() functions to the statistics module's administration
pages.  Patch #73 by Stefan.
2003-07-08 09:55:47 +00:00
Dries Buytaert 70c40e3a9b - Made it easier to translate the the "Jump to" link of the forum module.
Patch #68 by Stefan.
2003-07-08 09:53:14 +00:00
Dries Buytaert 1482a56596 - Usability improvement and bugfix for translation issue with the taxonomy
module.  Patch #70 by Stefan.
2003-07-08 09:51:22 +00:00
Dries Buytaert cd150ba731 - Improvement: made it easier to translate the book outline. Patch #67 by
Stefan.
2003-07-08 09:48:29 +00:00
Dries Buytaert 8963b895a1 - Translation improvement: made it easier to translate the site title of the
administration pages.  Patch #66 by Stefan.
2003-07-08 09:45:56 +00:00
Dries Buytaert cc34b3cf24 - Bugfix: fixed some typos in the Blogger API help. Patch #75 by Chris. 2003-07-08 09:41:36 +00:00
Dries Buytaert 877143131d - Bugfix: don't show the "blog it" links when the blog module is disabled.
Patch by Bart Jansens.
2003-07-08 09:07:30 +00:00
Dries Buytaert 07f9c4f636 - Removed some cruft. 2003-07-08 09:04:41 +00:00
Dries Buytaert d017514eba - Improvement: made it possible to translate the forum module. Patch #53 by Stefan.
- Improvement: some small changes to the user module to ease translation and to make things slightly more consistent.  This should be a better alternative for patch #54.

- Improvement: increase the maxlength of the node title.  This should fix bug #2018 and #2176.
2003-07-02 17:09:09 +00:00
Dries Buytaert 7997ebb982 - Bugfix: added more permissions checks. Patches #60-62 by Al. Should fix
bug #2163 and #2164.
2003-07-01 21:45:25 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 3bb6ddee4b - Bugfix: fixed problem with search terms not being escaped properly. 2003-06-30 19:42:19 +00:00
Dries Buytaert 886ae2bf15 - Fixed some "search related" bugs introduced by Moshe's latest patch.
Fixes bug #2127.
2003-06-30 19:18:47 +00:00
Dries Buytaert 74d9266b3f - Bugfix: fixed calendar block caching. Patch by Al. Fixes bug #2131.
- Improvement: improved the block module documentation.  Patch #59 by
  Gerhard.
2003-06-30 18:34:02 +00:00
Dries Buytaert 4d29898a96 - Bugfix: flush the cache after updating the new feeds (or after having
added or removed news items).  Fixes bug #2088.
2003-06-28 22:48:18 +00:00
Dries Buytaert f4df719502 - Reworked the CXX checking; now, _any_ user input will be checked
and the request will be terminated when something suspicious is
detected.  This will be logged in the watchdog.  With help from Marco.

- Fixed translation issue in the archive module.  Patch by Gerhard.

- Removed dead parameter from variable_get().  Patch by Chris Johnson.
Fixes bug #2111.

- Improved input checking of taxonomy module.  Patch by Gerhard.
Fixes bug #2112.
2003-06-27 17:48:20 +00:00
Dries Buytaert 2323e57233 - Improvement: moved hard-coded CSS from user module to drupal.css. Patch
#57 by Kristjan.
2003-06-26 19:30:20 +00:00
Dries Buytaert 1758fe779f *** empty log message *** 2003-06-26 19:13:32 +00:00
Dries Buytaert e95aa56e02 - Bugfix: fixed bug in the search module that prevented the title module
from working properly.  Patch by Moshe.  Fixes bug #1852.
2003-06-25 22:10:54 +00:00
Dries Buytaert 2689d6aa1e - Narrow the set of allowed usernames to prevent people from messing with it. 2003-06-25 15:46:03 +00:00
Dries Buytaert 1f91ef891e - Bugfix: fixed bug #1627. 2003-06-24 18:26:32 +00:00
Dries Buytaert 1c38cd9099 - Bugfix: renamed "create PHP content" to "create php content". Reported
by Simon, patch by Gerhard.

- Improvement: synchronized the import module help with the version on
drupal.org.
2003-06-24 15:55:22 +00:00
Dries Buytaert 7bbd226f88 - Bring back the statistics module. Not sure what went wrong. 2003-06-23 22:03:50 +00:00
Dries Buytaert 3ee119d0f7 - Improvement: SQL improvements to the user module. Patch #44 and #45 by
Gerhard.

- Improvement: CSS improvements.  Patch #40 by Al.

 (TODO: we might be able to simplify admin.css now both drupal.css and
 admin.css are included to render administration pages.  Tags like "body"
 and friends can probably be inherited.)
2003-06-23 18:02:56 +00:00
Dries Buytaert e86cc797fb - Bugfix: fixed timezone problem with archive module. Patch by Al. 2003-06-22 08:46:34 +00:00
Dries Buytaert 265127591f - Bugfix: fixed the character when importing news feeds. Reported at
http://drupal.org/node/view/2036.
2003-06-22 07:36:06 +00:00
Dries Buytaert f3e39503fa - Improvement: removed some dead code. Patch by Gerhard. 2003-06-22 06:47:08 +00:00
Dries Buytaert fbbccada8e - Translation improvement. Patch by Stefan. 2003-06-20 18:29:35 +00:00
Dries Buytaert e57faf2192 - Bugfix: fixed problem with changing themes. Didn't apply Al's patch as
the fix was somewhat simpler.  Fixes bug #2003.

- Bugfix: fixed problem with voting on certain poll pages.  Patch #37 by Al.

- Improvement: removed stupid descriptions from profile module.
2003-06-20 17:43:03 +00:00
Dries Buytaert 7fd4cc4bf7 - Bugfix: fixed problem with the use of % on the user module form. Patch
by Slavica.  Fixes bug #1730.
2003-06-20 05:05:53 +00:00
Dries Buytaert 828ba66500 - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al.
- Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.

- Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.

- Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.

  NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
2003-06-19 17:26:27 +00:00
Dries Buytaert 0c5b324809 - Improvement: made the default homepage setting more flexible. Patch by
Eric A. Farris.
2003-06-18 21:21:30 +00:00
Dries Buytaert 63fb132ec6 - Bugfix: it was not possible to delete a user account when "delete" was
translated.  Patch by Stefan.
2003-06-18 18:13:28 +00:00
Dries Buytaert f4fe0cf1e7 - Improvement: made the user module use themeable lists. Patch #32 by Kristjan. 2003-06-18 17:44:09 +00:00
Dries Buytaert 7a8a99d4a5 - Bugfix: corrected typo in the poll module. Patch by Al. 2003-06-17 18:20:17 +00:00
Dries Buytaert cc837807c6 - Bugfix: made searching locale strings work. Patch by Al. Fixes bug #1986. 2003-06-17 18:14:43 +00:00
Steven Wittens 282566271f Bugfix: user timezone-selection now uses the site's configured date_format_long value rather than a hardcoded one. 2003-06-16 21:03:12 +00:00
Dries Buytaert 026c09b6ce - Bugfix: fixed searches to do boolean AND rather than OR. This isn't the best way to do things, but seems to be pretty much the only way to get things to be properly
ANSI-compliant.  Patch by #17 by Al.  (Note: I haven't really tested this fix but this should fix bug #1857.)
2003-06-16 17:20:50 +00:00
Dries Buytaert c409368062 - Bugfix: emit the proper CSS tags for "normal" and "linked" days. Patch #18
by Al.  Thanks.
2003-06-16 17:17:51 +00:00
Dries Buytaert 4e91002fde - Improvement: show favicon on admin pages. Patch #20 by Al. 2003-06-16 17:16:34 +00:00
Dries Buytaert ef8735614f - Improvements: XHTML-ifications. Patch by GmbH. See feature #1813. 2003-06-16 17:09:23 +00:00
Dries Buytaert e5f2c1ef0e - Usability improvement: avoid showing two login forms on one page. Suggested
by Keith.
2003-06-15 20:24:49 +00:00
Dries Buytaert 10e1c07502 - Bugfix: locale module fix for bug # 1822 (translated/untranslated and search
issues).  Patch #12 by Al.
2003-06-15 19:42:27 +00:00
Dries Buytaert 2edb978db3 - Bugfix: fixed glitch with "blog it" images. Patch #15 by Al. 2003-06-15 19:41:15 +00:00
Dries Buytaert 8a9a5ba3da - Bugfix: the variable 'user_mail_welcome_approval_subject' was too long.
Modified patch from Al; used 'user_mail_approval_subject' instead of
  'user_mail_welcome_approval_subj'.  Patch #11 by Al.  Fixes bug #1976.
2003-06-15 19:17:43 +00:00
Dries Buytaert c31fe45f2f - Improvement: fixed wrapping in code samples in user module so that admin help doesn't have a huge horizontal scrollbar. Patch #13 by Al. 2003-06-15 19:11:17 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert a0e0ea9337 - Comment module documentation improvements; updates by Charlie, patch by Al. 2003-06-15 19:00:07 +00:00
Dries Buytaert 19a0731456 - Improvement: nicer, slightly larger arrows for the month selection within
the archive calendar.  Patch #2 by Al.
2003-06-15 07:05:06 +00:00
Dries Buytaert 677dbd46e2 - Bugfix: fixed broken links in the emitted RSS feed discovery code. Modified
patch by Kjartan.
2003-06-15 06:45:53 +00:00
Dries Buytaert ab03855a8a - Fixed braino in title.module; should fix bug #1966 reported by Moshe. 2003-06-14 16:18:40 +00:00
Dries Buytaert 5646f894ac - Bugfix: fixed broken links. Patch by Ax. 2003-06-14 16:11:29 +00:00
Dries Buytaert 3e9aabe058 - Moved some CXX checks to a centralized place; less error-prone. 2003-06-14 07:02:32 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 5ed848ecdb - Show a non-clickable example "link" when previewing comments. Should fix
bug #1437 for all themes (incl. theme Marvin and theme UnConeD).
2003-06-12 19:13:50 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Dries Buytaert 9e813c08a4 - Bugfix: when clean URLs are enabled, the cookie path was not always set correctly when the
user logged using the user block from within a subdirectory.  Patch by Ulf Rompe.
2003-06-11 20:42:31 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 75a44994cd - Bugfix: an administrator could not edit the avator through the admin interface because it used the global $user object inside its functions rather then the user to be edited. Patch by Matt Westgate. 2003-06-10 19:21:05 +00:00
Dries Buytaert cf5a17ca0d Patch be Matt Westgate:
- Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.

- Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
2003-06-10 19:00:48 +00:00
Dries Buytaert 222e1e5583 - Documentation improvements: improved and updated the block module documentation. Patch #44 by Al. We should add some real-life path examples!
- Fixed the "blog it" image size.  Patch #49 by Al.

- Some SQL performance improvements to the forum module.  This should also be more PostgreSQL safe.  Patch by me.

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.63 sec

changed to:

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.00 sec
2003-06-10 17:33:43 +00:00
Dries Buytaert b0081e5ac9 - Bring back the "blog it" icon. Patch #47 by Al. Thanks.
(I don't like the suggested icon so I suggest we continue to use the existing one, which I don't like either but oh well.  Thoughts?)
2003-06-08 19:31:27 +00:00
Dries Buytaert 54ddba4eea - Fixes CSS for archive calendar so that you can make non-link days padded
in a sensible fashion. Also removes table width 100% and puts that in css.
  Patch #48 by Al.
2003-06-08 19:26:26 +00:00
Dries Buytaert 643d2731e7 - Fixed two broken links in the "administration > content management >
post overview" page.
2003-06-08 17:40:13 +00:00
Dries Buytaert d80557672c - Made it possible to link search results. Patch by Ax.
- Removed some high ASCII characters from the code.  Patch by Ax.
2003-06-08 17:17:53 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 49ebc543b7 - Fixed various forum module queries such that they work with PostgreSQL. 2003-06-08 12:02:37 +00:00
Dries Buytaert d4ec431b44 - Bugfix: fixed approval e-mail and tidied up the e-mail handling. Patch #43 by
Al.  Fixes bug #1828.
2003-06-08 10:12:46 +00:00
Dries Buytaert 1aa341881d - Bugfix: added trailing slash to URL. Patch #39 by Al. Fixes bug #1848. 2003-06-08 08:39:28 +00:00
Steven Wittens e1adc0f780 Fixed some typoes... 2003-06-08 01:19:37 +00:00
Dries Buytaert ae45b735d3 - Bugfix: clicking the "Login" button after having created the first user
redirected you to an incorrect page.  Patch by Moshe.
2003-06-07 21:35:45 +00:00
Dries Buytaert 23423b46fb - Check the destrination URL before redirecting. 2003-06-07 15:59:49 +00:00
Dries Buytaert 2fc741867d - Bugfix: if you clicked on an archive date in the calendar block and
then select a new date via the form the block still displays the
  original click as the "selected" date.  Patch by Craig Courtney.
2003-06-07 06:08:52 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 47ba929ce2 - Removed a redundant check_input(). 2003-06-06 21:09:55 +00:00
Dries Buytaert 8f783f69dd - Removed a redundant check_query().
- Removed a bogus check_input().
2003-06-06 21:06:08 +00:00
Dries Buytaert 48bf7db71c - Bugfix: removed redundant check_input()s such that quotes are handled
properly.  You couldn't use a username or passwords that had quotes.
2003-06-06 20:52:21 +00:00
Dries Buytaert 2719ebde86 - Bugfix: fixed problem when register globals is turned off. Patch 0037.poll.register_globals.patch by Al.
(Can't we make the result URL look nicer?)
2003-06-06 18:22:21 +00:00
Dries Buytaert 3436c02c81 - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
Gerhard's patch was not 100% correct and I found a better alternative.
2003-06-06 17:30:09 +00:00
Dries Buytaert 1e7ef0cf21 - WOOOT! Patch by Al. 2003-06-06 04:38:11 +00:00
Dries Buytaert 3cf82a4eee - Bugfix: removed call to dead function. Patch by Al. Bug #1852. 2003-06-05 22:07:09 +00:00
Dries Buytaert 56e3e7d4a9 - Usability improvements: in the calendar, only add a link for days on which
new nodes have been posted.  Patch by Al.

  Al: I modified the query slightly - it will check whether 'status = 1'.
2003-06-05 21:34:56 +00:00
Dries Buytaert 522ed4d64c - More charset patches by Al. 2003-06-05 21:26:27 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert 31c36b7f54 - Fixed some translation bugs in the profile module. (I wasn't going to
commit this yet but I accidentically did so now I've cleaned it up.)
  Original patch by Matt.  Thanks for spotting the t() problem Al.
2003-06-03 19:13:19 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 54774aa825 - Removed the module field from the locale search form. It won't work and
there is no easy replacement.

- Wrapped the strings in htmlentities() such that one can see the HTML.
2003-06-02 20:54:37 +00:00
Dries Buytaert 85d22f3e82 - Fixed the blog it link to work with register globals off. Patch by Al. 2003-06-02 18:11:54 +00:00
Dries Buytaert c8b646320d - Resized two textfields for UI consistentcy. Patch by Stefan. 2003-06-02 18:09:07 +00:00
Dries Buytaert e5033fe1cf - Fixed critical bug #1788: cloud module pings too much. Modified patch by
Kjartan.

  This update requires some database changes so make sure to run update.php.
2003-06-01 06:46:55 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00
Dries Buytaert 5e2ce07616 - Documentation fixes by Kjartan. 2003-05-31 23:05:18 +00:00
Dries Buytaert 9b82630eaf - Bugfix: the forum module's "view" function should also call check_output(). 2003-05-31 16:30:21 +00:00
Dries Buytaert 39f6a9e79a - CSS improvements to the calendar of the archive module. Updated the Xtemplate
theme and theme Marvin to take advantage of this.  Patch by Al.  Pretty stuff.
2003-05-31 12:42:02 +00:00
Dries Buytaert b7a0a744c6 - Committed Al's rollback fixes and the title improvements. Thanks again. 2003-05-31 12:34:11 +00:00
Dries Buytaert c5637a0a02 - Small usability improvement by Al. 2003-05-31 12:21:07 +00:00
Dries Buytaert 34b51897d2 - Better CSS for the poll module. 2003-05-30 21:40:41 +00:00
Dries Buytaert 2aa762436f - Fixed a warning. Patch by Jacobo Tarrio. 2003-05-30 14:58:44 +00:00
Dries Buytaert adc5ab2f5a - Fixed bug 1763: changing comment preferences now works again. Tested with
authenticated and anonymous users.  Patch by Marco.
2003-05-30 11:13:53 +00:00
Dries Buytaert ed1a9cbfa7 Patch by Al:
- Made the import module use theme_item_list() instead of emitting the HTML
  and CSS itself.

- Renamed the "blog-it" tag to "icon" so it can be used for other (but
  similar) purposes.
2003-05-30 05:53:10 +00:00
Dries Buytaert 52e6ff8003 - "Administration overview" -> "sitemap" 2003-05-29 19:06:41 +00:00
Dries Buytaert e39cfcd22b - More CSS updates and fixes. Patch by Al. 2003-05-29 15:36:17 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert 3cebcdf636 - Fix for bug #1779a: all posts posted through the Blogger API where authored
by the anonymous user.  Thanks thorpexmachine and Al.

- Fix for bug #1779b: bloggerapi_user_blogs() returned broken link.  Thanks
  thorpexmachine and Al.

http://drupal.org/node/view/1779
2003-05-29 08:25:36 +00:00
Dries Buytaert c3119d1f18 - My filter commit accidentically broke the comment submission which is now
fixed.  Patch by Al.
2003-05-29 08:21:00 +00:00
Dries Buytaert c7bc17103a - Fixed braino. Reported by Remco as bug #1787. 2003-05-28 15:07:25 +00:00
Dries Buytaert c74f65a968 - Bugfix: assure that taxonomy_term_node_counts() only takes published nodes
into account.  Patch by Moshe.
2003-05-27 06:55:20 +00:00
Dries Buytaert b9e8016fc1 - Fixed validate problem. Patch by Ax. 2003-05-26 21:31:18 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 1cdda38df7 - Fixed typo. Patch by Al. 2003-05-25 20:24:59 +00:00
Dries Buytaert 102cbe5ee2 - Undid Kjartan's latest change (it breaks the feeds) and fixed it properly. 2003-05-25 07:08:21 +00:00
Kjartan Mannes 94fd74096c - Moved the theme("header") call in node_page outside the access check so the
page renders properly when a user does not have access to content.
2003-05-24 23:13:58 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert d592f76565 - Changed "user blogs" to "blogs". Patch by Al. 2003-05-24 07:09:49 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert 5bd07f4bb2 - Fixed search module bug. Patch by Michael. 2003-05-23 17:59:25 +00:00