Commit Graph

197 Commits (9000f825cc63e6b52ad4f19f633d67aa16fef799)

Author SHA1 Message Date
Dries Buytaert 36bb57555c - table(...) -> theme("table", ...) 2003-11-13 19:52:54 +00:00
Dries Buytaert 951b553a98 - Committed stage 2 of the theme system improvements! Patch by CodeMonkeyX. 2003-11-09 23:27:22 +00:00
Dries Buytaert 92995414b4 - Committed stage 1 of the menu callbacks improvements. Patch by Jonathan. 2003-11-08 09:56:22 +00:00
Dries Buytaert ef0fa006ed - Usability improvement: replaced many selection boxes by radio buttons.
Patch by Stefan.
2003-11-07 19:03:35 +00:00
Dries Buytaert eb95d6d7fc - Bugfix: fixed typo in cloud module. Patch by Marky.
- Bugfix: fixed menu glitch in book module.  Patch by Kjartan.
2003-11-03 08:59:39 +00:00
Dries Buytaert 8806f4c564 - Bugfix: fixed problem with book outlines. Reported by Mark Cheverton. 2003-10-23 12:13:51 +00:00
Dries Buytaert d5920c6278 - Bugfix: fixed book module links. Fixed bug #3621. Patch #132 by eafarris. 2003-10-21 16:11:12 +00:00
Dries Buytaert e688dfe6db - Fixed prefix problem with the book module. Patch by Moshe.
- Usability improvements to the user module: removed some redundant menu
  items by taking advantage of the column sorting, added status messages
  and so on.  Patch by Moshe plus some fixes.

- Made the profile module use the table() function.  Patch by Moshe.

- Fixed breadcrumb spacing.  Patch by Moshe.

- Fixed colspan problem with node overview table.  Patch by Stefan.

- Fixed inconsistency with table sorting.  Patch 0122 by Al.
2003-10-13 19:18:39 +00:00
Dries Buytaert c65d1da880 - Fixed some link titles that were no longer correct due to the menu
changes.

- Fixed some broken links.
2003-10-09 21:51:57 +00:00
Dries Buytaert 1a5fcacdd9 - Committed part 3 of Michael's help system improvements: removed the $help
parameter from the menu() function.
2003-10-09 18:53:22 +00:00
Dries Buytaert 22c889e7c0 - Help system improvements: eliminated the _system hook. Patch by Michael.
- Bloggerapi module fixes.  Patch by Kjartan.

- Coding style fixes.  Patch by Michael.
2003-10-07 18:16:41 +00:00
Dries Buytaert 9632b0b00f - Fixed book preview problem. Patch by Kjartan. 2003-10-06 08:53:17 +00:00
Dries Buytaert 058971c33b - Help improvements and translation improvements from Michael. Thanks! 2003-10-03 14:55:27 +00:00
Dries Buytaert a4c84bbe3d - Bugfix: made printer-friendly pages work. They were rendered but never
printed.
2003-10-02 17:58:47 +00:00
Dries Buytaert 32e8d77cd6 - Associate a callback with the menu links! (This callback is not yet being
called but will be as soon the remaining links have been transformed to use
  the menu system.)

- Made sure the menu does not render links with no callback and no children.
  Like this, the 'create content' link is not being shown when the user has
  no permission to add any content.
2003-09-28 17:53:04 +00:00
Dries Buytaert 069e1bb87b - More translation fixes for the menu items. Patch by Gabor. 2003-09-28 17:07:46 +00:00
Dries Buytaert 2fe79310df - Rewrote the most of the menu system; this fixes Al's problem with the
"create content" link.

- Manually merged the user module's new menu items.  Al's patch did not
  apply.

- Added some missing t()s.
2003-09-28 10:51:40 +00:00
Dries Buytaert fe09d5a786 - Committed Al's new admin link texts. Remarks:
1) As explained by Al, there is still a glitch with the 'create content'
     menu.
  2) The user module part of the patch did not apply due to Kjartan's earlier
     patch.
2003-09-27 06:00:43 +00:00
Dries Buytaert f104d3cc12 - Committed the admin menu integration patch. Thanks Adrian, Stefan and others. 2003-09-26 10:04:09 +00:00
Dries Buytaert 00a62647bc - Committed Nick's _content improvements. 2003-09-20 15:11:41 +00:00
Dries Buytaert 2fbc7fcf27 - Committed a partial administration page integration patch. 2003-09-19 07:41:55 +00:00
Dries Buytaert 93e6513ebc - Fixed typo. Patch by Nick. 2003-09-16 10:38:34 +00:00
Dries Buytaert d9cb4522bd - Book module improvements. This commit changes the behavior of the "view"
hook.  See mailing list for details; search for a mail with the subject:
  '[IMPORTANT] behavior of "view" hook changed'.  Modified patch from Nick.
2003-09-15 15:58:20 +00:00
Dries Buytaert d81f159c63 - Committed Nick's path improvements; you can now control the look and feel
of the breadcrumb navigation.
2003-09-11 17:53:45 +00:00
Dries Buytaert c485b54555 - Fixed a number of small user experience inconsistencies pointed out by
Keith.
2003-08-23 10:11:10 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 5c40037c8e 1) Bugfix: changed INNER JOIN to LEFT JOIN to make forum topics with no comments show on the topic overview page.
2) Beautified the forum module views; rewritten to use the table() rendering functions, X HTML-ified the emitted code, added additional CSS tags, and removed hard-coded markup.  This improves themeabality; it should be able to mimic the view and color scheme of, say, http://www.phpbb.com/.

3) Reorganized forms and links (interactive elements) to improve usability.  Also ensured that the link names and page titles match.

4) Temporary removed container functionality: this simplified the work and eliminated some usability issues.
2003-08-15 15:17:23 +00:00
Dries Buytaert c25bc33181 - Usability improvements based on Keith Instone's suggestions:
* Removed 'handbook' title.

   * Added a 'books' link to the book location bar: the link takes you to
     the book overview page.

   * Renamed a few 'collaborative books' to 'books' so that the links and
     page/box titles match.
2003-08-13 07:24:14 +00:00
Dries Buytaert 4131b785f7 - Help system improvements from Michael. 2003-08-05 18:33:39 +00:00
Dries Buytaert 337b3c9de9 - Committed a slightly modified version of Slavica's table prefix patch. 2003-07-10 17:46:44 +00:00
Dries Buytaert cd150ba731 - Improvement: made it easier to translate the book outline. Patch #67 by
Stefan.
2003-07-08 09:48:29 +00:00
Dries Buytaert dc15ba06e0 - Improvement: don't perform XSS checks for trusted users. Trusted users
are those that have the "bypass input data check" permission set.  Should
  address bug #2147.

- Improvement: simplified index.php and modules/admin.module.

- Bugfix: fixed broken links in bloggerapi documentation.  Patch by Chris
  Johnson.  Fixes bug #2030.

- Bugfix: fixed the date shown on a book module preview.  Reported as part
  of bug #2097.

- Bugfix: fixed broken URL in the book module documentation.
2003-07-01 17:54:22 +00:00
Dries Buytaert 828ba66500 - Bugfix: fixed utf-8 problem for people that use PHP 4.2.x or below. Patch #33 by Al.
- Bugfix: fixed translation problems in the user module and the block module.  Patch by Stefan.

- Improvement: made it impossible to delete user role #1 and #2.  Patch #38 by Al.

- Improvement: fixed the "Allowed HTML tag" issues.  Makes for better code and improved usability.  Patch #35 by Al.

  NOTE: as soon the compose tips make their way into CVS, most of this code can be removed.
2003-06-19 17:26:27 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Steven Wittens e1adc0f780 Fixed some typoes... 2003-06-08 01:19:37 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert 7e8aa5268b - Fixed bug in book_prev(). Patch by Andy Colson.
- Book optimizations: updated to use inner joins.  Patch by Andy Colson.
  This should address bug #1373.

  TODO: add index to MSSQL database scheme.
2003-05-18 16:43:56 +00:00
Dries Buytaert 460b902d70 - Added a couple of checks to avoid pg_atoi problems using PostgreSQL.
Reported by Michael Frankowski.
2003-05-13 21:34:39 +00:00
Dries Buytaert bf300292da - Made the teaser work for HTML book pages. Patch by Nick. 2003-05-13 20:17:14 +00:00
Dries Buytaert 0215c5032f - The book_admin_orphan() function is using the table() function to render
the orphan pages.  Patch by Nick.

- The "printer-friendly link" is only shown when the book page is not on
  the main page.  Patch by Nick.
2003-05-13 19:05:02 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert a956de78b9 - Fixed some PHP "notices". 2003-04-21 14:55:03 +00:00
Dries Buytaert e6cf829ece - Bugfix: show the 'printer-friendly version' link for everybody not just for
people with the update book permission.  Patch by Nick Berendsen.
2003-04-21 07:29:26 +00:00
Dries Buytaert bbab043785 - Made book_tree_recurse() emit code that validates as XHTML. Patch by Nick
Berendsen.
2003-04-14 21:03:59 +00:00
Dries Buytaert cb2d27c78d - Patch by Ax. Fixed some syntax errors:
-    case t("whatever");
    +    case t("whatever"):
2003-04-04 06:17:02 +00:00