Commit Graph

400 Commits (8b0a91f6027b7d74cd78541bcb0b7e7b8cd3c1ec)

Author SHA1 Message Date
catch 96d4338074 Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls to drupalPostForm(NULL, ...) to submitForm 2020-11-23 14:35:28 +00:00
catch f32886bfdc Issue #3180674 by Pooja Ganjage, paulocs, penyaskito, tim.plunkett: layout_builder_overrides_test test module is unused 2020-11-16 17:56:46 +00:00
catch 1d6e7e25d5 Issue #2851394 by GoZ, hgunicamp, oknate, jungle, wolffereast, tameeshb, mmatsoo, ridhimaabrol24, jofitz, swarad07, tanc, shaktik, dimaro, shashikant_chauhan, MerryHamster, quietone, nitesh624, martin_q, boaloysius, gaurav.kapoor, nitvirus, ankithashetty, Munavijayalakshmi, kostyashupenko, leolando.tan, amit.drupal, ravi.shankar, akashkrishnan01, Swapnil_Kotwal, Saviktor, mrinalini9, anmolgoyal74, Venkatesh Rajan.J, shimpy, lomasr, Dinesh18, shubham.prakash, mahtab_alam, markdorison, cilefen, longwave, bleen, xjm, alexpott, gmaltoni: Fix grammar 'a' to 'an' when necessary 2020-11-13 14:25:11 +00:00
Alex Pott 0eec7fe50d
Issue #3138746 by jungle, rajandro, sja112, longwave, jameszhang023, quietone, dww: Fix 45 "shouldBeCamelCased" and related typos in core 2020-11-09 11:14:31 +00:00
catch 9a28c1a7f6 Issue #3174928 by alexpott, andypost: Improve the stability of core JS testing and prepare for update of MinkSelenium2Driver 2020-10-29 18:19:17 +00:00
catch 3d7dd76cdf Issue #3037436 by alexpott, jonathan1055, Wim Leers, catch, tedbow, longwave: [random test failure] Make QuickEditIntegrationTest more robust and fail proof 2020-10-26 08:52:48 +00:00
Alex Pott 8e416f130c
Issue #2918149 by harpreet16, tim.plunkett, raman.b, anil.gangwal, dalin, grndlvl, nikunjkotecha, kalyansamanta, paulocs, ranjith_kumar_k_u, froboy: "This block is broken or missing..." should only be shown to users that have access to do something about it 2020-10-22 12:34:11 +01:00
catch 89f6acb734 Issue #3174884 by raman.b, alexpott, lauriii, zrpnr, nod_: Update yarn dependencies for Drupal 9.1.0 2020-10-21 11:41:33 +01:00
Alex Pott bc0cbe87cb
Issue #2273381 by clayfreeman, tim.plunkett, andypost, dawehner, EclipseGc, jungle, xjm, alexpott, Berdir: Convert ContextAwarePluginBase to traits 2020-10-16 16:02:33 +01:00
catch 484d80dbb9 Issue #3172438 by mondrake, kishor_kolekar, longwave, NitinLama, mikelutz, jungle: Since symfony/phpunit-bridge 5.1: Using "@expectedDeprecation" annotations in tests is deprecated, use the "ExpectDeprecationTrait::expectDeprecation()" method instead 2020-10-15 15:00:17 +01:00
catch b94f170f8a Issue #3069578 by danflanagan8, YurkinPark, ayushmishra206, andersen_ti, waspper, tim.plunkett, Anybody, Regnoy, larowlan: Layout builder doesn't show new "extra fields" 2020-10-08 16:43:50 +01:00
Alex Pott 75acedefef
Issue #3162008 by catch, mikelutz, Hardik_Patel_12, longwave: Prepare for EventDispatcherInterface::dispatch() return type hint 2020-10-01 13:25:41 +01:00
Lee Rowlands 6ffbfe25f3
Issue #3126746 by danflanagan8, Deepak Goyal, Neslee Canil Pinto, geek-merlin, tim.plunkett: LayoutBuilderHtmlEntityFormController breaks decoration 2020-09-29 14:31:04 +10:00
catch 3e0f0155a4 Issue #3131186 by mondrake, Vidushi Mehta, longwave, paulocs, xjm: Replace assertions involving calls to drupalGetHeader() with session-based assertions, where possible 2020-08-28 15:08:46 +01:00
Lee Rowlands 109fe60843
Issue #3053887 by Sam152, Lal_, fenstrat, acbramley, tedbow, larowlan: Add test coverage and document why inline blocks require a new revision to be created when modified, regardless of whether a new revision of the parent has been created 2020-08-18 09:16:31 +10:00
Alex Pott faabcf1373
Issue #2664322 by benjifisher, dawehner, daffie, almaudoh, mradcliffe, catch, quietone, alexpott, larowlan: key_value table is only used by a core service but it depends on system install 2020-08-07 21:36:13 +01:00
Lee Rowlands 84bae9dac3
Issue #3161300 by jungle, TR, Hardik_Patel_12, Chris Burge, longwave, Kristen Pol: Improve test coverage of \Drupal\Tests\layout_builder\Unit\SectionTest::testUnsetThirdPartySetting() 2020-07-31 13:30:36 +10:00
Alex Pott e77ca8b3b1
Issue #3143635 by b_sharpe, tim.plunkett, alexpott: Change Layout Preparation into an Event to allow proper alterations 2020-07-21 21:34:41 +01:00
Alex Pott 1dfbbd88b7
Issue #3159531 by jameszhang023, ipumpkin, jungle, longwave: Fix typos: "attibute|uneccesarilly|colletion|constucts|worklow" in core 2020-07-17 08:25:33 +01:00
Alex Pott 57af0a04c1
Issue #3091309 by tim.plunkett, godotislate, paulocs, thursday_bw, alexpott, TwiiK: Broken context-aware block plugins throw an unexpected exception 2020-07-16 22:34:03 +01:00
Alex Pott 3b8e432648
Issue #3055198 by catch, longwave, mikelutz, alexpott: [Symfony 5] Symfony/Component/EventDispatcher/Event is deprecated in Symfony 4.3 use Symfony/Contracts/EventDispatcher/Event instead 2020-07-14 11:46:12 +01:00
Alex Pott bd4c5f075f
Issue #3055194 by catch, mikelutz, longwave, mkalkbrenner, hchonov: [Symfony 5] The signature of the "Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch()" method should be updated to "dispatch($event, string $eventName = null)", not doing so is deprecated since Symfony 4.3 2020-07-14 10:08:00 +01:00
catch 207fb2b303 Issue #3155761 by Hardik_Patel_12, longwave: Replace assertions involving calls to stristr() with assertStringContainsString() 2020-07-13 12:46:25 +01:00
Alex Pott 700a6ab9d9
Issue #3089961 by tim.plunkett, Deepak Goyal, Lal_, ravi.shankar, tedbow: assertOffCanvasFormAfterWait() doesn't check for the correct form ID 2020-07-07 14:35:25 +01:00
catch a050029323 Issue #3135538 by mondrake, longwave, jungle: Replace remaining assert* involving use of count() where relevant 2020-07-02 13:16:28 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
xjm 7ff11794e5 Issue #2821499 by jungle, Andy_D, nikitagupta, lomasr, bbombachini, alexpott, andypost, Mile23, quietone, Sophie.SK, mtodor, barone, kuldeep_mehra27, vsujeetkumar, swatichouhan012, jhodgdon: Enable phpcs rule DrupalPractice.InfoFiles.NamespacedDependency 2020-05-19 13:54:06 -05:00
catch 421c588c16 Issue #3131343 by mondrake, dww, jungle: Replace assertions involving calls to in_array() with assertContains()/assertNotContains() 2020-05-11 09:10:55 +01:00
catch 5777f8f595 Issue #3101891 by tim.plunkett, zrpnr: Allow layout plugins to define default values for column widths 2020-05-07 19:34:37 +01:00
catch 40a5bd7e0a Issue #3126965 by jungle, quietone, longwave, mondrake, dww: Replace assert* involving count() and an integer literal with assertCount() 2020-05-07 19:07:00 +01:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
catch 5132c83fac Issue #3082415 by Krzysztof Domański, mondrake, alexpott, longwave, jungle: Replace assert(Not)Same/Identical() on booleans with assert(Not)True/False() in PHPUnit tests 2020-04-17 16:00:07 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 6108526c9c
Issue #3113077 by mondrake, Hardik_Patel_12, Neslee Canil Pinto, swatichouhan012, prabha1997, neelam_wadhwani, Berdir, longwave: Replace assertContains() on strings with assertStringContainsString() or assertStringContainsStringIgnoringCase() 2020-04-12 12:34:00 +01:00
xjm 4c453683e4 Issue #3106666 by catch, jungle, xjm, alexpott, tim.plunkett, Berdir: Remove post updates added prior to 8.8.0 2020-03-11 15:58:38 -05:00
Alex Pott f7a4b4b418
Issue #3045171 follow-up by alexpott: Form blocks rendered inside layout builder break save 2020-02-25 10:27:37 +00:00
Alex Pott 0a16b0f112
Issue #3045171 by godotislate, rlmumford, bnjmnm, ccasals, bkosborne, johndevman, shimpy, Madhura BK, phjou, xaqrox, a3hill, tim.plunkett, gnuget, grahamC, kualee: Form blocks rendered inside layout builder break save 2020-02-25 09:14:40 +00:00
Alex Pott 984f549d7f
Issue #3108640 by godotislate, tim.plunkett: Entity reference field blocks not bubbling cache metadata when view access to referenced entity is not allowed 2020-02-24 13:33:02 +00:00
Alex Pott 2957b44ca6
Issue #3072744 by twfahey, swatichouhan012, tim.plunkett: "Add a new inline block" title on settings tray doesn't match "Custom block" 2020-02-24 09:37:37 +00:00
Alex Pott 8e37bfb03f
Issue #3088077 by Sam152, bkosborne, rensingh99, tim.plunkett: Layout builder does not correctly bubble up cache metadata for empty blocks 2020-02-13 09:31:58 +00:00
catch 6ef456a287 Issue #3108252 by pratik_kamble, Hardik_Patel_12, rogerpfaff, nishantghetiya: Remove unused variables from layout builder module 2020-02-06 17:57:56 +00:00
catch 534ee0d39d Issue #3086374 by mondrake, alexpott, joseph.olstad, Spokje, ravi.shankar, Gábor Hojtsy, heddn, Charlie ChX Negyesi, amateescu: Make Drupal 9 compatible with PHP 7.4 2020-02-04 16:24:45 +00:00
catch 7acaffe529 Issue #2984509 by Falco010, tbsiqueira, tim.plunkett, johndevman, jdleonard: $delta is passed as string and not integer 2020-02-03 16:19:38 +00:00
Alex Pott 4577772da0
Issue #3101543 by lauriii, bnjmnm, ravi.shankar, alexpott: Update core JavaScript dependencies listed in package.json 2020-01-30 09:08:38 +00:00
Alex Pott 5b657b15b8
Revert "Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json"
This reverts commit 2dadb738bf.
2020-01-28 13:14:16 +00:00
Alex Pott 2dadb738bf
Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json 2020-01-28 11:36:14 +00:00
catch 720924f719 Issue #2893804 by Wim Leers, Stefdewa, Berdir, catch: Remove rest.module BC layers 2020-01-27 17:41:43 +00:00
catch e1a041c493 Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, xjm, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-24 23:52:03 +00:00
Lee Rowlands 2e53ac1699
Revert "Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88**"
This reverts commit 136f055066.
2020-01-22 10:30:15 +10:00
Lee Rowlands 136f055066
Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-22 09:33:30 +10:00
webchick e3873ccd41 Issue #3096034 by tim.plunkett, zrpnr: Allow customization of the list of layouts 2019-11-25 10:39:42 -08:00
catch d6694e2335 Issue #3088492 by tim.plunkett: Remove deprecated code from Layout Builder 2019-11-22 09:58:15 +00:00
Alex Pott a22c3c4580
Issue #3090174 by tim.plunkett, henriklarsson: Data attribute 'layout-content-preview-placeholder-label' exists outside LB UI 2019-11-15 21:39:03 +00:00
Alex Pott 2a009c5edd
Issue #3048498 by jonathan1055, Lendude, naveenvalecha, klausi, alexpott, Gábor Hojtsy: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard 2019-11-14 09:08:15 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
Lauri Eskola 4fb98eb269
Issue #3064049 by zrpnr, lauriii, bnjmnm, finnsky, alexpott, tedbow, phenaproxima, Wim Leers, xjm, Berdir, sasanikolic, justafish, larowlan: Replace jQuery UI sortable with Sortable js 2019-11-01 02:21:14 +02:00
catch bc6aabc9cd Issue #3087692 by Wim Leers, alexpott: Remove the core key from views configuration 2019-10-22 20:40:16 +01:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
webchick 3003cc65d8 Issue #3073872 by tim.plunkett, starshaped, webchick, phenaproxima, worldlinemine, AaronMcHale, jrockowitz, ckrina: Allow for Layout Builder sections to be given administrative labels 2019-08-23 11:30:10 -07:00
catch a2d8c0a816 Issue #3065474 by tim.plunkett, jeremyr, omkar06: An error occurs when viewing an entity after removing all layout sections and Quickedit module enabled 2019-07-18 14:14:49 +01:00
catch c12498bd9e Issue #2776031 by fgm, andypost, voleger, yogeshmpawar, Berdir, joachim: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage 2019-07-12 14:15:04 +01:00
catch c164ccc1da Issue #3066245 by jeissonp: Update hook name in docblock 2019-07-11 15:38:23 +01:00
catch 63148faa02 Issue #3020572 by mark_fullmer, bkosborne, tim.plunkett: Layout builder block for extra fields should appear in "Content Fields" category and not "Content" 2019-06-28 09:56:29 +01:00
Lee Rowlands 90534acefb
Issue #3001313 by bnjmnm, tim.plunkett, bobbygryzynger, Cyberschorsch, yogeshmpawar, mikey en, hershy.k, borisson_: Field blocks in the layout builder do not have view mode suggestions 2019-06-28 07:26:47 +10:00
Alex Pott e82e0c0573
Issue #3059090 by clepson, mondrake, alexpott: Deprecate \Drupal\Tests\PhpunitCompatibilityTrait::setExpectedException() 2019-06-11 12:38:53 +03:00
Lauri Eskola ffb1e1e553
Issue #3044366 by shaal, kjay, tim.plunkett, bnjmnm, alexpott, pawandubey, smaz, lauriii, markconroy, Gábor Hojtsy: Fix styling of Umami for layout builder 2019-06-06 17:12:34 +03:00
Lauri Eskola f8f83d5718
Issue #3050225 by smaz, shaal, kjay: Layout builder link add: Set background alignment to center 2019-06-05 14:39:31 +03:00
catch 44ffb271f1 Issue #3023220 by tim.plunkett, andyg5000, Berdir, phenaproxima, bkosborne: Performance: Prevent extra Layout Builder code from running when rendering fields in isolation (Views results, FieldBlock, etc) 2019-05-30 23:20:46 +01:00
Alex Pott 13cbe41170
Issue #3046007 by Sam152, alexpott, amateescu, tim.plunkett: In some circumstances the override field is not cleared from the field map when a bundle is deleted, resulting in a fatal error in layout_builder_post_update_make_layout_untranslatable 2019-05-30 14:08:22 +01:00
Alex Pott 408c540ccf
Issue #2886622 by Berdir, martin107, Mile23, tim.plunkett, mikelutz, jonathan1055: Deprecate all EntityManager methods with E_USER_DEPRECATED 2019-05-30 12:36:55 +01:00
Alex Pott 9a11de65fa
Issue #2892440 by bnjmnm, tedbow, alexpott, Krzysztof Domański, Lendude: Provide helper test method to wait for an element to be removed from the page 2019-05-25 09:25:44 +01:00
catch e46168f2dc Issue #3056536 by alexpott, tedbow: LayoutBuilderDisableInteractionsTest randomly fails 2019-05-24 11:25:35 +01:00
catch f4b3ab3a3b Issue #2901792 by alexpott, tedbow, dww, bnjmnm, jhodgdon, Krzysztof Domański: Disable all animations in Javascript testing 2019-05-22 15:28:27 +01:00
xjm c41776052c Issue #3053529 by tim.plunkett, Waxwing, portulaca: Cannot enable overrides for any bundle if another bundle has full view mode enabled 2019-05-15 11:31:16 -05:00
Alex Pott 7dfb49ba40
Issue #3052431 by amateescu, tim.plunkett: layout_builder_post_update_make_layout_untranslatable() still attempts to query all revisions for non-revisionable entities 2019-05-08 23:25:44 +01:00
Alex Pott 041895feda
Issue #3050429 by pfrenssen: Fix misspelled property "lable" in schema definitions 2019-05-06 14:23:57 +01:00
Alex Pott 1c40f14e1c
Issue #3029669 by tim.plunkett, K3vin_nl, mpdonadio: Layout Builder must adjust #states for formatters written expecting to be used by the Field UI 2019-04-23 11:23:06 +01:00
Alex Pott e1838d0272
Issue #3010825 by mark_fullmer, tim.plunkett, tedbow, johndevman: Back to site link returns user to manage layout for defaults 2019-04-23 11:14:53 +01:00
xjm 82bba2741a Issue #3018073 by tim.plunkett, kostyashupenko, mark_fullmer, johndevman, JacobSanford: Stop Using Title Case When Not Appropriate in Layout Builder UI 2019-04-22 12:09:53 -05:00
Alex Pott 7ca5921520
Issue #3019824 by nord102, tim.plunkett: Layout Builder's isOverridable()/setOverridable() do not respect the result of isLayoutBuilderEnabled() 2019-04-20 09:55:20 +01:00
Alex Pott 518e8fff0c
Issue #2955065 by tim.plunkett, phenaproxima, pixlkat, andypost, mtodor, dmsmidt: Customized layout does not display for node with customizations enabled when using full content view mode 2019-04-19 13:11:32 +01:00
Alex Pott ee1d667241
Issue #3040645 by mark_fullmer, tim.plunkett, porkloin, xjm, andrewmacpherson, mgifford: Add a role=region wrapper to the Layout Builder action form to fix screen reader navigation barriers 2019-04-19 12:50:34 +01:00
Francesco Placella 835ba7fcce Issue #3048950 by catch, bkildow, alexpott: layout_builder_post_update_make_layout_untranslatable() attempts to query all revisions for non-revisionable entities 2019-04-18 12:43:50 +02:00
catch f2eaf0178c Issue #3041985 by alexpott, pifagor: Add Generic.CodeAnalysis.EmptyPHPStatement to phpcs rules to prevent empty PHP statements 2019-04-16 21:22:07 +09:00
Alex Pott 9bd884d5cd
Issue #3041375 by lauriii, johndevman, yogeshmpawar, bnjmnm: Convert behaviors.layoutBuilderBlockDrag to use js- prefixed classes for attaching behaviors 2019-04-15 05:44:56 -07:00
Alex Pott cf3d779799
Issue #3042216 by johndevman, lauriii, tim.plunkett: Only add .layout-builder-block to blocks when in the Layout Builder UI 2019-04-13 15:25:59 -07:00
Alex Pott 8ea7023787
Issue #2994947 by dead_arm, mark_fullmer, alexpott, kostyashupenko, brad.bulger, tim.plunkett, PCate: Add RTL CSS to Layout Builder 2019-04-13 10:23:21 -07:00
Alex Pott b77d870b29
Issue #3018021 by tim.plunkett: Rename $id parameter to $type in SectionStorageManager 2019-04-12 16:51:01 -07:00
Gábor Hojtsy 060c85c509 Issue #3043228 by shaal, kjay, bnjmnm, tim.plunkett, Gábor Hojtsy: Add Umami-specific styling for Layout Builder messages 2019-04-05 07:38:15 +02:00
Lauri Eskola 9a4a499f07
Issue #3024527 by alexpott, markconroy, waako, occupant: Add and configure stylelint-order 2019-04-01 20:16:16 +03:00
xjm 0d4af63275 Issue #3044417 by tim.plunkett: Move custom Layout Builder icons to core/misc 2019-03-29 11:00:00 -05:00
xjm fab8d1e741 Issue #3041053 by tim.plunkett, tedbow, xjm, larowlan, phenaproxima, webchick, effulgentsia, DyanneNova, Sam152, lauriii, dead_arm, bnjmmn, balsama: Mark Layout Builder as a stable module 2019-03-28 16:35:39 -05:00
Lee Rowlands a83655a47c
Issue #3043646 by tedbow, lauriii, bnjmnm, xjm, tim.plunkett, effulgentsia, DyanneNova, webchick: For sites that have made layout overrides prior to 8.7.0 or sites that manually enable translation of the layout override field, add UI warnings 2019-03-28 16:39:30 +10:00
xjm a10a712f2e Issue #3043825 by tim.plunkett, johndevman, phenaproxima: Create an interface for LayoutBuilderSampleEntityGenerator 2019-03-27 19:00:37 -05:00
xjm f4f6026156 Issue #3043797 by tim.plunkett, johndevman, phenaproxima: Create an interface for InlineBlockUsage 2019-03-27 18:54:56 -05:00
xjm d28a92f7bb Issue #3043687 by phenaproxima, tim.plunkett, johndevman: Layout Builder's Quick Edit integration causes fatals when using field blocks for entities other than the one being viewed 2019-03-27 18:37:00 -05:00
effulgentsia 99382fb84b Issue #3043651 by tedbow, plach, tim.plunkett, effulgentsia, xjm: Update the Layout field to non-translatable when possible 2019-03-27 14:55:14 -07:00
Lee Rowlands d9e9f0c461
Issue #2995893 by tim.plunkett, Dylan Donkersgoed: Layout builder chokes on form exceptions that are part of natural form processing 2019-03-28 07:51:02 +10:00
effulgentsia cbf7788676 Issue #3041659 by tedbow, tim.plunkett, amateescu, plach, xjm, effulgentsia, Wim Leers, webchick: Remove the layout tab from translations because Layout Builder does not support translations yet 2019-03-26 21:47:30 -07:00
xjm e9c89de011 Issue #3042089 by bnjmnm: Update Layout Builder functional javascript tests now that local tasks are not required by the UI 2019-03-26 17:30:19 -05:00
webchick 687cf58de5 Issue #2914486 by tim.plunkett, tedbow, bendeguz.csirmaz, twfahey, bnjmnm, xjm, effulgentsia, Kristen Pol, benjifisher, larowlan, webchick, rainbreaw, jrockowitz, Gábor Hojtsy, ckrina: Add granular permissions to the Layout Builder
(cherry picked from commit d05d67fede)
2019-03-25 23:00:03 -07:00
effulgentsia d0ec4df02d Issue #3042198 by Wim Leers, tim.plunkett, phenaproxima, xjm: Add JSON:API integration test for LayoutBuilderEntityViewDisplay 2019-03-25 20:33:45 -07:00
xjm 195a3c9bf0 Revert "Issue #3042198 by Wim Leers, tim.plunkett, phenaproxima: Add JSON:API integration test for LayoutBuilderEntityViewDisplay"
This reverts commit 46d0fc7afd.
2019-03-25 21:32:55 -05:00
xjm 46d0fc7afd Issue #3042198 by Wim Leers, tim.plunkett, phenaproxima: Add JSON:API integration test for LayoutBuilderEntityViewDisplay 2019-03-25 18:45:06 -05:00
webchick f6b99c9d55 Issue #2959493 by bnjmnm, phenaproxima, tim.plunkett, tedbow, Adrian83, lauriii, xjm, andrewmacpherson, johndevman, KarenS, alwaysworking, jrockowitz, ckrina, cboyden, webchick, seanB, benjifisher, larowlan: Allow Layout Builder live previews to be toggled to allow easier drag-and-drop
(cherry picked from commit d028385c9c)
2019-03-25 16:27:22 -07:00
webchick 30abfa6af6 Issue #2988970 by phenaproxima, tim.plunkett, tedbow, bnjmnm, lauriii, sugaroverflow, DyanneNova, balsama, webchick, xjm, dead_arm, Gábor Hojtsy, worldlinemine: Layout Builder should make it easier to modify the default layout for an entity type when viewing an entity 2019-03-25 13:51:03 -07:00
webchick 399f5950d6 #2948828 follow-up by Wim Leers: Minor style fixes to comments. 2019-03-25 13:08:25 -07:00
webchick a22c264062 Issue #2948828 by tedbow, Wim Leers, tim.plunkett, samuel.mortenson, johndevman, Kristen Pol, webchick, phenaproxima, larowlan, dead_arm, bnjmnm: Layout Builder's Field Blocks do not work with Quick Edit 2019-03-25 13:05:39 -07:00
xjm 8d1a7d7c86 Issue #3038442 by Sam152, amateescu, tim.plunkett: Use hook_entity_form_display_alter() instead of Layout Builder's custom overrides display altering hook 2019-03-22 18:42:41 -05:00
webchick 406f483fcd Issue #2995689 by tedbow, bnjmnm, lauriii, bendeguz.csirmaz, andrewmacpherson, xjm, tim.plunkett, KarenS, alwaysworking: Allow reordering blocks without a pointer device
(cherry picked from commit a73bf047ed)
2019-03-22 14:23:41 -07:00
Lauri Eskola 40d6aca489
Issue #2994909 by bnjmnm, tedbow, kostyashupenko, tim.plunkett, lauriii, samuel.mortenson, Kristen Pol, xjm, andrewmacpherson, alwaysworking, DyanneNova, jrockowitz, worldlinemine, phenaproxima, ckrina, benjifisher, rainbreaw, webchick: Highlight active element while working with dialogs in Layout Builder 2019-03-21 23:30:38 +02:00
xjm aa091959b5 Issue #3002608 by bnjmnm, tedbow, Wim Leers, samuel.mortenson, tim.plunkett, xjm, lauriii, jibran, phenaproxima, effulgentsia: Remove contextual links not related to layout administration inside layout builder blocks 2019-03-21 11:31:53 -05:00
xjm 9985cc04b8 Issue #3041143 by tim.plunkett, cboyden, xjm, phenaproxima, rainbreaw: Add ARIA group roles to Layout Builder UI 2019-03-20 21:09:58 -05:00
xjm fe95def3b5 Issue #3041107 by tim.plunkett, Wim Leers, xjm: Remove EntityDisplaySectionsTest in favor of a full suite of REST/HAL tests 2019-03-20 14:42:49 -05:00
xjm cbef6823ee Issue #3040241 by bnjmnm, lauriii, DyanneNova: Add section and add block section doesn't have sufficient color contrast for text 2019-03-17 19:38:46 -05:00
xjm f3bafe57e5 Issue #3037129 by tim.plunkett, andrewmacpherson, phenaproxima: Use distinct accessible names for the configure-section buttons in Layout Builder UI 2019-03-15 13:50:36 -05:00
Lauri Eskola d4ddfe04de
Issue #3038413 by bnjmnm, lauriii, DyanneNova: Replace editable-area negative-offset outline with something that IE11 can handle 2019-03-15 09:20:37 +02:00
Lauri Eskola c73c8944be
Issue #3038562 by alexpott, markconroy: Update stylelint to 9.10.1 2019-03-14 10:00:17 +02:00
Alex Pott 30654bd41d
Issue #3026434 by tedbow, tim.plunkett, xjm, phenaproxima, plach, Kristen Pol, alexpott: Ensure that Layout Builder Inline Blocks doesn't assume section storage internals 2019-03-12 21:30:41 +00:00
Alex Pott 2dfe7b6d36
Issue #3016420 by tim.plunkett, EclipseGc: Allow context definition annotations to specify constraints 2019-03-08 23:03:16 +00:00
Francesco Placella 17de81c580 Issue #2942675 by tim.plunkett, Sam152, plach, phenaproxima: Layout builder should use the active variant of an entity 2019-03-06 23:46:19 +01:00
webchick e5472e4894 Issue #3037550 by bendeguz.csirmaz, tedbow, andrewmacpherson, tim.plunkett: Clarify which block or section is being removed in layout builder dialog 2019-03-06 10:50:17 -08:00
Lauri Eskola 4d6928db8e
Issue #3035669 by bnjmnm, Wim Leers, lauriii: Block contextual links intermittently ignore mouseup 2019-03-06 20:40:53 +02:00
webchick 0e83520cbc Issue #2929783 by tim.plunkett, MerryHamster, bnjmnm, xjm, webchick, samuel.mortenson, EclipseGc, kevincrafts, ndf, DyanneNova, yoroy, TheodorosPloumis, tedbow, pixelite, seanB, phenaproxima, AaronMcHale, benjifisher: Review Layout Builder UI terminology 2019-03-05 22:19:20 -08:00
webchick 9748db651e Issue #2938182 by bnjmnm, phenaproxima, DyanneNova, webchick, andrewmacpherson, xjm, tedbow, benjifisher: Design intuitive affordances for Layout Builder (for illustrating which parts of the page are editable in a given context) 2019-03-05 21:52:31 -08:00
webchick c04b1cef27 Issue #3037113 by tim.plunkett, andrewmacpherson: Replace layout builder discard-changes + revert-to-default links with buttons 2019-03-05 21:20:08 -08:00
xjm 84a06d6b6e Issue #3035554 by bnjmnm, tim.plunkett: "Configure section" link and section close button overlap 2019-03-05 17:55:01 -06:00
Gábor Hojtsy 272fdc6bf9 Issue #2999731 by tim.plunkett, r.aubin, bnjmnm, tedbow: Document Layout Builder functionality in its hook_help() text 2019-03-05 22:05:44 +01:00
Lee Rowlands 0d83597731
Issue #3030647 by tim.plunkett, phenaproxima, xjm, DyanneNova, bnjmnm, tedbow, dead_arm: Do not add a section when editing an empty layout, or differentiate between new layouts and existing empty layouts 2019-03-01 13:39:47 +10:00
xjm b3786231ec Issue #3033686 by tedbow, tim.plunkett, xjm, amateescu: Saving Layout override will revert other field values to their values when the Layout was started 2019-02-27 12:55:49 -06:00
xjm 34aa83070b Issue #2936501 by tim.plunkett, andrewmacpherson, EclipseGc, DyanneNova, bnjmnm, benjifisher, webchick, phenaproxima, jrockowitz: Reverting an override redirects the user to an edit form for a new override and therefore still sets the new override as "unsaved changes", which is confusing 2019-02-26 17:30:37 -06:00
xjm 1a945e7ea9 Issue #3034347 by dead_arm, phenaproxima, tim.plunkett, lauriii: Update the Layout Builder UI classes to implement BEM naming conventions 2019-02-26 15:13:22 -06:00
xjm eb433a87ed Revert "Issue #3033686 by tedbow, tim.plunkett: Saving Layout override will revert other field values to their values when the Layout was started"
This reverts commit 86e257b9e5.
2019-02-25 09:18:41 -06:00
Lee Rowlands 9431a1cb8e
Issue #3032376 by alexpott, dww, Berdir: Files renamed by \_file_save_upload_single() do not have the correct filename on the File entity 2019-02-25 20:45:21 +10:00
xjm d8b8a0aa26 Issue #2942661 by tedbow, tim.plunkett, bkosborne, johndevman, xjm, phenaproxima, Kristen Pol: Sections should have third-party settings 2019-02-23 15:15:16 -06:00
Lauri Eskola ef68ad6f3a
Issue #2973921 by tedbow, bnjmnm, yogeshmpawar, Kristen Pol, lauriii, alwaysworking, xjm, andrewmacpherson: Interactive controls inside preview block in the Layout Builder form should be disabled 2019-02-21 19:22:25 +02:00
xjm 72e0a4d821 Issue #2968110 by tedbow, tim.plunkett, Kristen Pol, bkosborne, andrewmacpherson: Layout Builder's ConfigureBlockFormBase forms do not display validation errors on submit 2019-02-21 08:57:29 -06:00
xjm 86e257b9e5 Issue #3033686 by tedbow, tim.plunkett: Saving Layout override will revert other field values to their values when the Layout was started 2019-02-21 08:34:34 -06:00
xjm c7f47000ee Issue #3028490 by tim.plunkett, Kristen Pol, xjm, tedbow, r.aubin, phenaproxima: Users with "configure any layout" can see entities they don't have "view" access to 2019-02-21 08:26:15 -06:00
xjm 0ab01bda64 Issue #3033691 by tim.plunkett, tacituseu: Serialized Layout Builder fixture is invalid in PHP 7.3 2019-02-21 03:41:20 -06:00
xjm 589519e59b Issue #3026698 by tim.plunkett, Kristen Pol, xjm, tedbow: Allow section storage to provide a more granular ID for tempstore 2019-02-15 02:36:35 -06:00
xjm 60bd499cf1 Issue #3019333 by tim.plunkett, julenmelgar, Ismail Cherri: If you translate the literal "inline blocks" to another language in the layout builder, it stops working 2019-02-13 16:49:20 -06:00
xjm 89a75c0780 Issue #3008927 by tim.plunkett, tedbow: The Layout Builder breadcrumbs for defaults don't lead to the view mode being edited 2019-02-13 13:51:49 -06:00
xjm ba0c245c75 Issue #2995143 by tim.plunkett, dead_arm: Remove non-functional CSS transition for .new-section 2019-02-13 12:14:35 -06:00
Lee Rowlands a9a53828a3
Issue #3004536 by tim.plunkett, tedbow, Sam152, phenaproxima, mark_fullmer: Move the Layout Builder UI into an entity form for better integration with other content authoring modules and core features 2019-02-13 14:09:13 +10:00
xjm 0a69221174 Issue #2964777 by tim.plunkett, tedbow: Method comment for \Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage::getDisplay is wrong 2019-02-12 12:26:05 -06:00
xjm f81c05e649 Issue #3023729 by tim.plunkett, bkosborne: LayoutBuilderController should iterate over components in a region using Element::children() 2019-02-11 16:13:24 -06:00
xjm d8859389a3 Issue #3028301 by tedbow, tim.plunkett, Wim Leers, xjm: Do not expose to Layout Builder's sections either in defaults or overrides to REST and other external APIs 2019-02-08 16:20:08 -06:00
Lauri Eskola 59f8c0d45d
Issue #2998862 by bnjmnm, tedbow, bendeguz.csirmaz, samuel.mortenson, starshaped, phenaproxima, lauriii, alwaysworking, andrewmacpherson: The Layout Builder block listing should be filterable 2019-02-07 12:30:04 +02:00
xjm c029270ec5 Issue #2924201 by tim.plunkett, tedbow, larowlan, xjm, jibran, Kristen Pol: Resolve random failure in LayoutBuilderTest so that it can be added to HEAD 2019-02-06 10:49:25 -06:00
xjm 4b69cc46c2 Issue #3009344 by tim.plunkett, xjm, bnjmnm: Reloading the Layout Builder while JS is available differs from when JS is not available 2019-02-04 19:53:02 -06:00
xjm 140e97ef29 Issue #3022749 by tim.plunkett, phenaproxima, bkosborne: The getDefaultSectionStorage() method on OverridesSectionStorage does not return the correct object 2019-02-04 06:34:31 -06:00
xjm ca8a550c05 Issue #3029819 by tim.plunkett, bnjmnm, tedbow, xjm: Do not allow Page Title block to be placed in Layout Builder until it works properly 2019-01-31 16:29:57 -06:00
xjm 0e165d7d0a Issue #3027938 by tim.plunkett, xjm, phenaproxima: Abstract the contents of LayoutBuilderController into a render element 2019-01-31 15:58:43 -06:00
xjm 898feb654c Issue #2999719 by mandclu, ifrik, tim.plunkett, Kristen Pol, xjm, AaronMcHale, DyanneNova, phenaproxima: Update the Layout Builder module description and clarify how it differs from Field Layout 2019-01-31 14:02:49 -06:00
xjm 1d83b5fe26 Issue #3029061 by tim.plunkett, xjm, phenaproxima, alexpott, tacituseu: New layouts are missing config schema 2019-01-31 13:27:26 -06:00
Alex Pott 6f7fe9b86b
Revert "Issue #3029061 by tim.plunkett, phenaproxima: New layouts are missing config schema"
This reverts commit f192f65bff.
2019-01-29 19:54:54 +00:00
xjm f192f65bff Issue #3029061 by tim.plunkett, phenaproxima: New layouts are missing config schema 2019-01-29 11:47:49 -06:00
xjm 06dbc81f02 Issue #2937073 by tim.plunkett, Saviktor, tedbow: Improve robustness of FieldBlockTest 2019-01-28 17:54:09 -06:00
xjm 94ac341ed9 Issue #3025870 by tim.plunkett, Kristen Pol, xjm: Cancelling changes in the Layout Builder UI should use a confirmation form 2019-01-17 16:27:23 -06:00
Alex Pott 0d2afd2960
Issue #3016829 by tim.plunkett, x11: Follow-up for intersection of #3014949 and #2968139 2019-01-13 21:47:56 +00:00
Alex Pott c00be4c49c
Issue #3020142 by mglaman, tim.plunkett: Test module no_transitions_css has invalid hook_page_attachments 2019-01-10 08:57:29 +00:00
xjm fea6c51226 Issue #3007973 by tim.plunkett, lukasss, xopoc, bnjmnm, stompersly: Layout builder prevents the rendering of extra fields (like Links) on pages not using Layout Builder 2019-01-09 15:24:56 -06:00
effulgentsia 2a8e1e0a3c Issue #2938132 followup by tim.plunkett, tacituseu: Fixed PHP 5.6 regression 2019-01-07 20:54:10 -08:00
Alex Pott 6cb2397837
Issue #2938132 by tedbow, tim.plunkett, xjm, EclipseGc, AaronMcHale, alexpott, DyanneNova: Ship layouts that make sense with Layout Builder's concept of sections 2019-01-07 22:00:47 +00:00
Alex Pott c67d4cfe6f
Issue #3022713 by tim.plunkett: Remove vestigial $sectionList properties from section storage classes 2019-01-01 13:19:14 +01:00
xjm 9065203c7b Issue #2976148 by tim.plunkett, phenaproxima, xjm, tedbow, Wim Leers, EclipseGc, larowlan, dead_arm: Layout-based entity rendering should delegate to the correct section storage instead of hardcoding to either defaults or overrides 2018-12-31 16:11:20 -05:00
Alex Pott 8bf6ee3870
Issue #3007439 by tim.plunkett, Wim Leers, xopoc: Layout builder renders Book navigation block on non-book pages 2018-12-15 22:34:30 +00:00
xjm 88ad0137b5 Issue #3016473 by tim.plunkett, xjm, tedbow, phenaproxima, EclipseGc, larowlan, samuel.mortenson: Allow a single SectionStorage plugin to be returned for a set of available contexts 2018-12-10 16:18:57 -06:00
xjm 5a929b6a1f Revert "Issue #3016473 by tim.plunkett, xjm, tedbow, phenaproxima, EclipseGc, larowlan, samuel.mortenson: Allow a single SectionStorage plugin to be returned for a set of available contexts"
This reverts commit 9c77f61ed3.
2018-12-10 15:08:32 -06:00
xjm 9c77f61ed3 Issue #3016473 by tim.plunkett, xjm, tedbow, phenaproxima, EclipseGc, larowlan, samuel.mortenson: Allow a single SectionStorage plugin to be returned for a set of available contexts 2018-12-10 12:42:37 -06:00
Nathaniel Catchpole 9ca03e7120 Issue #3003666 by tim.plunkett, segovia94: Provide access to a Section or SectionComponent from within a $form_state 2018-11-30 11:18:13 +00:00
Nathaniel Catchpole d553a65ea8 Issue #3013125 by tim.plunkett, johndevman, Dylan Donkersgoed: Content section component label_display setting is not saved when unchecked 2018-11-29 15:57:36 +00:00
Alex Pott bab4f6d3f3
Issue #3014949 by tim.plunkett: Deprecate 'context' on Block and Condition plugin annotations in favor of 'context_definitions' 2018-11-29 00:01:35 +00:00
Nathaniel Catchpole 87646bb85a Issue #2968139 by tim.plunkett, tedbow: Layout Builder field blocks show up on Block UI when they shouldn't 2018-11-28 11:59:59 +00:00
Alex Pott 23d304ffd8
Issue #3015004 by tedbow, andrewmacpherson, tim.plunkett: Distinguish between the repeated text of remove-section buttons in Layout Builder UI 2018-11-22 15:01:23 +00:00
Alex Pott a4c915aaff
Issue #2936360 by tim.plunkett, samuel.mortenson: Remove duplicate references to the "layout_builder__layout" field from Layout Builder 2018-11-22 11:59:49 +00:00
Nathaniel Catchpole b2a4a900e5 Issue #3013770 by tim.plunkett, andrewmacpherson: Distinguish between the repeated text of buttons in Layout Builder UI 2018-11-19 16:19:34 +00:00
Lee Rowlands d1c7fa1bc2
Issue #3013187 by tim.plunkett: Rename PlaceholderInterface to PreviewFallbackInterface 2018-11-19 07:40:04 +10:00
Alex Pott cd6c671028
Issue #3013197 by tim.plunkett: Cloning an implementation of SectionListInterface does not deep clone the Section or SectionComponent objects 2018-11-14 12:48:46 +00:00
webchick 257cfc7228 Issue #2968500 by tedbow, bendeguz.csirmaz, samuel.mortenson, phenaproxima, lauriii, AaronMcHale: Change inline blocks workflow in Layout Builder to match mocks 2018-11-12 15:45:45 -05:00
Alex Pott 964372f57a
Issue #2992817 by RoSk0, johndevman, phenaproxima, tim.plunkett, yanniboi, alexpott: Layout builder cron errors when no cleanup required 2018-10-31 08:22:54 +00:00
Lee Rowlands 19513d5f01
Issue #3002941 by tim.plunkett, tedbow: New enabled View modes for bundle have duplicate fields in layout 2018-10-26 19:47:22 +10:00
xjm 2227375f8b Issue #2990517 by tim.plunkett, alphex, xjm, phenaproxima, neclimdul: Adding a display mode to a content type using layout, and disabling layout on that new display mode removes the layout_builder__layout field and breaks layout in already configured display modes 2018-10-15 20:12:33 -05:00
webchick ebcf1459d9 Issue #2919795 by tim.plunkett, tedbow, dead_arm, webchick, alexpott, xjm: Add visual hints that Layout Builder work is in tempstore and will not be lost, or take effect until saved 2018-10-04 14:01:29 -07:00
Alex Pott 31ef300711
Revert "Issue #2919795 by tim.plunkett, dead_arm, tedbow: Add visual hints that Layout Builder work is in tempstore and will not be lost, or take effect until saved"
This reverts commit 5781cdba29.
2018-10-04 13:39:37 +01:00
webchick 60b88a7d67 Issue #2934223 by jibran, MerryHamster, tim.plunkett, kiamlaluno: layout_builder module has a hidden dependency on block module 2018-10-03 14:27:04 -07:00
webchick 5781cdba29 Issue #2919795 by tim.plunkett, dead_arm, tedbow: Add visual hints that Layout Builder work is in tempstore and will not be lost, or take effect until saved 2018-10-03 14:17:58 -07:00
Lauri Eskola 9ee0227bdd
Issue #2995078 by sugaroverflow, dead_arm: Add a title to the off-canvas dialog when opened by clicking "Add Block" 2018-09-28 14:32:01 +03:00
Lee Rowlands 53f1980711
Issue #2992410 by tim.plunkett, scottsawyer, sugaroverflow, phenaproxima: Provide placeholders for empty blocks (for example, an empty Views listing) 2018-09-25 16:44:48 +10:00
Lee Rowlands 58b776be9f
Issue #2995071 by tim.plunkett, sugaroverflow: Refactor LayoutBuilderLocalTaskDeriver to delegate local tasks to plugins 2018-09-18 06:49:05 +10:00
Alex Pott e3c750b08f
Issue #2970801 by tedbow, tim.plunkett, likin, sugaroverflow: If you add block then try to Revert the layout it doesn't revert 2018-09-17 16:16:45 +01:00
Alex Pott a228420963
Issue #2998215 by tim.plunkett, Ronak.addweb, bkosborne: PHP notices/warnings when managing display for non-default view mode when LB is enabled w/ overrides 2018-09-17 14:31:00 +01:00
Lee Rowlands 759371de95
Issue #2978939 by tedbow, dead_arm: Change 'field_block' block plugins to use "[entity_type] - fields" category to avoid confusion with other blocks 2018-09-12 10:17:47 +10:00
webchick 4ed41f4e8e Issue #2957425 by tedbow, johndevman, mpotter, tim.plunkett, hawkeye.twolf, alexpott, Berdir, samuel.mortenson, xjm, kevincrafts, jibran, amateescu, larowlan, twfahey, EclipseGc, sjerdo, japerry, mtodor, phenaproxima, johnzzon, mglaman: Allow the inline creation of non-reusable Custom Blocks in the layout builder 2018-08-25 13:07:16 -04:00
xjm ba347735e8 Revert "Issue #2957425 by tedbow, johndevman, tim.plunkett, hawkeye.twolf, Berdir, alexpott, samuel.mortenson, kevincrafts, jibran, larowlan, amateescu, twfahey, sjerdo, mtodor, japerry, xjm, phenaproxima, mglaman, EclipseGc, johnzzon: Allow the inline creation of non-reusable Custom Blocks in the layout builder"
This reverts commit 500403b458.
2018-08-16 18:12:46 -05:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Alex Pott 500403b458
Issue #2957425 by tedbow, johndevman, tim.plunkett, hawkeye.twolf, Berdir, alexpott, samuel.mortenson, kevincrafts, jibran, larowlan, amateescu, twfahey, sjerdo, mtodor, japerry, xjm, phenaproxima, mglaman, EclipseGc, johnzzon: Allow the inline creation of non-reusable Custom Blocks in the layout builder 2018-08-10 23:07:31 +01:00