Commit Graph

1213 Commits (8a9a5ba3da89822aa81481a1072f97eb9b0f4a64)

Author SHA1 Message Date
Dries Buytaert 8a9a5ba3da - Bugfix: the variable 'user_mail_welcome_approval_subject' was too long.
Modified patch from Al; used 'user_mail_approval_subject' instead of
  'user_mail_welcome_approval_subj'.  Patch #11 by Al.  Fixes bug #1976.
2003-06-15 19:17:43 +00:00
Dries Buytaert c31fe45f2f - Improvement: fixed wrapping in code samples in user module so that admin help doesn't have a huge horizontal scrollbar. Patch #13 by Al. 2003-06-15 19:11:17 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert a0e0ea9337 - Comment module documentation improvements; updates by Charlie, patch by Al. 2003-06-15 19:00:07 +00:00
Dries Buytaert 19a0731456 - Improvement: nicer, slightly larger arrows for the month selection within
the archive calendar.  Patch #2 by Al.
2003-06-15 07:05:06 +00:00
Dries Buytaert 677dbd46e2 - Bugfix: fixed broken links in the emitted RSS feed discovery code. Modified
patch by Kjartan.
2003-06-15 06:45:53 +00:00
Dries Buytaert ab03855a8a - Fixed braino in title.module; should fix bug #1966 reported by Moshe. 2003-06-14 16:18:40 +00:00
Dries Buytaert 5646f894ac - Bugfix: fixed broken links. Patch by Ax. 2003-06-14 16:11:29 +00:00
Dries Buytaert 3e9aabe058 - Moved some CXX checks to a centralized place; less error-prone. 2003-06-14 07:02:32 +00:00
Dries Buytaert d95499bf03 - Bugfix: small Xtemplate fixes. Patch by Ax. (Slightly modified.)
- Bugfix: block patch fix.  Patch by Gerhard.

- Bugfix: fixed broken URL in ping.  Patch by Gerhard.

  (This should fix the problems shown on http://www.blo.gs/info.php?id=1515.)

- Improvement: added better password generator.  Patch #1 by Al.  Fixes bug
  #1935.

- Improvement: performance improvement to the blog module.  Patch by Marco.
2003-06-13 17:34:18 +00:00
Dries Buytaert 5ed848ecdb - Show a non-clickable example "link" when previewing comments. Should fix
bug #1437 for all themes (incl. theme Marvin and theme UnConeD).
2003-06-12 19:13:50 +00:00
Dries Buytaert 1a2576036b - Bugfix: charset fixes/clean-up. Patch #52 by Al.
- Improvement: renamed some theme functions of the forum module for sake of consistency/readability.  Patch #2 by Kristjan.

- Improvement: usability improvements to the Xtemplate theme.  Patch #3 by Kristjan.

- Improvement: CSS'ified the book module pages.  Patch #3 by Al.  (I simplified the "l
ocation" part.  Al's approach gave you a bit more power but I'm not sure anyone wants
to change that.  Besides, this will change as soon we integrate the menu system so I kept it easy for now.)
2003-06-12 17:24:06 +00:00
Dries Buytaert 9e813c08a4 - Bugfix: when clean URLs are enabled, the cookie path was not always set correctly when the
user logged using the user block from within a subdirectory.  Patch by Ulf Rompe.
2003-06-11 20:42:31 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 75a44994cd - Bugfix: an administrator could not edit the avator through the admin interface because it used the global $user object inside its functions rather then the user to be edited. Patch by Matt Westgate. 2003-06-10 19:21:05 +00:00
Dries Buytaert cf5a17ca0d Patch be Matt Westgate:
- Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.

- Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
2003-06-10 19:00:48 +00:00
Dries Buytaert 222e1e5583 - Documentation improvements: improved and updated the block module documentation. Patch #44 by Al. We should add some real-life path examples!
- Fixed the "blog it" image size.  Patch #49 by Al.

- Some SQL performance improvements to the forum module.  This should also be more PostgreSQL safe.  Patch by me.

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.63 sec

changed to:

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.00 sec
2003-06-10 17:33:43 +00:00
Dries Buytaert b0081e5ac9 - Bring back the "blog it" icon. Patch #47 by Al. Thanks.
(I don't like the suggested icon so I suggest we continue to use the existing one, which I don't like either but oh well.  Thoughts?)
2003-06-08 19:31:27 +00:00
Dries Buytaert 54ddba4eea - Fixes CSS for archive calendar so that you can make non-link days padded
in a sensible fashion. Also removes table width 100% and puts that in css.
  Patch #48 by Al.
2003-06-08 19:26:26 +00:00
Dries Buytaert 643d2731e7 - Fixed two broken links in the "administration > content management >
post overview" page.
2003-06-08 17:40:13 +00:00
Dries Buytaert d80557672c - Made it possible to link search results. Patch by Ax.
- Removed some high ASCII characters from the code.  Patch by Ax.
2003-06-08 17:17:53 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 49ebc543b7 - Fixed various forum module queries such that they work with PostgreSQL. 2003-06-08 12:02:37 +00:00
Dries Buytaert d4ec431b44 - Bugfix: fixed approval e-mail and tidied up the e-mail handling. Patch #43 by
Al.  Fixes bug #1828.
2003-06-08 10:12:46 +00:00
Dries Buytaert 1aa341881d - Bugfix: added trailing slash to URL. Patch #39 by Al. Fixes bug #1848. 2003-06-08 08:39:28 +00:00
Steven Wittens e1adc0f780 Fixed some typoes... 2003-06-08 01:19:37 +00:00
Dries Buytaert ae45b735d3 - Bugfix: clicking the "Login" button after having created the first user
redirected you to an incorrect page.  Patch by Moshe.
2003-06-07 21:35:45 +00:00
Dries Buytaert 23423b46fb - Check the destrination URL before redirecting. 2003-06-07 15:59:49 +00:00
Dries Buytaert 2fc741867d - Bugfix: if you clicked on an archive date in the calendar block and
then select a new date via the form the block still displays the
  original click as the "selected" date.  Patch by Craig Courtney.
2003-06-07 06:08:52 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 47ba929ce2 - Removed a redundant check_input(). 2003-06-06 21:09:55 +00:00
Dries Buytaert 8f783f69dd - Removed a redundant check_query().
- Removed a bogus check_input().
2003-06-06 21:06:08 +00:00
Dries Buytaert 48bf7db71c - Bugfix: removed redundant check_input()s such that quotes are handled
properly.  You couldn't use a username or passwords that had quotes.
2003-06-06 20:52:21 +00:00
Dries Buytaert 2719ebde86 - Bugfix: fixed problem when register globals is turned off. Patch 0037.poll.register_globals.patch by Al.
(Can't we make the result URL look nicer?)
2003-06-06 18:22:21 +00:00
Dries Buytaert 3436c02c81 - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
Gerhard's patch was not 100% correct and I found a better alternative.
2003-06-06 17:30:09 +00:00
Dries Buytaert 1e7ef0cf21 - WOOOT! Patch by Al. 2003-06-06 04:38:11 +00:00
Dries Buytaert 3cf82a4eee - Bugfix: removed call to dead function. Patch by Al. Bug #1852. 2003-06-05 22:07:09 +00:00
Dries Buytaert 56e3e7d4a9 - Usability improvements: in the calendar, only add a link for days on which
new nodes have been posted.  Patch by Al.

  Al: I modified the query slightly - it will check whether 'status = 1'.
2003-06-05 21:34:56 +00:00
Dries Buytaert 522ed4d64c - More charset patches by Al. 2003-06-05 21:26:27 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert 31c36b7f54 - Fixed some translation bugs in the profile module. (I wasn't going to
commit this yet but I accidentically did so now I've cleaned it up.)
  Original patch by Matt.  Thanks for spotting the t() problem Al.
2003-06-03 19:13:19 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 54774aa825 - Removed the module field from the locale search form. It won't work and
there is no easy replacement.

- Wrapped the strings in htmlentities() such that one can see the HTML.
2003-06-02 20:54:37 +00:00
Dries Buytaert 85d22f3e82 - Fixed the blog it link to work with register globals off. Patch by Al. 2003-06-02 18:11:54 +00:00
Dries Buytaert c8b646320d - Resized two textfields for UI consistentcy. Patch by Stefan. 2003-06-02 18:09:07 +00:00
Dries Buytaert e5033fe1cf - Fixed critical bug #1788: cloud module pings too much. Modified patch by
Kjartan.

  This update requires some database changes so make sure to run update.php.
2003-06-01 06:46:55 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00