Commit Graph

408 Commits (89db09746fbcebeb3f5a886792d1287fb9d75818)

Author SHA1 Message Date
Dries Buytaert 10f329c057 - Patch #11728 by Uwe Hermann: fixed some typos in the code comments, Doxygen documentation and screen output.
Uwe: I dropped the 'iff' chunks as 'iff' stands for 'if and only if'.
2004-10-19 18:02:31 +00:00
Dries Buytaert 07cdcb439b - Patch by James: made the blogapi module work again. 2004-10-18 18:29:15 +00:00
Dries Buytaert 869a91b72e - Patch #11505 by Steven: 'my account' information is not saved.
+ Drupal 4.4 stored profile data in the serialized user->data column. Drupal 4.5 stores profile data in tables (but user->data is still available and used for other stuff, like locale or themes).  The update from 4.4 to 4.5 didn't remove the old data from the user->data column properly, because there is no mechanism in user_save to do so (it did try to unset the fields, but this has no effect).

  + On registration, hook_user('insert') is invoked after saving the data column. This means that any module-specific data is put into the data field. We cannot move hook_user('insert') higher up, because before that point, we do not have a complete $user object yet.
2004-10-16 16:59:59 +00:00
Dries Buytaert 5a2e0d0377 - Patch #11642 by Steven: when editing a user as an admin, you can choose the user's roles through form checkboxes. If the form validation fails and the form is redisplayed, the roles are lost. This is because the format for $user->roles is different from what form_checkboxes uses. 2004-10-16 16:48:04 +00:00
Steven Wittens a185443ed3 #11503: consistency improvements by Stefan 2004-10-12 16:16:22 +00:00
Steven Wittens 2c4a82bda2 #11503: (more) missing t() 2004-10-12 16:10:54 +00:00
Dries Buytaert 9a8cd6a2e7 - Patch #11312 by killes: fixed problems with menu caching. 2004-10-06 11:51:48 +00:00
Dries Buytaert 60f945bcc7 - Patch #11138 by Al: fixed GUI problem with deleting users. 2004-09-28 18:31:11 +00:00
Steven Wittens eecbda5635 - Fixing user_load() to use sprintf db_query syntax. Uglier, but safer. 2004-09-24 20:04:54 +00:00
Steven Wittens f298481316 - user.module: allow non-ascii usernames. 2004-09-24 02:38:29 +00:00
Dries Buytaert f8080719f2 - Patch #10983 by TDobes: failed logon attempts produce nonsensical watchdog message. 2004-09-21 17:46:22 +00:00
Dries Buytaert 16d3f9bc60 - Patch #10845 by James: fixed the user/help page. 2004-09-20 19:27:51 +00:00
Dries Buytaert bc58116129 - Usability improvement: on the registration page, mark the username and e-mail
address as required fields.  This makes for more consistent behavior, as the
  profile module might add required fields that are marked as such.
2004-09-19 13:43:29 +00:00
Dries Buytaert 5281a22070 - Usability improvement: made the status messages use <em>foo</em> rather than "foo". 2004-09-19 13:39:46 +00:00
Dries Buytaert 6dbd0bcfb4 - Patch #6500 by Mathias with help from Steven: made it possible to add fields to the registration form. This feature used to exist. 2004-09-19 13:28:11 +00:00
Dries Buytaert 34fc0b882d - Patch #10922 by drumm: usability improvment: tabified the user account pages (login, register, request new password). 2004-09-19 08:33:53 +00:00
Steven Wittens 30b69380af - #10689: Group permissions by module in UI + minor code cleanups.
- Adding a drupal_goto to the block admin.
2004-09-17 22:07:17 +00:00
Dries Buytaert 4b9926263c - Patch #10896 by ccourtne: user access rules for name were not enforced due to an incorrect URL. 2004-09-17 18:24:32 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 00ceea0986 - Fixed stupid 'SELECT u.* FROM users u WHERE LOWER(u.uid) = 'S' AND u.status < N LIMIT N, N' query. 2004-09-13 18:07:54 +00:00
Dries Buytaert 04ef7b1636 - Patch #10777 by ccourtne: performance improvement: the user module executes a query and never uses the results. 2004-09-13 09:00:27 +00:00
Steven Wittens 8c07aaa9c7 #10733: fixing problems when creating users. 2004-09-12 12:47:51 +00:00
Steven Wittens f6033d29e7 #10733: fixing broken user registration due to roles selection patch. 2004-09-11 22:49:20 +00:00
Dries Buytaert 0ddee8ff09 - Patch #10718 by drumm: bugfix: it was possible to save a user with no roles assigned when the form clearly said at least one was required. The result of saving that was silently leaving the roles unchanged, which is rather bad. 2004-09-10 20:00:28 +00:00
Dries Buytaert 2dedf5fbc3 - Modified patch #10644 by drumm: fixed some broken URLs. Patch modified to
use /user/$uid instead of /user/$uid/edit (where possible).
2004-09-08 18:39:14 +00:00
Steven Wittens 89b0a0a90e - #10398: User role settings corrupt after requesting new password. 2004-08-27 22:52:00 +00:00
Steven Wittens 674e2f493b Removing a left-over debug statement from Distributed Authentication. 2004-08-24 19:58:17 +00:00
Steven Wittens 44f341bebc Patch by me and Kjartan.
Upload.module
- Fixing a bug caused by the PHP5 patches.
Beware: PHP4's array_merge() will silently accept objects and convert them to arrays. We should not depend on this behaviour in the future.

File.inc / file-using modules:
- Removing the constant FILE_SEPARATOR: forward slashes work fine on Windows, and it was being used incorrectly as an URL separator sometimes.
- Adding @ to mkdir and chmod to supress ugly PHP errors. They are already reported with drupal_set_message().
- Fixing default for variable 'file_directory_temp'.
- Clarifying the help tip for 'file_directory_temp' in admin > settings.
2004-08-24 19:21:30 +00:00
Steven Wittens 51cf18e531 - #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken. 2004-08-22 17:03:42 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Steven Wittens 9cb5f7cdf8 Avatar/picture fixes:
- Changing theme('image') so the automatic image size fetching can be toggled independently from attributes. Specifying attributes and autosizing are 2 different things.
- Suppressing PHP errors from getimagesize() using @. drupal_set_message() is used to report these errors already and in a much prettier way.
- #9958: Fixing broken displaying of avatars.
- Don't show the default avatar in 'edit my account' if the user has no avatar of his/her own.
- Added ability to delete avatars (without having to replace them).
2004-08-20 04:35:33 +00:00
Steven Wittens 2436854a82 user.module - Fixing incorrect t() replacement string. 2004-08-20 00:41:56 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 83a739bd89 - Code improvements by Stefan: made all status messages consistent (and easier to translate). 2004-08-18 19:57:27 +00:00
Dries Buytaert 78b052a6af - The upload (filehandler) module has landed! 2004-08-17 21:35:26 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Dries Buytaert ba70b534b8 - Removed the offline users feature. 2004-08-15 14:23:28 +00:00
Dries Buytaert 334f24b448 - Patch by James: made the blogapi work with DA.
* Refactored the "brains" of user_login() to user_authenticate($user, $pass) so that blogapi (and others) can authenticate users (including those using DistAuth) without all the html and drupal_goto calls
   * Updates blogapi_validate_user to use user_authenticate.
2004-08-14 07:00:27 +00:00
Dries Buytaert 84c8ba504f - Patch #9975 by TDobes: fixes two consistency problems with watchdog entries:
* Adds missing quotes around the username in "session closed" watchdog messages from user.module (session opened has quotes, but session closed does not).
   * Changed "view detals" after watchdog entries to "details".
2004-08-14 06:21:53 +00:00
Dries Buytaert 5a566c55ec - Patch #9974 by njivi: report the number of offline users.
I had some trouble adding this feature but realized that the "who's online" block is a geek think, and therefore it won't hurt to add some more geekiness.  If you don't know what "offline users" means, you would not have understood "online users" in the first place.  Either way, I think most people who have the block enabled, will find this an interesting addition.
2004-08-12 22:12:21 +00:00
Dries Buytaert 0f088b79ca - Patch #9983 by Stefan: various code style improvements. 2004-08-12 18:00:11 +00:00
Steven Wittens 89510864b6 Tiny code cleanup in user.module. 2004-08-08 23:19:47 +00:00
Steven Wittens ddb31aaf6b - #3606: Missing translations for user.module watchdog 2004-08-07 19:49:46 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Dries Buytaert 35cad55e5b - Patch #8523 by killes: avoid profile data being deleted when requesting a new
password.
2004-08-05 20:41:57 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert b87b2abe65 - Patch #9768 by killes: admin/user/edit/$uid is no more, removed some left-overs. 2004-08-04 21:09:29 +00:00
Dries Buytaert c71bfded3d - Patch #9657: more intelligent theme() function. Hopefully, Adrian will be
able to use this patch too.
2004-08-04 20:40:01 +00:00
Dries Buytaert 202eee42a9 - Patch #9543 by JonBob: added node-level access control! 2004-07-31 09:30:09 +00:00
Dries Buytaert bd4f4ebbc3 - Patch #9547 by Eric: fixed avatar/picture upload bug. 2004-07-28 20:18:11 +00:00