Commit Graph

166 Commits (89db09746fbcebeb3f5a886792d1287fb9d75818)

Author SHA1 Message Date
Steven Wittens 2c4a82bda2 #11503: (more) missing t() 2004-10-12 16:10:54 +00:00
Dries Buytaert 57a96cbb78 - Bug #10530: added a missing period to a sentence in the help text. 2004-10-08 16:54:35 +00:00
Steven Wittens 1298d2b9c9 Modified version of #10230: Put placement of filter format selector in a module's hands, and move it below the relevant textarea. 2004-09-28 19:13:03 +00:00
Dries Buytaert 8d2eb9a55f - Patch #11083 by Allan Chandler: fixes PostgreSQL specific issue with the statistics pages. 2004-09-27 19:59:09 +00:00
Dries Buytaert db24d26dbb - Fixed HTML typo in the documentation: <p> -> </p>. Fixes bug #10412. 2004-09-22 21:36:47 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 0308b8c3be - Usability improvement: made the page titles better match the link titles.
- Bugfix: fixed some incorrect colspan's.
2004-09-11 14:43:52 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 7a885c8ffa - Patch #10044 by TDobes: fixed broken links in the statistics module. In the current statistics.module, clicking a page title should lead to the appropriate page within the local site. Instead, it leads to a 404 because the / character is turned into %2F... this is due to the paths being passed through urlencode(). The attached patch removes the problematic calls to urlencode. 2004-08-14 06:19:44 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert f971b768f6 - Patch by Jeremy: usability improvements for the statistics.module's GUI. 2004-08-05 20:30:16 +00:00
Dries Buytaert 0582a304fd - Patch by Jeremy: statistics module improvements. 2004-08-03 09:27:00 +00:00
Dries Buytaert c7b27b18de - Simplified referrer links. Suggested by Morbus. 2004-06-30 21:00:41 +00:00
Dries Buytaert f6b7f75512 - Patch #8733 by Morbus Iff: fixed statistics module. 2004-06-22 18:13:04 +00:00
Dries Buytaert ad3c6f345e - Patch #8681 by asimmonds: more help text updates 2004-06-21 08:26:20 +00:00
Dries Buytaert c2d7419f23 - Patch #8681 by stefan: fixed some broken URLs and help texts. 2004-06-20 19:49:14 +00:00
Dries Buytaert 4b449a7e5d - Patch #8670 by asimmonds: spelling fixes. 2004-06-20 19:43:28 +00:00
Dries Buytaert 54b77d6435 Tabs patch!
CHANGES
-------

 + Introduced tabs. First, we extended the menu system to support tabs. Next, a tab was added for every link that was (1) an administrative action other than the implicit 'view' (2) relevant to that particular page only. This is illustrated by the fact that all tabs are verbs and that clicking a page's tab leads you to a subpage of that page.

 + Flattened the administration menu. The tabs helped simplify the navigation menu as I could separate 'actions' from 'navigation'. In addition, I removed the 'administer > configuration'-menu, renamed 'blocks' to 'sidebars' which I hope is a bit more descriptive, and made a couple more changes. Earlier, we already renamed 'taxonomy' to 'categorization' and we move 'statistics' under 'logs'.

 + Grouped settings. All settings have been grouped under 'administer > settings'.

TODO
----

 + Update core themes: only Xtemplate default supports tabs and even those look ugly.  Need help.

 + Update contributed modules.  The menu() hook changed drastically.  Updating your code adhere the new menu() function should be 90% of the work.  Moreover, ensure that your modue's admin links are still valid and that URLs to node get updated to the new scheme ('node/view/x' -> 'node/x').
2004-06-18 15:04:37 +00:00
Dries Buytaert e52c0f5d41 - Code improvements by JonBob. Thanks. 2004-05-17 22:00:06 +00:00
Dries Buytaert 3de9d33e67 - Menu and code improvements by JonBob. 2004-05-08 07:17:47 +00:00
Dries Buytaert 681b26febc - Patch #7577 by JonBob: various code style improvements to the statistics
module.

   + Usages of to print titles have been replaced by proper drupal_set_title()
     calls.
   + Many arg() usages dropped in favor of meaningful parameters.
   + Doxygen comments standardized and expanded.
   + Some grammatical corrections to help text.
   + Broken /statistics page linked from page navigation restored.
   + Fixed small bug in menu.inc pertaining to menu callbacks without
     arguments.
2004-05-05 21:12:14 +00:00
Dries Buytaert 7231c88a32 - Added support for 403 handling. Patch by JonBob. As a side benefit,
administrators will be able to define a custom 403 page, just as they
  can define 404 pages now.

  This needs to be documented in the "Changes since / migrating to ..."
  pages.
2004-04-21 13:56:38 +00:00
Dries Buytaert 0dc1f820ff - Patch 6675 by Ax: reorganized the menu's of the watchdog and statistics module
to be more intuitive and moved some help text to Doxygen comments.
2004-04-18 12:51:55 +00:00
Steven Wittens 803dacf652 Poll.module / Statistics.module: fixing bug caused by using array_merge and drupal_map_assoc. This causes array keys to be renumbered, leading to bugs.
Remember to use $array1 + $array2 instead.
2004-04-14 14:02:36 +00:00
Dries Buytaert 142dd6ba43 Patch #5588 by bylund: XHTML improvements: <i> -> <em> and <b> -> <strong>. 2004-03-20 13:29:06 +00:00
Dries Buytaert 4b0b2d02ee - Patch by Steven: removed redundant permission checks. These are no longer
required thanks to the new 404 handling.
2004-02-15 20:09:46 +00:00
Dries Buytaert ae5136e51b - Patch #5111 by Bart: fixed inconsistent default values. 2004-02-15 16:33:33 +00:00
Dries Buytaert bd78422715 - Patch 5592 by Goba: let drupal_map_assoc() rule. :-)
- Renamed CHANGELOG to CHANGELOG.txt for Windows uses.
2004-02-15 15:19:36 +00:00
Dries Buytaert 6c99c2d86f - Patch #5766 by Moshe: replace getenv() with $_SERVER. 2004-02-10 19:41:57 +00:00
Dries Buytaert dc938c533b - Patch #5567 by Goba: fixed t() functions, cleanup of locale module's help,
fixed translation issues in taxonomy module, etc.
2004-02-01 21:04:42 +00:00
Dries Buytaert b85eb11e11 Patch 5287 by Stefan: multiline help texts should become inside a single $output. 2004-01-23 18:42:43 +00:00
Dries Buytaert a8b8c247db - Patch #5021: clean up URLs in _help texts. Patch by UnConeD. 2004-01-11 20:31:26 +00:00
Dries Buytaert 80f34e5ab0 - XHTML improvements: <b> -> <strong>. Patch by Stefan. 2003-12-29 17:14:27 +00:00
Dries Buytaert d5c8026454 - Updated the calls to menu() to use MENU_HIDE instead of 1 2003-12-17 22:27:23 +00:00
Dries Buytaert 35fb889776 - Show the top nodes on admin/statistics. Patch by James Walker. 2003-12-10 06:43:32 +00:00
Dries Buytaert 712a30b520 - Improvements by Goba:
+ removes the lots of pagers and indirect pager themeing
  + add the theme_pager() function, which should be called as
    theme("pager", ...) to get a pager.
2003-12-08 18:30:20 +00:00
Dries Buytaert d45bf0f1e7 - Patch 185 by Ax: fixed undefined variables, synchronized xtemplate with sf, etc. 2003-12-04 20:53:19 +00:00
Dries Buytaert f10cf4756e - Better separation between throttle and statistics module code. Patch by Jeremy. 2003-11-30 10:37:07 +00:00
Dries Buytaert 4201e07670 - More throttle improvements. Patch by Jeremy. 2003-11-29 06:53:03 +00:00
Dries Buytaert d5c607041a - Fixed incompatibility between the pager and statistics module 2003-11-27 22:01:56 +00:00
Dries Buytaert 1fb206d958 Patch by Jeremy:
- removed statistics_init() -- auto-throttle logic moved to
  statistics_exit()
- renamed internal-only update_throttle() to _update_throttle()
- removed some odd white spaces
- fixed 'Popular content' block's subtitles to actually display
2003-11-27 06:32:42 +00:00
Dries Buytaert 53cc5ba870 Statistics module patch by Jeremy:
- removed custom user-page configuration
  - added user-page configuration as group into statistics_settings()
  - inlined logic to display user-page within statistics_page()
  - changed references of "top content" to "most popular content"
  - updated help to reflect recent changes
  - removed references to title/subtitle text configuration
  - properly load _settings data for popular content block
  - fix admin pages to display referrers and top nodes (don't return...)
2003-11-26 16:11:47 +00:00
Dries Buytaert 35e92aa733 - Improved usability of the statistics module's setting page. Patch by
Jeremy.
2003-11-25 23:54:08 +00:00
Dries Buytaert 6135c14c44 Statistics module improvements by Jeremy:
- Remove custom configuration of "admin/system/block/top nodes block".
- Three remaining configuration options moved to "admin/system/modules/statistics".
- Move simple logic to display block within statistics_block().
2003-11-25 21:12:26 +00:00
Dries Buytaert 506fe741ec - Moved the "Who's online" block from the statistics module to the user module
as the code no longer relies on the statistics module.  In addition, some
  code has been simplified and other bits have been removed.  Patch by Jeremy.
2003-11-25 19:54:00 +00:00
Dries Buytaert c0494c0a2b - Committed phase 4 of JonBob's menu system changes. 2003-11-25 19:26:21 +00:00
Dries Buytaert 26735ac5dd - Committed phase 3 of JonBob's menu changes. Adds an API for modules to
define titles and breadcrumbs for their pages, and updates the theme
  system to display them.
2003-11-23 10:41:04 +00:00
Dries Buytaert 4bdac4333b - Patch by JonBob:
Phase 2 of the menu system integration project. This unifies the interface
  used by admin and non-admin pages, and deprecates the _page hook in favor of
  explicit callbacks from menu(). Breadcrumbs, titles, and help text go away
  as a result of this patch; they will return in the phase 3 patch, printed
  by the theme.
2003-11-20 21:51:23 +00:00
Dries Buytaert d03d933b73 - Performance improvement: changed a LEFT JOIN to an INNER JOIN. Patch #157
by Gerhard.
2003-11-19 17:54:44 +00:00