Commit Graph

484 Commits (8851b57acf1391fe1dbfab4877c1fdc7d63aac63)

Author SHA1 Message Date
Gábor Hojtsy 115285f30a #165675 by pwolanin: only show allowed parent items in menu/book select fields to avoid going deeper then what is allowed 2007-08-16 12:47:34 +00:00
Dries Buytaert 15c68075d9 - Patch #154470 by pwolanin et al: optimize menu queries and indices. 2007-08-11 14:06:15 +00:00
Gábor Hojtsy 509d570bbd #160039 by prakashp, chx and pwolanin: fix node saving:
- centralize/reuse some node form saving code
 - fix uploads without JS
 - fix reappearing teasers on node save
2007-08-09 11:01:00 +00:00
Gábor Hojtsy 2bfeda7672 #164348 by pwolanin: improve book block performance 2007-08-07 11:43:05 +00:00
Gábor Hojtsy b2ebf5d180 #164545 by pwolanin: fix call time pass by reference warning 2007-08-04 21:24:32 +00:00
Dries Buytaert e7f195bbee - Patch #146425 by pwolanin et al:
* Removes the hard-coded 'book' type and perform all node actions
      equally on any node type via hook_nodeapi.
    * Achieves 100% integration with the menu system.  Improves
      performance of book rendering.
    * All the algorithms have been changed to use the tree data structure
      returned by the menu system.
    * Added support for 'multiple books'.
    * Some UI improvements.

  This is a momumental patch that took 69 iterations. Although there is
  room for improvement, this is a big step forward.  Thanks for the
  persistence, pwolanin.
2007-07-30 18:20:21 +00:00
Dries Buytaert 4bf0b45a22 - Patch #142157 by xqus: fixed problem with l() conversion. 2007-07-03 19:29:32 +00:00
Dries Buytaert e59852d336 - Rollback of patch #147723: delete API. Talked to Steven and Gabor and we
unanimously agreed to rollback the deletion API.  We all support the
  features this patch added, yet not its actual design and implementation.
  After some talk, we decided that it would be better for Drupal -- in the
  long term -- not to go with a solution that isn't 100%. We also recognize
  that in the short term, this patch would have been useful addition. So
  let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Gábor Hojtsy 9e6ef53c2c #154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array 2007-06-30 19:46:58 +00:00
Dries Buytaert afc700a3f6 - Patch #153364 by webernet: notices and RTL issue with book.module. 2007-06-28 08:56:28 +00:00
Steven Wittens 38a1300df2 #147723: Deletion API (by hunmonk). Woop woop. 2007-06-22 05:44:21 +00:00
Gábor Hojtsy c059a6d984 #145737 follow up patch by yhager: include right to left styles for print.css 2007-06-10 08:55:55 +00:00
Dries Buytaert 1fe90cba4f - Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments 2007-06-04 07:22:23 +00:00
Dries Buytaert 96926ca047 - Patch #146470 by Eaton et al: standardize form API3 hook parameter order. 2007-05-28 06:08:47 +00:00
Dries Buytaert ac65ff9074 - Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :) 2007-05-14 13:43:38 +00:00
Dries Buytaert 7d4f2836ba - Patch #128082 by Goba et al: Allow localization of built-in menu items. 2007-04-30 17:03:29 +00:00
Dries Buytaert f73610bec6 - Patch #76588 by Gabor: made log messages translatable. Yay. 2007-04-24 13:53:15 +00:00
Dries Buytaert e675979091 - Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot. 2007-04-13 08:56:59 +00:00
Dries Buytaert dcbb5fa3f4 - Patch #107061 by Steven et al: add jQuery teaser splitter. 2007-04-09 13:58:03 +00:00
Dries Buytaert 5bbbf10ba8 - Patch #130987 by merlinofchaos: added theme registry for easier themability. 2007-04-06 13:27:23 +00:00
Steven Wittens f7440d4d73 #130971: Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc) 2007-03-27 05:13:55 +00:00
Dries Buytaert 632c09e419 - Patch #114745 by moonray: book module: can't remove top-level node. 2007-03-25 21:02:33 +00:00
Dries Buytaert 4b635f6d0a - Patch #128081 by Eaton: remove #base, paving the path for a simpler form API. 2007-03-17 18:30:14 +00:00
Dries Buytaert a1e6728a46 - Patch #113603 by chx: first crack at re-implementing tabs. 2007-02-11 09:30:51 +00:00
Dries Buytaert 05a708fb06 - Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks. 2007-01-31 15:49:26 +00:00
Dries Buytaert 3b543c18f5 - Rollback of E_ALL patch. Too much extra breakage. 2007-01-25 22:14:06 +00:00
Dries Buytaert fd32b42196 - Patch #112715 by webchick et al: fixed some E_ALL errors. 2007-01-25 21:32:07 +00:00
Dries Buytaert 03752e35a4 - Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet. 2007-01-24 14:48:36 +00:00
Neil Drumm 5c4d5386e2 #107443 by webchick. Proper . placement. 2007-01-09 08:31:22 +00:00
Dries Buytaert b52f2556f5 - Patch #107306 by webernet: fixed incomplete break-tag clean up. 2007-01-07 15:51:24 +00:00
Neil Drumm c2d3944273 #100963 by Eaton. Use new pattern for node rendering in printer-friendly version. 2006-12-29 07:41:44 +00:00
Neil Drumm dca26f5ebd #26552 by Heine. Add child page to unpublished book nodes doesn't work, so remove the link. 2006-11-30 02:04:31 +00:00
Neil Drumm 1fb7148854 #100350 by dvessel. Adda missing <p> tag. 2006-11-29 22:51:03 +00:00
Dries Buytaert 827f064deb - Patch # #98366 by webchick and ac: simplified strings for translators. 2006-11-24 10:18:24 +00:00
Dries Buytaert 6b08f590b1 - Patch #97889 by pwolanin, webchick et al: book documentation improvements. 2006-11-22 09:58:48 +00:00
Dries Buytaert b004f328ee - Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard. 2006-11-21 20:14:19 +00:00
Dries Buytaert e89c6c1da7 - Patch #93678 by chx: book module not updating the database properly. 2006-11-21 19:27:06 +00:00
Neil Drumm 1237159381 #87474 by webernet. Move the log message field from book to node module. 2006-11-16 21:14:44 +00:00
Neil Drumm 392041edf6 #72467 by m3avrck. Better display for long book page and forum topic titles. 2006-11-14 06:30:10 +00:00
Neil Drumm 3a5d412efb #90395 by joshk, mj2308, and kkaefer. Fix book outline saving. 2006-11-07 07:01:05 +00:00
Steven Wittens 36d44fbfb0 #84146: Use 'Sentence capitalization' for menu items, page titles, form items, etc 2006-10-22 08:28:47 +00:00
Dries Buytaert 878bb6162c - Patch #84117 by misawie: make book outlining work with PostgreSQL. 2006-09-26 14:14:30 +00:00
Dries Buytaert 5f8027f94c - Patch #83397 by edkwh: -> . Getting rid of super-globals. 2006-09-17 19:14:16 +00:00
Neil Drumm a74f6f0c3f #83494 by edkwh. Fix the book outline. 2006-09-13 01:30:21 +00:00
Dries Buytaert 2f8262e9aa - Patch #75465 by chx: fixed Doxygen of book.module. 2006-09-05 10:01:48 +00:00
Dries Buytaert 49fa25fb76 - Rollback of patch #68418: clean up node submit hooks. Needs more thinkering.
Restores the old node API.
2006-08-31 21:58:36 +00:00
Dries Buytaert c64db1da29 - Patch #80952 by earl, webchick, neclimdul et al: .info files 2006-08-31 20:22:37 +00:00
Dries Buytaert 5524604a95 - Patch #68418 by Moshe et al: clean up node submit hooks. 2006-08-29 18:43:26 +00:00
Neil Drumm 055844e74f #4074 by riccardoR, save the book weights if they aren't editable. 2006-08-23 06:38:49 +00:00
Dries Buytaert 7de41539df - Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model. 2006-08-18 18:58:47 +00:00
Steven Wittens 81938a3cdc #76802: Introduce placeholder magic into t()
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Neil Drumm 0c64b251c4 #39124 by dww. Don't default the log message to the last log message. 2006-08-17 09:08:16 +00:00
Neil Drumm 3cc2b1e3d7 #77183 by m3avrck and timcn, split up drupal.css by module. 2006-08-14 07:14:50 +00:00
Dries Buytaert ce85b7c7f8 - Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert 9700fa0c0b - Patch #72343 by dww: removed stray status message. 2006-08-07 19:29:38 +00:00
Dries Buytaert 729fa6c11b - Patch #77422 by timcn: corrected various paths in the documentation. 2006-08-07 15:04:16 +00:00
Neil Drumm 129c8eb18c #62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types. 2006-08-06 23:00:42 +00:00
Neil Drumm cd430165d7 #73884 by RobRoy, various code cleanup. 2006-08-05 00:26:36 +00:00
Dries Buytaert b138793b68 - Patch #72079 by Earl et al: give Drupal an overall administration page ... :-) 2006-07-31 11:25:55 +00:00
Neil Drumm c11c1c2800 #73605 by RobRoy, make hook_link() implementations consistent with documentation. 2006-07-19 07:15:35 +00:00
Dries Buytaert d3e8a43d4f - Patch #72343 by Chris Johnson: removed checks for the moderate-flag from the SQL queries. 2006-07-10 08:05:15 +00:00
Dries Buytaert e93f8be871 - Patch #72204 by nedjo: upper-cased all TRUE/FALSE/NULL constants. 2006-07-05 11:45:51 +00:00
Neil Drumm 59aa2ae8e8 #71925 by Steven, remove # prefix from link array keys. 2006-07-04 08:59:05 +00:00
Dries Buytaert b1869f6131 - Patch #71014 by fgm: fixed the parent navigation link. 2006-07-03 13:51:50 +00:00
Neil Drumm c50d7bcbc8 #71613 by keve, fixing some PHP notices in the book module. 2006-07-02 20:36:57 +00:00
Dries Buytaert b859406290 - Patch #69151 by flanker: make exported book pages themeable. 2006-06-25 14:27:12 +00:00
Dries Buytaert 32b4c92952 - Patch #67229 by chx: cleaned up book_load(). 2006-06-05 09:00:22 +00:00
Dries Buytaert cd85ca192b - Patch #66991 by dww and killes: infinite recursion in book_location_down() when there are multiple revisions. 2006-06-05 08:57:29 +00:00
Dries Buytaert c08eafe0ee - Patch #46290 by Neil, Egon, et al: when deleting a book page under 'orphan pages' we are returned to the homepage. 2006-05-24 11:19:00 +00:00
Dries Buytaert 1b291a2917 - Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules 2006-05-18 14:58:57 +00:00
Dries Buytaert 21649210f3 - Patch #60224 by rkerr: one page book showing another book in navigation links. 2006-05-13 10:02:54 +00:00
Neil Drumm 9cff02e91b #61802 by Zen, Double spaced sentences clean up 2006-05-07 00:08:36 +00:00
Neil Drumm 781880deaa #61696 by Zen, book module: Missing t() 2006-05-04 09:11:43 +00:00
Dries Buytaert d071f99172 - Removing trailing whitespace. 2006-04-17 20:48:26 +00:00
Gerhard Killesreiter b61d9c3e7b #58539, removed duplicate menu item, patch by Markus Petrux 2006-04-13 15:10:23 +00:00
Gerhard Killesreiter 002fee7aae #56105, remove title validation, already enforced by #required, patch by Moshe 2006-03-27 18:02:48 +00:00
Gerhard Killesreiter 3052c49e09 #53826, Book export: db_rewrite breaks sql query., patch by puregin 2006-03-26 19:35:05 +00:00
Gerhard Killesreiter 4a689a99b9 #55493, Editing an existing book page kills Drupal, patch by chx 2006-03-23 21:20:59 +00:00
Gerhard Killesreiter 5cfdac2448 #54565, cannot remove pages from book outline. Patch by Zen. 2006-03-18 13:09:56 +00:00
Steven Wittens 729c464d00 #50987: book next link breaks with php 5.1 2006-03-14 15:43:49 +00:00
Steven Wittens e74aa7eeb6 #53956: Don't allow moving away top-level book pages if you cannot move them back. 2006-03-14 15:36:25 +00:00
Gerhard Killesreiter 0e3f8f97eb #11206, Editing a top level book page inadvertently changes parent, patch by chx. 2006-03-14 09:21:49 +00:00
Dries Buytaert edce458e2f - Patch #50821 by Zen/merlinofchaos: convert book.module to form API so the forms can be altered/themed. 2006-03-02 08:44:52 +00:00
Steven Wittens 514b12c427 - #47844: Book module doesn't delete table entry for nodes added to outline. 2006-03-01 19:19:05 +00:00
Dries Buytaert 3603fe1bd8 - Patch #49912: www.drupal.org -> drupal.org. (Today's critical bugfix #5.) 2006-02-21 18:46:54 +00:00
Dries Buytaert 7f299b7a9b - Patch #49131 by puregin: refine book permissions. 2006-02-14 19:25:02 +00:00
Dries Buytaert 3b27048623 - Patch #47098 by JonBob: fixed book navigation divs when book has no child pages. 2006-02-09 07:27:11 +00:00
Dries Buytaert 1f206ca2fe - Patch #47066 by Zen: removed dead code. 2006-02-01 14:40:20 +00:00
Dries Buytaert 15ff8c8e32 - Patch #46827 by wulff: fixed incorrect links. 2006-01-29 07:50:45 +00:00
Dries Buytaert 30d59fd52c - Patch #46400 by m3avrck: clean up book navigation markup + UI improvements. (Hint: the forum module has previous and next links too.) 2006-01-27 18:57:13 +00:00
Dries Buytaert 3c6066cffa - Patch #45706 by markus: keep up with CSS improvements. 2006-01-24 08:22:12 +00:00
Dries Buytaert 4267ab5ea9 - Patch #45706 by markus: keeping up with CSS improvements. 2006-01-22 07:32:55 +00:00
Dries Buytaert 8c02d4ec93 - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:

# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
  $form[$key]['#weight'] = $count/1000;
}

The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).

Consider the following pseudo example:

$form['game_title'] = array(
    '#type' => 'textfield',
    ...
    );
$form['game_description'] = array(
    '#type' => 'textarea',
    ...
    );
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;

Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).

The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert e84a98a22b - Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API. 2006-01-19 08:54:41 +00:00
Dries Buytaert 52507806eb - Patch #45301 by Morbus: corrected the weight of form item titles of nodes. 2006-01-18 19:29:17 +00:00
Dries Buytaert 4e35060451 - Patch 42591 by Simon/me: fixed problem with deleting forum and book revisions. 2005-12-31 13:04:40 +00:00
Dries Buytaert 922a46d281 - Patch #34920 by Morbus/webchick/tangent: fixed order of form fields. 2005-12-15 16:24:40 +00:00
Dries Buytaert c4c5ce122d - Patch #31323 by Gerhard: delete extra data when a revision is deleted. 2005-12-05 16:07:18 +00:00
Dries Buytaert 28fdb3975e - Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick. 2005-12-05 09:11:33 +00:00
Dries Buytaert 26bd449860 - Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'. 2005-12-02 15:21:01 +00:00