Commit Graph

2728 Commits (87e5399a9ec981a4e217f1d82b0491fcd4677269)

Author SHA1 Message Date
Steven Wittens 4fee0bdbec - #13550: Prettier RSS discovery URLs for taxonomy pages. 2005-03-18 08:25:07 +00:00
Steven Wittens e17490b653 - #12401: Non-admins should obey workflow wrt revisions. 2005-03-18 08:14:37 +00:00
Steven Wittens d7588e4594 - #12211: Show link indicating that a node has attachments on the homepage 2005-03-18 08:05:47 +00:00
Steven Wittens ab700960e4 - #18597: Resolve conflict in column name between queue.module and poll.module. 2005-03-18 08:02:10 +00:00
Steven Wittens c3f1f7345e - #18939 (Stefan): Always use paragraph tags around page help text. 2005-03-18 07:07:04 +00:00
Steven Wittens ab7815c8cd - #19063: Use module_implements instead of hand-rolled routine. 2005-03-18 06:50:41 +00:00
Dries Buytaert 332a56334d - Patch #17161 by Morbus: increase 40-character limit in URL field for comments. 2005-03-16 22:14:15 +00:00
Dries Buytaert 82565266b8 - Patch #18927 by Periastron: as one navigates down through the forum taxonomy, the title used to change to the current term, but now it always just displays the vocabulary name. I have attached a patch that restores the previous behaviour. It looks like the regression may have been introduced in some changes to theme_forum_display. 2005-03-16 21:07:59 +00:00
Dries Buytaert 97ae6568e6 - Patch #13738 by TDobes: theme system fixes:
* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
2005-03-16 19:41:12 +00:00
Dries Buytaert f4b5313483 - Patch #18983 by Ber: small code improvement. 2005-03-16 19:34:13 +00:00
Dries Buytaert 3b5589f436 - Patch #14109 by wulff/Morbus: added missing t() funciton 2005-03-16 19:31:47 +00:00
Dries Buytaert 032544cf08 - Patch #18861 by nkurz: fixed logic error in taxonomy_node_save().
(Not sure how/when it triggered.)
2005-03-15 21:18:19 +00:00
Dries Buytaert 1c4419c439 - Patch #18696 by Morbus: one '(' too much in taxonomy_term_count_nodes(). 2005-03-13 21:20:51 +00:00
Dries Buytaert 3b70f0015f - Patch #18787 by nysus: when trying to delete a forum or container, multiple instances of a Drupal page appear nested inside of each other when the confirmation of deletion page is displayed. 2005-03-13 21:04:43 +00:00
Dries Buytaert a16e5d2492 - Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned). 2005-03-12 08:52:29 +00:00
Dries Buytaert 2ec787df34 - Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this. I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module. 2005-03-10 18:28:21 +00:00
Dries Buytaert 743b10078a - Patch #18465 by nysus: improved the forum container explanation. 2005-03-09 14:07:24 +00:00
Dries Buytaert 3becbd8997 - Patch #16914 by chx: avoid that putting a .theme file directly in './themes'
breaks your Drupal.  Only themes in './themes/subdir' are picked up now.
2005-03-08 22:06:11 +00:00
Steven Wittens 9d8badb8de - #18434: (search) Try wildcards automatically if there were no results.
- Fix missing format_plural()
2005-03-08 18:08:17 +00:00
Steven Wittens f7c858fcdf #12369: Linebreak filter should leave <pre> sections alone. 2005-03-07 22:44:54 +00:00
Dries Buytaert 49240b6b1e - Patch #18216: fixed nodeapi settings hook. 2005-03-07 21:58:13 +00:00
Dries Buytaert 0f7be2573e - Bumped the RSS version from 0.92 to 2.0 2005-03-07 21:52:57 +00:00
Dries Buytaert 000c10eb79 - Patch #18491: removed the 'access throttle block' permission. It is no longer used. 2005-03-07 21:17:03 +00:00
Dries Buytaert 9a47bc4e7e - Renamed some more 'region's to 'sidebar's 2005-03-06 15:06:19 +00:00
Dries Buytaert 344f33f6af - Patch by Neil: fixed typo. 2005-03-05 23:00:32 +00:00
Steven Wittens ebc7c0dfe0 - Fix missing parameter in user.module 2005-03-05 18:03:16 +00:00
Dries Buytaert 77f7aa0211 - Patch #18418 by chx: jonbob node_access_view_all patch changed the return value of node_access_where_sql to empty which breaks nicely all queries which are still using this function. This is a good incentive to upgrade to db_rewrite_sql, yes, but I think it causes confusion, 'cos it is not really trivial why the query suddenly not works. Let's make it trivial -- rename it _node_access_where_sql, it is no longer a function to be called from outside. node_access_join_sql similarly. 2005-03-05 11:05:07 +00:00
Dries Buytaert dcf985de21 - Patch #18404 by Gerhard: removed incorrect/outdated documentation from a form description. 2005-03-05 09:11:00 +00:00
Dries Buytaert 11dd94bde5 - Patch #18382 by Neil: usability improvement: organized the blocks on the block administration page by region. (I wanted to do that myself!) 2005-03-05 09:09:07 +00:00
Steven Wittens ad973366ab - Fix overzealous session wiping 2005-03-04 03:43:41 +00:00
Steven Wittens 96eb9c6f9f #18226: Non-admins were not obeying workflow. 2005-03-04 00:48:22 +00:00
Steven Wittens d16e18f9bb - Incorrectly filled in %name 2005-03-03 21:07:37 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Dries Buytaert 96211c616e - Patch #17955 by Neil: there was a subtle difference between form_select() and whatever taxonomy was doing. 2005-03-03 20:38:18 +00:00
Dries Buytaert f7c8a2c080 - Patch #17160 by Neil: fixed problem with aggregator block throwing DB errors after being deleted. 2005-03-03 20:05:46 +00:00
Dries Buytaert 749f15e7c0 - Modified patch #18328 by Neil: currently the two forum topic blocks share a number of topics in block setting. This is a bit confusing since configuring one blockshould not affect another block. Fixed some indentation as well. 2005-03-03 20:02:07 +00:00
Dries Buytaert 03374fc0f6 - Patch #17897 by Neil: changed the order of the joins so that a vocabulary which is not associated with any node types doesn't disappear. Also removed a centered column that shouldn't be hard coded and, IMO, looked rather weird. 2005-03-03 19:18:19 +00:00
Steven Wittens 4a9b9f4aca - Block admin usability: display block title if no description was given. 2005-03-03 05:54:25 +00:00
Steven Wittens 84b7defc07 - Bugfix: admin/forum tabs should not appear on edit forum/container pages. 2005-03-03 05:10:28 +00:00
Dries Buytaert c1d9fffb57 - Patch #18231 by cprice: -> = 0 2005-03-02 08:13:15 +00:00
Dries Buytaert cc78d6c8cf - Fixed PHP warnings. 2005-03-01 21:13:46 +00:00
Dries Buytaert c77153f19a - Removed dumb taxonomy block (based on DrupalCon feedback). 2005-03-01 20:43:59 +00:00
Dries Buytaert 84268b3a34 - Patch #17770 by chx: added missing NULL-arguments to _user() hook. 2005-03-01 20:21:08 +00:00
Dries Buytaert 3123d7e6ec - Patch #18045 by JonBob: the node type admin page uses an unclear callback name, and uses arg() where it is not necessary. The attached patch cleans this up by unifying node_types() with node_types_configure(). 2005-03-01 20:07:48 +00:00
Dries Buytaert a4befbb68b - Patch #18123 by chx: the $return['distinct'] in the past should have been module_implements('node_grants') but after JonBob's node_access_view_all_nodes, that part happens only if node_grants is in effect, so it is simplified to 1. 2005-03-01 20:01:40 +00:00
Steven Wittens ea08f062b2 - Fix broken session deleting on account blocking. 2005-03-01 18:44:41 +00:00
Steven Wittens 9803bc4321 - Delete a user's sessions when blocking his/her account. 2005-02-28 18:13:12 +00:00
Steven Wittens ff386b90bb #17747: PGSQL improvements 2005-02-28 18:00:59 +00:00
Dries Buytaert 174d22dbbb - Patch #17931 by Neil: fixed bug in access rules page:
* split up the menu callback for editing/adding/deleting rules
  * improved the delete message
  * fixed a double page printing bug
2005-02-28 16:41:15 +00:00
Steven Wittens 5f5f0b27ac - Oops: don't show refused words message if there are none. 2005-02-27 23:31:47 +00:00
Steven Wittens 4f196311c1 - Fix submissions from search boxes in themes 2005-02-27 18:39:18 +00:00
Dries Buytaert 39adda1687 - Patch #17747 by Adrian: more PostgreSQL fixes. Committed part of the patch:
1. Removed a duplicate line from the changes to update.inc.
   2. Excluded the session.inc changes: they did not make sense to me.
   3. Excluded the search related changes in the node and search module. According to Steven these are not correct.
2005-02-27 15:40:35 +00:00
Steven Wittens a794dd4419 - #17877: Auto-fill comment subject during _validate rather than _save. 2005-02-27 02:56:12 +00:00
Steven Wittens 538a3071de - #17870: Add preview CSS class to node preview (drumm) 2005-02-27 02:54:24 +00:00
Steven Wittens d4f1b435a1 - #17868: Remove hardcoded align="center" 2005-02-27 02:48:57 +00:00
Steven Wittens 69262e5a73 - Search: fix search block stretching sidebar 2005-02-27 02:46:37 +00:00
Steven Wittens cd552adee0 More search usability improvements!
- Clean URLs: search/type/keywords e.g. "search/node/drupal release". The search
  form is POST submitted, but drupal_gotos to a GET page. This makes it easy to
  copy/paste search URLs, and makes the pager a lot cleaner.

- Remember the search keywords when switching between the search tabs. This is
  done through the same GET URLs rather than the session, so it does not mess up
  between multiple browser tabs.

- Report which keywords were ignored because they were too short.

- #820: Provide search block

- Treat multiple wildcards in a row as one
2005-02-27 02:15:57 +00:00
Steven Wittens fb4b224a37 #16951: Move forum settings to configure tab (drumm) 2005-02-26 23:53:39 +00:00
Steven Wittens d2bfc18880 #17477: Remove dependency on GD for avatars. 2005-02-22 06:18:23 +00:00
Steven Wittens 9f5a97d6b7 - Fix double spaces in contact.module help and code. 2005-02-22 06:16:40 +00:00
Steven Wittens d5db06d5e9 #17216: Restore missing "delete" link for blocks. 2005-02-22 06:16:06 +00:00
Dries Buytaert 1e15bed312 - Patch #17687 by Gerhard: removed some cruft. 2005-02-21 19:47:44 +00:00
Dries Buytaert 9ed1a74c5d - Patch by Goba: fixed whitespaces. 2005-02-20 10:58:22 +00:00
Steven Wittens bb08146c67 - Fixing broken search after sql rewrite patches
- Minor code style fixes.
2005-02-19 22:24:24 +00:00
Dries Buytaert 79f6941e9b - Fixed typo. Reported by KB. 2005-02-19 08:16:56 +00:00
Dries Buytaert 9e8d74b490 - Patch #16590 by kbahey: usability improvement: add 'subject' form to contact form. 2005-02-18 18:50:11 +00:00
Dries Buytaert d6b553c256 - Patch #16558 by JonBob: improved performance of node access checks. 2005-02-18 18:40:05 +00:00
Dries Buytaert 892d828629 - Fixed broken colspan. Reported by asimmonds. 2005-02-14 21:28:08 +00:00
Dries Buytaert 18bd62e71e - Fixed bugs in RSS handling of blogs. 2005-02-12 09:23:06 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert 95f4d9751e - Fixed broken colspan. 2005-02-11 19:10:28 +00:00
Dries Buytaert 9c5646288c - Patch #11366 by Junyor: fixed twin comment problem in HEAD. 2005-02-11 19:01:53 +00:00
Dries Buytaert 470fe1c1fd - Patch #16960 by Goba: fixed content type options. 2005-02-10 20:58:03 +00:00
Dries Buytaert 2ab6be1ed0 - Bugfix: the aggregator module's setting page was no more.
- Patch #16630 by Aldon: usability improvement: made the lifetime of news items configurable.
2005-02-10 20:33:18 +00:00
Dries Buytaert 08e7c8b3a7 - Patch #16246 by Moshe: "Here is a patch for node.module since thta hunk failed last time. Note that I've removed the 'delete' link since it doesn't work and is mostly obsolete with the 'mass delete' feature. I've also added smart destination andling to the 'url alias delete' feature." 2005-02-10 19:30:08 +00:00
Dries Buytaert 16993da34f - Fixed two broken URLs in the help text. 2005-02-10 19:19:43 +00:00
Dries Buytaert f228b1cb9c - Patch #16829 by kbahey: separated the forum block for sake of consistency with other blocks. 2005-02-10 19:14:50 +00:00
Dries Buytaert af2b27f4b4 - Patch #16962 by Neil: "The page module's long help text is a bunch of lies and then it briefly explains it's permissions. IMO it should just be taken out. I can't think of what help should be there." 2005-02-08 19:44:39 +00:00
Dries Buytaert 632918e571 - Patch #16963 by Neil: the upload's module help text was in bad shape. Edited it down to what is needed with links that actually work. 2005-02-08 19:43:02 +00:00
Dries Buytaert a364148a31 - Patch #16965 by Neil: removed some help text. 2005-02-08 19:36:46 +00:00
Dries Buytaert 501dd722a7 - Patch #16966 by Neil: don't document code in the help text. 2005-02-08 19:33:01 +00:00
Dries Buytaert d77ac14c31 - Patch #16972 by Neil: don't use align operations. Removed hard-coded CSS. 2005-02-08 19:28:33 +00:00
Dries Buytaert 08b1729b8d - Patch #16949 by Neil: fixed two HTML typos/brainos in the help text.
I found another HTML typo, and replaced a <u></u> by <strong></strong> because <u> does not validate as 'XHTML 1.0 stict'.
2005-02-08 19:17:51 +00:00
Steven Wittens 10e3d66d87 - Missing apostrophe 2005-02-08 18:43:37 +00:00
Steven Wittens 5f78d14373 #16993: Bad query in upload. 2005-02-08 16:12:10 +00:00
Dries Buytaert 1970f1d2a8 - Fixed warning in the feed generation (enclosures). 2005-02-07 14:16:27 +00:00
Dries Buytaert de0a0b7a81 - Patch #16462 by Moshe: book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page. 2005-02-06 09:37:10 +00:00
Steven Wittens 95907f0c2e - Fixing broken drupal_goto() after node submission on PHP5. 2005-02-04 20:48:37 +00:00
Steven Wittens 7fe195a07e - PHP5 fix due object references: node previewing should not put node output into form. 2005-02-04 20:14:05 +00:00
Steven Wittens ab816b6d6d - Fix warning due to old session variable. 2005-02-02 01:03:25 +00:00
Steven Wittens d56cf2b59c #10296: Clean up admin - content:
- Mass-delete functionality (with confirmation)
- Flexible filtering for the overview table based on status, type and taxonomy.
- Missing drupal_goto's
- Clean up watchdog messages
- Remove some dead code
2005-02-02 00:55:59 +00:00
Dries Buytaert fbec279e4c - Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
(Moshe: the patch against node.module failed to apply.)
2005-02-01 19:45:58 +00:00
Dries Buytaert 7ccc5a6b1b - Patch #16358 by James: added toolkit to enable better image handling. The avatar code and the upload module have been updated to take advantage of the new image API.
There are 5 main functions that modules may now utilize to handle images:

* image_get_info() - this function checks a file.  If it exists and is a valid image file, it will return an array containing things like the pixel dimensions of the image, plus the 'type' and common extension.
* image_scale - resizes a given image to fit within a given width / height dimensions, while maintaining aspect ratio (not distorting the image).  This function can be used to generate thumbnails, or ensure a maximum resolution, etc.
* image_resize - similar to image_scale (but will not respect aspect ratio - may well distort the image).
* image_rotate - rotate an image by X degrees
* image_crop - crops an image to a given rectangle (defined as top-left x/y coordinates plus a width & height of the rectangle).

Contribution modules will now be able to rely on these base manipulation functions to offer additional functionality (such as image nodes, photo galleries, advanced image manipulation, etc).
2005-02-01 16:27:43 +00:00
Dries Buytaert 7931c778d7 - Patch #16513 by James (slightly modified): export categories and enclosures to RSS feeds (and made RSS feeds extensible).
NOTE: this needs to be documented.
2005-02-01 14:09:31 +00:00
Dries Buytaert 96c039680a - Patch #16111 by chx: fixed some bugs in the db_rewrite_sql() code. 2005-01-31 20:45:10 +00:00
Dries Buytaert e872b005f1 - Patch #6195 by nedjo/James: allow posting to multiple node types. 2005-01-31 19:36:20 +00:00
Dries Buytaert 7ae04af1e0 - Patch by Jose A Reyero: fixed probem with db_rewriste_sql() in the comment.module. 2005-01-31 19:30:13 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 9f77077584 - Fixed a misplaced bracket that slipped in due to the db/node_rewrite_sql_patch. 2005-01-30 08:53:05 +00:00
Dries Buytaert 18a0cc2327 - Added a missing DISTINCT() to the pager query. Spotted by Steven. 2005-01-30 08:39:35 +00:00
Dries Buytaert de9179147d - I had to use DISTINCT for the tracker.module's SQL queries. 2005-01-29 22:21:22 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert e6d36892ab - Moved the upload settings to 'admin/settings'. 2005-01-29 08:31:17 +00:00
Steven Wittens cc3fd1715f - #16271: Clean up Admin - users - configure. 2005-01-28 20:49:00 +00:00
Dries Buytaert 92320b2b21 - Patch #10425 by ccourtne and walkah: added admin screens to maintain forums instead of forcing the user to add a taxonomy. 2005-01-28 15:47:03 +00:00
Dries Buytaert bb4dff0c92 - Patch #16399 by James: fixed typo in block.module. 2005-01-28 15:24:16 +00:00
Steven Wittens 07acc7920f Typos. 2005-01-27 22:53:35 +00:00
Dries Buytaert e941b2060c - Consistency: 'deleted' -> 'Deleted'. 2005-01-27 22:47:08 +00:00
Dries Buytaert b4d516f423 - Patch #13184 by JonBob: changed the 'my account' menu to a 'dynamic menu' so it can't be edited. 2005-01-27 21:34:38 +00:00
Steven Wittens ffcf5ab71b - Code style 2005-01-27 19:55:22 +00:00
Dries Buytaert 1f91662123 - Patch #16074 by Andre Molnar: add configuration option to show blocks only on pages of certain node type. 2005-01-27 19:41:01 +00:00
Dries Buytaert c0f06fbe67 - Patch #6025 by Jeremy: avoid data to get lost when two users are editing a node at the same time. 2005-01-27 14:45:42 +00:00
Dries Buytaert 467dbdc4a1 - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. 2005-01-27 12:57:08 +00:00
Dries Buytaert 3c21bdfd5d - Patch #16237 by Neil: removed dead code from page.module. 2005-01-26 23:09:29 +00:00
Dries Buytaert cbd9db90a3 - Patch #16197 by Neil: removed useless watchdog "long" help.
Less is more.
2005-01-26 23:02:44 +00:00
Dries Buytaert 7415e0b1c8 - Patch #16192 by Neil: moved the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. 2005-01-26 22:59:41 +00:00
Dries Buytaert dbcda92b76 - Patch #16021 by tangent: changed the format "/blog/feed/52" to "/blog/52/feed". 2005-01-25 20:38:03 +00:00
Dries Buytaert 01b8e7fdf0 - Patch #16181 by Ankur: fixed typo. 2005-01-25 20:29:19 +00:00
Dries Buytaert 7f4be97763 - Patch #16176 by Drumm based on mockup from Kika: improve access rules UI. 2005-01-25 20:27:09 +00:00
Dries Buytaert 696ac8a9d8 - Patch #15937 by wulff: made it so that titles of profile fields only need to be unique within a single category. 2005-01-24 21:39:58 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Dries Buytaert cdc4ca816d - Patch #15977 by Neil: made the forum module suggest a menu item. 2005-01-24 21:01:57 +00:00
Dries Buytaert c8ef017446 - Patch #15948 by matteo: the book module should call the nodeapi hook when printing printer-friendly pages. 2005-01-23 22:35:41 +00:00
Dries Buytaert 668e8cbf18 - Patch #16016 by Goba: fixed various bugs in filter tip display. 2005-01-23 22:29:28 +00:00
Dries Buytaert 9cd36863b0 - I had to modify chx's patch/change because it did not work with PHP5. Please double-check. 2005-01-23 16:20:10 +00:00
Dries Buytaert 898e02252d - Patch #16026 by chx: fixed node-level permissions. 2005-01-23 15:45:38 +00:00
Dries Buytaert d9382d8c15 - Patch #16028 by Goba: added class="form-password" to the password form. 2005-01-23 15:39:49 +00:00
Dries Buytaert 37f6473a88 - Patch #16023 by chx: the upload.module still used the old node_access_*_sql calls. 2005-01-23 15:37:58 +00:00
Dries Buytaert 1f54afa528 - Patch #15655 by Goba: allow blank days in the calendar to be styled using CSS, and tidied up the calendar's CSS. 2005-01-23 15:36:07 +00:00
Dries Buytaert 8d72382662 - Patch #15962 by Goba: fixed the association between the accesslog data and the nodes. 2005-01-23 15:32:32 +00:00
Steven Wittens a332228326 Documenting a tricky regexp. 2005-01-22 22:33:20 +00:00
Dries Buytaert 9252be8bc0 - Consistency glitch: 'operations' => 'Operations'. 2005-01-22 12:10:16 +00:00
Dries Buytaert c0814a2072 - Patch #15957 by Goba: reintroduce translateable watchdog types. 2005-01-22 09:38:48 +00:00
Dries Buytaert e3f1c92d26 - Patch #14936 by Goba:
+ The "add new comment" was missing for polls.

   + Renames $main to $teaser where appropriate to follow latest Drupal conventions.
2005-01-22 09:02:17 +00:00
Dries Buytaert aacfec0fc1 - Patch #15978 by Drumm: code improvement: theme_forum_display() has no business calling theme_page(). Lets have it return the output and then forum_page() can put it in a page. 2005-01-22 08:38:25 +00:00
Dries Buytaert 630dcebf43 - Patch #15843 by Ber: in book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15. 2005-01-19 22:13:14 +00:00
Dries Buytaert 3ec108eccc - Refinements by Walkah, based on suggestions of Steven and myself. 2005-01-19 19:30:04 +00:00
Dries Buytaert 74aa71e89b - Patch #15847 by James: added rel="nofollow" support. This is implemented as a filter so it can be enabled/disabled on a per-role basis (eg. some people might want to enable this for anonymous users but not for authenticated users). 2005-01-19 16:35:14 +00:00
Dries Buytaert 7bdca92aad - Patch #6847 by Gerhard: replaced vocabulary->nodes by a separate table and tidied up the taxonomy API a bit. This fixes a number of issues. 2005-01-19 16:22:52 +00:00
Steven Wittens 6adc3dd055 - Bad quote 2005-01-19 12:01:35 +00:00
Steven Wittens 4e6ceaae99 - Another code style fix. 2005-01-19 01:51:58 +00:00
Steven Wittens 09bd156ba2 - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
Steven Wittens 86af977eca - #15500: Fix tracker not showing nodes without comments.
- Tiny code style fix
2005-01-19 01:12:14 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Steven Wittens a1579a3aee - Reversing bad commit, sorry everyone. 2005-01-17 18:56:11 +00:00
Steven Wittens b45bd13d44 - Various code style fixes 2005-01-17 00:41:35 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Dries Buytaert f276f7f95b - Stripped white-space. 2005-01-15 09:03:39 +00:00
Dries Buytaert 816dc903db - Patch #15264 by Ber et al.: improved the story module's help text. 2005-01-15 08:01:09 +00:00
Dries Buytaert d14bc428c6 - Patch #15570 by Drumm: integrated the admin and system module. Renamed the callback as per Goba's suggestion. 2005-01-14 15:21:39 +00:00
Dries Buytaert a6e7e9c104 - Patch #15566 by drumm: must specify a userneme or password error happens when it shouldn't. 2005-01-14 15:15:19 +00:00
Steven Wittens bf3c137097 Fixing search tabs going back to "content" when searching on other tabs. 2005-01-14 03:24:20 +00:00
Steven Wittens 5314b9a14c - Some search doxygen tweaks 2005-01-13 17:34:01 +00:00
Steven Wittens b8b36bd941 - Fix comment pager counting unpublished comments. 2005-01-12 16:02:42 +00:00
Steven Wittens bf12368205 - Fix comment pager counting unpublished comments. 2005-01-12 16:02:20 +00:00
Steven Wittens bf09864c5d - Readding cron note. 2005-01-11 09:46:51 +00:00
Steven Wittens 92bc08b5b9 - Make the search settings page more user-friendly. 2005-01-11 09:41:49 +00:00
Steven Wittens 410f301006 Tweak api.module output 2005-01-11 07:04:37 +00:00
Steven Wittens fc4e2487b8 Various additions, improvements and fixes to the search documentation. 2005-01-11 06:49:11 +00:00
Steven Wittens 0b8ff5d19f - Oopsie 2005-01-11 05:01:15 +00:00
Steven Wittens 857082ce7e - Ensure word length <= 50 bytes 2005-01-11 04:50:00 +00:00
Steven Wittens 854fa41fb3 - Fixing duplicate rows error during indexing
- Fixing broken "pagerank" detection
2005-01-11 03:37:13 +00:00
Steven Wittens 59a2c464c7 - Fix search excerpt highlighter marking substrings of words too + small improvements 2005-01-10 23:37:26 +00:00
Dries Buytaert 3f34a78d18 - Renamed 'visit' to 'view'. 2005-01-10 20:26:02 +00:00
Steven Wittens 8655d4368a - Fixing a couple of watchdog() calls. 2005-01-09 12:58:53 +00:00
Dries Buytaert 075b443860 - Improved the watchdog message 2005-01-09 10:19:42 +00:00
Dries Buytaert 37d9be8f33 - Updated watchod call. 2005-01-09 10:07:17 +00:00
Dries Buytaert df6fe90286 - Updated two watchdog calls. 2005-01-09 10:06:26 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 0f91dce414 - Patch #15247 by Drumm: simplified the logout code. 2005-01-07 18:01:13 +00:00
Dries Buytaert 7f890fd1b1 - Patch #15184 by drumm: clean up user password mailing.
+ After mailing the password, set a message and go to the login form (was print a message as the entire page).
  + Provide feedback if neither field was filled in.
  + Make it a full menu callback instead of going through user_page().
  + Fixed some indentation.
  + Changed some double quotes to single quotes.
  + Made sure all if statements have {}.
2005-01-06 20:38:19 +00:00
Steven Wittens 9d6253374d #15185: Fix front page handling of blocks 2005-01-06 01:17:31 +00:00
Dries Buytaert fc143ca3af - Modified patch #15122 by killes: fixed some PHP5 problems. 2005-01-04 20:54:23 +00:00
Dries Buytaert fe58724f25 - Small bugfix + small improvement. 2005-01-04 19:52:33 +00:00
Steven Wittens 0bda8f4700 #14548: Add optional HTML help to filter.module's HTML filter. 2005-01-03 01:09:02 +00:00
Dries Buytaert ceb20b45e5 - Small change 2004-12-31 09:31:54 +00:00
Dries Buytaert 1dbe0dc2ee - Patch #14917 by UnConeD/Steven:
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.

2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.

3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert 26875e9b38 - Added missing space 2004-12-29 23:03:05 +00:00
Dries Buytaert 627699cc9e - Patch #14545 by nysus: don't grant access to files if the node is not accessible. 2004-12-29 23:01:01 +00:00
Dries Buytaert 09c55017f6 - Patch #14882 by Jeremy: removed some cruft: status = 2 is no more. 2004-12-29 18:41:52 +00:00
Dries Buytaert 5049c3e1e4 - Reorganized the code a bit 2004-12-28 22:42:47 +00:00
Dries Buytaert f4dfafe860 - Patch #14852 by Goba: show the number of posts at each day. 2004-12-28 18:47:44 +00:00
Dries Buytaert ddbec122dc - Forgot to close a tag in the help text. 2004-12-27 12:29:33 +00:00
Dries Buytaert f763bb731e - Made the ping module ping pingomatic.com, which in turn, will ping all the major ping services.
Less code to ping more services.
2004-12-27 12:27:02 +00:00
Dries Buytaert 49f4123976 - Fixed two SQL bugs in the queue.module. Fixes #14115. 2004-12-27 11:46:48 +00:00
Dries Buytaert 05ede21745 - Patch #6308 by gordon: allow node_submit() to be used by external interfaces. 2004-12-26 20:10:02 +00:00
Steven Wittens 57e402e0d0 #10949: Incorrect output with invalid term id 2004-12-24 06:48:57 +00:00
Steven Wittens 61b174e7d2 #11548: node.module - Ensure that only valid fields are saved 2004-12-24 06:44:11 +00:00
Dries Buytaert fde5f1bf6f - Patch #14709 by matteo: added missing call to the nodeapi's 'view' hook. 2004-12-23 23:26:14 +00:00
Dries Buytaert b2e04ead89 - Patch #14710 by tangent: only show post button if preview is optional or if we are in preview mode. We show the post button in preview mode even if there are form errors so that optional form elements (e.g., captcha) can be updated in preview mode. 2004-12-23 06:47:24 +00:00
Dries Buytaert 046536f470 - Patch #12366 by mathias: fixed missing book edit tab. 2004-12-22 20:47:47 +00:00
Dries Buytaert 9f2952aa3f - Bug #14609: improved the status messages and avoid empty roles being saved. 2004-12-22 08:51:39 +00:00
Dries Buytaert 0b18bf0e6b - Patch #14614 by Neil: made the archive module respect the node-level permissions. 2004-12-20 22:01:17 +00:00
Steven Wittens 9f7b16ada9 #12793: Remove dependency of node.module on search.module. 2004-12-20 14:34:41 +00:00
Steven Wittens e7b0b227b9 Making comment moderation query PGSQL/ANSI compatible. 2004-12-20 02:05:00 +00:00
Dries Buytaert 78c24e67c0 - Bugfix: the book module incorrectly assumed that there is an active revision if n.moderate = 0. We can (and need) to rewrite this when the revision changes hit core. In essence, we need an efficient query to retrieve the 'last puslished revision that is not in the moderation queue'. 2004-12-18 10:27:28 +00:00
Dries Buytaert 7307de5c9e - Patch #14532 by andre molnar: tidied up some block.module code. 2004-12-18 07:52:59 +00:00
Dries Buytaert 22869afd38 - Patch #14262 by Richard: help text improvements for the tracker module. 2004-12-16 21:42:30 +00:00
Dries Buytaert 2b17b3a966 - Patch #13907 by Neil: less ways to set the page title.
* Less logic in theme code.
   * Encourages use of the menu system.
   * Easier to find where a title or breadcrumb comes from in other people's code because there are less places to look. Look in menu and then grep for the appropriate set function. Looking for calls to theme_page() is hard because there are too many of them.
   * Very slightly more efficient.
2004-12-15 21:19:42 +00:00
Dries Buytaert 5628256e69 - Patch #14288 by Goba: "the archive module calendar indexes the array used to build up the header cells by the short names of the days. In Hungary, we have both Wednesday and Sunday start with the same two letters, so if I translate the short versions with the same two letters, the second associative array index will overwrite the first. The obvious soluion was to swap the array, and index by the full day name, which is expected to be unique in all languages." 2004-12-14 06:46:08 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert a0291bb936 - Patch #14209 by nysus: improved the clarity and readability for a group of radio buttons for a block's visibility settings. 2004-12-11 12:32:01 +00:00
Dries Buytaert 260f886699 - Fixed typo: db_queryd() -> db_query() 2004-12-11 12:26:40 +00:00
Dries Buytaert d61e7a663e - Bugfix: make sure to update the node_comment_statistics table when a node is updated. 2004-12-11 11:41:17 +00:00
Dries Buytaert 5520513879 - Modified patch by Goba: don't save user roles in the serialized data field of the user table. 2004-12-08 19:41:16 +00:00
Dries Buytaert 3d491defbd - Patch #14035 by Goba: fixed problem with UTF-8 conversion when mixing LOWER() and strtolower(). 2004-12-07 17:42:35 +00:00
Dries Buytaert 33baf53cdd - Added a simple contact module to core. 2004-12-07 17:03:46 +00:00
Dries Buytaert 60352821bf - Refactored the queue module: removed the queue module's field from the node table. With help from Gerhard.
- Slight addition to INSTALL.txt with regard to PHP versions.

- Updated/reworded some node type descriptions as per Boris' suggestions.

- Adding missing {} around a table name in update.php.
2004-12-07 16:55:38 +00:00
Dries Buytaert 1365740f6e - Patch #14006 by Neil:
* user/view/$n has been replaced with user/$n.
   * More blank lines in the right places.
   * Prevent unwanted case fallthrough.
2004-12-07 07:24:46 +00:00
Dries Buytaert 3cf4f14a9c - Patch #14005 by Richard: rewrote the ping module's built-in documentation. 2004-12-07 07:06:19 +00:00
Dries Buytaert 255e3b11eb - Fixed colspan bug reported by Steven. 2004-12-06 13:23:48 +00:00
Dries Buytaert 63f252113a - Added a special category for throttle messages. 2004-12-04 12:07:58 +00:00
Dries Buytaert 7ad0dfdc6d - Some aggegrator improvements:
+ Moved the block configuration settings to the block administration pages like we did with the other modules (also, administrators had to enable the aggregator blocks twice).
   + Small UI changes to the 'add news feed' page.
2004-12-04 12:02:09 +00:00
Dries Buytaert 5151a96f65 - Patch #13828 by Moshe: tidied up the story module.
- Updated the help text a bit.
2004-12-04 10:00:22 +00:00
Dries Buytaert e4a3b6f89f - Patch #13816 by Neil: tidied up the comment module code a bit. 2004-12-02 20:24:53 +00:00
Dries Buytaert 55df38710f - Patch #13786 by drumm: fixed handling of HTTP 301 response codes. 2004-12-02 18:37:04 +00:00
Steven Wittens 925bd41585 Search: wrong parameter order on search_wipe(). 2004-12-02 06:45:18 +00:00
Steven Wittens 2afd987398 Search: indexing should invoke nodeapi to catch all user-visible data (e.g. file attachment names). 2004-12-02 06:44:55 +00:00
Dries Buytaert aa1413d82e - Fixed #13643: increased the maxlength of the 'path to custom logo'-setting. 2004-11-30 18:40:24 +00:00
Dries Buytaert 8f049a4e75 - Modified patch #6475 by Killes: sites -> drupalsites -> drupal-sites 2004-11-30 18:25:39 +00:00
Dries Buytaert 95610bdd6c - Patch #13647 by Goba:
1. Fixed broken watchdog calls: two watchdog calls omitted the type parameter, and thus injected logs into the type field, instead of the message field.
   2. Removed t() functions from user contributed content.
2004-11-29 17:52:35 +00:00
Dries Buytaert 29337ad8bb - Patch #13581 by Steven: Db_query() allows a variable amount of parameters so you can pass the query arguments in. There is however an alternative syntax: instead of passing the query arguments as function arguments, you can also pass a single array with the query arguments in it. For example the following two statements are equivalent:
db_query($query, $a, $b, $c);
db_query($query, array($a, $b, $c));

This usage is particularly interesting when the query is constructed dynamically, and the amount of arguments to pass varies. In that case we use the second method to avoid using call_user_func_array(). This behaviour is not documented explicitly, but it is used in several places.

However, db_query_range() and pager_query() do not support this syntax properly, which means there are several pieces of code which still revert to the ugly call_user_func_array() call.

This patch updates db_query_range() and pager_query() so they support the array-passing method. I also added documentation about this method to each of the db functions.

I also cleaned up the code for db_query (it was weird and hard to understand) and moved db_query() and db_queryd() from database.xxxxx.inc to database.inc: it was the same between both mysql and pgsql, as it doesn't do anything database specific. It just prefixes the tables and inserts the arguments. The actual db query is performed in _db_query(), which is still in database.xxxxx.inc.

Finally, I updated several places with the new syntax, and the code is a lot cleaner. For example:
- array_unshift($params, "SELECT u.* FROM {users} u WHERE $query u.status < 3");
- $params[] = 0;
- $params[] = 1;
- $result = call_user_func_array('db_query_range', $params);
+ $result = db_query_range("SELECT u.* FROM {users} u WHERE $query u.status < 3", $params, 0, 1);

and

- return call_user_func_array('db_query_range', array_merge(array($query), $args, array((int)$pager_from_array[$element], (int)$limit)));
+ return db_query_range($query, $args, (int)$pager_from_array[$element], (int)$limit);

I've tested it on mysql. I didn't alter the actual db behaviour, so pgsql should be okay too.

This patch is important because many people avoid the call_user_func_array() method and put data directly into the db query.  This is very, very bad because the database prefix will be applied to it, and strip out braces. It's also generally bad form as you have to call check_query() yourself.  With the new, documented syntax, there is no more excuse to put data directly in the query.
2004-11-29 13:13:29 +00:00
Dries Buytaert e35137a5ad - Patch #12555 by svemir: fixed problem with the 'Preview comment' button not being present when previews are optional. 2004-11-29 12:59:21 +00:00
Dries Buytaert e7ce1e3ccb - Patch #11977 by matteo: added extra DISTINCT()s to two SQL queries to make them work with node-level permissions. 2004-11-29 12:52:44 +00:00
Dries Buytaert b83b34018f - Patch #10697 by matteo: avoid that administrators can create nodes with the wrong node type. 2004-11-29 12:49:17 +00:00
Dries Buytaert d8113fda7e - Small code improvements. 2004-11-29 09:31:28 +00:00
Dries Buytaert 254233da61 - Fixed typo and reworded the filter. 2004-11-28 14:15:12 +00:00
Dries Buytaert 167c59e4da - Beautified the contents of the table.
- Removed some dead code.
2004-11-28 13:55:17 +00:00
Dries Buytaert a9ae831493 - Made it possible to sort the referrers by last visit. 2004-11-28 13:46:26 +00:00
Dries Buytaert 3981e571f9 - Fixed typo. 2004-11-28 13:31:51 +00:00
Dries Buytaert 70fcf51e84 - Refactored the statistics and watchdog module (views). The most important
changes are:

  1. Simplified the statistics pages: there are less pages and on the
     remaining pages there is a lot less visual clutter (less columns and
     better presentation).

  2. Reorganized the 'administer - logs' menu: flattened the menu structure
     and removed a number of links.

  3. Improved performance.  Most statistics pages used about 160 slow SQL
     queries which made the statistics pages fairly unusable on my system.
     The new pages use at least 10 times less SQL queries and render much
     faster.  They are actually usable.

  4. There is now a 'track'-tab on node pages, and a second subtrab on the
     user accounts 'track'-tab for people with the 'access statistics'
     permission.  They can be used to resp. track the node and the user.
     This makes the statistics more accessible.

  5. Changed the way watchdog messages are filtered.  This makes it easier
     to introduce new watchdog types.

  6. Reworked the statistics module's permissions.

  7. Less code: 223 insertions(+), 343 deletions(-).

  8. Fixed several glitches: for example, the statistics pages sorted the
     'Name' column by user ID instead of by name.  Unfortunately, it is
     too difficult to backport these to DRUPAL-4-5.

  TODO:

  1. Review the statistics modules help pages.

  2. Help fine-tune the interfaces/views.

  NOTES:

  1. You'll want to run update.php.
2004-11-28 12:28:35 +00:00
Dries Buytaert e1cf88e7f8 - Modified patch #11840 by Stefan: added conctext-sensitive help text to the 'revision'-page. 2004-11-27 10:02:06 +00:00
Dries Buytaert b8a556b81b - Bug 13503: updating the locale settings might impact the interface (eg. menu's) so we have to flush the cache. 2004-11-27 09:52:57 +00:00
Dries Buytaert 8b2f6699e4 - Patch #10693 by Ax: fixed broken (external) link in the taxonomy module's help. 2004-11-27 09:30:32 +00:00
Dries Buytaert 0c6a18cb44 - Patch #5942 by TDobes: fixed theme stuff after multi-site configuration patch. 2004-11-25 06:17:03 +00:00
Dries Buytaert 4726c93156 - Patch #13443 by Moshe: got rid of the semi-implemented 'page link' feature. All themes currently support primary and secondary links so page links are now deprecated. Check your contributed modules and update them accordingly. 2004-11-24 22:56:21 +00:00
Dries Buytaert 5d759ccbb9 - Patch #5942 by jhriggs and Adrian:
+ added support for multi-site configurations.
    + tidied up some old cruft and added code comments.
2004-11-24 22:44:01 +00:00
Dries Buytaert 062a8abdea - Patch #10990 by TDobes: adds a "create new blog entry" link at the top of each user's own blog page, similar to the "post new forum topic" link displayed at the top of forum pages. This adds consistency as well as convenience for users. 2004-11-24 20:06:10 +00:00
Dries Buytaert 30110a8770 - Patch #6166 by Moshe: node preview should not display links. Push the links to the theme instead of the theme having to pull them in using node_link().
TODO:
    1. Update theme upgrade instructions in the handbook: node_link() is gone.
    2. Remove page_link() just like we removed node_link().
2004-11-23 23:11:59 +00:00
Dries Buytaert 9574766ad8 - Patch by Stefan: wrapped the help texts in <p></p> tags. Helps improve consistency. 2004-11-23 22:20:41 +00:00
Dries Buytaert e19a3cf42d - Patch #12363: fixed glitch in user_access() as pointed out by TDobes. 2004-11-23 21:52:13 +00:00
Dries Buytaert b442fad027 - Patch #13263 and #13265 by arnab: added word-based truncation and made the comment module use it to extract subjects. 2004-11-21 20:17:44 +00:00
Dries Buytaert fa97839088 - Patch 13180 by chx: renamed check_query() to db_escape_string() and implemtented it properly per database backend.
Read the manual for pg_escape_string:  "Use of this function is recommended instead of addslashes()." Or read sqlite_escape_string: "addslashes() should NOT be used to quote your strings for SQLite queries; it will lead to strange results when retrieving your data."
2004-11-21 08:25:17 +00:00
Steven Wittens dc32e54f31 Search.module:
- Caching index statistics
- Minor code cleanup
2004-11-18 21:28:34 +00:00
Steven Wittens 90e67a3acb Search indexing bug: last updated timestamp needs to take last comment timestamp into account. 2004-11-18 21:16:30 +00:00
Dries Buytaert 38c91a8d95 - Patch #8506 by Gerhard: added basic node_load() caching. 2004-11-17 22:14:43 +00:00
Dries Buytaert 9bf33e5ac8 - Added generic flood control mechanism to throttle certain operations per hostname (eg. posting comments, requesting passwords, sending e-mails). See flood_register_event() and flood_is_allowed() for details. 2004-11-15 21:17:25 +00:00
Dries Buytaert f67c046d40 - Modified patch #8552 by Gerhard: added 'add child page' link to book pages you can edit. 2004-11-15 12:49:59 +00:00
Dries Buytaert f37a65cab9 - Patch #12353 by Stefan: usability improvement: don't show 'throttle fields' unless the throttle module is enabled. 2004-11-15 11:26:04 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00