Commit Graph

173 Commits (87e5399a9ec981a4e217f1d82b0491fcd4677269)

Author SHA1 Message Date
Dries Buytaert 8e0b516022 - Patch #26233 by Goba: fixed problem with block regions being buggy. 2005-07-03 15:27:52 +00:00
Dries Buytaert 2c10ff4b5f - Fixed problems with filter formats and problem with XML-RPC server. 2005-06-29 19:53:14 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert 2abaae6baf - Patch #22192 by tostinne: fixed invalid XHTML code 2005-05-22 12:48:47 +00:00
Dries Buytaert 2debcfb1ef - Patch #15595 by Stefan and Djun: improved status messages.
TODO: we should write down a couple guidelines for these document them in
        the PHPDoc code of drupal_set_message()!  .
2005-05-05 22:22:46 +00:00
Dries Buytaert cf1224d57b - Patch #21939 by Usability Poobah Chris: added missing </p> tag. 2005-05-05 11:24:21 +00:00
Dries Buytaert 8bfcf2c2e4 - Patch #21445 by Goba: added missing t() function. 2005-05-01 18:37:18 +00:00
Dries Buytaert a93cf89665 - Patch #21353 by chx: implemented PHP-mode for blocks. 2005-04-30 18:16:38 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 199aab5ff5 - Improved consistency. 2005-04-18 20:31:50 +00:00
Dries Buytaert f33f9a5fcd - Patch #19965 by Robin Monks: fixed problem with duplicate block titles. 2005-04-12 18:52:47 +00:00
Dries Buytaert c7c33cc174 - Modified patch #19694 by chx: makes sure that block.module deals by default only with regions 0 and 1 as it does now but lets you use block_list with any region you define. This opens many possibilites. You may do a multi region module, with your admin UI using the blocks table as storage and the block_list matcher. Or you may do a sections module using the block matcher without cluttering the current blocks list. 2005-04-04 12:27:05 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Steven Wittens c3f1f7345e - #18939 (Stefan): Always use paragraph tags around page help text. 2005-03-18 07:07:04 +00:00
Dries Buytaert 9a47bc4e7e - Renamed some more 'region's to 'sidebar's 2005-03-06 15:06:19 +00:00
Dries Buytaert 344f33f6af - Patch by Neil: fixed typo. 2005-03-05 23:00:32 +00:00
Dries Buytaert 11dd94bde5 - Patch #18382 by Neil: usability improvement: organized the blocks on the block administration page by region. (I wanted to do that myself!) 2005-03-05 09:09:07 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Steven Wittens 4a9b9f4aca - Block admin usability: display block title if no description was given. 2005-03-03 05:54:25 +00:00
Steven Wittens d4f1b435a1 - #17868: Remove hardcoded align="center" 2005-02-27 02:48:57 +00:00
Steven Wittens d5db06d5e9 #17216: Restore missing "delete" link for blocks. 2005-02-22 06:16:06 +00:00
Dries Buytaert bb4dff0c92 - Patch #16399 by James: fixed typo in block.module. 2005-01-28 15:24:16 +00:00
Steven Wittens 07acc7920f Typos. 2005-01-27 22:53:35 +00:00
Steven Wittens ffcf5ab71b - Code style 2005-01-27 19:55:22 +00:00
Dries Buytaert 1f91662123 - Patch #16074 by Andre Molnar: add configuration option to show blocks only on pages of certain node type. 2005-01-27 19:41:01 +00:00
Steven Wittens 9d6253374d #15185: Fix front page handling of blocks 2005-01-06 01:17:31 +00:00
Dries Buytaert 7307de5c9e - Patch #14532 by andre molnar: tidied up some block.module code. 2004-12-18 07:52:59 +00:00
Dries Buytaert 6e3eb60aab - Removed some cruft: left-over xxx_help_page() functions. 2004-12-11 14:13:24 +00:00
Dries Buytaert a0291bb936 - Patch #14209 by nysus: improved the clarity and readability for a group of radio buttons for a block's visibility settings. 2004-12-11 12:32:01 +00:00
Dries Buytaert f37a65cab9 - Patch #12353 by Stefan: usability improvement: don't show 'throttle fields' unless the throttle module is enabled. 2004-11-15 11:26:04 +00:00
Dries Buytaert 9979aceab0 - Patch #12783 by Stefan: various small consistency/usability improvements. 2004-11-15 11:16:39 +00:00
Dries Buytaert ef95773b1c - Modified patch by Jeremy: throttle module improvements and fixes:
+ throttle module: flush cache when the throttle enables/disables
   + throttle module: prevent throttle being enabled by 0 users or guests when disabled
   + system module: remove requirement for statistics.module
   + block module: update help text to reflect access log is no longer required
   + statistics module: throttle is now enabled/disabled, not using levels 0-5
2004-11-14 20:20:09 +00:00
Dries Buytaert 3769665b33 - Refactored the throttle module. Patch by Jeremy and me.
* There are only two throttle levels instead of 5, namely 'enabled' and 'disabled'.  This makes it a _lot_ easier to predict when the throttle will kick in.  However, if you maintain a module that is throttle-aware, it needs to be updated!

  * The throttle mechanism now uses the current number of anonymous users or the current number of authenticated users to kick in.  This is a _lot_ more intuitive than the old throttle mechanism.

  * The throttle block has been removed -- you can now use the "Who's online" block to determine the good throttle settings.

  * Most of the documentation has been removed because it was deprecated.

  * It's less code!
2004-11-07 22:47:00 +00:00
Dries Buytaert b3adcf05a3 - Patch #11875 by Neil Drumm: block module configuration improvements.
The primary goal of this patch is to take the 'custom' and 'path' columns of the block overview page and make them into something understandable. As of Drupal 4.5 'custom' lacked an explanation which wasn't buried in help text and path required dealing with regular expressions.

Every block now has a configuration page to control these options. This gives more space to make form controls which do not require a lengthy explanation. This page also gives modules a chance to put their block configuration options in a place that makes sense using new operations in the block hook.

The only required changes to modules implementing hook_block() is to be careful about what is returned. Do not return anything if $op is not 'list' or 'view'. Once this change is made, modules will still be compatible with Drupal 4.5. Required changes to core modules are included in this path.

An additional optional change to modules is to implement the additional $op options added. 'configure' should return a string containing the configuration form for the block with the appropriate $delta. 'configure save' will come with an additional $edit argument, which will contain the submitted form data for saving. These changes to core modules are also included in this patch.
2004-10-31 07:34:47 +00:00
Dries Buytaert df4ec83120 - Patch #10677 by drumm: removed dead code. Leftover. 2004-10-14 21:27:33 +00:00
Steven Wittens 9e4399aae8 #10677: Confirmation when deleting a block + unifying confirmation screens. 2004-10-14 15:28:24 +00:00
Dries Buytaert cca3c34faa - Patch #11401 by Goba: documentation updates:
+ Made error strings in blog.module consistent.
   + Explained a bit better what the RSD setting is for in the blog module.
   + Removed the notes about PHP content from block module and book module, since everything is handled via the input formats now.
2004-10-09 06:29:16 +00:00
Steven Wittens 30b69380af - #10689: Group permissions by module in UI + minor code cleanups.
- Adding a drupal_goto to the block admin.
2004-09-17 22:07:17 +00:00
Dries Buytaert 5c7983c4de - Patch #8179 by JonBob: reintroduced menu caching. 2004-09-16 07:17:56 +00:00
Dries Buytaert 7b716e8e77 - Patch #10622 by Adrian: fixes various PostgreSQL related problems.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
  2) Archive module fails with Postgres
  3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
  4) Book module fails with Postgres
  5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
  6) Creating accregator_item_table in PostgreSQL
  7) Postgres - Polls not displayed on Poll Page
  8) Blog module has sql errors with postgres

  This should not affect MySQL users (hopefully).
2004-09-08 15:38:26 +00:00
Steven Wittens 51cf18e531 - #9292: Make Drupal (somewhat) PHP5 compatible. xtemplate is still horribly broken. 2004-08-22 17:03:42 +00:00
Dries Buytaert 94e30bf776 - Patch by JonBob: for consistency and readability, add brief descriptions of each source file inside the @file comment block at the head of the file. This helps with Doxygen indexing, and also allows neophytes to see what a file does immediately on opening the source, regardless of the organization of the hooks. 2004-08-21 06:42:38 +00:00
Dries Buytaert fa25c7a0ca - Code improvements by Stefan: use capital letters for header titles (and added some missing t() functions). 2004-08-19 15:41:57 +00:00
Dries Buytaert 2f33b939c5 - Patch #9983 by Stefan: usability improvement: made sure all status messages start with a capital letter. 2004-08-16 18:02:48 +00:00
Steven Wittens 660f99287d The Input formats - filter patch has landed. I still need to make update instructions for modules and update the hook docs.
Here's an overview of the changes:
1) Multiple Input formats: they are complete filter configurations (what filters to use, in what order and with which settings). Input formats are admin-definable, and usage of them is role-dependant. For example, you can set it up so that regular users can only use limited HTML, while admins can free HTML without any tag limitations.
The input format can be chosen per content item (nodes, comments, blocks, ...) when you add/edit them. If only a single format is available, there is no choice, and nothing changes with before.

The default install (and the upgrade) contains a basic set of formats which should satisfy the average user's needs.

2) Filters have toggles
Because now you might want to enable a filter only on some input formats, an explicit toggle is provided by the filter system. Modules do not need to worry about it and filters that still have their own on/off switch should get rid of it.

3) Multiple filters per module
This was necessary to accomodate the next change, and it's also a logical extension of the filter system.

4) Embedded PHP is now a filter
Thanks to the multiple input formats, I was able to move the 'embedded PHP' feature from block.module, page.module and book.module into a simple filter which executes PHP code. This filter is part of filter.module, and by default there is an input format 'PHP', restricted to the administrator only, which contains this filter.
This change means that block.module now passes custom block contents through the filter system.
As well as from reducing code duplication and avoiding two type selectors for page/book nodes, you can now combine PHP code with other filters.

5) User-supplied PHP code now requires <?php ?> tags.
This is required for teasers to work with PHP code. Because PHP evaluation is now just another step in the filter process, we can't do this. Also, because teasers are generated before filtering, this would result in errors when the teaser generation would cut off a piece of PHP code.

Also, regular PHP syntax explicitly includes the <?php ?> tags for PHP files, so it makes sense to use the same convention for embedded PHP in Drupal.

6) Filter caching was added.
Benchmarking shows that even for a simple setup (basic html filtering + legacy URL rewriting), filtercache can offer speedups. Unlike the old filtercache, this uses the normal cache table.

7) Filtertips were moved from help into a hook_filter_tips(). This was required to accomodate the fact that there are multiple filters per module, and that filter settings are format dependant. Shoehorning filter tips into _help was ugly and silly. The display of the filter tips is done through the input format selector, so filter_tips_short() no longer exists.

8) A more intelligent linebreak convertor was added, which doesn't stop working if you use block-level tags and which adds <p> tags.
2004-08-10 18:34:29 +00:00
Dries Buytaert 9bbdb71ee4 - Patch #9330: ucfirst() gives problem when used with multibyte charset.
Replaced the use of ucfirst() with a CSS-based solution.
2004-08-06 20:15:32 +00:00
Steven Wittens f037130086 - Oopsie when committing. 2004-08-06 11:11:30 +00:00
Steven Wittens 300f91f4a7 - Cleaning up the rediculously long 'if' statement for checking block visibility.
- #9811: Remove session ID before matching block path
2004-08-06 11:10:15 +00:00
Dries Buytaert c6b1eaa20d - Patch #9775 by TDobes: consistency operation. Changed to "edit foo," "delete foo," and "view foo" links into simply "edit," "delete," and "view". 2004-08-05 05:40:53 +00:00
Dries Buytaert a7a5f51c7e - Simplified the block help a bit by removing some dated information. It
should be simplified more.
2004-08-01 19:26:07 +00:00