Commit Graph

54 Commits (876536a955b783c4f82185dc45557ef3b1bd949f)

Author SHA1 Message Date
Dries Buytaert 9c43e8fc7a Extremely large commit:
- Fixed tiny quote problem in account.php.

- Fixed tiny bug in comment.inc.

- Fixed tiny bug in comment.module.

- Fixed tiny bug in meta.module.

- Simplified user_access() API.

- Rewrote link system: still needs fine-tuning and testing so don't
  upgrade if you are running a production site. ;)

  Updated all modules and themes to reflect this change.  All other
  themes and modules need updating too!
2001-06-29 22:08:57 +00:00
natrak 564e3ed30f - Fixed some HTML errors in the help. 2001-06-26 14:58:00 +00:00
Dries Buytaert 6d107b084c - Fixed bug in account.module (reported by Gerhard and Kristjan).
- Incorporated some of the suggestions.  More to come.
2001-06-21 21:35:03 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert 29e0e0fc66 - Made it so that usernames can contain spaces. Like that, people can
use their full name as their username.
2001-06-19 06:55:19 +00:00
natrak 542b60a19a Changes
- Modifed form_select() to accept an optional 6th parameter which is appeneded
  to the select tag. $value can now also be an array. This allows for multiple
  selects:
  form_select($header, $name, $values, $options, $help, "multiple=\"true\" size=\"10\"");
- Updated account.module to use the extended form_select() functionality.
2001-06-18 20:51:57 +00:00
natrak 6e64691450 Changes
- Moved account_password() and account_validate() to user.inc.
- Greatly reduced the number of SQL calls in account_save() when editing an
  account. Now uses one db_query() call instead of 1 + (2 * # of access
  granted).
- Fixed access not being saved when account was added.
- Should now be possible to edit and add accounts. There were certain bugs
  before that would cause odd errors.
2001-06-18 20:29:36 +00:00
Dries Buytaert 3d73a48edc - Merged "system settings" and "module settings" into one page. IMHO
it wasn't a good idea to split them up in first place, and it turned
  out to be quite hard to decide where to put some variables.

  Also moved some variables around and even renamed a few variables
  while doing so.

- Added a page_header() and page_footer() to all top-level .php pages.
2001-06-17 20:35:48 +00:00
Dries Buytaert 03c06a86eb Oops, a rather large commit:
- Changed meta.module, node.module and index.php to use comma-seperated
  lists of attributes rather then "foo=a,bar=b" lists.  This makes it a
  a lot easier to use both modules.  In addition, error handling can be
  discarded as it can't be made any simpler, really ...

  It fits rather nicely in Drupal's design so I'm getting more and more
  happy with this meta.module (but we are not 100% there yet).

- node.module, node.inc:

   + Improved the node-related admin interface so that navigating back
     and forth the administrative menus is made both easier and faster.

   + Removed some redundant database fields from the node table.  See
     2.00-to-x.xx.sql!

   + Added 2 news hooks called "node_insert" and "node_update".  Just
     like this is the case with the existing hook "node_delete" these
     new hooks will automatically get called when a node has been
     inserted or udpated.  Note that this is an optional call-back that
     only needs to be implemented when required.  With the addition of
     these two hooks, the node mechanism (version 1) is pretty well
     completed.

- watchdog.module:
   + Fixed bug whit the 'regular messages' query in the watchdog.module.

- book.module:
   + Fixed bug in book.module: the 'parent' was not set properly when
     updating a book page.
   + Made it so that older versions of a book page are automatically
     reactived upon deletion of the most recent version, i.e. when
     doing a version roll-back.

- comment.inc:
   + Undid Remco's patch to comment.inc; it does not work in some cases.


- conf.module:
   + Fine-tuned some of the options in conf.module a bit.

- marvin.theme:
   + Visual changes to make it look better on Windows browsers.  Mind
     to give some feedback on this?
   + Fixed 3 HTML typos/bugs.
   + XHTML-ified the theme at a best effort basis; I didn't carry the
     XHTML specification with me.
   + Made use of the theme_slogan variable to display the site's slogan.
   + As soon we have at least one valid XHTML theme we can wonder on how
     to integrate other XML namespaces (cfr. MathML story at drop.org).

- database.mysql:
   + Updated database.mysql so that it contains all the latest "database
     patches".
2001-06-17 18:31:25 +00:00
natrak dc4a5bfc55 - Fixed a bug while editing an account it would loose the account info along
the way.
2001-06-16 17:42:21 +00:00
natrak 21386979e7 Changes
- Added a conf option to disable/enable user registrations.
- Added a add account feature to account.module.
- Moved some functions from account.php to account.module.

Todo
- Move most (all?) of account.php to account.module.
2001-06-15 11:34:06 +00:00
Dries Buytaert 1045715f44 - Added very basic 'filters' to the watchdog.module which should make it
easier to sort through all the watchdog "noise".  I'm sure the current
  filters will do for 99% of all the Drupal sites though.

  (Sorry for the awful color scheme, Coney but I can't do any better.)
2001-06-15 10:43:39 +00:00
Dries Buytaert c56ee67e29 - Changed field_set(), field_get() and field_merge() to use ',' and
'=' instead of ';' and ':'.  It is considered to be more readable.
  --> A _first_ step towards and improved index.module.  Stay tuned
      for more.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

- Changed all 'attribute' to 'attributes'.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

  + Important:
     This might require to ieni-wieni small update to your custom
     themes and/or node-related modules:
      - themes: node_index($node->attribute) -> node_index($node)
      - node modules: attribute -> attributes
2001-06-11 20:01:13 +00:00
Steven Wittens 10c96ede0a Typo: "oparations". 2001-06-10 12:18:58 +00:00
Dries Buytaert 792de8c537 - Fixed problem with account.module listings.
(Reported by Remco.)
2001-06-07 16:28:16 +00:00
Dries Buytaert 6c38796219 - Fixed bug in account.module.
- Simplified field_set() API.

- Made UnConeD's cool common timestamp format conform with the
  general coding style.  Sorry to be so picky about this but I
  really can't help it. ;)
2001-05-17 19:14:50 +00:00
Dries Buytaert 6f02738cc2 - Removed the "history"-field from the SQL table "users" and added
this information to the "users"-field in both nodes and comments.
  This database/table change reduces the number of SQL queries and
  makes Drupal scale better where a lot of voting/moderation takes
  place.  Last but not least it can be considered a new and better
  foundation for future moderation metrics / algorithms.  In other
  words: it is plain better.

    --> oops, all voting/moderation results will be lost!
    --> requires database update, see "2.00-to-x.xx.sql"!

- Updated database/database.mysql
2001-05-16 20:54:37 +00:00
Dries Buytaert 0000c2e401 - Code review: improved search API, tidied up the search related code,
and fixed a tiny bug when searching for users.
2001-05-09 18:28:09 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00
Dries Buytaert 343e71c8eb CHANGES:
- Added moderator permissions to nodes.

- Added moderator support to structure.module.

- Added new moderate.module.

- Renamed moderation.module to queue.module to avoid confusing.
  Updated theme yaroon as it seems to have a hard-coded reference
  to moderation.module.

- Polished on:
   + account.module: improved access list
   + fixed HTML typo in node.module

ACTIONS:

- Jeroen: can jeroen2.theme be removed from ./themes/yaroon?
2001-05-02 20:52:19 +00:00
Dries Buytaert fead09a8de Welp. Large commit ahead.
CHANGES:

- Added "read" and "write" permissions into drupal but removed
  it again because - when finished after 3 hours of work - it
  was considered nothing but added complexity that didn't buy
  us anything. :I

  (I'll explain this in detail on the mailing list, I guess.)

- Added a very simple help.module to group all available
  documentation on a single page.

- Fixed bug in node_control(), book.module: UnConeD forgot to
  global $user when updating the combobox code.

- Removed static wishlist.module: in future, the wishlist can
  be maintained as a page in our collaborative book.

- Revised most of settings.module: tidied up the code and the
  descriptions to accompany the settings and introduced a new
  "default maximum number of nodes to display on the main page"
  variable.

- Revised most of comment.module: the administration interface
  looks better now, integrated node permissions, and -finally-
  made it possible to delete comments.

- Polished on:
   + account.module
   + structure.module
   + locale.module
   + module.module
   + forum.module

- Form-ified:
   + account.php
   + account.module
   + setting.module
   + cvs.module
   + submit.php
   + comment.module
   + forum.module
   + book.module
   + page.module
   + locale.module

- Updated CHANGELOG

INFO:

- Designed a "generic tracker system with optional backends"
  on paper.  The idea is to allow registered users to hot-list
  certain topics, individual nodes or threads (comments) and
  to "plug-in" output backends like - for instance - an e-mail
  digest.  The design requires "intelligent blocks" though.


TODO:

- I want to tidy up the headline.module and backend.class as
  well as merge in headlineRSS10.module.  Julian spent quite
  some time working on headline.module but I'm not sure what
  he changed and whether he'd contribute it back?
2001-04-30 17:13:08 +00:00
Dries Buytaert 1f0565806b - improved submit.php:
it now uses the new category code, incl content bindings.
  You can setup different "categories" which map on a content
  type.  Example:
    review   -> review.module
    article  -> story.module
    column   -> story.module
    announc. -> story.module
    addons   -> file.module
    themes   -> file.module
- "generalised" story.module and book.module's output.
- fixed bug in includes/timer.inc
- fixed glitch in theme example.theme: it said "$how by" but
  the variable $how has never been declared.
- added "drupal development settings" to display some timings
- more work on the categories/topics -> does NOT work yet
2001-04-15 17:01:32 +00:00
Dries Buytaert 2926060f6a - fixed small glitch in account listings 2001-04-12 20:28:43 +00:00
Dries Buytaert 0f567be0ed - improved administrator interface of account, node, story and book
by (1) adding a few extra features to "easify" navigation and (b)
  to start using "status messages" as once suggested on the mailing
  list by Jeroen
2001-04-10 20:07:27 +00:00
Dries Buytaert 94d6b63f39 - small improvement to admin interface 2001-04-09 16:31:34 +00:00
Dries Buytaert 7fac91c2cc - various smaller improvements 2001-04-04 21:09:24 +00:00
Dries Buytaert 805107cd22 Commiting my work of last Sunday:
- removed ban.inc and ban.module and integrated it in account.module
   under the name "access control" --> the ban code was not really up
   to standard so this has now been dealt with.  This refactoring and
   reintegration cuts down the code size with 100 lines too.  :-)
   (The ban.module code was really old and it showed.)

 - added node.module and made the other modules reuse some of this
   code --> cut down the code size of modules by at least 100 lines
   and adds stability.

 - added a status() function to admin.php to display a conform status
   message where appropriate.  See admin.php for usage.

 - removed $theme->control() and made comments.inc handle this itself
   wrapped in a $theme->box().  No need to clutter the themes with
   such complexity --> updated all themes already. :-)

 - some small visual changes to some administration pages to be more
   consistent across different modules.
2001-04-02 15:54:37 +00:00
Dries Buytaert d1a07a2e8f - fixed "you-have-to-logout-and-login-before-permissions-change" bug
(reported by UnConeD)
- added "add node" link to book selection box and made it display the
  current location
- removed tabs and whitespaces from themes - done automatically
2001-03-31 14:58:37 +00:00
Dries Buytaert 04ad9b8af9 - fixed issue depricated call-by-reference issues
- fixed small visual glitch in includes/function.inc
- changed SQL tables around a bit to be more consistent
  (result: small changes to a lot of different files)
- improved robustness of includes/node.inc
- improved output of cron.module
- improved output of node.php
2001-03-29 19:50:31 +00:00
Dries Buytaert 3f2b0e0b3f Flushing my backlog (in case Natrak wants to make more changes):
- tidied up some of the code
 - fixed a small problems
2001-03-28 07:03:47 +00:00
natrak c72b91c6ab Fixed a small typ that caused the existing real name of an account now being shown when editing it. 2001-03-27 13:54:33 +00:00
Dries Buytaert 1f79863053 - large commit of everything else that has been queued in my backlog:
it's not 100% stable yet
2001-03-25 10:57:01 +00:00
Dries Buytaert accd5f0c31 - applied David Norman's patch to turn all <?'s into fully qualified
<?php's.
2001-03-10 11:07:52 +00:00
Dries Buytaert f516626a29 A rather large and important update:
revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
2001-03-07 21:29:40 +00:00
Dries Buytaert 74d3c351ce - Took all "rating logic" out of the account.module and moved it into
a seperate module called "rating.module".  This should allow people
  to experiment with different rating heuristics/algorithms.

- The rating module also generates a "Top 100 users" page, see:
     http://drop.org/module.php?mod=rating

- Adjusted ./scripts/php-clean to ignore png files.
  (I should do it the way around and make it ignore everything but
  our php files.)
2001-03-03 11:44:51 +00:00
Dries Buytaert a1a96ca29e - small changes to the watchdog module to make it more conform with other
modules
- small changes to the account module to make it more conform with other
  modules
- users can be deleted
2001-02-23 17:53:51 +00:00
Dries Buytaert 86e315e2b4 - locale module: added documentation (first draft)
- locale module: improved administration interface
- headline module: fixed small visual glitch in export function
- account: small improvements
2001-02-21 08:25:21 +00:00
Dries Buytaert 9b3cd99736 - fixed 2 bugs and 1 confusing issue in modules/account.module:
* last access field should not be updated when admin edits stuff
    * saving empty access list caused warning message
    * clicking the access links was confusing (no more links)
2001-02-18 17:05:57 +00:00
Dries Buytaert 4371b627d5 - added fine-grained user permission system which allows us to give
certain users access to specific administration sections only.
    Ex. a FAQ maintainer can only edit the FAQ, and members of an
        "editorial board" can only edit comments, diaries and
         stories, ..
- code review => rewrote include/user.inc which is much easier now
- fixed 4 small bugs
2001-02-18 15:14:56 +00:00
Dries Buytaert db554e857d - initial import of the preliminary translation code.
- added timer.inc for benchmarking purpose
- bugfix for php-clean
- bugfix for account.php
- removed redundant format_data
- ...
2001-02-12 20:40:43 +00:00
Dries Buytaert 3ba9cb5d72 - small updates 2001-02-10 17:54:51 +00:00
Dries Buytaert 171479fcfa - a 2nd batch of various updates 2001-02-10 14:36:49 +00:00
Dries Buytaert d6ce51e4ce - added a "search framework" which allows for easy searching
(to be continued)
- tidyied up some existing code
2001-02-10 11:59:06 +00:00
Dries Buytaert bff5ffeac4 - fixed tiny bug in the user account administration page 2001-02-08 16:57:26 +00:00
Dries Buytaert 77ed531035 - added new feature for evaluating purpose: user rating (mojo, karma)!
- removed tabs from Jeroen's theme
2001-02-07 22:01:57 +00:00
Dries Buytaert de2e393933 - various updates, bugfixes and improvements 2001-02-04 22:09:38 +00:00
Dries Buytaert 32c89442d3 - removed all tabs 2001-01-26 14:41:44 +00:00
Dries Buytaert d386c110f4 - removed redundant spaces 2001-01-26 13:38:46 +00:00
Dries Buytaert 2952d16f78 - updated/improved discussion engine: it needs additional fine-tuning
though but I think this is stable enough for public consumption and
  real-life testing.
   ==> a first big step towards a flexible comment engine.

IMPORTANT:
  - Required theme updatins:

    UnConeD: check your $theme->controls() as I added a very, very
             dummy implementation

  - Required database updates:

    alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
    alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
    alter table comments add link varchar(16) DEFAULT '' NOT NULL;
    update comments set link = 'story';
2001-01-20 12:20:31 +00:00
Dries Buytaert 8b4c95b259 - rewrote the block placement stuff and updated the themes.
IMPORTANT: you have to drop 2 tables "blocks" and "layout"
             and you have to recreate them again with those
             in database/database.mysql
- integrated the documentation written by UnConeD
2001-01-13 16:33:19 +00:00