Commit Graph

23 Commits (83ae5b5c36605ab3acc8d45e823d9d187602bdf0)

Author SHA1 Message Date
Dries Buytaert b66c616b8a - Some documentation fixes as per Charlie's suggestion: bug #2260. 2003-07-14 21:35:59 +00:00
Dries Buytaert e57faf2192 - Bugfix: fixed problem with changing themes. Didn't apply Al's patch as
the fix was somewhat simpler.  Fixes bug #2003.

- Bugfix: fixed problem with voting on certain poll pages.  Patch #37 by Al.

- Improvement: removed stupid descriptions from profile module.
2003-06-20 17:43:03 +00:00
Dries Buytaert eb030cb9d8 - Improvements: XHTML-ifications. Patch by GmbH. 2003-06-15 19:06:25 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 75a44994cd - Bugfix: an administrator could not edit the avator through the admin interface because it used the global $user object inside its functions rather then the user to be edited. Patch by Matt Westgate. 2003-06-10 19:21:05 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 31c36b7f54 - Fixed some translation bugs in the profile module. (I wasn't going to
commit this yet but I accidentically did so now I've cleaned it up.)
  Original patch by Matt.  Thanks for spotting the t() problem Al.
2003-06-03 19:13:19 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert 5632464104 - Fixed bug #1336: profile module problem. Patch by Al. 2003-05-03 05:44:25 +00:00
Dries Buytaert 5ce6e015d0 - Fixes bug #1336 and #1473. 2003-04-29 20:31:21 +00:00
Dries Buytaert a92bfba707 - Fixed bug #1336: http://drupal.org/node/view/1336. Thanks Marky. 2003-03-29 20:19:37 +00:00
Dries Buytaert 583104ce28 - Fixed typo: 'writeable' -> 'writable' 2003-03-16 12:36:07 +00:00
Dries Buytaert 34aeff6c6c - Fixed typo: maxumum -> maximum. Patch by Al. 2003-03-10 20:34:40 +00:00
Dries Buytaert e90f3b883b - See http://lists.drupal.org/pipermail/drupal-devel/2003-February/021824.html. 2003-02-11 20:01:17 +00:00
Dries Buytaert 637004c539 - Tidied up XHTML. Patch by Ulf.
- Added missing t() function.  Patch by Stefan.
2003-01-23 09:24:20 +00:00
Dries Buytaert 774688135c - Fixed some typos: "filesize" -> "file size" 2002-12-24 14:15:53 +00:00
Dries Buytaert d4c005acca - Make sure empty fields are not being displayed. Patch by Kjartan. 2002-11-17 06:50:25 +00:00
Dries Buytaert 1ef7f58e8e - Improved UI of profile module. Patch by Natrak.
NOTE: it is a first improvement but it isn't good enough yet ...
2002-11-08 13:13:25 +00:00
Dries Buytaert ea6ce100a1 Patch by Kjartan:
- Fixed empty fields being displayed.

- Fixed some coding standard discrepancies.

- Fixed the birthday date formatting.
2002-11-08 11:39:27 +00:00
Dries Buytaert 66c5b70736 - Wrapped some hardcoded colors in "theme_invoke()"s; we can still create
a drupal_error() later on but I think we better get used to theme_invoke().

- Fixed translation bug.  Patch by Moshe.

- Fixed PHP warning.  Patch by ax.
2002-10-22 18:46:43 +00:00
Dries Buytaert f5173ef233 - Applied user.module patch from Marco's sandbox.
- Added profile.module written by Marco.
2002-08-08 18:52:55 +00:00