Commit Graph

1553 Commits (831b208162d6171530f6f19e3d592cc198304c48)

Author SHA1 Message Date
catch 20895bdc97 Issue #3176394 by huzooka, Wim Leers, quietone: Do not migrate comment related configurations if "comment" wasn't enabled on the source site 2020-11-30 12:11:48 +00:00
catch dee581d3fa Issue #3128815 by mondrake, jungle, sja112, Spokje, shobhit_juyal, jameszhang023, nikitagupta, mrinalini9, xjm, longwave, dww: Replace assert*() involving greater/less comparison operators with assert(Greater|Less)Than(OrEqual) 2020-11-24 09:57:55 +00:00
catch 96d4338074 Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls to drupalPostForm(NULL, ...) to submitForm 2020-11-23 14:35:28 +00:00
catch 783e7eb88e Issue #3145005 by longwave, mondrake, cburschka, raman.b, Lal_, dww, xjm: [November 9, 2020] Remove uses of t() in drupalPostForm() calls 2020-11-16 16:51:39 +00:00
catch 1d6e7e25d5 Issue #2851394 by GoZ, hgunicamp, oknate, jungle, wolffereast, tameeshb, mmatsoo, ridhimaabrol24, jofitz, swarad07, tanc, shaktik, dimaro, shashikant_chauhan, MerryHamster, quietone, nitesh624, martin_q, boaloysius, gaurav.kapoor, nitvirus, ankithashetty, Munavijayalakshmi, kostyashupenko, leolando.tan, amit.drupal, ravi.shankar, akashkrishnan01, Swapnil_Kotwal, Saviktor, mrinalini9, anmolgoyal74, Venkatesh Rajan.J, shimpy, lomasr, Dinesh18, shubham.prakash, mahtab_alam, markdorison, cilefen, longwave, bleen, xjm, alexpott, gmaltoni: Fix grammar 'a' to 'an' when necessary 2020-11-13 14:25:11 +00:00
catch 5939e6b5f8 Issue #3145418 by longwave, paulocs, shetpooja04, Spokje, nikitagupta, mondrake, ravi.shankar, sarvjeetsingh, mrinalini9: [November 9, 2020] Remove uses of t() in assertText() calls 2020-11-13 11:06:01 +00:00
catch 652efc720a Issue #3139429 by mondrake, rahulrasgon, mohrerao, siddhant.bhosale, paulocs, longwave, jungle, cburschka, munish.kumar: Replace usages of AssertLegacyTrait::assert(No)FieldByXPath, that is deprecated 2020-11-11 16:24:44 +00:00
catch 7dbdbcb1fa Issue #3166450 by mondrake, longwave, snehalgaikwad: Split assertTrue using && into multiple assertions 2020-11-09 12:07:29 +00:00
catch 89f6acb734 Issue #3174884 by raman.b, alexpott, lauriii, zrpnr, nod_: Update yarn dependencies for Drupal 9.1.0 2020-10-21 11:41:33 +01:00
catch e738aa7c8c Issue #2858646 by gaurav.kapoor, TR, alexpott: Methods called with incorrect case 2020-10-15 15:11:24 +01:00
catch a14e48a157 Issue #3139406 by mondrake, mohrerao, longwave, rahulrasgon, Suresh Prabhu Parkala, jungle, ravi.shankar, Hardik_Patel_12, Bunty Badgujar, paulocs: Replace usages of AssertLegacyTrait::assert(No)FieldByName, that is deprecated 2020-09-25 09:22:28 +01:00
catch 71813a859c Issue #3139407 by pavnish, mohrerao, mondrake, shaktik, rahulrasgon, durgeshs, shetpooja04, paulocs, ravi.shankar, ankithashetty, anmolgoyal74, munish.kumar, jungle, longwave, daffie: Replace usages of AssertLegacyTrait::assert(No)FieldById, that is deprecated 2020-09-24 10:58:32 +01:00
catch e89a5699c0 Issue #3059719 by kndr, ravi.shankar, jcontreras, paulocs, Kristen Pol: Comments Depth, Undefined index: #markup - line 25 2020-09-23 15:31:15 +01:00
Lee Rowlands a44a9b1cd0
Issue #3159230 by mondrake, sandeep_jangra, ravi.shankar, naresh_bavaskar, larowlan, longwave: AssertLegacyTrait::assert(No)Raw() in functional tests still have a message passed in 2020-09-11 08:05:30 +10:00
Alex Pott 472b19010a
Issue #3139418 by mondrake, jungle, longwave: Replace usages of AssertLegacyTrait::assert(No)LinkByHref, that is deprecated 2020-09-08 16:00:31 +01:00
catch c09dc39b8f Issue #3139419 by mondrake, aleevas: Replace usages of AssertLegacyTrait::assertUrl, that is deprecated 2020-09-02 14:52:13 +01:00
catch c532b2f9b2 Issue #3139442 by mondrake, munish.kumar, Hardik_Patel_12, jungle, mohrerao, alexpott: Replace usages of AssertLegacyTrait::constructFieldXpath, that is deprecated 2020-09-01 10:48:04 +01:00
catch f4fd2d7336 Issue #3166349 by paulocs, snehalgaikwad, naresh_bavaskar, mondrake: Remove uses of t() in assertNoText() 2020-08-28 12:48:09 +01:00
catch 4a7c205450 Issue #3153143 by ridhimaabrol24, Hardik_Patel_12, siddhant.bhosale, guptahemant, quietone, paulocs: Remove uses of t() in linkExists() and linkNotExists() calls 2020-08-28 10:46:35 +01:00
catch 3ab889a1aa Issue #3153150 by Suresh Prabhu Parkala, paulocs, ravi.shankar, Deepak Goyal, Hardik_Patel_12, longwave: Remove uses of t() in assertTrue() and assertFalse() calls 2020-08-28 10:07:33 +01:00
Lee Rowlands 050b91b764
Issue #3160405 by mondrake, ravi.shankar, jungle, longwave: Deprecate overloading arguments to WebAssert methods to prevent conversions of legacy Simpletest test to carry over cruft 2020-08-28 12:06:48 +10:00
Lee Rowlands 82949679ce
Issue #3143870 by mondrake, pavnish, longwave: Calls to AssertLegacyTrait::assertUrl() have wrong number of arguments 2020-08-28 11:22:44 +10:00
catch 9beb71e610 Issue #2614720 by quietone, roderik, ofry, Dylan Donkersgoed, Deepak Goyal, samiullah, jonathanshaw, benjifisher, larowlan, Rewted, Ruedische, KlemenDEV, ao2, abramm, vadim.hirbu, HiMyNameIsSeb, dionsj, mgp_novicell, scalas89, rollins, dmytro-aragorn, hchonov, mayurjadhav, paranojik, nplowman: Fatal errors while loading/building orphaned comments 2020-08-27 10:25:44 +01:00
Lee Rowlands ce7d1d3c4c
Issue #3164721 by TR, quietone: More uses of public static $modules 2020-08-17 19:28:45 +10:00
catch 234af3fcc7 Issue #3163425 by shetpooja04, paulocs: Unused variable $fields in comment module, CommentViewsData.php 2020-08-14 10:08:00 +01:00
catch 96e72791eb Issue #3163686 by shetpooja04, longwave: Unused variable $comment in comment module, CommentLinksAlterTest.php 2020-08-11 15:14:39 +01:00
catch 49d9b09e64 Issue #3139436 by mondrake, jungle: Replace usages of AssertLegacyTrait::assertPattern, that is deprecated 2020-08-10 17:32:31 +01:00
catch 74ae4bdda2 Issue #3163685 by shetpooja04, longwave: Unused variable $block in comment module, CommentBlockTest.php 2020-08-10 13:34:34 +01:00
catch 7628e38b90 Issue #3139433 by mondrake, Hardik_Patel_12, mohrerao, jungle: Replace usages of AssertLegacyTrait::assert(No)Escaped, that is deprecated 2020-08-10 11:29:50 +01:00
catch 30ca835cce Issue #3139408 by mondrake, jungle, dww: Replace usages of AssertLegacyTrait::assert(No)Field, that is deprecated 2020-08-10 11:26:28 +01:00
Alex Pott f124d526c6
Issue #3130655 by daffie, andypost, Beakerboy, ravi.shankar, alexpott, mradcliffe, Lendude: Deprecate creating an instance of the class Drupal\Core\Database\Query\Condition with the new keyword 2020-08-07 21:00:15 +01:00
Alex Pott b5ccfba835
Issue #2984243 by Rithesh BK, ifrik, adityasingh, tripurari, rajandro: Reword the Comment filter button 2020-08-03 01:37:33 +01:00
Alex Pott 402567d128
Issue #3142749 by munish.kumar, shaktik, pavnish, sja112, ravi.shankar, Lal_, mondrake, daffie, xjm: AssertLegacyTrait::assertPattern() calls in functional tests still have a message passed in 2020-07-31 18:02:28 +01:00
catch d7300cc380 Issue #3142755 by sja112, mondrake, alexpott, mrinalini9, xjm: AssertLegacyTrait::assert(No)Field() in functional tests still have a message passed in 2020-07-29 14:57:52 +01:00
catch fad8b52c74 Issue #3159982 by nuklive, ultrabob, J2, billywardrop, antojose, daffie, mradcliffe, mcdruid, jungle: AS keyword should be capitalised in SQL queries 2020-07-29 14:53:25 +01:00
catch ef3190f75a Issue #3157954 by alexpott, andypost: Remove unnecessary route rebuild from tests 2020-07-16 22:21:08 +01:00
Alex Pott 09c6b3d80d
Issue #3139428 by jungle, ridhimaabrol24, Hardik_Patel_12, mondrake, mrinalini9, Bunty Badgujar: Replace usages of deprecated AssertLegacyTrait::assert(No)FieldChecked() 2020-07-15 23:46:47 +01:00
Alex Pott a76a7586a7
Issue #2801929 by Lendude, ridhimaabrol24, Sutharsan, gilles.koffmann, geek-merlin, dawehner: View loses records after adding comment count field 2020-07-14 17:04:34 +01:00
catch b7627bcae4 Issue #3123120 by mondrake, ridhimaabrol24, longwave: Properly deprecate AssertLegacyTrait::pass 2020-07-14 10:58:42 +01:00
catch 065f4812be Issue #3153791 by Wim Leers, quietone: Add comment field for 'et' content type to d7 fixture 2020-07-14 09:51:06 +01:00
catch eafefd897a Issue #2619482 by cburschka, ankit.singh, ravi.shankar, jungle, daffie: Convert all get_called_class()/get_class() to static:: 2020-07-13 15:35:49 +01:00
catch 65e525854c Issue #2855068 by jian he, larowlan, andypost, mrinalini9, Jody Lynn, himanshu-dixit, LaravZ, jurgenhaas: Can't create comments when comment is a base field 2020-07-09 12:16:00 +01:00
catch a050029323 Issue #3135538 by mondrake, longwave, jungle: Replace remaining assert* involving use of count() where relevant 2020-07-02 13:16:28 +01:00
catch 2b7d2e1e26 Issue #3139437 by pavnish, mrinalini9, mondrake, longwave, Bunty Badgujar: Replace usages of AssertLegacyTrait::assertCacheTag, that is deprecated 2020-06-29 16:26:59 +01:00
xjm de32f3ca2d Issue #3133033 by munish.kumar, xjm, Hardik_Patel_12, daffie, swatichouhan012: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the drupalCreateUser() test method 2020-06-21 16:39:19 -05:00
Alex Pott 0f9cecbab6
Issue #3139414 by cburschka, mohrerao, pavnish, jungle, ravi.shankar, daffie, mondrake, sja112: Replace usages of deprecated AssertLegacyTrait::assert(No)Link() 2020-06-16 10:29:37 +01:00
Alex Pott 9d1faa52f4
Issue #2824935 by idebr, mfernea, Deepak Goyal, pfrenssen, longwave, hgunicamp, jofitz, andypost, daffie: Fix Squiz.ControlStructures.SwitchDeclaration coding standard 2020-06-02 09:46:52 +01:00
xjm 88375258cd Issue #3139412 by Bunty Badgujar, longwave, mondrake, xjm: Replace usages of deprecated AssertLegacyTrait::assertTitle() 2020-05-29 16:55:45 -05:00
xjm da2fb10571 Issue #3138802 by sja112, kkalashnikov: Fix "snafus" relevant typos in core 2020-05-29 02:46:51 -05:00
xjm e4e64fa0ee Issue #3143339 by mohrerao, mondrake, longwave: Clean up the arguments of calls to WebAssert::titleEquals() and AssertLegacyTrait::assertTitle() 2020-05-28 17:29:40 -05:00
catch 483c579eb5 Issue #3138778 by sja112, jungle: Fix "Nourriture" relevant typos in core 2020-05-28 12:16:57 +01:00
xjm 68a59ee322 Issue #3139421 by mondrake, mrinalini9, daffie: Replace usages of deprecated AssertLegacyTrait::assert(No)Option() 2020-05-24 14:55:23 -05:00
xjm 11387380d5 Issue #3139218 by mondrake, daffie: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated 2020-05-24 08:33:20 -05:00
xjm f09c890298 Issue #3132964 by jungle, longwave, sja112, dww, xjm, daffie: assertResponse() does not actually support a $message parameter, so stop passing one 2020-05-22 12:37:50 -05:00
xjm 0f66cce399 Issue #2937513 by eltori, longwave, klausi, catch, idebr: Fix 'Drupal.Commenting.DocComment.TagGroupSpacing' coding standard 2020-05-20 17:11:54 -05:00
catch 287cbe29ea Issue #3136604 by lauriii, xjm, effulgentsia, justafish: Update to jQuery 3.5.1 2020-05-15 20:14:12 +01:00
catch 421c588c16 Issue #3131343 by mondrake, dww, jungle: Replace assertions involving calls to in_array() with assertContains()/assertNotContains() 2020-05-11 09:10:55 +01:00
Alex Pott 9d8849513f
Issue #3134475 by Beakerboy, daffie: Avoid directly comparing string to blob in CommentIntegrationTest 2020-05-09 11:02:05 +01:00
catch 40a5bd7e0a Issue #3126965 by jungle, quietone, longwave, mondrake, dww: Replace assert* involving count() and an integer literal with assertCount() 2020-05-07 19:07:00 +01:00
xjm b28613324a Issue #3112328 by jungle, hash6, xjm: FormatterBase implements ContainerFactoryPluginInterface, so it's not necessary for its child classes to repeat that they do as well 2020-05-04 13:02:41 -05:00
xjm 7b1f3e1132 Issue #3123253 by mondrake, Lal_, prabha1997, longwave, xjm, alexpott, jungle: Remove usage of AssertLegacyTrait::pass() from base test classes 2020-05-03 10:24:42 -05:00
Alex Pott 6b54e9534f
Issue #2778917 by kiamlaluno, jungle, elaman, dawehner, alexpott, tvb, vadim.hirbu, ravi.shankar, quietone: Use the second parameter of \Drupal::state()->get() instead of checking the method didn't return any value 2020-05-02 13:07:36 +01:00
Alex Pott 3f87e0d805
Issue #3132745 by jungle, longwave, xjm, swatichouhan012, daffie: Fix Drupal.Array.Array.LongLineDeclaration coding standard for instances of the $modules test property 2020-05-02 12:34:00 +01:00
catch 27515dc255 Issue #3130811 by mondrake, jungle, longwave: Remove redundant $message from assert(Not)InstanceOf calls 2020-04-27 10:35:37 +01:00
catch 4d02fe7c25 Issue #3128746 by mondrake, longwave, dww: Replace assertions involving calls to strpos() with more accurate string assertions 2020-04-27 10:02:44 +01:00
catch 4fe0b034a9 Issue #3128905 by jungle, longwave, Kristen Pol, mondrake: Replace assert* involving an instanceof operator with assertInstanceOf()/assertNotInstanceOf() 2020-04-24 21:27:52 +01:00
Alex Pott a6e402fc01
Issue #3126563 by mondrake, daffie, alexpott: Replace usage of assertAttributeEquals() that is deprecated 2020-04-18 10:31:47 +01:00
catch 09be91a395 Issue #3126564 by longwave, mondrake: Replace usage of assertArraySubset(), that is deprecated 2020-04-16 19:40:52 +01:00
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 6108526c9c
Issue #3113077 by mondrake, Hardik_Patel_12, Neslee Canil Pinto, swatichouhan012, prabha1997, neelam_wadhwani, Berdir, longwave: Replace assertContains() on strings with assertStringContainsString() or assertStringContainsStringIgnoringCase() 2020-04-12 12:34:00 +01:00
Alex Pott 221b7aed06
Issue #3108006 by mondrake, ravi.shankar, longwave: Replace assertInternalType() calls with dedicated methods 2020-04-11 06:35:50 +01:00
catch c964d76ad9 Issue #2966856 by Gábor Hojtsy, quietone, alexpott, vuil, catch, heddn: Hide and disable Drupal Migrate Multilingual 2020-03-13 17:29:40 +00:00
Alex Pott dcd666c63a
Issue #2746541 by quietone, alexpott, maxocub, Wim Leers, mikelutz, jofitz, masipila, firewaller, Madhura BK, Gábor Hojtsy, catch, heddn, plach, hchonov: Migrate D6 and D7 node revision translations to D8 2020-03-12 12:00:10 +00:00
xjm 4c453683e4 Issue #3106666 by catch, jungle, xjm, alexpott, tim.plunkett, Berdir: Remove post updates added prior to 8.8.0 2020-03-11 15:58:38 -05:00
Alex Pott b57afe5c7f
Issue #3069696 by Berdir, andypost, dhirendra.mishra, longwave, alexpott: Remove BC layers from the entity system 2020-02-26 08:25:29 +00:00
Alex Pott 915b74f937
Issue #2570985 by ifrik, chipway, lomasr, jhodgdon, shimpy, govind.maloo, vacho, Balu Ertl, Manjit.Singh, alexpott, Bojhan, volkswagenchick, mradcliffe, xjm, tkoleary, yoroy, no_angel, dawehner, webchick, Sam152, RuslanP, Gábor Hojtsy, wengerk, wla_g: Update the module descriptions on the Extend page 2020-02-24 14:24:57 +00:00
Alex Pott 642b7653d4
Issue #3095922 by huzooka, Wim Leers, quietone, andypost: The comment "language" column in D7 might be empty after migrating from D6, this is invalid in D8 2020-02-24 10:04:32 +00:00
Alex Pott 4577772da0
Issue #3101543 by lauriii, bnjmnm, ravi.shankar, alexpott: Update core JavaScript dependencies listed in package.json 2020-01-30 09:08:38 +00:00
Alex Pott 5b657b15b8
Revert "Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json"
This reverts commit 2dadb738bf.
2020-01-28 13:14:16 +00:00
Alex Pott 2dadb738bf
Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json 2020-01-28 11:36:14 +00:00
catch 720924f719 Issue #2893804 by Wim Leers, Stefdewa, Berdir, catch: Remove rest.module BC layers 2020-01-27 17:41:43 +00:00
Alex Pott fc46c7f3c2
Issue #3092606 by andypost, Wim Leers, Berdir, longwave: Remove comment.module BC layers 2020-01-26 12:06:27 +00:00
catch e1a041c493 Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, xjm, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-24 23:52:03 +00:00
Lee Rowlands 2e53ac1699
Revert "Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88**"
This reverts commit 136f055066.
2020-01-22 10:30:15 +10:00
Lee Rowlands 136f055066
Issue #3087644 by jibran, Berdir, alexpott, longwave, Wim Leers, amateescu, catch, larowlan, dpi, quietone: Remove Drupal 8 updates up to and including 88** 2020-01-22 09:33:30 +10:00
Alex Pott edb58dfe15
Issue #3062101 by Krzysztof Domański, larowlan: Incorrect data type when the preg_match function is used as the result of another function 2020-01-14 15:49:34 +00:00
Alex Pott 85fa773d51
Issue #2975217 by Sam152, Berdir, Wim Leers, alexpott: Update the default comment entity owner to the current user 2019-11-27 06:24:04 +00:00
Alex Pott f2469de972
Issue #3087546 by Berdir, alexpott, martin107, jibran: Remove deprecated entity manager 2019-11-14 10:49:28 +00:00
Alex Pott 2a009c5edd
Issue #3048498 by jonathan1055, Lendude, naveenvalecha, klausi, alexpott, Gábor Hojtsy: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard 2019-11-14 09:08:15 +00:00
catch 19f9474b9b Issue #2742585 by ZeiP, alexpott, mondrake, klausi, tomasnagy, Krzysztof Domański, sokru, kristiaanvandeneynde, dawehner, jeroenbegyn: Deprecate dangerous assertTrue/False() compatibility overrides in PHPUnit Kernel, Functional and FunctionalJavascript tests 2019-11-08 13:53:52 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
Alex Pott 7f45838237
Issue #3092615 by andypost: Clean-up CommentStorage constructor 2019-11-06 09:47:11 +00:00
catch bc6aabc9cd Issue #3087692 by Wim Leers, alexpott: Remove the core key from views configuration 2019-10-22 20:40:16 +01:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
Alex Pott 239ce7f53a
Issue #3069055 by mikelutz, dhirendra.mishra, quietone, larowlan: Undeprecate Drupal\comment\Plugin\migrate\source\d6\Comment::prepareComment() 2019-09-23 13:49:58 +01:00
catch 3d27d76d71 Issue #3051231 by TR, cindytwilliams: Class names in *.routing.yml inconsistently use leading \ 2019-09-17 11:30:36 +01:00
Alex Pott 0a6a417ec9
Issue #3073318 by Spokje, Mile23, mondrake: Remove usages of \PHPUnit_Framework_MockObject_MockObject 2019-09-02 12:24:14 +01:00
Alex Pott ae248f2e43
Issue #3047801 by Eduardo Morales, mikelutz, pguillard, nlisgo, sathish.redcrackle, Berdir: Replace all calls to the deprecated Drupal::l() function in Core 2019-07-24 16:48:42 +01:00
Alex Pott 4de7b7b46f
Issue #3068563 by mikelutz, Berdir: Properly deprecate Comment::getStatus() 2019-07-23 11:27:12 +01:00