Commit Graph

148 Commits (81ea70d101557e901bcad4bd1eb91385ab1b7096)

Author SHA1 Message Date
Dries Buytaert 52dfd806cc - Fixed a typo. 2002-01-01 22:20:41 +00:00
Dries Buytaert be3f89b06b - Fixed a typo: comments_all() -> comment_all() 2002-01-01 22:17:54 +00:00
Dries Buytaert d85e45bf64 - Added "x new comments" feature. Requires a SQL update.
- Tidied up some comment related code in node.module.
2001-12-31 13:02:53 +00:00
Dries Buytaert a95c2a68aa - import.module:
+ Improved input filtering; this should make the news items look
      more consistent in terms of mark-up.

    + Quoted all array indices: converted all instances of $foo[bar]
      to $foo["bar"].  Made various other changes to make the import
      module compliant with the coding style.

- theme.inc:

    + Fixed small XHTML glitch

- comment system:

    + Made it possible for users to edit their comments (when certain
      criteria are matched).

    + Renamed the SQL table field "lid" to "nid" and updated the code
      to reflect this change: this is a rather /annoying/ change that
      has been asked for a few times.  It will impact the contributed
      BBS/forum modules and requires a tiny SQL update:

        sql> ALTER TABLE comments CHANGE lid nid int(10) NOT NULL;

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

    + Added a delete button to the comment admin form and made it so
      that Drupal prompts for confirmation prior to deleting a comment
      from the database.  This behavior is similar to that of deleting
      nodes.

    + Disabled comment moderation for now.

    + Some of the above changes will make it easier to integrate the
      upcomcing mail-to-web and web-to-mail gateways.  They are part
      of a bigger plan.  ;)

- node system:

    + Made it so that updating nodes (like for instance updating blog
      entries) won't trigger the submission rate throttle.

    + Fixed a small glitch where a node's title wasn't always passed
      to the $theme->header() function.

    + Made "node_array()" and "node_object()" more generic and named
      them "object2array()" and "array2object()".

    + Moved most (all?) of the comment related logic from node.php to
      comment.module where it belongs.  This also marks a first step
      towards removing/reducing "node.php".

- misc:

    + Applied three patches by Foxen.  One to improve performance of
      the book module, and two other patches to fix small glitches in
      common.inc.  Thanks Foxen!
2001-12-30 16:16:38 +00:00
Dries Buytaert 9b69714c3f - Revised the comment links: when a user does not have the required
permissions to post comments, the "reply to this comment"-link is
  no longer shown.  Also, when a user is a "comment administrator",
  an "administer"-link will be displayed.

- Revised the threaded_min and threaded_max code: it makes rendering
  pages with more than 15 comments 200% times faster.
2001-12-27 20:35:40 +00:00
Dries Buytaert 9fa8e310d7 - Removed (the need for) the Comment-class: makes for cleaner code.
- Fixed the comment preview function: the preview shown was not being
  an exact preview of the comment.  Along the way, I polished the
  comment submission code.

- XMTML-ified the code, and quoted all "string"-based array indices.
2001-12-22 14:12:18 +00:00
Kjartan Mannes a4f431aeb4 - strip HTML tags from comment subjects. 2001-12-09 13:40:47 +00:00
Dries Buytaert 6f4d9d56d5 - Fixed a problem with the variable scopes. Thanks Natrak. 2001-12-08 12:36:05 +00:00
Dries Buytaert ab20a866c1 comment.module:
- small improvements to the comment admin interface.
  - merged comment.inc and comment.module.
2001-12-08 11:37:07 +00:00
Dries Buytaert facd9cc517 - Bugfix: you can no longer add non-existant node types. Thanks barry.
- Moved all comment related logic from node.module to comment.module.
2001-12-05 20:22:58 +00:00
Dries Buytaert ac1eecb753 - Small update wrt filters. 2001-11-25 13:48:34 +00:00
Dries Buytaert 42ecb27802 A set of updates to the "_link" system:
- Made the /comment links/ jump to the comments instead of to the top
   of the page.

 - Replaced the "Add comment"-button by a "add new comment"-link.
   (This should make UnConeD jump up and down of wild excitement.)

 - Moved all comment related logic from theme.inc and node.module to
   comment.inc and comment.module (where they belong).

 - Added some links to ease the site's usability/navigation.
2001-11-24 12:14:31 +00:00
Dries Buytaert 336b713a5f - A large batch of updates, amongst them a rewritten node system. More
information available on the mailing list.
2001-11-01 11:00:51 +00:00
Kjartan Mannes 864c18d4c3 - added the CVS keyword $Id$ to all files to make future version tracking
easier. Also changed the <? tag to <?php in some cases.
2001-10-20 18:57:09 +00:00
Dries Buytaert 33a3502dfe - Removed a node's link ID (lid) as discussed on the mailing list. See
'updates/3.00-to.x.xx.mysql' for the required MySQL updates.

- Renamed some "author" fields to "uid" fields for sake of consistency.

- Fixed the coding style of some PHP files.

- Fixed the moderation queue (fairly untested though).

- Re-introduced the temporary SQL table in _node_get().

- Added a missing 'auto_increment' to 'updates/3.00-to-x.xx.mysql'.
2001-10-16 20:13:22 +00:00
Dries Buytaert f1932821be - PEAR-ification of Drupal by claw: you can now host Drupal on a wide
range of databases including MySQL, PostgreSQL, MSSQL, and others.

  For additional information and an 'how to upgrade', check the mails
  sent to the mailing list.
2001-10-09 21:01:47 +00:00
Dries Buytaert 7a9bc86bd2 - Improved search architecture derived from Axel's new search patches.
(There is room for improvement so let's go from these ... and build
  on them.)

- Removed some $status's by calls to node_status().
2001-10-03 20:57:01 +00:00
Dries Buytaert 0cce47f15f - fixed small glitch in node_del()
- fixed small glitch in comment_del()

- changed the API of the form() function.  The first parameter, the
  "action"-attribute in the <form>-tag has been made optional.  By
  default, it will be set to "$REQUEST_URI".

  Why? Because in 98% of the cases we would do:

    global $REQUEST_URI;
    $form = form($REQUEST_URI, $form_content);

  while we can do:

    $form = form($form_content);

  now.

  Update your modules (and sorry for the inconvenience)!
2001-09-28 16:20:55 +00:00
Dries Buytaert 4a0e498f52 - a batch of updates, including some experimental changes to the moderation
of comments and nodes.
2001-09-27 20:51:26 +00:00
Dries Buytaert e2f249878e - improved the search system by making it context sensitive 2001-09-16 14:05:10 +00:00
Dries Buytaert 2d1e9126cb - Added the new user module! 2001-09-16 11:33:14 +00:00
Dries Buytaert 808b6b6cae - Changed the authentication and login scheme as discussed on the mailing
list.
- Fixed the export function in book.module (patch my Julian).
- Fixed the comment alignment (comments got truncated).
2001-08-11 14:54:39 +00:00
Dries Buytaert cd48b94ad9 - import.module:
+ applied Julian's fputs() patch
    + fixed typo

- cloud.module:
    + applied Julian's fputs() patch

- comment.module:
    + applied Julian's "delete" patch
2001-08-03 18:39:17 +00:00
Dries Buytaert f12fa06152 - various small updates:
+ fixed 2 small HTML typos in meta.module
   + better watchdog messages in comment.module
   + fixed typo in block.module
2001-07-07 14:58:54 +00:00
Dries Buytaert 9c43e8fc7a Extremely large commit:
- Fixed tiny quote problem in account.php.

- Fixed tiny bug in comment.inc.

- Fixed tiny bug in comment.module.

- Fixed tiny bug in meta.module.

- Simplified user_access() API.

- Rewrote link system: still needs fine-tuning and testing so don't
  upgrade if you are running a production site. ;)

  Updated all modules and themes to reflect this change.  All other
  themes and modules need updating too!
2001-06-29 22:08:57 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert 0000c2e401 - Code review: improved search API, tidied up the search related code,
and fixed a tiny bug when searching for users.
2001-05-09 18:28:09 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00
Dries Buytaert 1681877761 CHANGES:
- Added moderator information to forum.module.

- Simplified story.module, page.module, forum.module and book.module
  by removing redundant code, and by doing other small house-keeping
  tasks.
2001-05-03 18:48:42 +00:00
Dries Buytaert 343e71c8eb CHANGES:
- Added moderator permissions to nodes.

- Added moderator support to structure.module.

- Added new moderate.module.

- Renamed moderation.module to queue.module to avoid confusing.
  Updated theme yaroon as it seems to have a hard-coded reference
  to moderation.module.

- Polished on:
   + account.module: improved access list
   + fixed HTML typo in node.module

ACTIONS:

- Jeroen: can jeroen2.theme be removed from ./themes/yaroon?
2001-05-02 20:52:19 +00:00
Dries Buytaert fead09a8de Welp. Large commit ahead.
CHANGES:

- Added "read" and "write" permissions into drupal but removed
  it again because - when finished after 3 hours of work - it
  was considered nothing but added complexity that didn't buy
  us anything. :I

  (I'll explain this in detail on the mailing list, I guess.)

- Added a very simple help.module to group all available
  documentation on a single page.

- Fixed bug in node_control(), book.module: UnConeD forgot to
  global $user when updating the combobox code.

- Removed static wishlist.module: in future, the wishlist can
  be maintained as a page in our collaborative book.

- Revised most of settings.module: tidied up the code and the
  descriptions to accompany the settings and introduced a new
  "default maximum number of nodes to display on the main page"
  variable.

- Revised most of comment.module: the administration interface
  looks better now, integrated node permissions, and -finally-
  made it possible to delete comments.

- Polished on:
   + account.module
   + structure.module
   + locale.module
   + module.module
   + forum.module

- Form-ified:
   + account.php
   + account.module
   + setting.module
   + cvs.module
   + submit.php
   + comment.module
   + forum.module
   + book.module
   + page.module
   + locale.module

- Updated CHANGELOG

INFO:

- Designed a "generic tracker system with optional backends"
  on paper.  The idea is to allow registered users to hot-list
  certain topics, individual nodes or threads (comments) and
  to "plug-in" output backends like - for instance - an e-mail
  digest.  The design requires "intelligent blocks" though.


TODO:

- I want to tidy up the headline.module and backend.class as
  well as merge in headlineRSS10.module.  Julian spent quite
  some time working on headline.module but I'm not sure what
  he changed and whether he'd contribute it back?
2001-04-30 17:13:08 +00:00
Dries Buytaert 7fac91c2cc - various smaller improvements 2001-04-04 21:09:24 +00:00
Dries Buytaert f39bba80fa - All comments on the administration page are actually "linked" now: the
comments on the drupal page where originally *not* click-able but this
  turned out to be confusing only.   Now we live in a nodified world, we
  can simply link all comments without a single problem! :-)
2001-03-25 16:56:37 +00:00
Dries Buytaert 10aaea3342 - simplified the comment code: the SQL queries are less complex, thus
faster now.
2001-03-24 17:01:23 +00:00
Dries Buytaert accd5f0c31 - applied David Norman's patch to turn all <?'s into fully qualified
<?php's.
2001-03-10 11:07:52 +00:00
Dries Buytaert f516626a29 A rather large and important update:
revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
2001-03-07 21:29:40 +00:00
Dries Buytaert 4d31d27ff0 - added comment index for performance sake
- improved comment module - code revision
- improved backend module - moreover headlines now work
- (automatically) stripped tabs and trailing whitespaces from
  Jeroen's theme.
2001-02-27 07:45:03 +00:00
Dries Buytaert 4371b627d5 - added fine-grained user permission system which allows us to give
certain users access to specific administration sections only.
    Ex. a FAQ maintainer can only edit the FAQ, and members of an
        "editorial board" can only edit comments, diaries and
         stories, ..
- code review => rewrote include/user.inc which is much easier now
- fixed 4 small bugs
2001-02-18 15:14:56 +00:00
Dries Buytaert 171479fcfa - a 2nd batch of various updates 2001-02-10 14:36:49 +00:00
Dries Buytaert d6ce51e4ce - added a "search framework" which allows for easy searching
(to be continued)
- tidyied up some existing code
2001-02-10 11:59:06 +00:00
Dries Buytaert 77ed531035 - added new feature for evaluating purpose: user rating (mojo, karma)!
- removed tabs from Jeroen's theme
2001-02-07 22:01:57 +00:00
Dries Buytaert d386c110f4 - removed redundant spaces 2001-01-26 13:38:46 +00:00
Dries Buytaert 2952d16f78 - updated/improved discussion engine: it needs additional fine-tuning
though but I think this is stable enough for public consumption and
  real-life testing.
   ==> a first big step towards a flexible comment engine.

IMPORTANT:
  - Required theme updatins:

    UnConeD: check your $theme->controls() as I added a very, very
             dummy implementation

  - Required database updates:

    alter table users modify mode tinyint(1) DEFAULT '' NOT NULL;
    alter table comments change sid lid int(6) DEFAULT '0' NOT NULL;
    alter table comments add link varchar(16) DEFAULT '' NOT NULL;
    update comments set link = 'story';
2001-01-20 12:20:31 +00:00
Dries Buytaert 55679210c2 - created 2 new functions; check_textfield() and check_textarea() and
integrated them were appropriate.  It works better and the code is
  more readable then it used to be:
    (see http://drop.org/discussion.php?id=44&pid=0#0)

- story authors can no longer moderate their own stories
    (requested by Natrak)

- fix inie-winnie small detail in theme marvin
2001-01-13 08:29:50 +00:00
Dries Buytaert 8511d9fb45 A batch of patches:
- configuration:
    + renamed $db_name to $db_user
    + renamed $db_base to $db_name
  - fixed small diary glitch
  - fixed initial-comment-score problem
  - fixed comment rating bug: improved the API and updated the
    themes
  - removed some tabs from Steven ;)
  - fixed backend warnings and improved robustness
    I'm not happy yet with the headline grabber - it generates
    too many SQL errors.
  - some small cosmetic changes in comment.module
  - fixed minor glitch in format_interval()
2001-01-06 11:39:43 +00:00
Dries Buytaert fd64164419 Surprise, surprise. After nothing but code, a large batch of changes:
- removed droplets
 - added (optional) admin_blocks module
 - added (optional) affiliate module
 - added (optional) about module (only placeholder, under construction)
 - fixed some tiny bugs (e.g. quote bug in search.php)
 - partionally rewrote some modules to be big, bad and better
 - partionally rewrote some modules to be more uniform
 - added GNU GPL license to CVS

Also:
 - installed PHP 4.0.4 on my localhost and now working
   towards PHP 4.0.4 compatibility.
 - I think I'll baptize the engine "drupal".  If you have a
   better idea, try convincing me ASAP.

Todo:
 - more testing (also with PHP 4.0.4)
 - make "project"-module: download, info, blah blah
 - complete documentation
2000-12-29 11:00:56 +00:00
Dries Buytaert dcfcd99c6c - improved web interface of cron module.
- improved web interface of account module.

- added simple permission system with both administrators
  and regular users. It can be made more fine-grained but
  it will do for now.

- various small enhancements to the other modules, but
  nothing big.
2000-12-16 21:42:52 +00:00
Dries Buytaert 7a45d84a9f - added a whole bunch of NEW modules 2000-12-14 14:13:37 +00:00