Commit Graph

258 Commits (7e60456ca98e9faa12fcf2ea56ee57f31c6450af)

Author SHA1 Message Date
Dries Buytaert 5a6a4206b9 - fixed HTML/XHTML typos 2001-09-21 21:10:47 +00:00
Dries Buytaert 2d1e9126cb - Added the new user module! 2001-09-16 11:33:14 +00:00
Kjartan Mannes 8a1b410adf node.module
- fixed a listing bug.
2001-08-30 08:34:28 +00:00
Dries Buytaert 098ab8ef82 - fixed bug in node.listing as reported by Julian 2001-08-27 08:20:57 +00:00
Dries Buytaert 90db2c6041 - fixed some bugs 2001-08-16 20:43:17 +00:00
Dries Buytaert af1e20e429 - node.module:
+ fixed author names not being displayed.
   + XHTML-ified the code.
2001-08-15 14:13:14 +00:00
Dries Buytaert 0d35fa4ab5 - Added some 'header("Content-Type: text/xml")' as suggested by Julian. 2001-08-14 06:52:50 +00:00
Dries Buytaert 808b6b6cae - Changed the authentication and login scheme as discussed on the mailing
list.
- Fixed the export function in book.module (patch my Julian).
- Fixed the comment alignment (comments got truncated).
2001-08-11 14:54:39 +00:00
Kjartan Mannes 2e8763bac0 node.module
- some minor modifications to node_link()
2001-08-02 15:54:09 +00:00
Dries Buytaert a3b9b7e92d - node.module:
+ added missing t()-functions (reported by Nick).

- locale.module:
    + renamed '$lang' to '$language' (reported by Nick).
2001-07-18 08:09:46 +00:00
Kjartan Mannes 6fdef17257 page.module
- added a links option so pages can be displayed on the links of the site in an
  easy way. (Requires an SQL update.)
- made HTML and text type pages be $theme->box()ed again.
- made the page body hidden in a comment during editing, in case things
  crash you should still be able to retrieve your code. Will keep working on a
  better solution.

node.module
- made all node types be listed in the node listings.
2001-07-17 20:08:05 +00:00
Dries Buytaert 39df1cba7f - Various updates, mostly related to our RDF/RSS backend. 2001-07-15 17:00:24 +00:00
Dries Buytaert af7d8ebeed - Various updates, mostly related to our RDF/RSS backend. 2001-07-15 16:56:44 +00:00
Dries Buytaert b99d4d7a42 - theme system:
+ added $theme->images()

- blog.module:
    + improved user-friendliness and rewrote most of the output routines
    + made quoted text /italic/ by default
    + integrated discussion system like it should
    + ...

- marvin.theme:
    + small visual improvements
2001-07-14 12:12:41 +00:00
Dries Buytaert 43db9cf86f - common.inc:
+ Made '$na' translatable on popular demand.

- node.module:
   + replaced a confusing configuration description, as suggested by
     Remco.

- statistics.module:
   + Added a 'most recent referers'-table sorted by timestamp.

- drupal.module:
   + Small update of the links.
2001-07-03 19:16:20 +00:00
Dries Buytaert e6a67118eb - Made search.php a module, being search.module.
- Updated the permission names to be more consistent.

- Small improvement to node.php.
2001-06-30 09:50:36 +00:00
Dries Buytaert 9c43e8fc7a Extremely large commit:
- Fixed tiny quote problem in account.php.

- Fixed tiny bug in comment.inc.

- Fixed tiny bug in comment.module.

- Fixed tiny bug in meta.module.

- Simplified user_access() API.

- Rewrote link system: still needs fine-tuning and testing so don't
  upgrade if you are running a production site. ;)

  Updated all modules and themes to reflect this change.  All other
  themes and modules need updating too!
2001-06-29 22:08:57 +00:00
Dries Buytaert 124694ee4d - Fixed bug node.module bug:
+ the node scheduler did not un-schedule a node!

- Fixed comment bugs (as a result of the formification):

    + no signatures where being attached to the comments.

    + check_input was used where is should have been check_output,
      with broken filters as the immediate result.
2001-06-27 18:06:36 +00:00
Dries Buytaert ca6af5ad76 - Fixed conf_save bug in node.module (reported by Jared). 2001-06-25 06:47:55 +00:00
Dries Buytaert 72065fb835 - Added a brand-new access.module which allows you to manage 'roles'
(groups) and 'permissions' ... (inspired by Zope's system).

    + Once installed, click the help-link for more information.

    + See updates/2.00-to-x.xx.sql for the SQL updates.

- Modified loads of code to use our new access.module.  The system
  still has to mature though: new permissions have to be added and
  existing permissions need stream-lining.  Awaiting suggestions.

- As a direct result of the new access system, I had to rewrite the
  way the top-level links in admin.php are rendered and displayed,
  and xhtml-ified admin.php while I was at it.

TODO

- Home-brewed modules need updating, home-brewed themes not.
  (Examples: file.module, trip_link.module)

- As soon we *finished* the refactoring of the user system (KJ has
  been working on this refactoring already) we should consider to
  embed this role and permission code into account.module ...
2001-06-20 20:00:40 +00:00
Dries Buytaert 9f2eec079c - block.module:
+ renamed 'overview' to 'preview' as suggested by Kristjan.

- meta.module:
    + renamed 'verify' to 'preview' to make it consistent with
      block.module.
    + fixed comma-bug with attribute list reported by Kristjan.

- node.module:
    + fixed typo: "id$nid" should have been "id=$nid"
2001-06-18 18:00:13 +00:00
Dries Buytaert 3d73a48edc - Merged "system settings" and "module settings" into one page. IMHO
it wasn't a good idea to split them up in first place, and it turned
  out to be quite hard to decide where to put some variables.

  Also moved some variables around and even renamed a few variables
  while doing so.

- Added a page_header() and page_footer() to all top-level .php pages.
2001-06-17 20:35:48 +00:00
Dries Buytaert 03c06a86eb Oops, a rather large commit:
- Changed meta.module, node.module and index.php to use comma-seperated
  lists of attributes rather then "foo=a,bar=b" lists.  This makes it a
  a lot easier to use both modules.  In addition, error handling can be
  discarded as it can't be made any simpler, really ...

  It fits rather nicely in Drupal's design so I'm getting more and more
  happy with this meta.module (but we are not 100% there yet).

- node.module, node.inc:

   + Improved the node-related admin interface so that navigating back
     and forth the administrative menus is made both easier and faster.

   + Removed some redundant database fields from the node table.  See
     2.00-to-x.xx.sql!

   + Added 2 news hooks called "node_insert" and "node_update".  Just
     like this is the case with the existing hook "node_delete" these
     new hooks will automatically get called when a node has been
     inserted or udpated.  Note that this is an optional call-back that
     only needs to be implemented when required.  With the addition of
     these two hooks, the node mechanism (version 1) is pretty well
     completed.

- watchdog.module:
   + Fixed bug whit the 'regular messages' query in the watchdog.module.

- book.module:
   + Fixed bug in book.module: the 'parent' was not set properly when
     updating a book page.
   + Made it so that older versions of a book page are automatically
     reactived upon deletion of the most recent version, i.e. when
     doing a version roll-back.

- comment.inc:
   + Undid Remco's patch to comment.inc; it does not work in some cases.


- conf.module:
   + Fine-tuned some of the options in conf.module a bit.

- marvin.theme:
   + Visual changes to make it look better on Windows browsers.  Mind
     to give some feedback on this?
   + Fixed 3 HTML typos/bugs.
   + XHTML-ified the theme at a best effort basis; I didn't carry the
     XHTML specification with me.
   + Made use of the theme_slogan variable to display the site's slogan.
   + As soon we have at least one valid XHTML theme we can wonder on how
     to integrate other XML namespaces (cfr. MathML story at drop.org).

- database.mysql:
   + Updated database.mysql so that it contains all the latest "database
     patches".
2001-06-17 18:31:25 +00:00
Steven Wittens 304d28681d - Replaced um...flashy... nodelisting colors with something a bit more neutral. 2001-06-14 14:14:21 +00:00
Kjartan Mannes 3b35b43576 - changed $this->timestamp = $node[attributes]; to
$this->attributes = $node[attributes];
  Makes more sense this way :-)
2001-06-12 11:50:38 +00:00
Dries Buytaert be7077be33 - More updates to index.module. 2001-06-11 20:33:35 +00:00
Dries Buytaert c56ee67e29 - Changed field_set(), field_get() and field_merge() to use ',' and
'=' instead of ';' and ':'.  It is considered to be more readable.
  --> A _first_ step towards and improved index.module.  Stay tuned
      for more.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

- Changed all 'attribute' to 'attributes'.

  + Important:
     If you update from CVS - apply the queries in 2.00-to-x.xx.sql!

  + Important:
     This might require to ieni-wieni small update to your custom
     themes and/or node-related modules:
      - themes: node_index($node->attribute) -> node_index($node)
      - node modules: attribute -> attributes
2001-06-11 20:01:13 +00:00
Dries Buytaert d397bbe935 This a rather large commit that needs a lot of fine-tuning. If you
update, you'll break your site as you need switching from structure
to index.module: so this can be considered an intermediate commit.

If you upgrade, and you are welcome to, just create a collection
called "section" (for now) and assign your nodes some attributes
in the described format.

Feedback and bugreports are welcomed.  Questions will be answered.

CHANGES:

- comment system:
   + when replying to a node (rather then to a comment), that
     node is displayed above the reply form.
   + when replying to a comment (rather then to a node), that
     comment is displayd above the reply form.

- removed structure.inc, removed structure.module.

- node.inc:
   + added 2 new node functions called 'node_attribute_edit()' and
     'node_attribute_save()' used to 'hook in' any indexing system
    including your home-brewed stuff if you'd want to.  Currently,
    index.module is the facto default index system.

    See story.module for usage.

- book.module, story.module, poll.module, page.module, forum.module:
   + added preview functionality to administration section (via node
     module).
   + removed all references to structure.inc (category, topic).

- moderate.module:
   + removed all references to structure.inc (category, topic).

- book.module, story.module, page.module, forum.module:
   + increased the sizes of some textareas.

- submit.php:
   + removed all references to structure.inc (category, topic).

- marvin.theme:
   + removed dead code: function story() was depricated.

- unconed.theme:
   + removed hardcoded references to drop.org.

- marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
   + removed all references to structure.inc (category, topic).

TODO:

- file.module, trip_link.module:
   + update preview functionality:
       see story.module for example.
   + remove references to 'cid' and 'tid', use 'attribute' instead:
       see story.module for example.

- extend and build upon index.module as well as making it configurable
2001-06-10 15:01:20 +00:00
Dries Buytaert 1383729ec1 - Node filters: renamed 'Strip link tags' to 'Enable link tags'.
(Suggestion by Remco.)
2001-06-07 16:28:48 +00:00
Dries Buytaert f9de04c93f - Fixed bug in node_search of node.module. 2001-06-07 07:16:11 +00:00
Dries Buytaert 67958d3d41 - Added 'help structure' for node.module. We still need documentation
for nodes ... anyone maybe?

- Improved help.module.
2001-06-06 20:26:12 +00:00
Dries Buytaert c9e807a347 - Fixed permission problem in node.module.
Kristjan: this should fix the problem you reported on the mailing-list.
            We aim at providing a better solution in the long though.
2001-06-06 18:57:13 +00:00
Dries Buytaert a286e9dd2d - Fixed bug in 'attribute editor'. 2001-06-05 19:13:03 +00:00
Dries Buytaert f490fc26df - Improved node_query such that an 'illegal offset' is less likekely to
happen.
2001-06-05 18:32:04 +00:00
Dries Buytaert d3de63cac5 - Fixed small bug in "search node" of node.module. 2001-06-04 16:24:15 +00:00
Dries Buytaert 8fafe12188 CHANGES:
- Improvement to node listings.

- Patched story.module to work with new node.module!

NOTE:

- UnConeD: poll.module needs updating.  Let me know if you want me to do
           it as I assume you will update it unless otherwise mentioned.
2001-06-04 16:03:10 +00:00
Dries Buytaert c75057bb0f CHANGES:
- Added improved node scheduler:

   + Automatically post node at date 'xx/xx/xx, xx:xx'.

   + Automatically queue node at date 'xx/xx/xx, xx:xx'.

   + Automatically dump node at date 'xx/xx/xx, xx:xx'.

  Requires a database update, see ./updates/2.00-to-x.xx.sql!

- Refactored the admin interface of node.module.  It is only a start
  but it should show the direction we are going.

   + The new interface is easier to extend with new functionality
     and operations.  New "edit xxx" links can easily be added on
     our way.

   + The new interface tries to cover all content- or node-related
     functions.  Thus making a special admin interface for each new
     node type redundant.  To demonstrate this, I removed the admin
     hook from page.module and forum.module.  This removes quite a
     bit of logic from the invidual modules which is a good sign if
     you ask me.

     A centralized GUI or interface covering all node-related
     administration should make Drupal easier to administer.

TODO:

- All node-related nodes need updating.  This should be trivial and
  I'll hapilly tackle this later tonight.

- There will be bugs, and I'm still working on this but I would like
  to get some feedback (from Natrak et all) on both user-friendliness
  and usability of this new interface.  I'm still working on it as we
  speak ...
2001-06-04 15:40:39 +00:00
Dries Buytaert 0c89ef1249 - Fixed bug in "delete node". 2001-06-04 06:26:53 +00:00
Dries Buytaert e58207f2e0 - Fixed another typo: node_default -> node_setting 2001-06-03 09:51:57 +00:00
Dries Buytaert 50a490d261 - Fixed typo: "Save defaults" -> "Save settings". 2001-06-03 09:32:14 +00:00
Dries Buytaert b0c349e247 - Moved most of the options in structure.module to node.module. The
structure.module either needs work, or replacement by index.module:
  see "admin > node > node settings".

  It will do for now and it can always made better when we can think
  of a better solution; it is the best I could think of.   Now what?
  index.module or structure.module?  I'm currently pro index.module.

- Drastically simplified "variable.inc".

- Removed most dependecies on structure.module from all content related
  modules.  Thus making our modules more modular.  ;)

- Fixed calculation glitch in queue.module.

- Fixed potential function name clash/conflict in rating.module, and
  simplified some code on my way.

- Started removing all global variables $status and $rstatus.  Global
  variables are "yucky" so in near future, we will replace all global
  $status variables by a call to node_status().  Originally, $status
  was only introduced as a temporary hack and nothing is as permanent
  as a temporary hack so I took it out when still possible.

- Changed the watchdog messages a bit.
2001-06-02 22:12:35 +00:00
Steven Wittens 27496c4620 - Changed the node_get_object() and node_get_array() functions to allow multiple conditions
- Added the "delete" hook for node-modules. When called, a module should do additional clean-up if necessary.

- Updated all node-modules
2001-05-20 16:47:50 +00:00
Dries Buytaert 20397ad3d9 CHANGES
- Redid settings.module and even renamed it to conf.module.
    * Settings are now grouped in basic categories like "system
      settings", "module settings" and "filters".
  * Added new settings to make Drupal easier to configure and
  to make some aspects like the watchdog scale better.

- Renamed includes/settings.php to includes/conf.php.

- Added filter support to conf.module and introduced filter hooks so
  modules can implement and export new filters.  Example filters are
  an HTML filter (implemented), a profanity filter, an url converter,
  ASCII smileys to images filter and so on ...

- Reworked the check_* functions: user contributed content/input is
  only verified and filtered once in its lifespan.

NOTES

- Altough this is a large commit, no database changes are required.
2001-05-20 13:51:40 +00:00
Dries Buytaert 031e4d4208 - Tidied up the field_get() API and improved the implementation of
both field_set() and field_get().
2001-05-17 20:50:15 +00:00
Dries Buytaert 1022eb61ab - Drastically simplified the node_save() API, which should make the
node-forms more secure.  Updated "node.module" and "queue.module"
  to work with the new API.

  The upgrade script, 2.00-to-x.xx.php, is still broken and needs
  fixing.
2001-05-15 21:35:27 +00:00
Dries Buytaert c1c3943934 CHANGES:
- "Formified" node.module and structure.module.

- Added moderator capabilities to topics in structure.module; you can
  define the default moderators.
2001-05-10 19:47:35 +00:00
Dries Buytaert be8e898d23 - Uhm. Rewrote the module system: less code clutter, less run-time
overhead, and a lot better (simpler) module API.  I had to edit a
  LOT of files to get this refactored but I'm sure it was worth the
  effort.

  For module writers / maintainers:

  None of the hooks changed, so 95% of the old modules should still
  work.  You can remove some code instead as "$module = array(...)"
  just became obsolete.  Also - and let's thank God for this - the
  global variable "$repository" has been eliminated to avoid modules
  relying on, and poking in drupal's internal data structures.  Take
  a look at include/module.inc to investigate the details/changes.

- Improved design of the content modules "story", "book" and "node"
  (to aid smooth integration of permisions + moderate.module).  I'm
  still working on the permissions but I got side tracked for which
  I "Oops!".
2001-05-05 13:57:29 +00:00
Dries Buytaert 343e71c8eb CHANGES:
- Added moderator permissions to nodes.

- Added moderator support to structure.module.

- Added new moderate.module.

- Renamed moderation.module to queue.module to avoid confusing.
  Updated theme yaroon as it seems to have a hard-coded reference
  to moderation.module.

- Polished on:
   + account.module: improved access list
   + fixed HTML typo in node.module

ACTIONS:

- Jeroen: can jeroen2.theme be removed from ./themes/yaroon?
2001-05-02 20:52:19 +00:00
Dries Buytaert fead09a8de Welp. Large commit ahead.
CHANGES:

- Added "read" and "write" permissions into drupal but removed
  it again because - when finished after 3 hours of work - it
  was considered nothing but added complexity that didn't buy
  us anything. :I

  (I'll explain this in detail on the mailing list, I guess.)

- Added a very simple help.module to group all available
  documentation on a single page.

- Fixed bug in node_control(), book.module: UnConeD forgot to
  global $user when updating the combobox code.

- Removed static wishlist.module: in future, the wishlist can
  be maintained as a page in our collaborative book.

- Revised most of settings.module: tidied up the code and the
  descriptions to accompany the settings and introduced a new
  "default maximum number of nodes to display on the main page"
  variable.

- Revised most of comment.module: the administration interface
  looks better now, integrated node permissions, and -finally-
  made it possible to delete comments.

- Polished on:
   + account.module
   + structure.module
   + locale.module
   + module.module
   + forum.module

- Form-ified:
   + account.php
   + account.module
   + setting.module
   + cvs.module
   + submit.php
   + comment.module
   + forum.module
   + book.module
   + page.module
   + locale.module

- Updated CHANGELOG

INFO:

- Designed a "generic tracker system with optional backends"
  on paper.  The idea is to allow registered users to hot-list
  certain topics, individual nodes or threads (comments) and
  to "plug-in" output backends like - for instance - an e-mail
  digest.  The design requires "intelligent blocks" though.


TODO:

- I want to tidy up the headline.module and backend.class as
  well as merge in headlineRSS10.module.  Julian spent quite
  some time working on headline.module but I'm not sure what
  he changed and whether he'd contribute it back?
2001-04-30 17:13:08 +00:00
Dries Buytaert ef7d5e1201 CHANGES:
- Added new form_* functions to common.inc, used for building
  forms: it should improve 'stability' (no form typos, every-
  thing properly escaped/unescaped) and should help providing
  a very consistent user interface (wrt forms).

- Adjusted node.module to use the new form functions.
  (Can be used as an example.)

- Adjusted book.module to use the new form functions.
  (Can be used as an example.)

- Merged function.inc into common.inc!

- Slowly removing all global $status and $rstatus variables:
  use node_status() instead.

TODO:

- Apart from implementing the permission system, I'll spend
  some time updating most modules today and tomorrow to use
  the new form functions.
2001-04-29 12:39:55 +00:00
Dries Buytaert cccb132c81 - Addition: added a "promote" field to the node table, which
makes "promoting nodes" to the main page possible.  Stories
  and reviews could be promoted by default, but - on accasion
  a good book entry could be manually promoted too.  Thus all
  existing content types can be shown on the main page, not
  just stories.

  Requires a SQL update, see 2.00-to-x.xx.sql!

- Addition: implemented "auto-post new submissions" feature
  to disable or by-pass the moderation queue in addition to
  "moderate new submissions".

  TODO: admin moderation versus registered user moderation.

- Addition: added category and topic support to page.module.
2001-04-21 14:19:20 +00:00
Dries Buytaert 3f1979aa3c - Addition: made it so that comments can be enabled/disabled on
a node per node basis, rather then on a category per category
  basis.  The default settings for each individual category can
  be changed though.

  Example: it can be setup so that - by default - all stories
  posted to the category "article" will have comments enabled
  but stories submitted to "announcement" not.

  Different configuration schemes can easily be added later.

  Requires a SQL update, see 2.00-to-x.xx.sql/database.mysql.

- Addition: made submit.php only use categories that users can
  actually submit new content to.
2001-04-19 19:59:48 +00:00
Dries Buytaert b1c66cb5de Another big update so please read this carefully because there is important information hidden in it.
Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.

I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)

Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)

In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)

I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)

Oh, I also fixed a few bugs and made various small improvements.
2001-04-16 18:21:22 +00:00
Dries Buytaert 4711869f52 - fixed a small SQL bug in page.module
- slightly improved story.module, node.module and book.module
- made the "default theme" a setting from the setting page
- polished a bit on the export function: we can now export the
  book or parts thereof through the following url:

    1.  http://drop.org/export/book/
          (full book)
    2.  http://drop.org/export/book/nid
          (where nid is the node id to start with)

  The export routine demonstrates how it can be done yet the
  output is too basic and can only improve over time.
2001-04-11 19:44:24 +00:00
Dries Buytaert 0f567be0ed - improved administrator interface of account, node, story and book
by (1) adding a few extra features to "easify" navigation and (b)
  to start using "status messages" as once suggested on the mailing
  list by Jeroen
2001-04-10 20:07:27 +00:00
Dries Buytaert 38806b4a39 - fixed bug in common.inc: throttle()
- streamlined method invocation in node.inc
- added node_status() function to modules
- added NEW (mostly static) page module
- added NEW settings module
2001-04-07 15:02:28 +00:00
Dries Buytaert 36ea1cf957 - list nodes chronological 2001-04-02 20:13:19 +00:00
Dries Buytaert 805107cd22 Commiting my work of last Sunday:
- removed ban.inc and ban.module and integrated it in account.module
   under the name "access control" --> the ban code was not really up
   to standard so this has now been dealt with.  This refactoring and
   reintegration cuts down the code size with 100 lines too.  :-)
   (The ban.module code was really old and it showed.)

 - added node.module and made the other modules reuse some of this
   code --> cut down the code size of modules by at least 100 lines
   and adds stability.

 - added a status() function to admin.php to display a conform status
   message where appropriate.  See admin.php for usage.

 - removed $theme->control() and made comments.inc handle this itself
   wrapped in a $theme->box().  No need to clutter the themes with
   such complexity --> updated all themes already. :-)

 - some small visual changes to some administration pages to be more
   consistent across different modules.
2001-04-02 15:54:37 +00:00