Commit Graph

102 Commits (7af49ab274e7ea650abfecb323ae4b510960b5c3)

Author SHA1 Message Date
Dries Buytaert 7af49ab274 - Committed Marco's comment module patch:
+ Dramatically improves performance of large discussions/threads: only
      very few SQL queries are required.
    + Replaces custom pager with standard pager.

  Modifications by me:

    + Reworded some code comments.
    + Removed dependencies on pager internals.
2003-08-12 18:32:54 +00:00
Dries Buytaert 24de26c13d - Changing the node body to type 'mediumtext'. Addresses bug #2155. 2003-07-26 18:27:16 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert e5033fe1cf - Fixed critical bug #1788: cloud module pings too much. Modified patch by
Kjartan.

  This update requires some database changes so make sure to run update.php.
2003-06-01 06:46:55 +00:00
Dries Buytaert 17e5b5c2d7 - Changed the type of the string fields in the locale table to BLOB.
This fixes bug #987.  For PostgreSQL this is not required because
  its string comparisons are case-senitive.  Not idea about MSSQL.
2003-05-24 14:31:36 +00:00
Dries Buytaert 7e8aa5268b - Fixed bug in book_prev(). Patch by Andy Colson.
- Book optimizations: updated to use inner joins.  Patch by Andy Colson.
  This should address bug #1373.

  TODO: add index to MSSQL database scheme.
2003-05-18 16:43:56 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert fd37c0db4b - Added default table values to MSSQL database scheme. Patch by Moshe. Fixes bug #1571. 2003-04-28 20:53:42 +00:00
Dries Buytaert b85cf71962 - Applied modified version of Al's "block delta" patch. I left out the
blogroll feature as I think it would get very confusing.  I don't mind
  to add it but it need some thought and documentation as it somewhat
  conflicts with the existing cloud module.

  These changes require you to run update.php.
2003-04-19 16:42:42 +00:00
Dries Buytaert 9d5fb1029a - Made sure the admin menu is enabled after a fresh install. This is
required to make the menu show up.

  This partly fixes bug #1508.
2003-04-18 22:33:15 +00:00
Dries Buytaert fd9635e63a - Some MSSQL related fixes by Moshe. 2003-04-13 17:12:52 +00:00
Dries Buytaert 164003ed91 - Added missing tid-column to the forum table. Patch by Anarcat. 2003-04-13 15:26:52 +00:00
Dries Buytaert 2e2e247979 - Added missing 'created' field to 'cache' table. 2003-03-19 21:55:32 +00:00
Dries Buytaert 2976bc59f0 - The link field got accidentically removed. Thanks Stephane. 2003-03-18 21:03:42 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert 6dc1cf59ba - Added a database scheme for Microsoft's SQL server. 2003-03-16 06:34:59 +00:00
Dries Buytaert a8edbf638f - Removing the menu table: it is no longer used.
[TODO: update 'update.php'.]
2003-02-24 23:17:39 +00:00
Dries Buytaert d5bb7bce52 - database.mysql cannot be run from within phpMyAdmin because of line
consisting of hyphens only.  Patch by Zbynek.
2003-02-24 22:39:32 +00:00
Dries Buytaert 73f476a6c1 - Fixed typo: forum2 -> forum. 2003-02-07 08:06:37 +00:00
Dries Buytaert 4ea6d5048d - Updated the database scheme. 2003-02-06 19:14:19 +00:00
Dries Buytaert d268783669 - Small improvement to the admin menu based on feedback from Michael. 2003-01-14 20:33:42 +00:00
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert 1ad6cff2ec - Fixed typo in the database scheme. Reported by Ettiene. 2002-12-15 08:20:57 +00:00
Dries Buytaert b6b24c28e0 Applied patch by Natrak:
- page_header() now adds Last-Modified and ETag http headers.
- When running PHP as an Apache module page_header() will check the HTTP
  headers for conditional gets, and will only push the content when it
  fails. (Works for html and xml pages as they are all cached). Note:
  this is a PHP limitation, so until PHP makes it work for other web
  servers this won't work for them.
- Added created field to cache database to hold the timestamp when the
  cache was created.
- Changed cache_get() to return an object with ->data and ->created.
- Update forum and locale modules.
2002-12-11 22:00:04 +00:00
Dries Buytaert d2d381d7c4 - Removed rating module; it is not being used much and it has a known bug.
Will add it to the contributions repository.
2002-12-08 07:54:30 +00:00
Dries Buytaert b62025c217 - Removed two a dead table from both the MySQL and the PostgreSQL database
scheme.

- Fixed the default settings for both the MySQL and the PostgreSQL database
  scheme.
2002-12-07 10:36:44 +00:00
Dries Buytaert f42bfcac31 - Fixed small glitch in the database schemes; the block table has changed but
the queries that insert some default block values were not updated.
2002-11-30 15:21:36 +00:00
Dries Buytaert 697dde0fe5 - Updated PostgreSQL scheme. Patch by Stefan. 2002-11-21 17:43:37 +00:00
Dries Buytaert 56d72a918f - Added Stefan's page module improvements.
[NOTE: the PostgreSQL database scheme needs updating.]
2002-11-20 20:54:56 +00:00
Dries Buytaert 96a45ecba6 - Updated the PostgreSQL database scheme (thanks James) and the MySQL
database scheme.
2002-11-09 20:19:13 +00:00
Dries Buytaert 86a3ebefd3 - Made the forum module work with PostgreSQL. Patch by Gordon Kerr, verified
by James Arthur.
2002-11-08 13:11:42 +00:00
Dries Buytaert 74c722502b - Applied a PostgreSQL patch from James. 2002-11-01 09:37:31 +00:00
Dries Buytaert 66c5b70736 - Wrapped some hardcoded colors in "theme_invoke()"s; we can still create
a drupal_error() later on but I think we better get used to theme_invoke().

- Fixed translation bug.  Patch by Moshe.

- Fixed PHP warning.  Patch by ax.
2002-10-22 18:46:43 +00:00
Kjartan Mannes b60b9ca828 - removed function module_rehash().
- updated database dump.
- removed tables modules, layout and referrer (don't forget to backup!).
2002-10-17 18:34:38 +00:00
Kjartan Mannes 8457c4d2ff - serializing update_start variable. 2002-09-25 18:50:50 +00:00
Dries Buytaert e4d92b5892 - Some PostgreSQL improvements. Patch by James Arthur. 2002-09-22 10:01:03 +00:00
Dries Buytaert a28f818006 - Changed "$watchdog->message" from type "varchar(255)" to type "text".
Patch by James.  For sake of consistency, I updated the MySQL scheme
  and added a new update entry to "update.php".
2002-08-26 18:18:12 +00:00
Dries Buytaert 2fe2a123a4 - Removed the unused table and included the sequences table. Patch by
jaa.
2002-08-22 18:21:44 +00:00
Dries Buytaert fd05ff03d6 - Fixed typo. Patch by Marco. 2002-08-21 04:20:06 +00:00
Dries Buytaert bfe5b85dbd - Applied a (modified) version of Marco's SQL sequence patch. 2002-08-20 19:29:16 +00:00
Dries Buytaert c34d77854d - Bugfix: changed the PostgreSQL database scheme of the session field in
the user table.  Patch by jaa.
2002-08-18 15:03:28 +00:00
Dries Buytaert d4a918b806 - Renewed the PostgreSQL database scheme! Patch by jaa. 2002-08-16 07:38:36 +00:00
Dries Buytaert e04f6d2328 - Made the rating module and its SQL table ASNI compliant. Patch by jaa. 2002-08-16 07:37:03 +00:00
Kjartan Mannes 80aca19a61 - removing cvs table definition. 2002-07-31 08:25:48 +00:00
Kjartan Mannes ec59398791 - feed table should have not null defined for refresh and timestamp. 2002-07-31 08:14:25 +00:00
Dries Buytaert c3a60df58b - Patch my Marco: "session in my users table is actually varchar(32), which is small. locale data was greater and so was not correctly recorded. strangely, update_11() in update.php reads: update_sql("ALTER TABLE users ADD session TEXT;"); but in database.mysql.inc, line 496 session varchar(32) NOT NULL default '', so the update fails." 2002-07-13 13:01:47 +00:00
Kjartan Mannes 66ccfb3f8d - fixed the markup of the collapsed comment view settings.
- updated update.php and database.mysql disable a few more modules by default.
  Without the config options in place to disable things this might confuse users.
2002-06-15 10:49:44 +00:00