Commit Graph

1248 Commits (7997ebb9820f0fe6cd8220aefb9365d29c6ee426)

Author SHA1 Message Date
Dries Buytaert cf5a17ca0d Patch be Matt Westgate:
- Bugfix: in the user_admin_edit() function, the data array returned from the callback modules was not being merged into the edit array.

- Bugfix: added enctype="multipart/form-data" to the form tag so that we can update things like the avatar image in the admin interface.
2003-06-10 19:00:48 +00:00
Dries Buytaert 222e1e5583 - Documentation improvements: improved and updated the block module documentation. Patch #44 by Al. We should add some real-life path examples!
- Fixed the "blog it" image size.  Patch #49 by Al.

- Some SQL performance improvements to the forum module.  This should also be more PostgreSQL safe.  Patch by me.

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f, node n LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.63 sec

changed to:

mysql> SELECT n.nid, n.created AS timestamp, u.name AS name, u.uid AS uid FROM forum f LEFT JOIN node n ON n.nid = f.nid LEFT JOIN users u ON n.uid = u.uid WHERE f.tid = 2 AND n.nid = f.nid AND n.type = 'forum' AND n.status = 1 ORDER BY timestamp DESC LIMIT 1, 0;
==> 0.00 sec
2003-06-10 17:33:43 +00:00
Dries Buytaert b0081e5ac9 - Bring back the "blog it" icon. Patch #47 by Al. Thanks.
(I don't like the suggested icon so I suggest we continue to use the existing one, which I don't like either but oh well.  Thoughts?)
2003-06-08 19:31:27 +00:00
Dries Buytaert 54ddba4eea - Fixes CSS for archive calendar so that you can make non-link days padded
in a sensible fashion. Also removes table width 100% and puts that in css.
  Patch #48 by Al.
2003-06-08 19:26:26 +00:00
Dries Buytaert 643d2731e7 - Fixed two broken links in the "administration > content management >
post overview" page.
2003-06-08 17:40:13 +00:00
Dries Buytaert d80557672c - Made it possible to link search results. Patch by Ax.
- Removed some high ASCII characters from the code.  Patch by Ax.
2003-06-08 17:17:53 +00:00
Dries Buytaert a448f5a9b4 - Charset simpliciations. Patch #46 by Al. 2003-06-08 16:50:05 +00:00
Dries Buytaert 49ebc543b7 - Fixed various forum module queries such that they work with PostgreSQL. 2003-06-08 12:02:37 +00:00
Dries Buytaert d4ec431b44 - Bugfix: fixed approval e-mail and tidied up the e-mail handling. Patch #43 by
Al.  Fixes bug #1828.
2003-06-08 10:12:46 +00:00
Dries Buytaert 1aa341881d - Bugfix: added trailing slash to URL. Patch #39 by Al. Fixes bug #1848. 2003-06-08 08:39:28 +00:00
Steven Wittens e1adc0f780 Fixed some typoes... 2003-06-08 01:19:37 +00:00
Dries Buytaert ae45b735d3 - Bugfix: clicking the "Login" button after having created the first user
redirected you to an incorrect page.  Patch by Moshe.
2003-06-07 21:35:45 +00:00
Dries Buytaert 23423b46fb - Check the destrination URL before redirecting. 2003-06-07 15:59:49 +00:00
Dries Buytaert 2fc741867d - Bugfix: if you clicked on an archive date in the calendar block and
then select a new date via the form the block still displays the
  original click as the "selected" date.  Patch by Craig Courtney.
2003-06-07 06:08:52 +00:00
Dries Buytaert aa38097c07 - Dropped check_input(); use check_query() instead.
- Made the statistics module use referer_uri() for security's sake.
2003-06-06 21:37:11 +00:00
Dries Buytaert 47ba929ce2 - Removed a redundant check_input(). 2003-06-06 21:09:55 +00:00
Dries Buytaert 8f783f69dd - Removed a redundant check_query().
- Removed a bogus check_input().
2003-06-06 21:06:08 +00:00
Dries Buytaert 48bf7db71c - Bugfix: removed redundant check_input()s such that quotes are handled
properly.  You couldn't use a username or passwords that had quotes.
2003-06-06 20:52:21 +00:00
Dries Buytaert 2719ebde86 - Bugfix: fixed problem when register globals is turned off. Patch 0037.poll.register_globals.patch by Al.
(Can't we make the result URL look nicer?)
2003-06-06 18:22:21 +00:00
Dries Buytaert 3436c02c81 - Bugfix: fixed the login problem due to incorrect use of drupal_goto().
Gerhard's patch was not 100% correct and I found a better alternative.
2003-06-06 17:30:09 +00:00
Dries Buytaert 1e7ef0cf21 - WOOOT! Patch by Al. 2003-06-06 04:38:11 +00:00
Dries Buytaert 3cf82a4eee - Bugfix: removed call to dead function. Patch by Al. Bug #1852. 2003-06-05 22:07:09 +00:00
Dries Buytaert 56e3e7d4a9 - Usability improvements: in the calendar, only add a link for days on which
new nodes have been posted.  Patch by Al.

  Al: I modified the query slightly - it will check whether 'status = 1'.
2003-06-05 21:34:56 +00:00
Dries Buytaert 522ed4d64c - More charset patches by Al. 2003-06-05 21:26:27 +00:00
Dries Buytaert de3b0796d2 - Bugfix: better charset support for non-ISO-8859-1 languages. Patch 0029.charset.fixes.patch by Al. Could East Asia test this please.
- Bugfix: made the "moderate" field behave.  Patch 0030.queue.module.help.and.settings.form.patch by Al.

- Documentation: revised a large part of the help texts / documentation!  Al's 0024.* patches.

- Documentation: added a glossary to the help module.  Patch 0025.help.module.glossary.patch by Al and Michael.

- Usability: first step towards unifying the terminology used in the cloud module.  Patch by 0028.site.cloud.rationalize.name.patch Al.

- Usability + CSS improvements: revamped the node form and removed all tables.  Patch 0027.node.form.rewrite.patch by Al.

- CSS improvements: patch 0026.admin.css.small.improvement.patch by Al.

- Updated the MAINTAINERS file.
2003-06-05 18:09:39 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert 3151a1cb71 - Usability improvements to the node form. Patch by Al. Will incorporate
some of Moshe's node form work later on.

TODO:

- I just spotted a problem with the promote field; it does not seem to be
  "sticky" when you click the preview button.  I checked and this was also
  the case prior to applying this patch.
2003-06-03 20:33:56 +00:00
Dries Buytaert ed528531c7 - CSS improvements: use form functions wrapped in a <div> instead of
hard-coded form elements.  Modified patch by Kristjan.

  I added some CSS to drupal.css to center the text and ordered the
  list of CSS tags alphabetically.
2003-06-03 20:02:33 +00:00
Dries Buytaert 31c36b7f54 - Fixed some translation bugs in the profile module. (I wasn't going to
commit this yet but I accidentically did so now I've cleaned it up.)
  Original patch by Matt.  Thanks for spotting the t() problem Al.
2003-06-03 19:13:19 +00:00
Dries Buytaert 05288ac48a - Bugfix: made request_uri() rewrite ( and ) with their entity equivalents
to avoid XSS attacks!  Patch by Al, Moshe, Marco, Kjartan and me.

- Bugfix: the admin module does now import drupal.css prior to admin.css.
Patch by me.

- Bugfix: the admin module was still emitting a <base href=""> tag.  I
removed this as it is been taken care of by theme_head();  Patch by me.

- Bugfix: made the tracker module's pager only consider published pages.
Patch by Moshe.

- Bugfix: cured some typos in the comment module's help function.  Patch by
Marco.

- Bugfix: fixed a typo in the pager_display() that caused optional
attributes to be discarded.

- Bugfix: made the Xtemplate emit empty boxes like any other theme does.
Patch by Al.

- Bugfix: fixed broken link on the statistics module's log page.
Reported by Kjartan.

- CSS improvements: made the HTML output emitted by the tracker module
look nicer.  Patch by Moshe and Al.

- CSS improvements: added CSS classes for form elements.  Patch by Al.

- CSS improvements: added a vertical gap between the last form item and the
submit button.  Patch by Al.  Note that Opera 6 is not picking up this
CSS but apparently others browsers such as Konqueror do.

- Xtemplate improvements: changed the color of the selected day in the
archive module's calendar.  Patch by Al.

- Usability improvements: made the "birthday" field of the profile module
look nicer.  Patch by Al.

------

- TODO: it might be a good idea to emit the following meta tag in the
theme_head() function:

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

Currently, some themes (and modules!) emit this while others don't.  This
would also make it possible to change the charset site-wide.

- TODO: now we added support for td.dark and td.light to drupal.css, maybe
it can be removed from admin.css as well as xtemplate.css?
2003-06-03 18:04:47 +00:00
Dries Buytaert 54774aa825 - Removed the module field from the locale search form. It won't work and
there is no easy replacement.

- Wrapped the strings in htmlentities() such that one can see the HTML.
2003-06-02 20:54:37 +00:00
Dries Buytaert 85d22f3e82 - Fixed the blog it link to work with register globals off. Patch by Al. 2003-06-02 18:11:54 +00:00
Dries Buytaert c8b646320d - Resized two textfields for UI consistentcy. Patch by Stefan. 2003-06-02 18:09:07 +00:00
Dries Buytaert e5033fe1cf - Fixed critical bug #1788: cloud module pings too much. Modified patch by
Kjartan.

  This update requires some database changes so make sure to run update.php.
2003-06-01 06:46:55 +00:00
Dries Buytaert 882c3f6d2d Removed node_get_node_from_nid() and modified node_load() to take an optional 2nd arguments to return a specified revision. Patch be Kjartan. 2003-06-01 06:32:55 +00:00
Dries Buytaert 5e2ce07616 - Documentation fixes by Kjartan. 2003-05-31 23:05:18 +00:00
Dries Buytaert 9b82630eaf - Bugfix: the forum module's "view" function should also call check_output(). 2003-05-31 16:30:21 +00:00
Dries Buytaert 39f6a9e79a - CSS improvements to the calendar of the archive module. Updated the Xtemplate
theme and theme Marvin to take advantage of this.  Patch by Al.  Pretty stuff.
2003-05-31 12:42:02 +00:00
Dries Buytaert b7a0a744c6 - Committed Al's rollback fixes and the title improvements. Thanks again. 2003-05-31 12:34:11 +00:00
Dries Buytaert c5637a0a02 - Small usability improvement by Al. 2003-05-31 12:21:07 +00:00
Dries Buytaert 34b51897d2 - Better CSS for the poll module. 2003-05-30 21:40:41 +00:00
Dries Buytaert 2aa762436f - Fixed a warning. Patch by Jacobo Tarrio. 2003-05-30 14:58:44 +00:00
Dries Buytaert adc5ab2f5a - Fixed bug 1763: changing comment preferences now works again. Tested with
authenticated and anonymous users.  Patch by Marco.
2003-05-30 11:13:53 +00:00
Dries Buytaert ed1a9cbfa7 Patch by Al:
- Made the import module use theme_item_list() instead of emitting the HTML
  and CSS itself.

- Renamed the "blog-it" tag to "icon" so it can be used for other (but
  similar) purposes.
2003-05-30 05:53:10 +00:00
Dries Buytaert 52e6ff8003 - "Administration overview" -> "sitemap" 2003-05-29 19:06:41 +00:00
Dries Buytaert e39cfcd22b - More CSS updates and fixes. Patch by Al. 2003-05-29 15:36:17 +00:00
Dries Buytaert 1fc8a18c2d - Al's CSS patches. This commit improves the themability of some core
components such as lists, form items, removes an ugly hack from the
  archive module and should fix the poll problem (although it doesn't
  Opera/Konqueror).
2003-05-29 10:18:38 +00:00
Dries Buytaert 8d2b1238b4 - Michael Frankowski's excellent help text improvements! 2003-05-29 09:15:00 +00:00
Dries Buytaert 3cebcdf636 - Fix for bug #1779a: all posts posted through the Blogger API where authored
by the anonymous user.  Thanks thorpexmachine and Al.

- Fix for bug #1779b: bloggerapi_user_blogs() returned broken link.  Thanks
  thorpexmachine and Al.

http://drupal.org/node/view/1779
2003-05-29 08:25:36 +00:00
Dries Buytaert c3119d1f18 - My filter commit accidentically broke the comment submission which is now
fixed.  Patch by Al.
2003-05-29 08:21:00 +00:00
Dries Buytaert c7bc17103a - Fixed braino. Reported by Remco as bug #1787. 2003-05-28 15:07:25 +00:00
Dries Buytaert c74f65a968 - Bugfix: assure that taxonomy_term_node_counts() only takes published nodes
into account.  Patch by Moshe.
2003-05-27 06:55:20 +00:00
Dries Buytaert b9e8016fc1 - Fixed validate problem. Patch by Ax. 2003-05-26 21:31:18 +00:00
Dries Buytaert d8f78a7c95 - Removed check_output() from the theme system layer. 2003-05-26 19:50:39 +00:00
Dries Buytaert 1cdda38df7 - Fixed typo. Patch by Al. 2003-05-25 20:24:59 +00:00
Dries Buytaert 102cbe5ee2 - Undid Kjartan's latest change (it breaks the feeds) and fixed it properly. 2003-05-25 07:08:21 +00:00
Kjartan Mannes 94fd74096c - Moved the theme("header") call in node_page outside the access check so the
page renders properly when a user does not have access to content.
2003-05-24 23:13:58 +00:00
Dries Buytaert 45d5aad6df - Updated Drupal to use "on output" filters. Derived from Gerhard's patch. 2003-05-24 16:26:13 +00:00
Dries Buytaert d592f76565 - Changed "user blogs" to "blogs". Patch by Al. 2003-05-24 07:09:49 +00:00
Dries Buytaert 9863dd5a71 - Fixed typo in URL(). Patch by Al.
- Added a filter option to disable/enable the rewrite_old_urls() filter.
  See task #1542.
2003-05-23 21:59:44 +00:00
Dries Buytaert 5bd07f4bb2 - Fixed search module bug. Patch by Michael. 2003-05-23 17:59:25 +00:00
Dries Buytaert 210203a72d - Fixed broken link. Patch by Al. 2003-05-23 04:49:08 +00:00
Dries Buytaert a87f442e05 - Fixed typo in help. Patch be Al. 2003-05-20 04:36:34 +00:00
Dries Buytaert e99d422273 - Fixed register_globals issue. Patch by Michael. 2003-05-19 21:17:30 +00:00
Kjartan Mannes 8c037610ab - $_SERVER["edit"] -> $_POST["edit"] 2003-05-19 18:59:34 +00:00
Kjartan Mannes 1a2f8acb2c - Patch by Jonathan Chaffer: $_SERVER["op"] -> $_POST["op"] 2003-05-19 18:58:50 +00:00
Dries Buytaert b5e644d6b0 - Some fields can be passed through the $_GET array (eg. to make the "blog
it" modules work).  Patch by Ax.
2003-05-19 18:36:58 +00:00
Dries Buytaert 8bc39e9083 - Undid my changes to user_access(). 2003-05-19 09:07:42 +00:00
Dries Buytaert 8205b62666 - Replaced some PHP_SELF's by request_uri()'s. Patch by Gerhard. 2003-05-18 20:21:35 +00:00
Dries Buytaert 7e8aa5268b - Fixed bug in book_prev(). Patch by Andy Colson.
- Book optimizations: updated to use inner joins.  Patch by Andy Colson.
  This should address bug #1373.

  TODO: add index to MSSQL database scheme.
2003-05-18 16:43:56 +00:00
Dries Buytaert d54465b800 - Fixed 3 PostgreSQL problems!
- Fixed some locale problems; made it easier to translate some strings.

- Removed some dead wood.
2003-05-18 10:09:28 +00:00
Dries Buytaert 57c7d7b43b - The page_footer() function was always called twice due to the introduction
of the "footer" hook (and because of the existence of the page module).
  This caused the node view counter to be incremented twice per page view,
  the cache being set twice, etc.  Quite a bug.
2003-05-18 09:48:49 +00:00
Dries Buytaert 494aa87e37 - Small change that reduces the number of SQL queries when a certain role has
no permissions set.
2003-05-18 09:10:17 +00:00
Dries Buytaert 9c43f5440e - Fixed some PostgreSQL issues. Reported by Michael.
- Removed some dead wood.
2003-05-18 07:01:37 +00:00
Dries Buytaert 07ab3915c4 - Only export the "who is online" block when the access log is enabled.
Patch by Al.  Fixed bug #1692.

- Only export the "top nodes" block when the node counters are enabled.
2003-05-17 19:57:52 +00:00
Dries Buytaert badf1ca458 - Fixed bug #1665 : teaser is not trimmed when creating static pages.
Patch by Marco.
2003-05-17 13:56:53 +00:00
Dries Buytaert 8d50bab9f9 - Specified the charset such that the administration pages would validate.
Is this an OK thing to do?
2003-05-13 21:36:57 +00:00
Dries Buytaert 460b902d70 - Added a couple of checks to avoid pg_atoi problems using PostgreSQL.
Reported by Michael Frankowski.
2003-05-13 21:34:39 +00:00
Dries Buytaert bf300292da - Made the teaser work for HTML book pages. Patch by Nick. 2003-05-13 20:17:14 +00:00
Dries Buytaert 0215c5032f - The book_admin_orphan() function is using the table() function to render
the orphan pages.  Patch by Nick.

- The "printer-friendly link" is only shown when the book page is not on
  the main page.  Patch by Nick.
2003-05-13 19:05:02 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert 73d5cf8644 *** empty log message *** 2003-05-10 16:13:17 +00:00
Dries Buytaert b523de70d3 - Changed some "tid"s to "r.tid"s to avoid confusion. Patch by Gerhard. 2003-05-10 15:22:38 +00:00
Dries Buytaert 167cf56aa6 - Fixed warning when creating a vocabulary with no types. Reported by Gerhard,
patch by Marco.
2003-05-10 14:56:23 +00:00
Dries Buytaert a31c329735 - Patch by Marco:
+ Fixed bug 1544: comment_mod_matrix() was broken.

   + Emit tables using the table rendering functions.

   + Fixed a typo in the documentation/comments.

(Welcome back Marco!)
2003-05-10 14:43:22 +00:00
Dries Buytaert 7aa28ea114 - Added an option to make "node previews" optional. Patch by n8. See
"site configuration > modules > node".
2003-05-10 13:54:38 +00:00
Dries Buytaert a161110a6b - Applied Michael Caerwyn's "%s -> %d" patch.
- Changed all occurences of '%d' to %d as suggested on the mailing list.
2003-05-07 21:00:36 +00:00
Dries Buytaert c60e3b13fa - Added missing t() function. Patch ba Al. 2003-05-06 06:42:01 +00:00
Dries Buytaert 5632464104 - Fixed bug #1336: profile module problem. Patch by Al. 2003-05-03 05:44:25 +00:00
Dries Buytaert 3672ce2cf3 - Fixed typo. 2003-05-02 22:44:11 +00:00
Dries Buytaert 54459cc01a - Fixed the function prototypes of the newly introduced theme_user_list(),
theme_node_list(), and theme_menu_list().  This will fix the excessive
  gap between lists and avoids generating empty <b></b> constructs.
2003-05-02 20:44:14 +00:00
Dries Buytaert 8a95b9b87e - Fixed critical bug #1539; incorrect use of pager_query(). 2003-05-02 19:36:59 +00:00
Dries Buytaert 2d6408dff3 - Committed Adrian's item patch. It would be nice if one or more of the
standard themes could be updated to demonstrate the possibilities.
2003-04-29 20:48:50 +00:00
Dries Buytaert 5ce6e015d0 - Fixes bug #1336 and #1473. 2003-04-29 20:31:21 +00:00
Dries Buytaert db04650411 - Added support for user registration guidelines. Patch by Al. Feature request #1109. 2003-04-28 21:36:43 +00:00
Dries Buytaert 4a9e233d75 - News items are now filtered using node_filter() instead of filter(). This stops the other filters (such as textile) from kicking in and messing with the data. Reported by Gary. 2003-04-28 21:23:11 +00:00
Dries Buytaert 50b5fa0459 - Simplified blogger API module thanks to node API changes. Patch by Moshe. 2003-04-28 20:54:39 +00:00
Dries Buytaert 4ca11cab45 - Fixed the grammer of the Who's online block. Patch by Al. Fixes bug #1541. 2003-04-28 20:54:14 +00:00
Dries Buytaert fe4b713b68 - Added title module; this brings back some old functionality. Thanks
Moshe and Gerhard.
2003-04-24 21:56:12 +00:00
Dries Buytaert 4c0d7da02f - Added admin description suggested by Gunnar (slightly modified). 2003-04-22 20:10:23 +00:00