Commit Graph

308 Commits (78de902353fce6589c4337c9c05810ce86cdde61)

Author SHA1 Message Date
Alex Pott 6bf02d966d
Issue #2822382 by voleger, pfrenssen, erozqba, jungle, RytoEX, borisson_, jofitz, shashikant_chauhan, sidharthap, dawehner, xjm, kiamlaluno, catch, daffie, klausi: Make every $modules property protected on classes extending BrowserTestBase and KernelTestBase 2020-04-13 12:05:00 +01:00
Alex Pott 0dc28534c8
Issue #3107732 by mondrake, longwave, swatichouhan012, salah1, xjm, catch, alexpott, Berdir: Between April 13 and April 17, 2020: Add return typehints to setUp/tearDown methods in concrete test classes 2020-04-13 09:56:30 +01:00
Alex Pott 6108526c9c
Issue #3113077 by mondrake, Hardik_Patel_12, Neslee Canil Pinto, swatichouhan012, prabha1997, neelam_wadhwani, Berdir, longwave: Replace assertContains() on strings with assertStringContainsString() or assertStringContainsStringIgnoringCase() 2020-04-12 12:34:00 +01:00
xjm 4c453683e4 Issue #3106666 by catch, jungle, xjm, alexpott, tim.plunkett, Berdir: Remove post updates added prior to 8.8.0 2020-03-11 15:58:38 -05:00
Alex Pott 915b74f937
Issue #2570985 by ifrik, chipway, lomasr, jhodgdon, shimpy, govind.maloo, vacho, Balu Ertl, Manjit.Singh, alexpott, Bojhan, volkswagenchick, mradcliffe, xjm, tkoleary, yoroy, no_angel, dawehner, webchick, Sam152, RuslanP, Gábor Hojtsy, wengerk, wla_g: Update the module descriptions on the Extend page 2020-02-24 14:24:57 +00:00
Alex Pott 4577772da0
Issue #3101543 by lauriii, bnjmnm, ravi.shankar, alexpott: Update core JavaScript dependencies listed in package.json 2020-01-30 09:08:38 +00:00
Alex Pott 5b657b15b8
Revert "Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json"
This reverts commit 2dadb738bf.
2020-01-28 13:14:16 +00:00
Alex Pott 2dadb738bf
Issue #3101543 by lauriii, bnjmnm, ravi.shankar: Update core JavaScript dependencies listed in package.json 2020-01-28 11:36:14 +00:00
catch 32d95eccd7 Issue #3082655 by Wim Leers, alexpott, iyyappan.govind, dww, lauriii: Specify the $defaultTheme property in all functional tests 2019-11-08 13:39:33 +00:00
catch e37031e09a Issue #3072702 by alexpott, Wim Leers, mikelutz, xjm, catch, Berdir, tedbow, webchick, shaal, Mixologic, heddn: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed 2019-10-15 15:34:52 +01:00
Lauri Eskola 253fc6f2ef
Issue #2873389 by mgifford, andrewmacpherson, RachelOlivero, mradcliffe: ARIA role="form" on contextual menu buttons is unnecessarily verbose and misleading for screen readers 2019-10-10 21:13:37 +03:00
catch 17153a2605 Issue #3053956 by alexpott, neeravbm, aleevas, voleger, Berdir: Deprecate \Drupal\Component\Utility\Crypt::hashEquals() in favour of PHP's builtin hash_equals() 2019-06-10 14:28:03 +01:00
catch 9791614b78 Issue #2731817 by mikelutz, ashishdalvi, Sonal.Sangale, dbt102, andypost, jhodgdon, martin107, roderik: Replace all calls to the deprecated Drupal::url() function in Core 2019-04-16 14:38:27 +09:00
Lauri Eskola 9a4a499f07
Issue #3024527 by alexpott, markconroy, waako, occupant: Add and configure stylelint-order 2019-04-01 20:16:16 +03:00
Lee Rowlands 12c3109341
Issue #2707879 by hctom, Sam152, grahl, reekris, casey, gngn, Noemi, dawehner, jherencia: Contextual Links do not respect pathPrefix 2018-10-26 16:33:00 +10:00
Lee Rowlands 4dfab43fd5
SA-CORE-2018-006 by alexpott, attilatilman, bkosborne, catch, bonus, Wim Leers, Sam152, Berdir, Damien Tournoud, Dave Reid, Kova101, David_Rothstein, dawehner, dsnopek, samuel.mortenson, stefan.r, tedbow, xjm, timmillwood, pwolanin, njbooher, dyates, effulgentsia, klausi, mlhess, larowlan 2018-10-18 08:46:04 +10:00
Alex Pott 2dabd1de10
Issue #2829185 by vaplas, Jo Fitzgerald, anmolgoyal74, chipway, gaurav.kapoor, mark_fullmer, amit.drupal, cilefen, longwave, xjm, wturrell, anavarre: Fix spelling errors in Drupal core comments 2018-09-20 17:12:38 +01:00
xjm fa6b3d95dd Revert "Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase"
This reverts commit 69501f3062.
2018-08-16 18:12:22 -05:00
Nathaniel Catchpole 69501f3062 Issue #2822382 by voleger, pfrenssen, erozqba, RytoEX, borisson_, sidharthap, Jo Fitzgerald, shashikant_chauhan: Make every property protected on classes extending BrowserTestBase and KernelTestBase 2018-08-15 19:55:23 +09:00
Lauri Eskola e742590eed
Issue #2981652 by ApacheEx, corbacho, drpal, dawehner, xjm, alexpott, lauriii: Format core JavaScript using recently add Prettier 2018-08-09 18:49:18 +03:00
Alex Pott 72d0bff47d
Issue #2865407 by nlisgo, ApacheEx, GoZ, dawehner, michielnugter, Lendude, Mile23: Convert web tests to browser tests for contextual module 2018-07-22 12:37:57 +01:00
Alex Pott e4b5fe2ef8
Issue #2983375 by m1r1k, ApacheEx, drpal: JS codestyle: function-paren-newline 2018-07-06 12:18:34 +01:00
Alex Pott 27740c26de
Issue #2942900 by Mixologic, vaplas, jibran, dawehner, Lendude, martin107, alexpott, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 15:36:57 +01:00
Alex Pott ff99cb2133
Revert "Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver"
This reverts commit f55d974612.
2018-07-04 08:20:33 +01:00
Alex Pott f55d974612
Issue #2942900 by Mixologic, vaplas, jibran, Lendude, martin107, alexpott, dawehner, tedbow, tacituseu, tstoeckler, heddn: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver 2018-07-04 08:16:25 +01:00
Alex Pott 59fe5e752d
Issue #2975439 by aron.beal, martin107: ContextualController property incorrectly named 2018-05-30 11:42:26 +02:00
Alex Pott be6d515cad
Issue #2572613 by Malevi4, idebr, pfrenssen, Mile23, RajeevK: Fix 'Drupal.Array.Array.CommaLastItem' coding standard 2018-05-11 10:40:33 +01:00
Nathaniel Catchpole 45bc05523f Issue #2958429 by alexpott: Properly deprecate SafeMarkup::format() 2018-05-01 16:14:09 +01:00
Alex Pott 51afa6813a
Issue #2870452 by andypost, vaplas, claudiu.cristea, Ujin, Jo Fitzgerald, michielnugter, Lendude: Convert web tests to browser tests for menu_ui module 2018-04-30 15:24:22 +01:00
Nathaniel Catchpole d90ac78f3e Issue #2798891 by ankitjain28may, trobey, TR: Define project dependencies in core module .info files 2018-04-06 13:13:01 +01:00
Alex Pott 7d2f3a3b76 Issue #2946603 by drpal, alexpott, dawehner: JS codestyle: no-use-before-define 2018-03-05 09:14:08 +00:00
Alex Pott 0013e901fe Issue #2866810 by BrightBold, harsha012, joelpittet: Update stylelint rule function-comma-space-after to be consistent with Drupal's CSS standards 2018-01-09 18:38:49 +00:00
Alex Pott c5654de7aa Issue #2866809 by BrightBold: Update stylelint rule declaration-colon-space-after to be consistent with Drupal's CSS standards 2018-01-05 09:45:13 +00:00
webchick f9445b466b Issue #2919147 by tedbow, tim.plunkett: When edit mode is enabled new page loads will not have Contextual tabbing constrained 2018-01-03 12:29:21 -08:00
xjm 9032c68faa Issue #2916154 by drpal, droplet, dawehner, alexpott, xjm: JS codestyle: no-multi-assign 2017-10-24 07:42:16 -05:00
Alex Pott 27266234c2 Revert "Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign"
This reverts commit 169e867159.
2017-10-21 21:49:45 +01:00
Alex Pott 169e867159 Issue #2916154 by drpal, dawehner, xjm: JS codestyle: no-multi-assign 2017-10-21 21:46:43 +01:00
xjm 5d01c25222 Issue #2917303 by alexpott: JS codestyle: padded-blocks revisited 2017-10-19 15:14:17 -05:00
webchick 18f322a212 Issue #2764931 by tedbow, tim.plunkett, nod_, drpal, droplet, dawehner, Wim Leers, phenaproxima: Contextual links don't work with 'use-ajax' links 2017-10-16 18:15:27 -04:00
Nathaniel Catchpole 4577185c9b Issue #2572791 by Mile23, andriyun, attiks, RoSk0: Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard 2017-09-22 12:16:23 +01:00
Lee Rowlands 5c31080600
Issue #2821724 by tedbow, tim.plunkett: Create Javascript Tests for Contextual Links 2017-09-21 07:48:05 +10:00
Nathaniel Catchpole 69edc2a364 Issue #2903908 by mfernea, martin107: Fix 'Drupal.Commenting.FunctionComment.ParamCommentIndentation' coding standard 2017-09-05 14:19:41 +01:00
Lee Rowlands 50a541b97f
Issue #2551373 by drpal, danlinn, ruthleopold, Berdir, droplet, Wim Leers, prajaankit: contextual.js and quickedit.js should fail gracefully, with useful error messages, when Twig templates forget to print attributes 2017-08-07 18:27:31 +10:00
Lauri Eskola 279b57d1ad Issue #2892942 by Wim Leers, Chi, tedbow: Contextual links support options but not use them to generate links
(cherry picked from commit 4c8c5e1f0f)
2017-08-01 23:18:02 +03:00
xjm b7fff873d9 Revert "Issue #2892942 by Chi: Contextual links support options but not use them to generate links"
This reverts commit f06b26b760.
2017-07-11 14:17:17 -05:00
Gabor Hojtsy f06b26b760 Issue #2892942 by Chi: Contextual links support options but not use them to generate links 2017-07-11 17:22:02 +02:00
Lauri Eskola 612c1fa68c Issue #2880007 by drpal, nod_, droplet: Auto-fix ESLint errors and warnings 2017-07-06 09:21:40 +03:00
Lauri Eskola 7f27bbaba1 Issue #2704871 by pepegarciag, Mile23, Manuel Garcia, ieguskiza, snehi, gaurav.pahuja, dimaro, rajeshwari10, gargsuchi, pashupathi nath gajawada, penyaskito, xjm, ZeiP, Wim Leers, alexpott: Replace usages of deprecated method drupal_render() 2017-07-03 18:35:13 +03:00
Nathaniel Catchpole 193bab81f7 Issue #2863222 by dmsmidt, tedbow, drpal, tim.plunkett: Contextual Accessibility: Announcement broken after enabling editing mode a second time 2017-06-14 15:05:21 +01:00
Nathaniel Catchpole f3cf9c43b5 Issue #2880560 by alexpott, droplet: Fix comment added to top of .js files by build process 2017-05-23 15:31:29 +01:00
Alex Pott 8287017e03 Issue #2818825 by drpal, nod_, droplet, cilefen: Rename all JS files to *.es6.js and compile them 2017-05-19 23:12:53 +01:00
Alex Pott 0022c5e115 Issue #2869903 by martin107: ContextualController: remove ContainerAwareTrait 2017-04-30 00:04:05 +01:00
Alex Pott 488a6b142a Issue #2650910 by drpal, Anishnirmal, markdorison, Tom Robert, psend, yannickoo, rachel_norfolk, Wim Leers, droplet: Contextual links button is always rendered even when no links are available (with warm client-side cache) 2017-03-28 15:25:09 +01:00
Chris McCafferty 8cc93d064b Issue #2794289 by GoZ, droplet, chiranjeeb2410: add `type=button` to toolbar tab buttons 2017-03-06 20:13:44 -05:00
Nathaniel Catchpole 01f8bd64ed Issue #2854529 by alexpott, xjm, klausi, Chi, Mixologic: Fix Drupal.Scope.MethodScope - all methods should have scopes 2017-03-06 11:25:01 +00:00
xjm 52e3eec616 Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase 2017-03-03 19:20:24 -06:00
xjm e223ebe5f7 Revert "Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render()"
This reverts commit ae3ee31751.
2016-12-12 13:03:21 -06:00
xjm ae3ee31751 Issue #2704871 by pepegarciag, ieguskiza, snehi, gaurav.pahuja, rajeshwari10, dimaro, gargsuchi, pashupathi nath gajawada, penyaskito, Manuel Garcia, Mile23: Replace usages of deprecated method drupal render() 2016-12-12 12:49:03 -06:00
Scott Reeves 6316f21245 Issue #2655772 by Anishnirmal, andrewmacpherson, pbuyle, BarisW, mgifford, LaravZ: Remove unneeded role="button" attribute from <button> elements 2016-07-31 11:28:06 -04:00
Alex Pott c2b28643f6 Issue #2745953 by dawehner, tim.plunkett, Wim Leers: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified 2016-06-22 16:01:50 +02:00
Alex Pott cf1a9f8a4c Issue #576296 by no_angel, joachim, dagmar, jhodgdon, coderintherye, yoroy, xjm: Remove redundant description for some permissions 2016-06-08 10:41:18 +01:00
Alex Pott 133c212ed9 Issue #2719695 by alexpott, Mile23: Fix 'Drupal.Classes.ClassDeclaration.CloseBraceAfterBody' coding standard 2016-05-08 10:05:38 -05:00
Alex Pott 6098437ef5 Issue #2572793 by attiks, andypost: Fix 'Drupal.WhiteSpace.OperatorSpacing' coding standard 2016-04-29 12:02:20 +01:00
Alex Pott bfde6d3423 Issue #2665992 by alexpott, klausi, heykarthikwithu, xjm, tstoeckler: @file is not required for classes, interfaces and traits 2016-04-09 15:48:39 +01:00
Alex Pott 0db5b13892 Issue #2686207 by Berdir: Convert simpletest kernel tests in modules A-I to phpunit 2016-03-28 19:36:47 +01:00
Nathaniel Catchpole 92161a9b76 Issue #2650246 by swentel, Wim Leers: Only emit Contextual Links data- attributes when actually necessary 2016-03-21 10:48:39 +09:00
Alex Pott 2d76033105 Issue #2588373 by chhavik, Cottser: Remove unused image files from core 2015-12-10 16:18:25 +00:00
Nathaniel Catchpole 9ed49f24dd Issue #2568387 by nod_, TJacksonVA, cosmicdreams, dcrocks: Update JS lib: Modernizr to 3.1 2015-10-16 11:34:24 +01:00
Alex Pott b0e82e5871 Issue #2548195 by nod_, JohnAlbin, madhavvyas, sriharsha.uppuluri: Only use single quotes in JavaScript and update .eslintrc 2015-10-13 23:37:56 +01:00
Nathaniel Catchpole 8b65164c5a Issue #2533800 by alexpott: Remove all unused use statements from core 2015-10-08 20:46:26 +01:00
Alex Pott f3f0555e9c Revert "Issue #2570681 by juanse254, AndreaD, giancarlosotelo, lucastockmann, edurenye: when admin toolbar-oriented vertically a div is over the options"
This reverts commit 2acfed878b.
2015-09-30 15:04:54 +01:00
Alex Pott 2acfed878b Issue #2570681 by juanse254, AndreaD, giancarlosotelo, lucastockmann, edurenye: when admin toolbar-oriented vertically a div is over the options 2015-09-29 12:02:33 +01:00
Alex Pott 7599b055c7 Issue #2493475 by ifrik, walangitan, XaviP, jhodgdon, batigolix: Fix online docs references in Help to conform to our standards 2015-09-26 16:01:27 +02:00
Alex Pott c2563f6b59 Issue #2568743 by bruvers: Administrative toolbar edit button text not visible in Stark 2015-09-26 15:50:28 +02:00
Alex Pott 7a25f513f5 Issue #2560783 by stefan.r, joelpittet, lauriii, Cottser, Sutharsan, kgoel, justAChris, Gábor Hojtsy, dawehner, jhodgdon, effulgentsia, xjm, andypost, googletorp: Replace !placeholder with :placeholder for URLs in hook_help() implementations 2015-09-21 12:38:19 +01:00
Alex Pott afffe84a4f Issue #2569279 by dawehner, izus: Replace remaining !placeholder for Non-URL HTML outputs only in contextual.module 2015-09-18 00:15:05 +01:00
Nathaniel Catchpole 2ea19c7158 Issue #2559969 by alexpott: Make SafeStringInterface extend \JsonSerializable so we don't have to do so much string casting 2015-08-31 13:04:27 +01:00
webchick a7326f8ebe Issue #2514894 by eiriksm: JSDoc contextual module 2015-08-28 23:24:55 -07:00
Nathaniel Catchpole 9bee458886 Issue #2311393 by tim.plunkett: Remove hook_element_info() and all references to it 2015-08-28 22:30:43 +01:00
effulgentsia 764890d629 Issue #2349819 by amateescu, swentel, Leksat, larowlan, dawehner, Gábor Hojtsy, mpdonadio, benjy, jmuzz, yched, jibran, marthinal, dmsmidt: String field type doesn't consider empty string as empty value 2015-08-20 12:15:48 -07:00
Alex Pott fad555c2eb Issue #2545826 by JohnAlbin, nod_: Update.eslintrc to work with eslint 1.0.0 2015-08-07 15:08:23 +01:00
Alex Pott 6e95f0060e Issue #2078803 by Wim Leers, aspilicious, wmortada, Sumit kumar, mrjmd, John Cook: Change contextual links background color to match the styleguide 2015-07-28 16:08:48 +01:00
Alex Pott 4b12bbf0db Issue #2338081 by pwolanin, dawehner, effulgentsia, kgoel, vijaycs85, mpdonadio, chx, brandon.holtsclaw, alexpott, Gábor Hojtsy, Fabianx, catch, YesCT, JvE: Local Tasks, Actions, and Contextual links mark strings from derivatives (or alter hooks) as safe and translated 2015-07-24 22:09:33 +01:00
Nathaniel Catchpole d3c33d5821 Issue #2506581 by alexpott, Wim Leers, Fabianx, xjm, joelpittet, Cottser, dawehner: Remove SafeMarkup::set() from Renderer::doRender 2015-07-20 16:15:11 +01:00
webchick 79c2dc4c4d Issue #2494063 by tohesi, trwad, dcmul, droplet, nod_, naveenvalecha: Update Backbone to 1.2.1 2015-07-02 00:09:51 -07:00
Alex Pott 1f53649bfb Issue #1392754 by tss, justAChris, jhodgdon: Comply with new documentation standards for @file for namespaced class files 2015-06-26 21:53:33 +01:00
Alex Pott 68d4f0be10 Issue #2511472 by Wim Leers, Fabianx, dawehner: Refactor all usages of drupal_render()/Renderer::render() that break #2450993 2015-06-24 16:31:20 -05:00
Nathaniel Catchpole 30ca0d1de6 Issue #2481453 by dawehner, pwolanin, rteijeiro, neclimdul, znerol: Implement query parameter based content negotiation as alternative to extensions 2015-06-08 11:11:09 +01:00
xjm 2f903e47ac Issue #2273925 by larowlan, aneek, lauriii, mikey_p, joelpittet, dimaro, Fabianx, xjm, jaredsmith, effulgentsia, lokapujya, iMiksu, chx, YesCT, googletorp, dawehner, Wim Leers, Cottser: Ensure #markup is XSS escaped in Renderer::doRender() 2015-06-07 13:34:39 -05:00
Jennifer Hodgdon c3cb303173 Issue #2493691 by nod_, eiriksm, dawehner: Add JSDoc for core modules JS 2015-06-05 13:17:55 -07:00
Nathaniel Catchpole 5c8a50ed7f Issue #2254865 by Wim Leers, lauriii, borisson_, JeroenT, alexpott, Fabianx: toolbar_pre_render() runs on every page and is responsible for ~15ms/17000 function calls 2015-06-01 17:49:02 +01:00
xjm 088f8b357a Issue #2491155 by mikeburrelljr, Mac_Weber, opdavies: Update drupal.org and kernel.org URLs in core modules (Follow-up to 2489912) 2015-05-24 15:08:46 -05:00
Jennifer Hodgdon 6477492ee6 Issue #2473105 by ifrik, jhodgdon, lostkangaroo, opratr, LinL: Update hook_help texts that link to modules that can be uninstalled 2015-05-20 07:25:07 -07:00
Alex Pott 0b1a9a3d12 Issue #2488940 by plach: Contextual links are broken on multilingual sites 2015-05-18 14:55:26 +01:00
xjm 4f2257113e Issue #2383865 by mgifford, pguillard, rpayanm, alexpott, jhodgdon: Spellchecking Drupal - Javascript 2015-05-12 16:54:27 -07:00
Alex Pott 74802813c8 Issue #2453931 by pjonckiere: ContextualDynamicContextTest follow up 2015-05-03 17:29:54 +01:00
Alex Pott b676df9303 Issue #2031641 by aburrows, lauriii, nlisgo, Pol, redsquid, tuutti, LewisNyman, akalata, agviu, kallehauge, _nolocation, rpayanm, saki007ster, mdrummond, RavindraSingh, brahmjeet789: Change active class to is-active 2015-04-16 16:25:55 +02:00
Alex Pott 22ef398d2b Issue #2154475 by tarekdj, neelam.chaudhary, droplet, nod_, lanchez, Poornima3, jamin_melville: Convert position selectors to be compatible with with jQuery native-API selector 2015-04-15 09:59:36 +02:00
Alex Pott d48d9c9271 Issue #2448605 by martin107, willzyx, tim.plunkett, klausi, dpopdan: Replace usages of drupal_get_destination() with the redirect destination service 2015-04-09 15:56:37 +01:00
Alex Pott f3b8d0714e Issue #2457781 by prateekMehta, stefan.r, AjitS, hussainweb: Use Utility\Html class instead of Utility\String for decodeEntities() function 2015-03-30 10:20:36 +01:00