Commit Graph

240 Commits (7710bd6098e5a56ecf7f37a131344c292df164e8)

Author SHA1 Message Date
Lauri Eskola 29763eaaf5
Issue #956186 by catch, dpolant, SteffenR, yhahn, lauriii, nod_, sokrplare, rwaery.11, Supreetam09, effulgentsia, geek-merlin: Allow AJAX to use GET requests 2023-04-07 12:48:30 +03:00
Lee Rowlands 40b09f3b48
Revert "Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD"
This reverts commit 7ea52649ec.
2023-04-05 08:21:03 +10:00
Lee Rowlands 7ea52649ec
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-04 14:37:06 +10:00
Dave Long b91861bf59
Revert "Issue #3306554 by andypost, mondrake: InvocationMocker::withConsecutive() is deprecated in PHPUnit 9.6 and removed from PHPUnit 10 - easy replacements"
This reverts commit 240099013d.
2023-03-29 10:41:52 +01:00
Lee Rowlands bb8f1aadaf
Issue #2977785 by acbramley, ameymudras, mrinalini9, Hardik_Patel_12, Berdir, sourabhjain, ravi.shankar, Deepak Goyal, Prem Suthar, TanujJain-TJ, kishor_kolekar, snehalgaikwad, nghai, larowlan, Lendude, smustgrave, Sam152, quietone: No error messages are shown for applied validation on a view exposed filter with on "AJAX" 2023-03-29 17:03:00 +10:00
Dave Long 240099013d
Issue #3306554 by andypost, mondrake: InvocationMocker::withConsecutive() is deprecated in PHPUnit 9.6 and removed from PHPUnit 10 - easy replacements 2023-03-12 19:55:29 +00:00
catch 84547a7972 Issue #3266341 by nlisgo, cilefen, carstenG, david.qdoscc, Lendude, quietone, smustgrave: Views pagers do math on disparate data types, resulting in type errors in PHP 8 2023-03-08 15:45:59 +00:00
Lauri Eskola 5030f45e0c
Issue #3300481 by Murz, smustgrave, catch: Move ScrollTopCommand views Ajax command to the Drupal Core 2023-03-04 09:08:13 +02:00
xjm 00bcd1740c
Issue #2574981 by Manjit.Singh, dimaro, wengerk, darol100, izus, pguillard, vsujeetkumar, Himanshu5050, snehi, paulocs, rakesh.gectcr, jofitz, _utsavsharma, charginghawk, rajeshwari10, sdstyles, quietone, benjifisher, marcusvsouza, LoMo, joelpittet, justAChris, cilefen, YesCT, mradcliffe, spitzialist, annajl, jhodgdon, catch, alexpott, Sabbi0612, kattekrab, Mile23, antojose, leanderl, rodrigoac: Fix grammar ("an URL" should be "a URL") and consistent use of URL (not "url" / "Url") in documentation only 2023-01-26 16:06:23 -06:00
Alex Pott 812ec978db
Issue #3259090 by Lendude, mr.york, Pandepoulus: Exposed filter equality check works differently in PHP 8.0 2022-12-12 09:27:33 +00:00
Dave Long 85eeb1bde1
Issue #3324801 by Spokje, mondrake: Fix PHPStan L2 error "Property Foo::$bar has unknown class Baz as its type." 2022-12-07 11:22:31 +00:00
Lee Rowlands d09bd3817c
Issue #2939442 by Lendude, joachim, Ankit.Gupta, Akhil Babu, Kristen Pol, jidrone: views 'Entity Operations' field crashes if on a non-required relationship 2022-12-06 07:10:59 +10:00
Alex Pott e2d4dcfdf2
Issue #3319582 by mondrake, Spokje, longwave, mallezie: Fix calls to methods with too many parameters passed in 2022-11-29 11:38:06 +00:00
Alex Pott 81b8c86909
Issue #3322763 by Spokje: Fix PHPStan L2 error "PHPDoc tag @return with type Foo is incompatible with native type void." 2022-11-21 14:14:04 +00:00
Alex Pott fdaf5636e4
Issue #3295880 by Spokje, longwave: ->willReturn(...) would make more sense here 2022-10-03 15:41:01 +01:00
Alex Pott 2c468a0049
Issue #3264947 by Niklan, quietone, ravi.shankar, longwave, TR, xjm: [Sep 12, 2022] Add missing docblocks for test methods ::setUp() and ::tearDown() 2022-09-27 13:28:52 +01:00
Alex Pott 803da73c0b
Issue #2937515 by Spokje, quietone, idebr, longwave, SherFengChong, anweshasinha, borisson_, mfernea, xjm, bbrala, daffie, Berdir: Fix Drupal.Array.Array.[ArrayClosingIndentation, ArrayIndentation] coding standard 2022-09-27 11:11:12 +01:00
catch 3254513103 Issue #3311466 by Temoor, andypost: Remove obsolete ViewExecutable::editing property access 2022-09-26 12:18:39 +01:00
Alex Pott 6dd0db56c8
Issue #3281535 by mondrake, daffie: Fix 'Access to an undefined property' PHPStan L0 errors in test code 2022-06-14 11:27:54 +01:00
Alex Pott de4c1e82c2
Issue #3232714 by paulocs, vsujeetkumar, mondrake, longwave, quietone, larowlan: Replace, in tests, mocks that do not configure doubles with their actual objects 2022-05-19 09:50:46 +01:00
catch 7e81e515da Issue #2616814 by dpi, Xano, geek-merlin, Hardik_Patel_12, jofitz, alexpott, Fabianx, catch, joachim, andypost, dawehner, daffie, cweagans, neclimdul: Delegate all hook invocations to ModuleHandler 2022-03-29 11:00:53 +01:00
Alex Pott 76c0ec234c
Issue #3219649 by quietone, murilohp, longwave: Fix spelling for words used once, beginning with 'q' -> 's', inclusive 2022-01-27 02:25:01 +00:00
catch c0228273ac Issue #3162981 by murilohp, andypost, quietone, paulocs, lucienchalom, longwave, daffie, catch: [Symfony 6] Use Symfony\Component\HttpFoundation\InputBag where appropriate instead of ParameterBag 2022-01-24 16:00:19 +00:00
Alex Pott 09795b6e93
Issue #3131348 by Spokje, jungle, mondrake, vsujeetkumar, sja112, kishor_kolekar, Hardik_Patel_12, mrinalini9, yogeshmpawar, daffie: Replace assertions involving calls to empty() with assertEmpty()/assertNotEmpty()/assertArrayNotHasKey() 2021-12-30 13:40:35 +00:00
catch cfd8517353 Issue #3182103 by TR, dan2k3k4, longwave, mondrake, Sweetchuck, Kristen Pol: Ensure correct signature for setUp(), tearDown(), setUpBeforeClass(), and assertPostConditions() methods 2021-12-14 12:05:17 +00:00
catch 92836c436b Issue #3138078 by mondrake, larowlan, longwave, xjm: [D9.3 beta - w/c Nov 8, 2021] Add a 'void' return typehint to custom assert* methods 2021-11-22 15:25:32 +00:00
Lee Rowlands 6d39cdeeb4
Issue #3222769 by bbrala, alexpott, longwave, Matroskeen: [November 8, 2021] Replace all list (array destructuring) assignment to the array syntax 2021-11-15 12:35:55 +10:00
Lee Rowlands 330473e759
Issue #3222251 by bbrala, longwave: [November 8, 2021] Replace all isset constructs with the null coalescing operator 2021-11-15 12:19:43 +10:00
Alex Pott 47c2f348cf
Issue #3116481 by joachim, daffie: Convert EntityViewsDataTest from a unit test to a kernel test 2021-10-18 11:18:40 +01:00
catch 1b66ab0cb3 Issue #3130606 by shaktik, mondrake, KapilV, longwave, daffie: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10 2021-09-13 17:23:15 +01:00
catch 6951f4d77a Issue #3225328 by mxr576, Berdir, longwave: Improve page performance by sorting cache contexts/tags on-demand 2021-08-27 12:36:31 +01:00
catch 6335af17b4 Issue #3221312 by Spokje: ->willReturn(...) would make more sense here 2021-07-28 11:57:46 +01:00
xjm c1179c9377 Issue #3217717 by longwave, mondrake, tim.plunkett, xjm: Replace usages of the at() matcher, which is deprecated 2021-06-28 16:09:48 -05:00
catch e48dcff470 Issue #2879159 by Spokje, LoMo, ravi.shankar, quietone, mondrake: Some calls to assertEquals have expected/actual parameters reversed 2021-06-21 11:27:34 +01:00
Lee Rowlands 93d251d78a
Issue #2716019 by joseph.olstad, rodrigoaguilera, _Archy_, Lendude, mdupont, anmolgoyal74, mpp, Krzysztof Domański, DamienMcKenna, adityasingh, Skymen, benelori, Suresh Prabhu Parkala, rensingh99, alexpott, paulocs, HeyJo, iiRealXz, dawehner, xjm, 5n00py, tstoeckler, Karsa, dbyers55, idebr: View titles in breadcrumb and metatag title don't get properly translated 2021-06-14 17:28:27 +10:00
catch f3ad0680a3 Issue #3133162 by jungle, ravi.shankar, Deepak Goyal, Neslee Canil Pinto, anmolgoyal74, xjm, Kristen Pol: Replace the start verb Test with Tests in method comments of tests 2021-05-24 14:26:11 +01:00
Alex Pott 4a72cc3169
Issue #3207734 by Spokje, quietone: Fix Drupal.Commenting.InlineVariableComment 2021-05-20 21:47:18 +01:00
catch 14d175470c Issue #3207119 by longwave: Fix 'Squiz.WhiteSpace.ScopeKeywordSpacing' coding standard 2021-04-05 08:05:00 +01:00
catch 4634506480 Issue #3000383 by drunken monkey, mbovan, anushrikumari, alexpott, ravi.shankar: Assert the current path on Views AJAX requests is not set with two leading slashes 2021-01-22 09:23:26 +00:00
Alex Pott 8fafcd342e
Issue #3047216 by mxr576, kevin.dutra, jungle, xjm, Lendude, alexpott, catch, joelpittet: Displays are attached even when user does not have access 2020-12-22 11:30:24 +00:00
catch 203664afdd Issue #3185652 by jonathan1055, daffie: Fix 'Drupal.Commenting.DocComment.ShortFullStop' coding standard - part 2 2020-12-16 12:37:42 +00:00
catch 86c7ed07ab Issue #3183673 by jonathan1055, longwave: Fix 'Drupal.Commenting.DocComment.ShortFullStop' coding standard - part 1 auto-fixes 2020-11-30 18:10:49 +00:00
catch dee581d3fa Issue #3128815 by mondrake, jungle, sja112, Spokje, shobhit_juyal, jameszhang023, nikitagupta, mrinalini9, xjm, longwave, dww: Replace assert*() involving greater/less comparison operators with assert(Greater|Less)Than(OrEqual) 2020-11-24 09:57:55 +00:00
catch 1111de8446 Issue #3118591 by alexpott, xjm, chesnut: Datetime-related test failures on PostgreSQL 12 2020-11-16 15:15:37 +00:00
catch 1d6e7e25d5 Issue #2851394 by GoZ, hgunicamp, oknate, jungle, wolffereast, tameeshb, mmatsoo, ridhimaabrol24, jofitz, swarad07, tanc, shaktik, dimaro, shashikant_chauhan, MerryHamster, quietone, nitesh624, martin_q, boaloysius, gaurav.kapoor, nitvirus, ankithashetty, Munavijayalakshmi, kostyashupenko, leolando.tan, amit.drupal, ravi.shankar, akashkrishnan01, Swapnil_Kotwal, Saviktor, mrinalini9, anmolgoyal74, Venkatesh Rajan.J, shimpy, lomasr, Dinesh18, shubham.prakash, mahtab_alam, markdorison, cilefen, longwave, bleen, xjm, alexpott, gmaltoni: Fix grammar 'a' to 'an' when necessary 2020-11-13 14:25:11 +00:00
catch 7dbdbcb1fa Issue #3166450 by mondrake, longwave, snehalgaikwad: Split assertTrue using && into multiple assertions 2020-11-09 12:07:29 +00:00
catch b72fe50a60 Issue #3151118 by alexpott, Beakerboy, kapilkumar0324, anmolgoyal74, jungle, heddn, Mile23, andypost, daffie: Include bootstrap.inc using composer 2020-11-03 11:45:09 +00:00
catch 47355e3ba7 Issue #3135027 by mondrake, Spokje, ayushmishra206, rajandro, nitesh624: Replace usages of assertArrayEquals, deprecate it 2020-09-30 10:32:01 +01:00
catch b62e2843cf Issue #3154909 by jungle, adityasingh, nitesh624, mohrerao, rajandro, sanjayk, priyanka.sahni, ju.vanderw, tripurari: Change words 'not existing' to 'non-existent' 2020-09-01 17:42:19 +01:00
Lee Rowlands 98856bb10c
Issue #3074595 by Lendude, ravi.shankar, sime, jian he, Kristen Pol, longwave: var_export only returns if the second parameter set to TRUE 2020-07-31 11:51:17 +10:00