Commit Graph

367 Commits (74e7bcdf7f2a6f088fa2ef76f8425b8379a9f7c5)

Author SHA1 Message Date
Dries Buytaert d9d6a6e05c - Patch #7582 by Gerhard: improved node revisions!
All node revisions were stored in a serialized field in the node table and retrieved for _each_ page view although they are rarely needed. We created a separate revisions table which would be in principle identical to the node table, only that it could have several old copies of the same node.  This also allows us to revision-related information, and to provide log entries to non-book pages when a new revision is being created.

TODO:

1. Provide upgrade instructions for node module maintainers!
2. Upgrade modules that implement node types.
3. Provide an upgarde path for revisions.  Dependency on the upgrade system.
2005-08-30 15:22:29 +00:00
Dries Buytaert 494e5ab97c - Renamed 'user comments' to 'comment options' for consistency.' 2005-08-28 15:16:58 +00:00
Dries Buytaert 7b8a409675 - Patch #29385 by chx: no ?> add end of files. 2005-08-25 21:14:17 +00:00
Dries Buytaert 29d6660149 - Patch #23620 by Robin: don't hard code forms into comment.module. Will be
depricated by form API patch though.  Hopefully helps migration.
2005-08-17 20:07:35 +00:00
Dries Buytaert 7625a4e91a - Patch #27737 by Gerhard: format_name($object) -> theme('username', $object).
Usernames can now be themed; eg. an icon/avatar could be added.

  TODO: update contributed modules + update the migration docs.
2005-08-01 05:14:05 +00:00
Steven Wittens e4096e1418 - #27551: Rename check_output() to check_markup(). Needs contrib updates! 2005-07-29 21:06:33 +00:00
Steven Wittens aa2de74fa2 - #27624, #27614, #27627: dead code 2005-07-29 08:18:20 +00:00
Steven Wittens bd055961cd - #25285: Use correct permission for node form comment admin 2005-07-25 09:41:29 +00:00
Dries Buytaert 50dac6f671 - Fixed typo reported by Stefan: theem -> theme 2005-07-20 15:13:12 +00:00
Dries Buytaert 13954f90dd - Modified patch #18656 by Moshe: unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. Also gave administrators the ability to change the author and timestamp of a comment. Also removed comment links from the bottom of the comment preview box (as we did for nodes)
Modifications: fixed breadcrumbs, tidied up delete confirmation page to be consistent with node deletions..
2005-07-19 17:51:59 +00:00
Dries Buytaert 160a1e0ef8 - Patch #25634 by chx: simplified node_load(). 2005-07-17 18:29:32 +00:00
Dries Buytaert 02460ed9d8 - Removed tab. 2005-07-05 19:31:36 +00:00
Dries Buytaert 2c10ff4b5f - Fixed problems with filter formats and problem with XML-RPC server. 2005-06-29 19:53:14 +00:00
Dries Buytaert 58aee8cdad - Patch #25603 by Stefan: made the sizes of forms consistent.
TODO: document the defaults in the PHPdoc comments.
2005-06-27 18:33:33 +00:00
Dries Buytaert e550f84162 - Patch #16204 by Thox: committed the collapsible form elements patch.
NOTE: this patch works well, but the improved node edit form still has
        some rough edges.  It is important that we continue to improve
        usability.  Give it a try.
2005-06-21 09:45:45 +00:00
Steven Wittens 21274fbb94 - #23285: Allow theming of comment previews, like node previews. 2005-05-22 21:14:59 +00:00
Dries Buytaert e5ecab0797 - Patch #22804 by Cvbge: fixed typo in documentation. 2005-05-14 17:23:18 +00:00
Dries Buytaert 381853c6b9 - Patch #21221 by Robert: make status values in comment.module defined constants for readability. 2005-05-05 20:12:49 +00:00
Dries Buytaert a76a1e1f3f - Patch 20910 by chx: centralize print theme page. 2005-04-24 16:34:36 +00:00
Dries Buytaert 8f1e9cd720 - Modified patch #18215 by ankur: make sure the comment statistics update after approval in the moderation queue. 2005-04-08 13:34:10 +00:00
Dries Buytaert a21f084160 - Patch by Drumm: change the wording for clarity. 2005-04-08 13:06:37 +00:00
Dries Buytaert 961cf7af44 - By default, do not show comment controls. 2005-04-07 05:24:08 +00:00
Dries Buytaert 29f6541c5e - Patch #20103 by Neil: Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway. 2005-04-07 05:21:30 +00:00
Dries Buytaert a3e9b35afc - Patch #19451 by JonBob: improved consistency of module descriptions. We should write guidelines for this -- maybe in the PHPDoc code of the _help hook. 2005-04-01 15:55:02 +00:00
Steven Wittens be14203534 - #18817: Clean up plain-text checking (see drupal-devel!) 2005-03-31 09:25:33 +00:00
Dries Buytaert 5ad5f28cda - Patch #19009 by chx: fixed a bug with comment replies letting one access nodes. 2005-03-20 19:42:14 +00:00
Steven Wittens c3f1f7345e - #18939 (Stefan): Always use paragraph tags around page help text. 2005-03-18 07:07:04 +00:00
Dries Buytaert 332a56334d - Patch #17161 by Morbus: increase 40-character limit in URL field for comments. 2005-03-16 22:14:15 +00:00
Dries Buytaert 3b5589f436 - Patch #14109 by wulff/Morbus: added missing t() funciton 2005-03-16 19:31:47 +00:00
Dries Buytaert a16e5d2492 - Patch #18692 by Goba: old comments (comments for nodes having no entry in the history table anymore) are counted as new comments, since the timestamp retrieved from the history table is used to check for new comments (which is 0, if an entry was not found). This patch sets the timestamp used to check for new comments to the NODE_NEW_LIMIT value at least (which is when the history table was/should have been pruned). 2005-03-12 08:52:29 +00:00
Dries Buytaert 2ec787df34 - Patch #18676 by frjo: When anonymuos users are allowed to add comments there are a required e-mail field. This field are, as far as i can see, not shown publicly. A user asked me about this and after confirming that it is not shown publicly I added a description that inform the users of this. I have included a patch that add the description "The content of this field is kept private and will not be shown publicly". This is the same description that is used by the profile module. 2005-03-10 18:28:21 +00:00
Steven Wittens 198ec98f75 #18329: Unify confirmation messages (and make them themable) 2005-03-03 20:51:27 +00:00
Steven Wittens a794dd4419 - #17877: Auto-fill comment subject during _validate rather than _save. 2005-02-27 02:56:12 +00:00
Dries Buytaert 5b7ecb8650 - Patch #17208 by asimmonds: help text fixes:
- permissions menu link updates in a number of modules help
    - anchor link fix in distributed auth help
    - "my account" link fix in user help
    - spelling correction in tracker.module help

- I also changed 'admin/access/perms' to 'admin/access/permissions'.
2005-02-12 07:51:14 +00:00
Dries Buytaert 9c5646288c - Patch #11366 by Junyor: fixed twin comment problem in HEAD. 2005-02-11 19:01:53 +00:00
Dries Buytaert fbec279e4c - Patch #16246 by Moshe: added mechanism to direct the user back to the referring page after completing a form.
(Moshe: the patch against node.module failed to apply.)
2005-02-01 19:45:58 +00:00
Dries Buytaert 7ae04af1e0 - Patch by Jose A Reyero: fixed probem with db_rewriste_sql() in the comment.module. 2005-01-31 19:30:13 +00:00
Dries Buytaert 59c2208ea6 - Patch #16253 by Goba: incremental improvements to the new content markers.
Goba: it would be nice if one of the core themes would showcase this functionality. ;-)
2005-01-30 09:53:19 +00:00
Dries Buytaert 993ea0c6c5 - Patch #16111 by chx: generalized node_rewrite_query to db_rewrite_query. 2005-01-29 22:02:37 +00:00
Dries Buytaert 467dbdc4a1 - Patch #16253 by Goba: this simple and straightforward patch adds the ability to define different types of markers (while retaining the old default behaviour of the new and required markers to look the same). Someone with enough time on his hands might be able to partition the new marker to a real new marker and a changed marker (since node_is_new() returns TRUE even if nodes changed, and not only when they are new). This is the base on which the new patch can be worked though. 2005-01-27 12:57:08 +00:00
Dries Buytaert 173f528f59 - Modified patch #14170 by Neil: improved default workflow (default node type) configuration page.
Modified the patch to remove some redundant code, to translate strings, and to better use the menu system.
2005-01-24 21:20:16 +00:00
Steven Wittens 09bd156ba2 - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes).
- Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings.
2005-01-19 01:46:25 +00:00
Steven Wittens e7edb55d63 - The real code fixes ;) 2005-01-17 19:00:03 +00:00
Dries Buytaert 971a0e24aa - Patch #14731 by chx: made it possible to rewrite node queries. 2005-01-16 18:44:49 +00:00
Steven Wittens b8b36bd941 - Fix comment pager counting unpublished comments. 2005-01-12 16:02:42 +00:00
Steven Wittens bf12368205 - Fix comment pager counting unpublished comments. 2005-01-12 16:02:20 +00:00
Dries Buytaert df6fe90286 - Updated two watchdog calls. 2005-01-09 10:06:26 +00:00
Dries Buytaert 64b100d19a - Patch #13260 by UnConeD: watchdog module improvements.
We added a 'severity' column to watchdog():
    watchdog($type, $message, $link) --> watchdog($type, $message, $severity, $link);

    * Specify a severity in case you are reporting a warning or error.
    * The $link-parameter is now the fourth parameter instead of the third.

  TODO: document this in the upgrade guide.
2005-01-09 09:22:40 +00:00
Dries Buytaert 1dbe0dc2ee - Patch #14917 by UnConeD/Steven:
1) The different types of search, which used to be radio button options in the search form, are now subtabs of "search" (default "search/node"). This seems better from a UI point of view, but also has another advantage: modules which implement a custom search form (flexinode, project) can add it as a subtab of search. This means that all search forms will be located in the same place, and also without needing an extra api call to search.module.

2) The current code was a bit hackish, as the indexing of comments along with nodes was hardcoded in node.module. Instead, I created a nodeapi operation "update index" which allows modules to add more data for a node that is being indexed. Comments are now indexed using this mechanism and from comment.module, which is a lot cleaner.

3) The search results format was also hardcoded to include "N comments". I replaced this with a nodeapi operation "search result" and moved the comment code to comment.module where it belongs. This op is quite useful, as for example I also modified upload.module to add "N attachments" to a search result if any are present.
2004-12-31 09:30:12 +00:00
Dries Buytaert 09c55017f6 - Patch #14882 by Jeremy: removed some cruft: status = 2 is no more. 2004-12-29 18:41:52 +00:00