Commit Graph

119 Commits (71db4f261a65bd2b2746335db2422b845d59228c)

Author SHA1 Message Date
Dries Buytaert d64bc008fd Patch by Moshe:
- comment.module: fixed an ambigous 'timestamp' query

- forum.module: prev/next links no longer excerpt from the title+body in
their title attribute. they now excerpt from only their title. this is
more consistent with rest of drupal, and GROUP BY on node.body which
isn't appreciated by MSSQL. also replaced some '' with NULL which caused
errors in MSSQL

- statistics.module: replaced a USING join with a standard ON join. USING
is not as widely supported, and functionally equivalent.
2003-10-17 16:10:48 +00:00
Dries Buytaert 2ff3222458 - Fixed translation bugs with statistics module. Patch by Gabor.
- Removed 'homepage' field from user table.  Patch by Gabor.

- Added 'real name' field to the profile module.  Patch by Gabor.
2003-10-12 21:25:42 +00:00
Dries Buytaert a30f75f050 - MSSQL improvements/fixes from Moshe:
> brings mssql schema into modern era. mainly adds path table and a few
> defaults and indexes.
2003-10-08 21:01:36 +00:00
Dries Buytaert fa2581edcf - Modifies path.module to get rid of pgsql reserved word. Patch by Adrian.
- Updates database.pgsql and database.mysql to work with current cvs. Patch
  by Adrian.

- Updates update.php to be able to update postgres from 4.2 to current.
  Patch by Adrian.

- Small fixes by me.
2003-10-01 05:18:03 +00:00
Dries Buytaert 6baa7d7c21 - Some URL alias fixes by Matt. 2003-09-30 20:59:26 +00:00
Dries Buytaert 5a667eb580 - Url aliasing improvements. Patch by Matt. See mailing list for more
information.
2003-09-30 17:01:34 +00:00
Dries Buytaert 52c4240600 - Added PostgreSQL support to the update script. Patch by Adrian.
- Making Adrian the new PostgreSQL maintainer.
2003-09-30 08:55:03 +00:00
Dries Buytaert b9633dcded - Patch by Bart Jansen:
<quote>

  This adds session support for anonymous users and fixes a bug/typo.

    1. changed rid for user #0 from 0 to 1 (rid 1 == anonymous user) to make
       inner join work.

    2. replaced "if ($user .." by "if ($user->uid .." because now $user is
       always set (my previous change probably caused this).

    3. db_next_id("user_uid") -> db_next_id("users_uid");
  </quote>

  I repeat:

  "This adds session support for anonymous users and fixes a bug/typo."
2003-09-10 19:30:34 +00:00
Dries Buytaert 8e657f64ef - Gerhard's uid 0 patches. These patches bring various performance
improvements.  Requires a database update.
2003-09-09 18:18:43 +00:00
Dries Buytaert 99400fa334 - Small bugfix for the database.mysql sql structure with the new indexes
introduced in yesterday's forum query patch.  Patch by Matt.
2003-08-28 18:03:40 +00:00
Dries Buytaert 89005902e4 - Tested and committed Kjartan's performance patches. (Fixed the access check
in update.php though.)
2003-08-27 05:49:52 +00:00
Dries Buytaert 4e2ee96d4c - Removed left-overs from the rating module. Patch by Gerhard. Updated the
PostgreSQL and MSSQL database scheme as well.

- Made sure the update script updates the correct tables when database
  prefixing is enabled.  Patch by Bart Jansens.

- Improved the breadcrumb navigation of the book and the forum module as per
  Keith Instone's suggestions.

- Updated page titles (or block titles) and links to match.  Suggested by
  Keith Instone.

- Added missing 'thread' field to the comment table of the MySQL database scheme.
  Fixes bug #2590.
2003-08-22 17:06:44 +00:00
Dries Buytaert 405d2a3f10 - Fixed typo in database.pgsql. Patch by Michael. 2003-08-21 19:30:48 +00:00
Dries Buytaert 0bbe58901e - Fixed braino in PostgreSQL database scheme. 2003-08-21 14:26:37 +00:00
Dries Buytaert 881956cae7 - Fixed braino in MySQL database scheme. Patch by Gerhard. 2003-08-21 14:25:49 +00:00
Dries Buytaert 0431f0700f - Committed Jeremy's session patch: this brings us one step closer to having
session for anonymous users.
2003-08-20 19:19:13 +00:00
Dries Buytaert a078e515f6 - Fixed typo: 'vharchar' -> 'varchar'. Patch by Michael Frankowski. 2003-08-13 17:30:25 +00:00
Dries Buytaert 7af49ab274 - Committed Marco's comment module patch:
+ Dramatically improves performance of large discussions/threads: only
      very few SQL queries are required.
    + Replaces custom pager with standard pager.

  Modifications by me:

    + Reworded some code comments.
    + Removed dependencies on pager internals.
2003-08-12 18:32:54 +00:00
Dries Buytaert 24de26c13d - Changing the node body to type 'mediumtext'. Addresses bug #2155. 2003-07-26 18:27:16 +00:00
Dries Buytaert 8759ca7368 - Commited the URL aliasing patch. Thanks Matt.
This update requires you to run update.php!
2003-07-16 20:14:26 +00:00
Dries Buytaert 3b8c99d91e - Bugfix: fixed the CREATE FUNCTION in database.mssql as it needs to be prefixed with GO for some obscure reason. Patch by Kjartan.
- Bugfix: fixed the defaults for blocks in database.mssql so the NOT NULL fields get values.  Patch by Kjartan.

- Bugfix: changed check_form() to use htmlspecialchars() instead of drupal_specialchars() as this caused Drupal to emit incorrect form items in presence of quotes.  Example:

  <input type="submit" class="form-submit" name="op" value="Submit "top nodes" block changes" />

  IMO, drupal_specialchars() is better called xmlspecialchars() to avoid confusion.

- Bugfix: when an anonymous user visits a site, they shouldn't see any content (except the login block, if it is enabled) unless they have the "access content" permissions.  Patch by Matt Westgate.

- Improvement: improved the error checking and the error messages in the profile module.  Updated the code to match the Drupal coding conventions.  Modified patch from Matt Westgate.

- Improvement: don't generate the <base href=""> tag in the base theme; it is already emitted by theme_head().  Patch by Kristjan.

- Improvement: don't execute any SQL queries when checking the permissions of user #1.  Patch by Kjartan.

- Improvement: made a scalable layout form that works in IE and that behaves better with narrow themes.  Part of patch #51 by Al.

- Improvement: removed some redundant print statements from the comment module.  Modified patch from Craig Courtney.
2003-06-11 18:16:32 +00:00
Dries Buytaert 355d25e73d - Bugfix: renamed the SQL field 'types' to 'nodes' because 'types' is a reserved keyword in MySQL 4. This fixes critical bug #1618. Patch by Marco.
==> This fix requires to run update.php!

- Bugfix: made sessions work without warnings when register_globals is turned off. The solution is to use $_SESSION instead of session_register().  This fixes critical bug #1797.  Patch by Marco.

- Bugfix: sometimes error messages where being discarded when previewing a node.  Patch by Craig Courtney.

- Bugfix: fixed charset problems.  This fixes critical bug #1549.  Patch '0023.charset.patch' by Al.

- Code improvements: removed some dead code from the comment module.  Patch by Marco.

- Documentation improvements: polished the node module help texts and form descriptions.  Patch '0019.node.module.help.patch' by Al.

- CSS improvements all over the map!  Patch '0021.more.css.patch' by Al.

- GUI improvements: improved the position of Druplicon in the admin menu.  Patch '0020.admin.logo.patch' by Al.

- GUI improvements: new logos for theme Marvin and theme UnConeD.  Logos by Kristjan Jansen.

- GUI improvements: small changes to the output emitted by the profile module.  Suggestions by Steven Wittens.

- GUI improvements: small fixes to Xtemplate.  Patch '0022.xtemplate.css.patch' by Al.

TODO:

- Some modules such as the buddy list module and the annotation module in the contributions repository are also using session_register().  They should be updated.  We should setup a task on Drupal.

- There is code emitting '<div align="right">' which doesn't validate.

- Does our XML feeds validate with the charset changes?

- The forum module's SQL doesn't work properly on PostgreSQL.
2003-06-04 18:24:39 +00:00
Dries Buytaert e5033fe1cf - Fixed critical bug #1788: cloud module pings too much. Modified patch by
Kjartan.

  This update requires some database changes so make sure to run update.php.
2003-06-01 06:46:55 +00:00
Dries Buytaert 17e5b5c2d7 - Changed the type of the string fields in the locale table to BLOB.
This fixes bug #987.  For PostgreSQL this is not required because
  its string comparisons are case-senitive.  Not idea about MSSQL.
2003-05-24 14:31:36 +00:00
Dries Buytaert 7e8aa5268b - Fixed bug in book_prev(). Patch by Andy Colson.
- Book optimizations: updated to use inner joins.  Patch by Andy Colson.
  This should address bug #1373.

  TODO: add index to MSSQL database scheme.
2003-05-18 16:43:56 +00:00
Dries Buytaert c2d2fb7309 - Fixed a typo in the PostgreSQL database scheme. Patch by Michael Frankowski.
- Fixed a typo in the MSSQL database scheme.  Patch by Michael Frankowski.

- Removed dependency on "register_globals = on"!  Patches by Michael Frankowski.

  Notes:

  + Updated the patches to use $foo["bar"] instead of $foo['bar'].
  + Updated the INSTALL and CHANGELOG files as well.

- Tiny improvement to the "./scripts/code-clean.sh" script.
2003-05-13 18:36:38 +00:00
Dries Buytaert fd37c0db4b - Added default table values to MSSQL database scheme. Patch by Moshe. Fixes bug #1571. 2003-04-28 20:53:42 +00:00
Dries Buytaert b85cf71962 - Applied modified version of Al's "block delta" patch. I left out the
blogroll feature as I think it would get very confusing.  I don't mind
  to add it but it need some thought and documentation as it somewhat
  conflicts with the existing cloud module.

  These changes require you to run update.php.
2003-04-19 16:42:42 +00:00
Dries Buytaert 9d5fb1029a - Made sure the admin menu is enabled after a fresh install. This is
required to make the menu show up.

  This partly fixes bug #1508.
2003-04-18 22:33:15 +00:00
Dries Buytaert fd9635e63a - Some MSSQL related fixes by Moshe. 2003-04-13 17:12:52 +00:00
Dries Buytaert 164003ed91 - Added missing tid-column to the forum table. Patch by Anarcat. 2003-04-13 15:26:52 +00:00
Dries Buytaert 2e2e247979 - Added missing 'created' field to 'cache' table. 2003-03-19 21:55:32 +00:00
Dries Buytaert 2976bc59f0 - The link field got accidentically removed. Thanks Stephane. 2003-03-18 21:03:42 +00:00
Dries Buytaert 170b674a09 - All LIMIT queries must go through the pager or through db_query_range().
The syntax for db_query_range() was enhanced so it matches db_query(). So
  you may pass extra arguments of the SQL statement which are checked via
  check_query() and then substituted into the SQL statement. After these
  optional arguments, you always pass $from and $count parameters which
  define your range.  Most often, the $from is 0 and the count is the max
  number of records you want returned.  Patch by Moshe.

- The pager_query() function for PEAR was enhanced so that it adds  proper
  GROUP BY statement counting the number of records to be paged. Patch by
  James Arthur.

- MSSQL database scheme by Moshe.
2003-03-16 07:02:20 +00:00
Dries Buytaert 6dc1cf59ba - Added a database scheme for Microsoft's SQL server. 2003-03-16 06:34:59 +00:00
Dries Buytaert a8edbf638f - Removing the menu table: it is no longer used.
[TODO: update 'update.php'.]
2003-02-24 23:17:39 +00:00
Dries Buytaert d5bb7bce52 - database.mysql cannot be run from within phpMyAdmin because of line
consisting of hyphens only.  Patch by Zbynek.
2003-02-24 22:39:32 +00:00
Dries Buytaert 73f476a6c1 - Fixed typo: forum2 -> forum. 2003-02-07 08:06:37 +00:00
Dries Buytaert 4ea6d5048d - Updated the database scheme. 2003-02-06 19:14:19 +00:00
Dries Buytaert d268783669 - Small improvement to the admin menu based on feedback from Michael. 2003-01-14 20:33:42 +00:00
Dries Buytaert 8a63646576 - Added an extra parameter to watchdog() which lets you specifiy an "action"
or "operation" link.

- Made the main page of the administration section show an overview of all
  watchdog entries with such action link.

- Fixed typo in PostgreSQL database scheme.
2003-01-04 11:03:15 +00:00
Dries Buytaert 22fa9ed70a - Refactored the administration pages. 2002-12-24 15:40:32 +00:00
Dries Buytaert 1ad6cff2ec - Fixed typo in the database scheme. Reported by Ettiene. 2002-12-15 08:20:57 +00:00
Dries Buytaert b6b24c28e0 Applied patch by Natrak:
- page_header() now adds Last-Modified and ETag http headers.
- When running PHP as an Apache module page_header() will check the HTTP
  headers for conditional gets, and will only push the content when it
  fails. (Works for html and xml pages as they are all cached). Note:
  this is a PHP limitation, so until PHP makes it work for other web
  servers this won't work for them.
- Added created field to cache database to hold the timestamp when the
  cache was created.
- Changed cache_get() to return an object with ->data and ->created.
- Update forum and locale modules.
2002-12-11 22:00:04 +00:00
Dries Buytaert d2d381d7c4 - Removed rating module; it is not being used much and it has a known bug.
Will add it to the contributions repository.
2002-12-08 07:54:30 +00:00
Dries Buytaert b62025c217 - Removed two a dead table from both the MySQL and the PostgreSQL database
scheme.

- Fixed the default settings for both the MySQL and the PostgreSQL database
  scheme.
2002-12-07 10:36:44 +00:00
Dries Buytaert f42bfcac31 - Fixed small glitch in the database schemes; the block table has changed but
the queries that insert some default block values were not updated.
2002-11-30 15:21:36 +00:00
Dries Buytaert 697dde0fe5 - Updated PostgreSQL scheme. Patch by Stefan. 2002-11-21 17:43:37 +00:00
Dries Buytaert 56d72a918f - Added Stefan's page module improvements.
[NOTE: the PostgreSQL database scheme needs updating.]
2002-11-20 20:54:56 +00:00
Dries Buytaert 96a45ecba6 - Updated the PostgreSQL database scheme (thanks James) and the MySQL
database scheme.
2002-11-09 20:19:13 +00:00